@autorest/python 5.12.2 → 5.12.3

package/ChangeLog.md

@@ -1,5 +1,20 @@
 # Change Log
 
+### 2022-01-13 - 5.12.3
+
+| Library | Min Version
+| --------------- | -------
+|`@autorest/core` |  `3.6.2`
+|`@autorest/modelerfour` | `4.19.1`
+|`azure-core` dep of generated code | `1.20.1`
+|`msrest` dep of generated code | `0.6.21`
+|`azure-mgmt-core` dep of generated code (If generating mgmt plane code) | `1.3.0`
+
+**Bug Fixes**
+
+- Unify multiapi constant behavior with single API version  #1119
+- Clean up docstrings by removing descriptions for client constants on methods and request builders  #1119
+
 ### 2022-01-11 - 5.12.2
 
 | Library | Min Version

package/autorest/codegen/models/parameter.py

@@ -177,8 +177,6 @@ class Parameter(BaseModel):  # pylint: disable=too-many-instance-attributes, too
         return not(
             # don't put accept in signature
             self.rest_api_name == "Accept"
-            # if i'm multiapi, don't add constants
-            or (self.code_model.options["multiapi"] and self.constant)
             # If i'm not in the method code, no point in being in signature
             or not self.in_method_code
             # If I'm grouped, my grouper will be on signature, not me
@@ -302,8 +300,6 @@ class Parameter(BaseModel):  # pylint: disable=too-many-instance-attributes, too
     @property
     def is_kwarg(self) -> bool:
         # this means "am I in **kwargs?"
-        if self.code_model.options["multiapi"]:
-            return self.rest_api_name == "Content-Type"
         return self.rest_api_name == "Content-Type" or (self.constant and self.rest_api_name != "Accept")
 
     @property
@@ -313,7 +309,9 @@ class Parameter(BaseModel):  # pylint: disable=too-many-instance-attributes, too
 
     @property
     def is_hidden(self) -> bool:
-        return self.serialized_name in _HIDDEN_KWARGS
+        return self.serialized_name in _HIDDEN_KWARGS or (
+            self.yaml_data["implementation"] == "Client" and self.constant
+        )
 
     @property
     def is_positional(self) -> bool:

package/autorest/codegen/models/request_builder_parameter.py

@@ -18,8 +18,6 @@ class RequestBuilderParameter(ParameterOnlyPathAndBodyPositional):
         return not(
             # don't put accept in method signature
             self.rest_api_name == "Accept"
-            # if i'm multiapi, don't add constants
-            or (self.code_model.options["multiapi"] and self.constant)
             # If i'm not in the method code, no point in being in signature
             or not self.in_method_code
             # If I'm a flattened property of a body, don't want me, want the body param

package/autorest/codegen/templates/metadata.json.jinja2

@@ -18,7 +18,7 @@
     },
     "global_parameters": {
         "sync": {
-            {% for gp in sync_global_parameters.config_method %}
+            {% for gp in sync_global_parameters.config_method | rejectattr("serialized_name", "equalto", "api_version") %}
             {{ gp.serialized_name | tojson }}: {
                 "signature": {{ gp.method_signature(is_python3_file=False) | tojson }},
                 "description": {{ gp.description | tojson }},
@@ -28,7 +28,7 @@
             {% endfor %}
         },
         "async": {
-            {% for gp in async_global_parameters.config_method %}
+            {% for gp in async_global_parameters.config_method | rejectattr("serialized_name", "equalto", "api_version") %}
             {{ gp.serialized_name | tojson }}: {
                 "signature": {{ (gp.method_signature(is_python3_file=True)) | tojson }},
                 "description": {{ gp.description | tojson }},
@@ -42,7 +42,7 @@
             {{ gp.serialized_name | tojson }}: {{ gp.constant_declaration | tojson }}{{ "," if not loop.last else "" }}
             {% endfor %}
         },
-        "call": {{ code_model.global_parameters.config_method | map(attribute="serialized_name") | join(', ') | tojson }},
+        "call": {{ code_model.global_parameters.config_method | rejectattr("serialized_name", "equalto", "api_version") | map(attribute="serialized_name") | join(', ') | tojson }},
         "service_client_specific": {
             "sync": {
                 "api_version": {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@autorest/python",
-    "version": "5.12.2",
+    "version": "5.12.3",
     "description": "The Python extension for generators in AutoRest.",
     "scripts": {
         "prepare": "node run-python3.js prepare.py",