@automattic/vip 4.1.5 → 4.1.6

package/internal/sqlexport/livecopy.go

@@ -1,150 +0,0 @@
-package sqlexport
-
-import (
-	"errors"
-	"fmt"
-	"os"
-	"strings"
-
-	"encoding/json/jsontext"
-	json "encoding/json/v2"
-)
-
-// LiveCopyCLIOptions ports LiveBackupCopyCLIOptions (live-backup-copy.ts:13).
-type LiveCopyCLIOptions struct {
-	UseLiveBackupCopy bool
-	SiteIDs           []string
-	Tables            []string
-	WpcliCommand      string
-	ConfigFile        string
-}
-
-// ParseLiveCopyCLIOptions ports parseLiveBackupCopyCLIOptions
-// (live-backup-copy.ts:21): exclusivity rules + comma-split with trim.
-func ParseLiveCopyCLIOptions(configFile string, tables, siteIDs []string, wpcliCommand string) (*LiveCopyCLIOptions, error) {
-	if configFile != "" && (len(tables) > 0 || len(siteIDs) > 0 || wpcliCommand != "") {
-		return nil, errors.New("The --config-file option cannot be used with the --table, --site-id, or --wpcli-command options. Please use only one of these options at a time.")
-	}
-	if wpcliCommand != "" && (len(tables) > 0 || len(siteIDs) > 0) {
-		return nil, errors.New("The --wpcli-command option cannot be used with the --table or --site-id options. Please use only one of these options at a time.")
-	}
-
-	opts := &LiveCopyCLIOptions{}
-	split := func(values []string) []string {
-		var out []string
-		for _, v := range values {
-			for _, part := range strings.Split(v, ",") {
-				out = append(out, strings.TrimSpace(part))
-			}
-		}
-		return out
-	}
-	if len(tables) > 0 {
-		opts.Tables = split(tables)
-		opts.UseLiveBackupCopy = true
-	}
-	if len(siteIDs) > 0 {
-		opts.SiteIDs = split(siteIDs)
-		opts.UseLiveBackupCopy = true
-	}
-	if configFile != "" {
-		opts.ConfigFile = configFile
-		opts.UseLiveBackupCopy = true
-	}
-	if wpcliCommand != "" {
-		opts.WpcliCommand = wpcliCommand
-		opts.UseLiveBackupCopy = true
-	}
-	return opts, nil
-}
-
-// LiveCopyConfig ports DBLiveCopyConfig (live-backup-copy.ts:120) for the
-// FLAG path only — it is the Go spelling of the object literal Node builds in
-// getLiveBackupConfigFromCLIOptions (export-sql.ts:639-644):
-//
-//	return {
-//		type,
-//		tables,          // undefined unless --table was passed
-//		site_ids: siteIds,
-//		wpcli_command: this.liveBackupCopyCLIOptions?.wpcliCommand,
-//	};
-//
-// The `omitempty` tags reproduce JSON.stringify dropping `undefined` fields.
-//
-// It is deliberately NOT used to parse --config-file. Node's
-// loadLiveBackupCopyConfig is `JSON.parse( … ) as DBLiveCopyConfig`: a
-// compile-time cast, not a runtime schema. Decoding a user's config file into
-// this struct silently discarded every key it doesn't declare and every empty
-// collection, changing the scope of the export without any signal. See
-// BuildConfig.
-type LiveCopyConfig struct {
-	Tool string `json:"tool,omitempty"`
-	Type string `json:"type"`
-	// Values are `string | boolean` in Node (live-backup-copy.ts:123), hence
-	// `any` rather than `string`.
-	Tables       map[string]map[string]any `json:"tables,omitempty"`
-	SiteIDs      []int64                   `json:"site_ids,omitempty"`
-	WpcliCommand string                    `json:"wpcli_command,omitempty"`
-}
-
-// BuildConfig ports getLiveBackupConfigFromCLIOptions (export-sql.ts:616) +
-// loadLiveBackupCopyConfig (export-sql.ts:647). It returns the JSON document
-// that becomes LiveBackupCopyConfigInput.config (a `JSON` scalar in the
-// schema), so the two paths differ:
-//
-//   - --config-file: the file's bytes are validated as JSON and passed
-//     through VERBATIM, because that is what Node does. `JSON.parse` +
-//     an `as` cast keeps every key the user wrote — including ones the CLI
-//     has never heard of (`exclude_tables`, `limit`, per-table `where`) —
-//     and startLiveBackupCopy hands the whole object to the server. Anything
-//     the CLI drops here silently changes which rows the user gets back,
-//     with exit 0. Parsing uses encoding/json/v2: a config file is
-//     untrusted user input, which is exactly where v1 is finicky.
-//
-//   - flags: the LiveCopyConfig literal above, marshaled.
-func BuildConfig(opts *LiveCopyCLIOptions) ([]byte, error) {
-	if opts.ConfigFile != "" {
-		if _, err := os.Stat(opts.ConfigFile); err != nil {
-			return nil, fmt.Errorf("Configuration file not found: %s", opts.ConfigFile)
-		}
-		raw, err := os.ReadFile(opts.ConfigFile) // #nosec G304 -- user-supplied CLI path
-		if err != nil {
-			return nil, fmt.Errorf("Error reading configuration file: %s - %s", opts.ConfigFile, err.Error())
-		}
-		// Validate only — the decoded shape is not inspected. `any` accepts
-		// any JSON document, matching JSON.parse: Node throws only on a
-		// SyntaxError, never on an unexpected shape. AllowDuplicateNames
-		// keeps us from being STRICTER than JSON.parse, which takes the last
-		// of a duplicated member instead of failing.
-		var probe any
-		if err := json.Unmarshal(raw, &probe, jsontext.AllowDuplicateNames(true)); err != nil {
-			return nil, fmt.Errorf("Invalid JSON in configuration file: %s - %s", opts.ConfigFile, err.Error())
-		}
-		// Re-marshal the *validated* value rather than shipping the file's
-		// raw bytes: that normalises whitespace and rejects anything the
-		// validator accepted but an embedder would mangle, while preserving
-		// every key, every empty collection and every value type.
-		return json.Marshal(probe)
-	}
-
-	cfg := &LiveCopyConfig{Type: "tables"} // BackupLiveCopyType.TABLES default (export-sql.ts:621)
-	if len(opts.Tables) > 0 {
-		cfg.Tables = map[string]map[string]any{}
-		for _, t := range opts.Tables {
-			cfg.Tables[t] = map[string]any{}
-		}
-	}
-	if len(opts.SiteIDs) > 0 {
-		cfg.Type = "site_ids"
-		for _, id := range opts.SiteIDs {
-			var n int64
-			_, _ = fmt.Sscanf(strings.TrimSpace(id), "%d", &n)
-			cfg.SiteIDs = append(cfg.SiteIDs, n)
-		}
-	}
-	if opts.WpcliCommand != "" {
-		cfg.Type = "wpcli_command"
-		cfg.WpcliCommand = opts.WpcliCommand
-	}
-	return json.Marshal(cfg)
-}

package/internal/sqlexport/livecopy_test.go

@@ -1,273 +0,0 @@
-package sqlexport
-
-import (
-	"os"
-	"path/filepath"
-	"strings"
-	"testing"
-
-	json "encoding/json/v2"
-)
-
-func TestParseLiveCopyCLIOptionsExclusivity(t *testing.T) {
-	_, err := ParseLiveCopyCLIOptions("cfg.json", []string{"wp_posts"}, nil, "")
-	if err == nil || !strings.Contains(err.Error(), "The --config-file option cannot be used with the --table, --site-id, or --wpcli-command options.") {
-		t.Errorf("err = %v", err)
-	}
-	_, err = ParseLiveCopyCLIOptions("", []string{"wp_posts"}, nil, "wp post list")
-	if err == nil || !strings.Contains(err.Error(), "The --wpcli-command option cannot be used with the --table or --site-id options.") {
-		t.Errorf("err = %v", err)
-	}
-}
-
-func TestParseLiveCopyCLIOptionsCommaSplit(t *testing.T) {
-	opts, err := ParseLiveCopyCLIOptions("", []string{"wp_posts, wp_comments", "wp_users"}, []string{"2,3"}, "")
-	if err != nil {
-		t.Fatal(err)
-	}
-	if !opts.UseLiveBackupCopy {
-		t.Error("UseLiveBackupCopy must be set")
-	}
-	if len(opts.Tables) != 3 || opts.Tables[1] != "wp_comments" {
-		t.Errorf("tables = %v", opts.Tables)
-	}
-	if len(opts.SiteIDs) != 2 || opts.SiteIDs[1] != "3" {
-		t.Errorf("siteIDs = %v", opts.SiteIDs)
-	}
-}
-
-func TestParseLiveCopyCLIOptionsEmpty(t *testing.T) {
-	opts, err := ParseLiveCopyCLIOptions("", nil, nil, "")
-	if err != nil {
-		t.Fatal(err)
-	}
-	if opts.UseLiveBackupCopy {
-		t.Error("no options must not enable live copy")
-	}
-}
-
-// decodePayload reads the JSON document BuildConfig produces — i.e. exactly
-// what lands in LiveBackupCopyConfigInput.config on the wire.
-func decodePayload(t *testing.T, raw []byte) map[string]any {
-	t.Helper()
-	var got map[string]any
-	if err := json.Unmarshal(raw, &got); err != nil {
-		t.Fatalf("payload is not a JSON object: %v (%s)", err, raw)
-	}
-	return got
-}
-
-func writeConfig(t *testing.T, body string) string {
-	t.Helper()
-	p := filepath.Join(t.TempDir(), "cfg.json")
-	if err := os.WriteFile(p, []byte(body), 0o600); err != nil {
-		t.Fatal(err)
-	}
-	return p
-}
-
-func TestBuildConfigFromFlags(t *testing.T) {
-	raw, err := BuildConfig(&LiveCopyCLIOptions{UseLiveBackupCopy: true, SiteIDs: []string{"2", "3"}})
-	if err != nil {
-		t.Fatal(err)
-	}
-	got := decodePayload(t, raw)
-	if got["type"] != "site_ids" {
-		t.Errorf("type = %v, want site_ids", got["type"])
-	}
-	ids, _ := got["site_ids"].([]any)
-	if len(ids) != 2 || ids[1] != float64(3) {
-		t.Errorf("site_ids = %v", got["site_ids"])
-	}
-	// Node's getLiveBackupConfigFromCLIOptions leaves the unused fields
-	// `undefined`, and JSON.stringify drops them — so the flag path must NOT
-	// emit empty tables/wpcli_command keys.
-	if _, ok := got["tables"]; ok {
-		t.Errorf("flag path emitted a tables key: %v", got)
-	}
-	if _, ok := got["wpcli_command"]; ok {
-		t.Errorf("flag path emitted a wpcli_command key: %v", got)
-	}
-
-	raw, err = BuildConfig(&LiveCopyCLIOptions{UseLiveBackupCopy: true, WpcliCommand: "wp post list"})
-	if err != nil {
-		t.Fatal(err)
-	}
-	got = decodePayload(t, raw)
-	if got["type"] != "wpcli_command" || got["wpcli_command"] != "wp post list" {
-		t.Errorf("cfg = %v", got)
-	}
-}
-
-func TestBuildConfigFromFile(t *testing.T) {
-	raw, err := BuildConfig(&LiveCopyCLIOptions{
-		UseLiveBackupCopy: true,
-		ConfigFile:        writeConfig(t, `{"type":"tables","tables":{"wp_posts":{}}}`),
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-	got := decodePayload(t, raw)
-	tables, _ := got["tables"].(map[string]any)
-	if got["type"] != "tables" || len(tables) != 1 {
-		t.Errorf("cfg = %v", got)
-	}
-
-	dir := t.TempDir()
-	_, err = BuildConfig(&LiveCopyCLIOptions{UseLiveBackupCopy: true, ConfigFile: filepath.Join(dir, "nope.json")})
-	if err == nil || !strings.Contains(err.Error(), "Configuration file not found:") {
-		t.Errorf("err = %v", err)
-	}
-
-	_, err = BuildConfig(&LiveCopyCLIOptions{UseLiveBackupCopy: true, ConfigFile: writeConfig(t, "{nope")})
-	if err == nil || !strings.Contains(err.Error(), "Invalid JSON in configuration file:") {
-		t.Errorf("err = %v", err)
-	}
-}
-
-// TestBuildConfigFromFilePreservesUnknownKeys is register 2.18's first
-// defect. Node's loadLiveBackupCopyConfig (export-sql.ts:647-662) is a bare
-// `JSON.parse( … ) as DBLiveCopyConfig` — a compile-time cast with no runtime
-// filtering — and startLiveBackupCopy passes the parsed object straight into
-// the GraphQL `config: JSON` scalar. Every key the user wrote reaches the
-// server. Go decoded into a typed struct, so keys the struct didn't declare
-// (`exclude_tables`, `limit`, per-table `where` clauses) were silently
-// dropped: the user got a dump with the WRONG SCOPE and exit 0.
-func TestBuildConfigFromFilePreservesUnknownKeys(t *testing.T) {
-	raw, err := BuildConfig(&LiveCopyCLIOptions{
-		UseLiveBackupCopy: true,
-		ConfigFile: writeConfig(t, `{
-			"type": "tables",
-			"tool": "mysqldump",
-			"tables": {"wp_posts": {"where": "ID > 100"}},
-			"exclude_tables": ["wp_options", "wp_usermeta"],
-			"limit": 500
-		}`),
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-	got := decodePayload(t, raw)
-
-	excluded, ok := got["exclude_tables"].([]any)
-	if !ok || len(excluded) != 2 || excluded[0] != "wp_options" {
-		t.Errorf("exclude_tables was dropped: %v", got)
-	}
-	if got["limit"] != float64(500) {
-		t.Errorf("limit was dropped: %v", got)
-	}
-	tables, _ := got["tables"].(map[string]any)
-	wpPosts, _ := tables["wp_posts"].(map[string]any)
-	if wpPosts["where"] != "ID > 100" {
-		t.Errorf("per-table option was dropped: %v", got)
-	}
-	if got["tool"] != "mysqldump" {
-		t.Errorf("tool was dropped: %v", got)
-	}
-}
-
-// TestBuildConfigFromFilePreservesEmptyCollections is register 2.18's second
-// defect: `omitempty` on the typed struct deleted collections the user wrote
-// explicitly. `{"site_ids": []}` is a meaningful (if degenerate) scope; Node
-// sends it, Go used to send a config with no site_ids at all — which the
-// server reads as a different scope entirely.
-func TestBuildConfigFromFilePreservesEmptyCollections(t *testing.T) {
-	raw, err := BuildConfig(&LiveCopyCLIOptions{
-		UseLiveBackupCopy: true,
-		ConfigFile:        writeConfig(t, `{"type":"site_ids","site_ids":[],"tables":{},"wpcli_command":""}`),
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-	got := decodePayload(t, raw)
-	if _, ok := got["site_ids"]; !ok {
-		t.Errorf("empty site_ids was dropped by omitempty: %v", got)
-	}
-	if _, ok := got["tables"]; !ok {
-		t.Errorf("empty tables was dropped by omitempty: %v", got)
-	}
-	if _, ok := got["wpcli_command"]; !ok {
-		t.Errorf("empty wpcli_command was dropped by omitempty: %v", got)
-	}
-}
-
-// TestBuildConfigFromFileAcceptsBooleanTableOptions is register 2.18's third
-// defect. Node's own type says a per-table option value may be a boolean:
-//
-//	tables?: Record< string, Record< string, string | boolean > >
-//
-// (live-backup-copy.ts:123). Go's `map[string]map[string]string` made that a
-// hard unmarshal failure, so a config file Node accepts aborted the export.
-func TestBuildConfigFromFileAcceptsBooleanTableOptions(t *testing.T) {
-	raw, err := BuildConfig(&LiveCopyCLIOptions{
-		UseLiveBackupCopy: true,
-		ConfigFile: writeConfig(t,
-			`{"type":"tables","tables":{"wp_posts":{"where":"ID > 1","structure_only":true,"skip_data":false}}}`),
-	})
-	if err != nil {
-		t.Fatalf("boolean per-table option rejected (Node allows string | boolean): %v", err)
-	}
-	got := decodePayload(t, raw)
-	tables, _ := got["tables"].(map[string]any)
-	wpPosts, _ := tables["wp_posts"].(map[string]any)
-	if wpPosts["structure_only"] != true {
-		t.Errorf("structure_only = %v, want true", wpPosts["structure_only"])
-	}
-	if wpPosts["skip_data"] != false {
-		t.Errorf("skip_data = %v, want false", wpPosts["skip_data"])
-	}
-	if wpPosts["where"] != "ID > 1" {
-		t.Errorf("where = %v, want the string", wpPosts["where"])
-	}
-}
-
-// TestBuildConfigFromFileAllowsDuplicateKeys keeps the jsonv2 port from being
-// STRICTER than Node. `JSON.parse` accepts a duplicated object member and
-// keeps the last one; jsonv2 rejects duplicates by default, which would turn
-// a config file Node runs fine into a hard failure. That would be a new
-// divergence introduced by the fix, so it is opted out of explicitly.
-func TestBuildConfigFromFileAllowsDuplicateKeys(t *testing.T) {
-	raw, err := BuildConfig(&LiveCopyCLIOptions{
-		UseLiveBackupCopy: true,
-		ConfigFile:        writeConfig(t, `{"type":"tables","type":"site_ids","site_ids":[4]}`),
-	})
-	if err != nil {
-		t.Fatalf("duplicate key rejected; JSON.parse accepts it (last wins): %v", err)
-	}
-	got := decodePayload(t, raw)
-	if got["type"] != "site_ids" {
-		t.Errorf("type = %v, want site_ids (JSON.parse keeps the LAST duplicate)", got["type"])
-	}
-}
-
-// TestSiteIDCommaSplitIsADeliberateKeep pins cutover register item 1.12.
-//
-// Node's bin declares `--site-id` with `Number.parseInt` as the coercer
-// (src/bin/vip-export-sql.js:86-91), so `--site-id=2,3` arrives as the number
-// 2 and site 3 is silently dropped — even though Node's own `--site-id=2,3`
-// usage example (vip-export-sql.js:44-46) promises both sites. Go splits on
-// the comma and exports BOTH, matching the documented behaviour rather than
-// the shipped behaviour.
-//
-// That divergence is a decided KEEP. This test exists so a future agent
-// "fixing" it toward Node has to delete an explicit assertion rather than
-// quietly regress the scope of a partial export.
-func TestSiteIDCommaSplitIsADeliberateKeep(t *testing.T) {
-	opts, err := ParseLiveCopyCLIOptions("", nil, []string{"2,3"}, "")
-	if err != nil {
-		t.Fatal(err)
-	}
-	if len(opts.SiteIDs) != 2 || opts.SiteIDs[0] != "2" || opts.SiteIDs[1] != "3" {
-		t.Fatalf("SiteIDs = %v, want [2 3] (register 1.12 KEEP; Node's parseInt yields just [2])", opts.SiteIDs)
-	}
-
-	raw, err := BuildConfig(opts)
-	if err != nil {
-		t.Fatal(err)
-	}
-	got := decodePayload(t, raw)
-	ids, _ := got["site_ids"].([]any)
-	if len(ids) != 2 || ids[0] != float64(2) || ids[1] != float64(3) {
-		t.Errorf("site_ids = %v, want [2 3] on the wire (register 1.12 KEEP)", got["site_ids"])
-	}
-}

package/internal/sqlvalidation/devenv_checks_test.go

@@ -1,134 +0,0 @@
-package sqlvalidation
-
-import (
-	"strings"
-	"testing"
-)
-
-// devEnvOptions mirrors the option set Node's dev-env import passes
-// (src/commands/dev-env-import-sql.ts:96-100): skipChecks is EMPTY (for a
-// mysqldump), which overrides DEFAULT_VALIDATION_OPTIONS.skipChecks and turns
-// the two DEV_ENV_SPECIFIC_CHECKS back on, plus the expected local domain as
-// siteHomeUrlLando's extraCheckParam.
-func devEnvOptions(domain string) Options {
-	return Options{ExtraCheckParams: map[string]string{CheckSiteHomeURLLando: domain}}
-}
-
-func TestDevEnvOptionsRegisterUseStatement(t *testing.T) {
-	res, err := ValidateWith(strings.NewReader("USE my_database;\n"), devEnvOptions("e.vipdev.site"), nil)
-	if err != nil {
-		t.Fatalf("ValidateWith: %v", err)
-	}
-	c := findCheck(t, res, CheckUseStatement)
-	if len(c.Results) != 1 || c.Results[0].Line != 1 {
-		t.Errorf("useStatement: got %#v, want one result on line 1", c.Results)
-	}
-}
-
-func TestDevEnvUseStatementIsCaseInsensitiveAndAnchored(t *testing.T) {
-	res, _ := ValidateWith(strings.NewReader("use other_db;\nSELECT 'USE something';\n"), devEnvOptions("e.vipdev.site"), nil)
-	c := findCheck(t, res, CheckUseStatement)
-	if len(c.Results) != 1 || c.Results[0].Line != 1 {
-		t.Errorf("useStatement: got %#v, want only the anchored line 1 match", c.Results)
-	}
-}
-
-// Node sql.ts:344-369. A siteurl/home pointing anywhere but the local domain
-// is the finding that matters most for dev-env: importing production SQL
-// without a search-replace leaves the LOCAL site redirecting to production.
-func TestDevEnvSiteHomeURLLandoFlagsForeignDomain(t *testing.T) {
-	in := strings.NewReader(`INSERT INTO wp_options VALUES (1,'siteurl','https://example.com');` + "\n")
-	res, _ := ValidateWith(in, devEnvOptions("e.vipdev.site"), nil)
-	c := findCheck(t, res, CheckSiteHomeURLLando)
-	if len(c.Results) != 1 {
-		t.Fatalf("siteHomeUrlLando: got %#v, want 1 result", c.Results)
-	}
-	got := c.Results[0]
-	if got.FalsePositive {
-		t.Errorf("foreign domain marked falsePositive: %#v", got)
-	}
-	if got.Line != 1 {
-		t.Errorf("line = %d, want 1", got.Line)
-	}
-	want := `Use '--search-replace="example.com,e.vipdev.site"' switch to replace the domain`
-	if got.Recommendation != want {
-		t.Errorf("recommendation =\n %q\nwant %q", got.Recommendation, want)
-	}
-}
-
-// Node's matchHandler returns { falsePositive: true } for three shapes; each
-// must NOT produce a finding.
-func TestDevEnvSiteHomeURLLandoFalsePositives(t *testing.T) {
-	cases := []struct {
-		name string
-		sql  string
-	}{
-		// Not an absolute http(s) URL — Node's /^https?:\/\//i test fails.
-		{"relative value", `INSERT INTO wp_options VALUES (1,'siteurl','/blog');`},
-		// Scheme only: empty after stripping -> trim() is falsy.
-		{"scheme only", `INSERT INTO wp_options VALUES (1,'home','https://');`},
-		// Already points at the local environment.
-		{"matches expected domain", `INSERT INTO wp_options VALUES (1,'home','https://e.vipdev.site');`},
-		// Subdomain of the local environment still "includes" it.
-		{"subdomain of expected", `INSERT INTO wp_options VALUES (1,'home','https://sub.e.vipdev.site/x');`},
-	}
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			res, _ := ValidateWith(strings.NewReader(tc.sql+"\n"), devEnvOptions("e.vipdev.site"), nil)
-			c := findCheck(t, res, CheckSiteHomeURLLando)
-			for _, r := range c.Results {
-				if !r.FalsePositive {
-					t.Errorf("expected falsePositive, got %#v", r)
-				}
-			}
-		})
-	}
-}
-
-// Node's matcher for this check has no /i flag, so it is case-SENSITIVE on the
-// option name (unlike most other checks). Pinning it stops a future "cleanup"
-// from adding (?i) and diverging.
-func TestDevEnvSiteHomeURLLandoMatcherIsCaseSensitive(t *testing.T) {
-	in := strings.NewReader(`INSERT INTO wp_options VALUES (1,'SITEURL','https://example.com');` + "\n")
-	res, _ := ValidateWith(in, devEnvOptions("e.vipdev.site"), nil)
-	if c := findCheck(t, res, CheckSiteHomeURLLando); len(c.Results) != 0 {
-		t.Errorf("uppercase option name matched: %#v", c.Results)
-	}
-}
-
-// SkipChecks is honoured: Node passes ['dropTable','dropDB'] for a MyDumper
-// dump (dev-env-import-sql.ts:98).
-func TestValidateWithSkipChecksOmitsChecks(t *testing.T) {
-	opts := devEnvOptions("e.vipdev.site")
-	opts.SkipChecks = []string{"dropTable", "dropDB"}
-	res, _ := ValidateWith(strings.NewReader("DROP DATABASE wordpress;\n"), opts, nil)
-	for _, c := range res.Checks {
-		if c.Key == "dropTable" || c.Key == "dropDB" {
-			t.Errorf("%s must not be registered when skipped", c.Key)
-		}
-	}
-}
-
-// REGRESSION GUARD for the platform path: `vip import validate-sql` and
-// `vip import sql` run with DEFAULT_VALIDATION_OPTIONS, whose skipChecks is
-// DEV_ENV_SPECIFIC_CHECKS. Neither dev-env check may ever appear there.
-func TestPlatformValidateSkipsBothDevEnvChecks(t *testing.T) {
-	sql := "USE my_database;\n" +
-		`INSERT INTO wp_options VALUES (1,'siteurl','https://example.com');` + "\n"
-	res, err := Validate(strings.NewReader(sql))
-	if err != nil {
-		t.Fatalf("Validate: %v", err)
-	}
-	for _, c := range res.Checks {
-		if c.Key == CheckUseStatement || c.Key == CheckSiteHomeURLLando {
-			t.Errorf("%s must stay skipped on the platform validate-sql path", c.Key)
-		}
-	}
-}
-
-func TestPlatformOptionsSkipsDevEnvSpecificChecks(t *testing.T) {
-	got := PlatformOptions().SkipChecks
-	if len(got) != 2 || got[0] != CheckUseStatement || got[1] != CheckSiteHomeURLLando {
-		t.Errorf("PlatformOptions().SkipChecks = %v, want %v", got, DevEnvSpecificChecks)
-	}
-}

package/internal/sqlvalidation/filename.go

@@ -1,30 +0,0 @@
-package sqlvalidation
-
-import (
-	"errors"
-	"path/filepath"
-	"regexp"
-	"strings"
-)
-
-// validFilenameRE — Node sql.ts:106's /^[a-z0-9\-_.]+$/i.
-var validFilenameRE = regexp.MustCompile(`(?i)^[a-z0-9\-_.]+$`)
-
-// ValidateFilename ports validateFilename (sql.ts:105): the import file's
-// basename may only contain [0-9 a-z A-Z - _ .].
-func ValidateFilename(filename string) error {
-	if !validFilenameRE.MatchString(filename) {
-		return errors.New("Error: The characters used in the name of a file for import are limited to [0-9,a-z,A-Z,-,_,.]")
-	}
-	return nil
-}
-
-// ValidateImportFileExtension ports validateImportFileExtension
-// (sql.ts:98): only .sql and .gz files can be imported.
-func ValidateImportFileExtension(fileName string) error {
-	ext := strings.ToLower(filepath.Ext(fileName))
-	if ext != ".sql" && ext != ".gz" {
-		return errors.New("Invalid file extension. Please provide a .sql or .gz file.")
-	}
-	return nil
-}

package/internal/sqlvalidation/line_by_line.go

@@ -1,91 +0,0 @@
-// Package sqlvalidation ports Node's src/lib/validations/sql.ts +
-// is-multi-site-sql-dump.ts + line-by-line.ts to Go. Local-only — no
-// network calls.
-package sqlvalidation
-
-import (
-	"bufio"
-	"io"
-)
-
-// readBufSize is the size of the rolling read buffer. It is NOT a per-line
-// ceiling: lines longer than this are stitched together from successive
-// ReadSlice fragments (see ScanLines).
-//
-// Node's line-by-line.ts uses fd.readLines(), which imposes no per-line
-// limit whatsoever. We previously used a bufio.Scanner with a 16MB cap,
-// which rejected dumps Node validates fine — `mysqldump --extended-insert`
-// packs a whole table into one INSERT, mydumper does the same, and a single
-// row with a multi-MB LONGTEXT column is enough on its own. Worse, the
-// failure surfaced to the user as the raw Go internal
-// "bufio.Scanner: token too long".
-//
-// Memory: only ONE line is ever held at a time, so a multi-GB dump costs
-// max(readBufSize, longest line) — the file is never loaded whole.
-const readBufSize = 256 * 1024
-
-// ScanLines reads r line-by-line and calls fn for each line payload. Line
-// numbers are 1-indexed (Node's lineNum starts at 1 in sql.ts). Returns the
-// first non-nil error returned by fn (stops scanning on that line) or any
-// underlying read error.
-//
-// Line splitting matches bufio.ScanLines and Node's readline: '\n'
-// terminates a line and a single trailing '\r' is stripped, so CRLF dumps
-// behave identically. A final line without a trailing newline is still
-// delivered.
-//
-// Mirrors Node's src/lib/validations/line-by-line.ts getReadInterface +
-// the perLineValidations dispatch loop in sql.ts.
-func ScanLines(r io.Reader, fn func(line string, lineNum int) error) error {
-	br := bufio.NewReaderSize(r, readBufSize)
-
-	lineNum := 1
-	for {
-		line, err := readLine(br)
-		if err != nil && err != io.EOF {
-			return err
-		}
-		// At EOF with nothing buffered there is no final partial line.
-		if err == io.EOF && len(line) == 0 {
-			return nil
-		}
-		if cbErr := fn(string(trimEOL(line)), lineNum); cbErr != nil {
-			return cbErr
-		}
-		lineNum++
-		if err == io.EOF {
-			return nil
-		}
-	}
-}
-
-// readLine returns the next '\n'-terminated chunk, growing past the read
-// buffer when necessary. The returned slice may alias br's internal buffer
-// when the line fit in one read, so callers must copy (ScanLines converts
-// to string immediately) before the next read.
-func readLine(br *bufio.Reader) ([]byte, error) {
-	frag, err := br.ReadSlice('\n')
-	if err != bufio.ErrBufferFull {
-		return frag, err
-	}
-	// Long line: keep pulling fragments until the delimiter (or EOF).
-	// append copies frag out of br's buffer before it is reused.
-	buf := append([]byte(nil), frag...)
-	for err == bufio.ErrBufferFull {
-		frag, err = br.ReadSlice('\n')
-		buf = append(buf, frag...)
-	}
-	return buf, err
-}
-
-// trimEOL drops the trailing '\n' and an immediately preceding '\r',
-// matching bufio.ScanLines and Node's readline /\r?\n/ split.
-func trimEOL(b []byte) []byte {
-	if n := len(b); n > 0 && b[n-1] == '\n' {
-		b = b[:n-1]
-	}
-	if n := len(b); n > 0 && b[n-1] == '\r' {
-		b = b[:n-1]
-	}
-	return b
-}