@automattic/vip 3.19.0 → 3.19.2

package/dist/bin/vip-app.js

@@ -43,9 +43,13 @@ function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e
   await (0, _tracker.trackEvent)('app_command_success');
 
   // Clone the read-only response object so we can modify it
-  const clonedResponse = Object.assign({}, res);
+  const clonedResponse = {
+    ...res
+  };
   clonedResponse.environments = clonedResponse.environments.map(env => {
-    const clonedEnv = Object.assign({}, env);
+    const clonedEnv = {
+      ...env
+    };
     clonedEnv.name = (0, _command.getEnvIdentifier)(env);
 
     // Use the short version of git commit hash

package/dist/bin/vip-dev-env-info.js

@@ -13,17 +13,14 @@ const exampleUsage = 'vip dev-env info';
 const usage = 'vip dev-env info';
 const examples = [{
   usage: `${exampleUsage} --slug=example-site`,
-  description: 'Retrieve basic information about the local environment named "example-site".'
-}, {
-  usage: `${exampleUsage} --slug=example-site --extended`,
-  description: 'Retrieve a larger amount of information about the local environment named "example-site".'
+  description: 'Retrieve information about the local environment named "example-site".'
 }, {
   usage: `${exampleUsage} --all`,
-  description: 'Retrieve basic information about all local environments.'
+  description: 'Retrieve information about all local environments.'
 }];
 (0, _command.default)({
   usage
-}).option('slug', 'A unique name for a local environment. Default is "vip-local".', undefined, _devEnvironmentCli.processSlug).option('all', 'Retrieve information about all local environments.').option('extended', 'Retrieve a larger amount of information.').examples(examples).argv(process.argv, async (arg, opt) => {
+}).option('slug', 'A unique name for a local environment. Default is "vip-local".', undefined, _devEnvironmentCli.processSlug).option('all', 'Retrieve information about all local environments.').option('extended', 'Deprecated, not used.').examples(examples).argv(process.argv, async (arg, opt) => {
   let trackingInfo;
   let slug;
   const lando = await (0, _devEnvironmentLando.bootstrapLando)();
@@ -41,7 +38,7 @@ const examples = [{
   debug('Args: ', arg, 'Options: ', opt);
   try {
     const options = {
-      extended: Boolean(opt.extended),
+      extended: true,
       suppressWarnings: true
     };
     if (opt.all) {

package/dist/bin/vip-dev-env-sync-sql.js

@@ -4,7 +4,6 @@
 var _devEnvSyncSql = require("../commands/dev-env-sync-sql");
 var _command = _interopRequireDefault(require("../lib/cli/command"));
 var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
-var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core");
 var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
 var _tracker = require("../lib/tracker");
 var _userError = _interopRequireDefault(require("../lib/user-error"));
@@ -58,8 +57,8 @@ const appQuery = `
   });
   await trackerFn('execute');
   const lando = await (0, _devEnvironmentLando.bootstrapLando)();
-  const envPath = (0, _devEnvironmentCore.getEnvironmentPath)(slug);
-  if (!(await (0, _devEnvironmentLando.isEnvUp)(lando, envPath)) && !opt.force) {
+  const isUp = (await Promise.all([(0, _devEnvironmentLando.isContainerRunning)(lando, slug, 'php'), (0, _devEnvironmentLando.isContainerRunning)(lando, slug, 'database')])).every(Boolean);
+  if (!isUp && !opt.force) {
     await trackerFn('env_not_running_error', {
       errorMessage: 'Environment was not running'
     });

package/dist/bin/vip-import-sql.js

@@ -103,8 +103,8 @@ function isValidMd5(md5) {
 }
 
 /**
- * @param {AppForImport} app
- * @param {EnvForImport} env
+ * @param {import('../lib/site-import/db-file-import').AppForImport} app
+ * @param {import('../lib/site-import/db-file-import').EnvForImport} env
  * @param {string} fileNameOrURL
  * @param {boolean} isUrl
  * @param {string|null} md5
@@ -367,7 +367,7 @@ const displayPlaybook = ({
     }
   }
 };
-void (0, _command.default)({
+(0, _command.default)({
   appContext: true,
   appQuery,
   envContext: true,

package/dist/bin/vip-import-validate-files.js

@@ -8,7 +8,6 @@
 exports.__esModule = true;
 exports.vipImportValidateFilesCmd = vipImportValidateFilesCmd;
 var _chalk = _interopRequireDefault(require("chalk"));
-var _url = _interopRequireDefault(require("url"));
 var _command = _interopRequireDefault(require("../lib/cli/command"));
 var _config = require("../lib/media-import/config");
 var _tracker = require("../lib/tracker");
@@ -24,9 +23,7 @@ async function vipImportValidateFilesCmd(arg = []) {
    *
    * Manipulating the file path/name to extract the folder name
    */
-  const folder = arg.join(); // File comes in as an array as part of the args- turn it into a string
-  arg = _url.default.parse(folder); // Then parse the file to its URL parts
-  const filePath = arg.path; // Extract the path of the file
+  const filePath = arg.join(); // File comes in as an array as part of the args- turn it into a string
 
   if (!(await (0, _vipImportValidateFiles.isDirectory)(filePath))) {
     console.error(_chalk.default.red('✕ Error:'), 'The given path is not a directory. Provide a valid directory path.');

package/dist/bin/vip-wp.js

@@ -10,6 +10,7 @@ var _socket2 = _interopRequireDefault(require("socket.io-stream"));
 var _stream = require("stream");
 var _wpSsh = require("../commands/wp-ssh");
 var _api = _interopRequireWildcard(require("../lib/api"));
+var _app = require("../lib/app");
 var _command = _interopRequireWildcard(require("../lib/cli/command"));
 var exit = _interopRequireWildcard(require("../lib/cli/exit"));
 var _format = require("../lib/cli/format");
@@ -20,7 +21,7 @@ var _tracker = require("../lib/tracker");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function (e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != typeof e && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (const t in e) "default" !== t && {}.hasOwnProperty.call(e, t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, t)) && (i.get || i.set) ? o(f, t, i) : f[t] = e[t]); return f; })(e, t); }
 function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 const debug = (0, _debug.default)('@automattic/vip:wp');
-const appQuery = `id, name,
+const appQuery = `id, name, typeId,
 	organization {
 		id
 		name
@@ -103,7 +104,6 @@ const bindStreamEvents = ({
     if (!isSubShell) {
       subShellRl.close();
       process.exit();
-      return;
     }
     subShellRl.resume();
     subShellRl.prompt();
@@ -131,6 +131,14 @@ const getTokenForCommand = async (appId, envId, command) => {
     }
   });
 };
+
+/**
+ * Returns the error so it can be caught by the `socket.on('error')`.
+ *
+ * @param {Error} err
+ * @returns {Error}
+ */
+const onSocketError = err => err;
 const launchCommandAndGetStreams = async ({
   socket,
   guid,
@@ -162,10 +170,7 @@ const launchCommandAndGetStreams = async ({
     socket.close();
     exit.withError(`Cancel received from server: ${message}`);
   });
-  (0, _socket2.default)(socket).on('error', err => {
-    // This returns the error so it can be catched by the socket.on('error')
-    return err;
-  });
+  (0, _socket2.default)(socket).off('error', onSocketError).on('error', onSocketError);
   socket.on('error', err => {
     if (err === 'Rate limit exceeded') {
       console.log(_chalk.default.red('\nError:'), 'Rate limit exceeded: Please wait a moment and try again.');
@@ -262,10 +267,17 @@ const bindReconnectEvents = ({
 
     // create a new input stream so that we can still catch things like SIGINT while reconnecting
     if (currentJob.stdinStream) {
-      process.stdin.unpipe(currentJob.stdinStream);
+      unpipeStreamsFromProcess({
+        stdin: currentJob.stdinStream,
+        stdout: currentJob.stdoutStream
+      });
     }
-    process.stdin.pipe(_socket2.default.createStream());
+    currentJob.stdinStream = _socket2.default.createStream();
     currentJob.stdoutStream = _socket2.default.createStream();
+    pipeStreamsToProcess({
+      stdin: currentJob.stdinStream,
+      stdout: currentJob.stdoutStream
+    });
     bindStreamEvents({
       subShellRl,
       isSubShell,
@@ -306,6 +318,7 @@ const examples = [{
   const {
     id: appId,
     name: appName,
+    typeId: appTypeId,
     organization: {
       id: orgId
     }
@@ -314,6 +327,9 @@ const examples = [{
     id: envId,
     type: envName
   } = opts.env;
+  if ((0, _app.isAppNodejs)(appTypeId)) {
+    exit.withError('WP-CLI commands are not supported on Node.js environments.');
+  }
 
   /* eslint-disable camelcase */
   const commonTrackingParams = {

package/dist/commands/dev-env-import-sql.js

@@ -55,7 +55,8 @@ class DevEnvImportSQLCommand {
     } = this.options;
     const resolvedPath = await (0, _devEnvironmentCore.resolveImportPath)(this.slug, this.fileName, searchReplace, inPlace);
     if (!this.options.skipValidate) {
-      if (!(await (0, _devEnvironmentLando.isEnvUp)(lando, (0, _devEnvironmentCore.getEnvironmentPath)(this.slug)))) {
+      const isUp = (await Promise.all([(0, _devEnvironmentLando.isContainerRunning)(lando, this.slug, 'php'), (0, _devEnvironmentLando.isContainerRunning)(lando, this.slug, 'database')])).every(Boolean);
+      if (!isUp) {
         throw new _userError.default('Environment needs to be started first');
       }
       const expectedDomain = `${this.slug}.${lando.config.domain}`;

package/dist/commands/phpmyadmin.js

@@ -138,12 +138,12 @@ class PhpMyAdminCommand {
     const {
       default: open
     } = await import('open');
-    void open(url, {
+    return open(url, {
       wait: false
     });
   }
   async getStatus() {
-    return await getPhpMyAdminStatus(this.app.id, this.env.id);
+    return getPhpMyAdminStatus(this.app.id, this.env.id);
   }
   async maybeEnablePhpMyAdmin() {
     const status = await this.getStatus();

package/dist/lib/api/http.js

@@ -29,8 +29,6 @@ var _default = async (path, options = {}) => {
     url = `${_api.API_HOST}${path}`;
   }
   const authToken = await _token.default.get();
-
-  // TODO: remove this cast once the typings are fixed
   const proxyAgent = (0, _proxyAgent.createProxyAgent)(url);
   debug('running fetch', url);
   return (0, _nodeFetch.default)(url, {

package/dist/lib/cli/command.js

@@ -316,21 +316,19 @@ _args.default.argv = async function (argv, cb) {
   }
 
   // Negotiate flag values
-  switch (_opts.module) {
-    case 'import-media':
-      if ([true, 'true', 'yes'].includes(options.saveErrorLog)) {
-        options.saveErrorLog = 'true';
-      } else if ([false, 'false', 'no'].includes(options.saveErrorLog)) {
-        options.saveErrorLog = 'false';
-      } else {
-        options.saveErrorLog = 'prompt';
-      }
-      break;
+  if (_opts.module === 'import-media') {
+    if ([true, 'true', 'yes'].includes(options.saveErrorLog)) {
+      options.saveErrorLog = 'true';
+    } else if ([false, 'false', 'no'].includes(options.saveErrorLog)) {
+      options.saveErrorLog = 'false';
+    } else {
+      options.saveErrorLog = 'prompt';
+    }
   }
 
   // Prompt for confirmation if necessary
   if (_opts.requireConfirm && !options.force) {
-    /** @type {Tuple[]} */
+    /** @type {import('./format').Tuple[]} */
     const info = [];
     if (options.app) {
       info.push({

package/dist/lib/cli/config.js

@@ -2,19 +2,38 @@
 
 exports.__esModule = true;
 exports.default = void 0;
+exports.loadConfigFile = loadConfigFile;
 var _debug = _interopRequireDefault(require("debug"));
+var _nodeFs = require("node:fs");
+var _nodePath = _interopRequireDefault(require("node:path"));
 function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
+// I don't like using synchronous versions, but until we migrate to ESM, we have to.
+
 const debug = (0, _debug.default)('@automattic/vip:lib:cli:config');
-let configFromFile;
-try {
+function loadConfigFile() {
+  const paths = [
   // Get `local` config first; this will only exist in dev as it's npmignore-d.
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
-  configFromFile = require('../../../config/config.local.json');
-  debug('Loaded config data from config.local.json');
-} catch {
-  // Fall back to `publish` config file.
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
-  configFromFile = require('../../../config/config.publish.json');
-  debug('Loaded config data from config.publish.json');
+  _nodePath.default.join(__dirname, '../../../config/config.local.json'), _nodePath.default.join(__dirname, '../../../config/config.publish.json')];
+  for (const filePath of paths) {
+    try {
+      const data = (0, _nodeFs.readFileSync)(filePath, 'utf-8');
+      debug(`Found config file at ${filePath}`);
+      return JSON.parse(data);
+    } catch (err) {
+      if (!(err instanceof Error) || !('code' in err) || err.code !== 'ENOENT') {
+        debug(`Error reading config file at ${filePath}:`, err);
+      }
+    }
+  }
+  return null;
+}
+const configFromFile = loadConfigFile();
+if (null === configFromFile) {
+  // This should not happen because `config/config.publish.json` is always present.
+  console.error('FATAL ERROR: Could not find a valid configuration file');
+  process.exit(1);
 }
-var _default = exports.default = configFromFile;
+
+// Without this, TypeScript will export `configFromFile` as `Config | null`
+const exportedConfig = configFromFile;
+var _default = exports.default = exportedConfig;

package/dist/lib/cli/format.js

@@ -91,14 +91,10 @@ function keyValue(values) {
     value
   } of values) {
     let formattedValue;
-    switch (key.toLowerCase() // NOSONAR
-    ) {
-      case 'environment':
-        formattedValue = formatEnvironment(value);
-        break;
-      default:
-        formattedValue = value;
-        break;
+    if (key.toLowerCase() === 'environment') {
+      formattedValue = formatEnvironment(value);
+    } else {
+      formattedValue = value;
     }
     lines.push(`+ ${key}: ${formattedValue}`);
   }

package/dist/lib/config/software.js

@@ -315,7 +315,8 @@ const formatSoftwareSettings = (softwareSetting, includes, format) => {
   if (includes.includes('available_versions')) {
     result.available_versions = _optionsForVersion(softwareSetting).filter(option => !option.deprecated).map(option => option.value);
     if (format !== 'json') {
-      result.available_versions = result.available_versions.sort().join(',');
+      result.available_versions.sort((lhs, rhs) => lhs.localeCompare(rhs));
+      result.available_versions = result.available_versions.join(',');
     }
   }
   return result;

package/dist/lib/dev-environment/dev-environment-core.js

@@ -155,8 +155,6 @@ function preProcessInstanceData(instanceData) {
     // We need to make sure the redirect is an absolute path
     newInstanceData.mediaRedirectDomain = `https://${instanceData.mediaRedirectDomain}`;
   }
-
-  // isNaN supports only number in TypeScript, actually, because isNaN('123') returns false despite being a string
   if (isNaN(instanceData.wordpress.tag)) {
     newInstanceData.wordpress.tag = 'trunk';
   }
@@ -692,7 +690,6 @@ async function maybeUpdateVersion(lando, slug) {
  */
 function fetchVersionList() {
   const url = `https://${_devEnvironment.DEV_ENVIRONMENT_RAW_GITHUB_HOST}${_devEnvironment.DEV_ENVIRONMENT_WORDPRESS_VERSIONS_URI}`;
-  // TODO: remove this cast once the typings are fixed
   const proxyAgent = (0, _proxyAgent.createProxyAgent)(url);
   return (0, _nodeFetch.default)(url, {
     agent: proxyAgent ?? undefined

package/dist/lib/dev-environment/dev-environment-lando.js

@@ -4,6 +4,7 @@ exports.__esModule = true;
 exports.bootstrapLando = bootstrapLando;
 exports.checkEnvHealth = checkEnvHealth;
 exports.getProxyContainer = getProxyContainer;
+exports.isContainerRunning = isContainerRunning;
 exports.isEnvUp = isEnvUp;
 exports.landoDestroy = landoDestroy;
 exports.landoExec = landoExec;
@@ -594,4 +595,18 @@ function validateDockerInstalled(lando) {
       throw new Error(`docker-compose version ${compose} is not supported. Please upgrade to version 2.0.0 or higher - https://docs.docker.com/compose/install/`);
     }
   }
+}
+async function isContainerRunning(lando, slug, serviceName) {
+  const envPath = (0, _devEnvironmentCore.getEnvironmentPath)(slug);
+  const app = await getLandoApplication(lando, envPath);
+  const {
+    docker
+  } = app.engine;
+  const containers = await docker.listContainers({
+    filters: {
+      label: [`com.docker.compose.project=${app.project}`, `com.docker.compose.service=${serviceName}`],
+      status: ['running']
+    }
+  });
+  return containers.length > 0;
 }

package/dist/lib/keychain.js

@@ -5,17 +5,18 @@ exports.default = void 0;
 var _debug = _interopRequireDefault(require("debug"));
 var _insecure = _interopRequireDefault(require("./keychain/insecure"));
 function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
-let exportValue;
+let keychain;
 const debug = (0, _debug.default)('@automattic/vip:keychain');
 try {
   // Try using Secure keychain ("keytar") first
   // eslint-disable-next-line @typescript-eslint/no-var-requires
   const Secure = require('./keychain/secure');
-  exportValue = new Secure();
+  keychain = new Secure();
 } catch (error) {
   debug('Cannot use Secure keychain; falling back to Insecure keychain (Details: %o)', error);
 
   // Fallback to Insecure keychain if we can't
-  exportValue = new _insecure.default('vip-go-cli');
+  keychain = new _insecure.default('vip-go-cli');
 }
-var _default = exports.default = exportValue;
+const exportedKeychain = keychain;
+var _default = exports.default = exportedKeychain;

package/dist/lib/validations/line-by-line.js

@@ -44,7 +44,7 @@ async function fileLineValidations(appId, envId, fileName, validations, searchRe
   await new Promise(resolve => readInterface.on('close', resolve));
   readInterface.close();
   return Promise.all(validations.map(validation => {
-    if (Object.prototype.hasOwnProperty.call(validation, 'postLineExecutionProcessing') && typeof validation.postLineExecutionProcessing === 'function') {
+    if (Object.hasOwn(validation, 'postLineExecutionProcessing') && typeof validation.postLineExecutionProcessing === 'function') {
       return validation.postLineExecutionProcessing({
         fileName,
         isImport,

package/docs/CHANGELOG.md

@@ -1,5 +1,42 @@
 ## Changelog
 
+### 3.19.2
+
+* Improve environment checks when importing or syncing local databases to prevent common errors.
+* Remove outdated options and clarify usage instructions for environment info commands.
+* Prevent certain unsupported commands from running in incompatible environments.
+* Upgrade internal components for better compatibility and future support.
+
+* refactor(dev-env): deprecate `extended` option in `vip dev-env info`
+* build(deps-dev): bump typescript from 5.8.3 to 5.9.2
+* build(deps): bump @automattic/vip-search-replace from 1.1.3 to 2.0.0
+* Do not allow WP-CLI commands to be run from Node Apps
+* build(deps-dev): bump @types/node from 24.1.0 to 24.2.0
+* refactor(dev-env): use `isContainerRunning` for import and sync commands
+
+**Full Changelog**: https://github.com/Automattic/vip-cli/compare/3.19.1...3.19.2
+
+### 3.19.1
+
+* build(deps-dev): bump @types/node from 24.0.12 to 24.0.13
+* build(deps): bump open from 10.1.2 to 10.2.0
+* build(deps-dev): bump @types/node from 24.0.13 to 24.0.14
+* build(deps): bump step-security/harden-runner from 2.12.2 to 2.13.0
+* ci: add AI Changelog workflow
+* build(deps-dev): bump @types/node from 24.0.14 to 24.0.15
+* build(deps-dev): bump @types/node from 24.0.15 to 24.1.0
+* build(deps-dev): bump the testing group with 3 updates
+* security: update `form-data` to fix CVE-2025-7783
+* fix(wp): resource leak during reconnection
+* fix(wp): EventEmitter memory leak for `error` listeners
+* refactor: remove deprecated `url.parse()` in favor of WHATWG URL API
+* ci: simplify changelog generation workflow
+* chore(deps): replace `socket.io-stream` with a fork
+* fix: code smells detected by SonarCloud
+* chore(deps): update Lando
+
+**Full Changelog**: https://github.com/Automattic/vip-cli/compare/3.19.0...3.19.1
+
 ### 3.19.0
 
 * build(deps-dev): bump the testing group across 1 directory with 4 updates