@automattic/vip 2.30.0 → 2.31.0

package/CHANGELOG.md

@@ -1,5 +1,30 @@
 ## Changelog
 
+### 2.31.0
+
+- #1397	feature(dev-env): Add ability to sync multisites
+- #1399	chore(dev-deps): Remove stub type definitions
+- #1394	FORNO-1609: Combine all error events into one error event
+- #1345	feat(dev-env): Add Photon
+- #1398	Fix coverage generation
+- #1395	Add types for the other ways of using enquirer
+- #1388	Typescript: refactor `vip-whoami`
+- #1393	refactor: Convert `lib/{app-logs,envvar}` to TypeScript
+- #1392	refactor: Convert `lib/config` to TypeScript
+- #1391	refactor: Convert lib to TypeScript
+- #1390	chore(deps): Update @automattic/vip-search-replace to 1.1.1
+- #1389	Replace 'site' by 'environment' in error msg
+- #1385	refactor: Convert lib/api to TypeScript
+- #1387	chore(deps): Update @automattic/vip-search-replace to 1.1.0
+- #1386	fix: Fix `getAbsolutePath()` and convert `utils.js` to TypeScript
+- #1383	fix(dev-env): Pull uniqueLabel field from backend
+- #1382	test: Reduce noise from tests
+- #1384	fix: Add return type to parseEnvAliasFromArgv()
+- #1381	refactor: Convert lib/cli and dependencies to TypeScript
+- #1377	chore: Configure linting for TS files
+- #1380	chore(dev-deps): Remove jest-environment-jsdom
+- #1378	refactor: Convert analytics and dependencies to TypeScript
+
 ### 2.30.0
 
 - #1264	feature(dev-env): Add dev-env-sync-sql command

package/assets/dev-env.lando.template.yml.ejs

@@ -222,6 +222,20 @@ services:
         LANDO_NEEDS_EXEC: 1
 <% } %>
 
+<% if ( photon ) { %>
+  photon:
+    type: compose
+    services:
+      image: ghcr.io/automattic/vip-container-images/photon:latest
+      command: /usr/sbin/php-fpm
+      environment:
+        LANDO_NO_USER_PERMS: 1
+        LANDO_NO_SCRIPTS: 1
+        LANDO_NEEDS_EXEC: 1
+      volumes:
+        - ./uploads:/usr/share/webapps/photon/uploads:ro
+<% } %>
+
 tooling:
   wp:
     service: php

package/assets/dev-env.nginx.template.conf.ejs

@@ -1,6 +1,27 @@
+<% if ( photon ) { %>
+
+location ^~ /wp-content/uploads/ {
+    expires max;
+    log_not_found off;
 <% if ( mediaRedirectDomain ) { %>
+    if (!-f $request_filename) {
+        rewrite ^/(.*)$ <%= mediaRedirectDomain %>/$1 redirect;
+    }
+<% } %>
+
+    include fastcgi_params;
+    fastcgi_param DOCUMENT_ROOT /usr/share/webapps/photon;
+    fastcgi_param SCRIPT_FILENAME /usr/share/webapps/photon/index.php;
+    fastcgi_param SCRIPT_NAME /index.php;
+
+    if ($request_uri ~* \.(gif|jpe?g|png)\?) {
+        fastcgi_pass photon:9000;
+    }
+}
+
+<% } else if ( mediaRedirectDomain ) { %>
 
-location ~* /wp-content/uploads {
+location ^~ /wp-content/uploads {
     expires max;
     log_not_found off;
     try_files $uri @prod_site;
@@ -10,4 +31,4 @@ location @prod_site {
     rewrite ^/(.*)$ <%= mediaRedirectDomain %>/$1 redirect;
 }
 
-<% } %>
+<% } %>

package/dist/bin/vip-dev-env-shell.js

@@ -29,7 +29,8 @@ const userMap = {
   elasticsearch: 'elasticsearch',
   phpmyadmin: 'www-data',
   mailhog: 'mailhog',
-  mailpit: 'root'
+  mailpit: 'root',
+  photon: 'root'
 };
 const examples = [{
   usage: `${_devEnvironment.DEV_ENVIRONMENT_FULL_COMMAND} shell`,

package/dist/bin/vip-dev-env-sync-sql.js

@@ -8,9 +8,12 @@
 /**
  * External dependencies
  */
+
+/**
+ * Internal dependencies
+ */
 "use strict";
 
-var _chalk = _interopRequireDefault(require("chalk"));
 var _command = _interopRequireDefault(require("../lib/cli/command"));
 var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core");
 var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
@@ -19,9 +22,6 @@ var _devEnvSyncSql = require("../commands/dev-env-sync-sql");
 var _devEnvironment = require("../lib/constants/dev-environment");
 var _tracker = require("../lib/tracker");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-/**
- * Internal dependencies
- */
 const examples = [{
   usage: `${_devEnvironment.DEV_ENVIRONMENT_FULL_COMMAND} sync sql @my-test.develop --slug=my_site`,
   description: 'Syncs with the `my-test` site\'s `develop` environment database into `my_site`'
@@ -39,6 +39,13 @@ const appQuery = `
 		primaryDomain { name }
 		uniqueLabel
 		isMultisite
+		wpSitesSDS(first:500) {
+			nodes {
+				id
+				blogId
+				homeUrl
+			}
+		}
 	}
 `;
 (0, _command.default)({
@@ -55,23 +62,10 @@ const appQuery = `
   const trackerFn = (0, _tracker.makeCommandTracker)('dev_env_sync_sql', {
     app: app.id,
     env: env.uniqueLabel,
-    slug
+    slug,
+    multisite: env.isMultisite
   });
   await trackerFn('execute');
-  if (env.isMultisite) {
-    console.log(_chalk.default.yellow('You seem to be trying to sync a SQL database for a network site.'));
-    console.log(_chalk.default.yellow('Unfortunately, the current version of our tool does not yet support syncing network sites.\n'));
-    console.log(_chalk.default.yellow('However, you can manually export the database using the following command:'));
-    console.log(_chalk.default.yellow(_chalk.default.bold(`vip export sql @${app.id}.${env.uniqueLabel} --output=${app.id}-${env.uniqueLabel}-exported.sql.gz\n`)));
-    console.log(_chalk.default.yellow('After exporting the database, you\'ll need to perform the necessary search and replace operations on the exported file to update any relevant data or configurations.'));
-    console.log(_chalk.default.yellow('See: https://docs.wpvip.com/how-tos/dev-env-add-content/#h-3-import-the-sql-file\n'));
-    console.log(_chalk.default.yellow('Once you\'ve made the required changes, you can import the modified SQL file into your development environment using the following command:'));
-    console.log(_chalk.default.yellow(_chalk.default.bold(`vip dev-env import sql ${app.id}-${env.uniqueLabel}-exported.sql.gz --slug=${slug}`)));
-    await trackerFn('aborted', {
-      error_type: 'multisite_not_supported'
-    });
-    process.exit(0);
-  }
   const lando = await (0, _devEnvironmentLando.bootstrapLando)();
   const envPath = (0, _devEnvironmentCore.getEnvironmentPath)(slug);
   if (!(await (0, _devEnvironmentLando.isEnvUp)(lando, envPath))) {
@@ -81,6 +75,8 @@ const appQuery = `
     throw new _userError.default('Environment needs to be started first');
   }
   const cmd = new _devEnvSyncSql.DevEnvSyncSQLCommand(app, env, slug, trackerFn);
+  // TODO: There's a function called handleCLIException for dev-env that handles exceptions but DevEnvSyncSQLCommand has its own implementation.
+  // We should probably use handleCLIException instead?
   await cmd.run();
   await trackerFn('success');
 });

package/dist/bin/vip-dev-env-update.js

@@ -64,6 +64,7 @@ cmd.argv(process.argv, async (arg, opt) => {
       phpmyadmin: currentInstanceData.phpmyadmin,
       xdebug: currentInstanceData.xdebug,
       mailpit: (_currentInstanceData$ = currentInstanceData.mailpit) !== null && _currentInstanceData$ !== void 0 ? _currentInstanceData$ : currentInstanceData.mailhog,
+      photon: currentInstanceData.photon,
       mediaRedirectDomain: currentInstanceData.mediaRedirectDomain,
       multisite: false,
       title: ''

package/dist/bin/vip-export-sql.js

@@ -26,17 +26,18 @@ const examples = [{
   description: 'The output file can be specified with the --output flag'
 }];
 const appQuery = `
-  id,
-  name,
-  type,
-  organization { id, name },
-  environments{
-    id
-    appId
-    type
-    name
-    primaryDomain { name }
-  }
+	id,
+	name,
+	type,
+	organization { id, name },
+	environments{
+		id
+		appId
+		type
+		name
+		primaryDomain { name }
+		uniqueLabel
+	}
 `;
 (0, _command.default)({
   appContext: true,

package/dist/bin/vip-import-sql.js

@@ -317,7 +317,7 @@ const displayPlaybook = ({
     }
   }
 };
-(0, _command.default)({
+void (0, _command.default)({
   appContext: true,
   appQuery,
   envContext: true,
@@ -498,7 +498,7 @@ Processing the SQL import for your environment...
   } catch (uploadError) {
     await track('import_sql_command_error', {
       error_type: 'upload_failed',
-      upload_error: uploadError
+      upload_error: uploadError.message
     });
     progressTracker.stepFailed('upload');
     return failWithError(uploadError);

package/dist/bin/vip-whoami.js

@@ -1,10 +1,5 @@
 #!/usr/bin/env node
 
-/**
- * 
- * @format
- */
-
 /**
  * External dependencies
  */
@@ -26,28 +21,30 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 async function whoamiCommand() {
+  var _currentUser$displayN, _currentUser$id;
   const trackingParams = {
     command: 'vip whoami'
   };
   await (0, _tracker.trackEvent)('whoami_command_execute', trackingParams);
-  let currentUser = {};
+  let currentUser;
   try {
     currentUser = await (0, _user.getCurrentUserInfo)();
   } catch (err) {
+    const error = err instanceof Error ? err : new Error('Unknown error');
     await (0, _tracker.trackEvent)('whoami_command_error', {
       ...trackingParams,
-      error: err.message
+      error: error.message
     });
-    exit.withError(`Failed to fetch information about the currently logged-in user error: ${err.message}`);
+    exit.withError(`Failed to fetch information about the currently logged-in user error: ${error.message}`);
   }
   await (0, _tracker.trackEvent)('whoami_command_success', trackingParams);
-  const output = [`- Howdy ${currentUser.displayName}!`, `- Your user ID is ${currentUser.id}`];
+  const output = [`- Howdy ${(_currentUser$displayN = currentUser.displayName) !== null && _currentUser$displayN !== void 0 ? _currentUser$displayN : 'user'}!`, `- Your user ID is ${(_currentUser$id = currentUser.id) !== null && _currentUser$id !== void 0 ? _currentUser$id : ' not found'}`];
   if (currentUser.isVIP) {
     output.push('- Your account has VIP Staff permissions');
   }
   console.log(output.join('\n'));
 }
-(0, _command.default)({
+void (0, _command.default)({
   usage: 'vip whoami'
 }).examples([{
   usage: 'vip whoami',

package/dist/commands/dev-env-sync-sql.js

@@ -37,13 +37,10 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
  * @return {string} Site home url. null if not found
  */
 function findSiteHomeUrl(sql) {
+  var _sql$match;
   const regex = "'(siteurl|home)',\\s?'(.*?)'";
-  const results = sql.match(regex);
-  if (results) {
-    const url = results[2];
-    return _url.default.parse(url).hostname;
-  }
-  return null;
+  const url = ((_sql$match = sql.match(regex)) === null || _sql$match === void 0 ? void 0 : _sql$match[2]) || '';
+  return _url.default.parse(url).hostname || null;
 }
 
 /**
@@ -60,11 +57,12 @@ async function extractSiteUrls(sqlFile) {
     readInterface.on('line', line => {
       const domain = findSiteHomeUrl(line);
       if (domain) {
-        domains.add('//' + domain);
+        domains.add(domain);
       }
     });
     readInterface.on('close', () => {
-      resolve(Array.from(domains));
+      // Soring by length so that longest domains are replaced first
+      resolve(Array.from(domains).sort((dom1, dom2) => dom2.length - dom1.length));
     });
     readInterface.on('error', reject);
   });
@@ -86,7 +84,7 @@ class DevEnvSyncSQLCommand {
     this.tmpDir = (0, _utils.makeTempDir)();
   }
   get landoDomain() {
-    return `//${this.slug}.vipdev.lndo.site`;
+    return `${this.slug}.vipdev.lndo.site`;
   }
   get sqlFile() {
     return `${this.tmpDir}/sql-export.sql`;
@@ -114,7 +112,7 @@ class DevEnvSyncSQLCommand {
    * @throws {Error} If there is an error reading the file
    */
   async runSearchReplace() {
-    const replacements = this.siteUrls.reduce((acc, url) => [...acc, url, this.landoDomain], []);
+    const replacements = Object.entries(this.searchReplaceMap).flat();
     const readStream = _fs.default.createReadStream(this.sqlFile);
     const replacedStream = await (0, _vipSearchReplace.replace)(readStream, replacements);
     const outputFile = `${this.tmpDir}/sql-export-sr.sql`;
@@ -127,6 +125,20 @@ class DevEnvSyncSQLCommand {
       replacedStream.on('error', reject);
     });
   }
+  generateSearchReplaceMap() {
+    this.searchReplaceMap = {};
+    for (const url of this.siteUrls) {
+      this.searchReplaceMap[url] = this.landoDomain;
+    }
+    const networkSites = this.env.wpSitesSDS.nodes;
+    if (!networkSites) return;
+    for (const site of networkSites) {
+      if (!site.blogId || site.blogId === 1) continue;
+      const url = site.homeUrl.replace(/https?:\/\//, '');
+      if (!this.searchReplaceMap[url]) continue;
+      this.searchReplaceMap[url] = `${site.blogId}.${this.landoDomain}`;
+    }
+  }
 
   /**
    * Runs the SQL import command to import the SQL file
@@ -153,6 +165,14 @@ class DevEnvSyncSQLCommand {
     try {
       await this.generateExport();
     } catch (err) {
+      // this.generateExport probably catches all exceptions, track the event and runs exit.withError() but if things go really wrong
+      // and we have no tracking data, we would at least have it logged here.
+      // the following will not get executed if this.generateExport() calls exit.withError() on all exception
+      await this.track('error', {
+        error_type: 'export_sql_backup',
+        error_message: err === null || err === void 0 ? void 0 : err.message,
+        stack: err === null || err === void 0 ? void 0 : err.stack
+      });
       exit.withError(`Error exporting SQL backup: ${err === null || err === void 0 ? void 0 : err.message}`);
     }
     try {
@@ -160,27 +180,38 @@ class DevEnvSyncSQLCommand {
       await (0, _clientFileUploader.unzipFile)(this.gzFile, this.sqlFile);
       console.log(`${_chalk.default.green('✓')} Extracted to ${this.sqlFile}`);
     } catch (err) {
-      await this.track('archive_extraction_error', {
-        errorMessage: err === null || err === void 0 ? void 0 : err.message
+      await this.track('error', {
+        error_type: 'archive_extraction',
+        error_message: err === null || err === void 0 ? void 0 : err.message,
+        stack: err === null || err === void 0 ? void 0 : err.stack
       });
-      exit.withError(`Error extracting the SQL export: ${err === null || err === void 0 ? void 0 : err.message}`);
+      exit.withError(`Error extracting the SQL export: ${err.message}`);
     }
     try {
       console.log('Extracting site urls from the SQL file...');
       this.siteUrls = await extractSiteUrls(this.sqlFile);
     } catch (err) {
+      await this.track('error', {
+        error_type: 'extract_site_urls',
+        error_message: err === null || err === void 0 ? void 0 : err.message,
+        stack: err === null || err === void 0 ? void 0 : err.stack
+      });
       exit.withError(`Error extracting site URLs: ${err === null || err === void 0 ? void 0 : err.message}`);
     }
+    console.log('Generating search-replace configuration...');
+    this.generateSearchReplaceMap();
     try {
       console.log('Running the following search-replace operations on the SQL file:');
-      this.siteUrls.forEach(domain => {
-        console.log(`  ${domain} -> ${this.landoDomain}`);
-      });
+      for (const [domain, landoDomain] of Object.entries(this.searchReplaceMap)) {
+        console.log(`  ${domain} -> ${landoDomain}`);
+      }
       await this.runSearchReplace();
       console.log(`${_chalk.default.green('✓')} Search-replace operation is complete`);
     } catch (err) {
-      await this.track('search_replace_error', {
-        errorMessage: err === null || err === void 0 ? void 0 : err.message
+      await this.track('error', {
+        error_type: 'search_replace',
+        error_message: err === null || err === void 0 ? void 0 : err.message,
+        stack: err === null || err === void 0 ? void 0 : err.stack
       });
       exit.withError(`Error replacing domains: ${err === null || err === void 0 ? void 0 : err.message}`);
     }
@@ -189,8 +220,10 @@ class DevEnvSyncSQLCommand {
       await this.runImport();
       console.log(`${_chalk.default.green('✓')} SQL file imported`);
     } catch (err) {
-      await this.track('import_error', {
-        errorMessage: err === null || err === void 0 ? void 0 : err.message
+      await this.track('error', {
+        error_type: 'import_sql_file',
+        error_message: err === null || err === void 0 ? void 0 : err.message,
+        stack: err === null || err === void 0 ? void 0 : err.stack
       });
       exit.withError(`Error importing SQL file: ${err === null || err === void 0 ? void 0 : err.message}`);
     }

package/dist/commands/export-sql.js

@@ -322,7 +322,8 @@ class ExportSQLCommand {
       } catch (err) {
         await this.track('error', {
           error_type: 'cannot_write_to_path',
-          error_message: `Cannot write to the specified path: ${err === null || err === void 0 ? void 0 : err.message}`
+          error_message: `Cannot write to the specified path: ${err === null || err === void 0 ? void 0 : err.message}`,
+          stack: err === null || err === void 0 ? void 0 : err.stack
         });
         exit.withError(`Cannot write to the specified path: ${err === null || err === void 0 ? void 0 : err.message}`);
       }
@@ -351,9 +352,16 @@ class ExportSQLCommand {
         if (err !== null && err !== void 0 && err.message.includes('Backup Copy already in progress')) {
           await this.track('error', {
             error_type: 'job_already_running',
-            error_message: err === null || err === void 0 ? void 0 : err.message
+            error_message: err === null || err === void 0 ? void 0 : err.message,
+            stack: err === null || err === void 0 ? void 0 : err.stack
+          });
+          exit.withError('There is an export job already running for this environment: ' + `https://dashboard.wpvip.com/apps/${this.app.id}/${this.env.uniqueLabel}/data/database/backups\n` + 'Currently, we allow only one export job at a time, per site. Please try again later.');
+        } else {
+          await this.track('error', {
+            error_type: 'create_export_job',
+            error_message: err === null || err === void 0 ? void 0 : err.message,
+            stack: err === null || err === void 0 ? void 0 : err.stack
           });
-          exit.withError('There is an export job already running for this site: ' + `https://dashboard.wpvip.com/apps/${this.app.id}/${this.env.uniqueLabel}/data/database/backups\n` + 'Currently, we allow only one export job at a time, per site. Please try again later.');
         }
         exit.withError(`Error creating export job: ${err === null || err === void 0 ? void 0 : err.message}`);
       }
@@ -378,7 +386,8 @@ class ExportSQLCommand {
       this.stopProgressTracker();
       await this.track('error', {
         error_type: 'download_failed',
-        error_message: err === null || err === void 0 ? void 0 : err.message
+        error_message: err === null || err === void 0 ? void 0 : err.message,
+        stack: err === null || err === void 0 ? void 0 : err.stack
       });
       exit.withError(`Error downloading exported file: ${err === null || err === void 0 ? void 0 : err.message}`);
     }

package/dist/lib/analytics/clients/pendo.js

@@ -4,36 +4,29 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
+var _debug = _interopRequireDefault(require("debug"));
 var _http = _interopRequireDefault(require("../../../lib/api/http"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
  * External dependencies
  */
-const debug = require('debug')('@automattic/vip:analytics:clients:pendo');
 
 /**
  * Internal dependencies
  */
 
+const debug = (0, _debug.default)('@automattic/vip:analytics:clients:pendo');
 /**
  * Pendo analytics client.
  */
-
 class Pendo {
-  context = {};
-  static get ENDPOINT() {
-    return '/pendo';
-  }
-  constructor({
-    userId,
-    eventPrefix,
-    env
-  }) {
-    this.eventPrefix = eventPrefix;
-    this.userAgent = env.userAgent;
-    this.userId = userId;
+  static ENDPOINT = '/pendo';
+  constructor(options) {
+    this.eventPrefix = options.eventPrefix;
+    this.userAgent = options.env.userAgent;
+    this.userId = options.userId;
     this.context = {
-      ...env
+      ...options.env
     };
   }
   async trackEvent(eventName, eventProps = {}) {
@@ -52,10 +45,8 @@ class Pendo {
       return await this.send(eventName, eventProps);
     } catch (error) {
       debug(error);
+      return Promise.resolve(false);
     }
-
-    // Resolve to false instead of rejecting
-    return Promise.resolve(false);
   }
   async send(eventName, eventProps) {
     const body = {
@@ -69,11 +60,11 @@ class Pendo {
     debug('send()', body);
     const response = await (0, _http.default)(Pendo.ENDPOINT, {
       method: 'POST',
-      body
+      body: JSON.stringify(body)
     });
     const responseText = await response.text();
     debug('response', responseText);
-    return responseText;
+    return response;
   }
 }
 exports.default = Pendo;

package/dist/lib/analytics/clients/tracks.js

@@ -6,19 +6,19 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = void 0;
 var _nodeFetch = _interopRequireDefault(require("node-fetch"));
 var _querystring = _interopRequireDefault(require("querystring"));
+var _debug = _interopRequireDefault(require("debug"));
 var _apiConfig = require("../../cli/apiConfig");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
  * External dependencies
  */
-const debug = require('debug')('@automattic/vip:analytics:clients:tracks');
 
 /**
  * Internal dependencies
  */
 
+const debug = (0, _debug.default)('@automattic/vip:analytics:clients:tracks');
 const validEventOrPropNamePattern = /^[a-z_][a-z0-9_]*$/;
-
 /**
  * Simple class for tracking using Automattic Tracks.
  *
@@ -28,9 +28,7 @@ const validEventOrPropNamePattern = /^[a-z_][a-z0-9_]*$/;
 // TODO: add batch support (can include multiples in `events` array)
 
 class Tracks {
-  static get ENDPOINT() {
-    return 'https://public-api.wordpress.com/rest/v1.1/tracks/record';
-  }
+  static ENDPOINT = 'https://public-api.wordpress.com/rest/v1.1/tracks/record';
   constructor(userId, userType, eventPrefix, env) {
     this.eventPrefix = eventPrefix;
     this.userAgent = env.userAgent;
@@ -54,9 +52,10 @@ class Tracks {
     });
     eventProps.is_vip = await (0, _apiConfig.checkIfUserIsVip)(); // Add `is_vip` flag to every Tracks event recorded
 
-    const event = Object.assign({
-      _en: name
-    }, eventProps);
+    const event = {
+      _en: name,
+      ...eventProps
+    };
 
     // For when we want to support batched events
     const events = [event];
@@ -89,10 +88,13 @@ class Tracks {
     }
 
     // Resolve to false instead of rejecting
-    return Promise.resolve(false);
+    return false;
   }
   send(extraParams) {
-    const params = Object.assign({}, this.baseParams, extraParams);
+    const params = {
+      ...this.baseParams,
+      ...extraParams
+    };
     const method = 'POST';
     const body = _querystring.default.stringify(params);
     const headers = {
@@ -100,8 +102,6 @@ class Tracks {
       'User-Agent': this.userAgent
     };
     debug('send()', body);
-
-    // eslint-disable-next-line no-undef
     return (0, _nodeFetch.default)(Tracks.ENDPOINT, {
       method,
       body,

package/dist/lib/analytics/index.js

@@ -5,15 +5,16 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _debug = _interopRequireDefault(require("debug"));
-var _stub = _interopRequireDefault(require("./clients/stub"));
 var _env = _interopRequireDefault(require("../env"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
  * External dependencies
  */
+
 /**
  * Internal dependencies
  */
+
 const debug = (0, _debug.default)('@automattic/vip:analytics');
 
 /* eslint-disable camelcase */
@@ -26,23 +27,19 @@ const client_info = {
 /* eslint-enable camelcase */
 
 class Analytics {
-  constructor({
-    clients = new _stub.default()
-  }) {
+  constructor(clients) {
     this.clients = clients;
   }
   async trackEvent(name, props = {}) {
     if (process.env.DO_NOT_TRACK) {
       debug(`trackEvent() for ${name} => skipping per DO_NOT_TRACK variable`);
-      return Promise.resolve(`Skipping trackEvent for ${name} (DO_NOT_TRACK)`);
+      return [];
     }
-    return Promise.all(this.clients.map(client => {
-      return client.trackEvent(name, {
-        // eslint-disable-next-line camelcase
-        ...client_info,
-        ...props
-      });
-    }));
+    return Promise.all(this.clients.map(client => client.trackEvent(name, {
+      // eslint-disable-next-line camelcase
+      ...client_info,
+      ...props
+    })));
   }
 }
 exports.default = Analytics;