@automattic/vip 2.24.2 → 2.25.1

package/CHANGELOG.md

@@ -1,5 +1,44 @@
 ## Changelog
 
+# 2.25.1
+
+- #1239 Downgrade Apollo client to 3.3.6
+
+# 2.25.0
+
+- #1233 Update @automattic/vip-go-preflight-checks to 2.0.16
+- #1232 fix(dev-env): Make environment existence check more robust
+- #1231 fix(dev-env): Inherit stdio descriptors for 'dev-env exec'
+- #1230 Dev-env: Fix ES service reference
+- #1229 fix(dev-env): Perform ES healthcheck properly
+- #1209 refactor(dev-env): Run health checks in parallel
+- #1201 fix(dev-env): Do not check env is up for every action
+- #1224 fix(tests): do not fail when `DO_NOT_TRACK` is set
+- #1211 fix(dev-env)!: remove support for statsd
+- #1183 feat(dev-env): Add support for the most recent Lando
+- #1203 test(dev-env): Add E2E tests for dev env
+- #1222 chore(deps): Update babel to 7.20.7
+- #1223 chore(deps): Update flow to 0.196.3
+- #1226 Add some additional info on installation
+- #1225 chore: Update dot files
+- #1197 feat(dev-env): Pipe files to Docker instead of copying them when doing SQL import
+- #1221 dev-env: Fix Mailhog being undefined in instance data from older versisons of VIP-CLI
+- #1218 Fix a grammatical mistake in the error message
+- #1217 Add filename validation to sql import
+- #1213 chore(deps): Update jest to 29.3.1 and nock to 13.2.9
+- #1214 chore(deps): Update babel to 7.20
+- #1208 feat(dev-env): Add quiet mode to `vip dev-env exec`
+- #1212 fix(dev-env): Errors should go to stderr, not stdout
+- #1206 fix(dev-env): await handleCLIException() and set proper exit code
+- #1202 fix(dev-env): Do not load integrations for Acquia, Lagoon, Pantheon
+- #1200 fix(dev-env): Reuse Lando App instead of recreating it every time
+- #1204 Dev-env: Update ES to 7.17.8 to match prod
+- #1205 ci: Pass correct node-version in CI workflow
+- #1199 fix(dev-env): Update `max_allowed_packet` to mirror prod envs
+- #1194 Add debugger instructions
+- #1196 fix(dev-env): Fix ambiguous short option for MailHog/MariaDB
+- #1195 fix(dev-env): increase max number of event listeners for AsyncEvents
+
 ## 2.24.2 (22 Dec 2022)
 
 - #1219 fix(dev-env): Fix search/replace on SQL file import

package/CONTRIBUTING.md

@@ -29,6 +29,36 @@ VIP_PROXY="" API_HOST=http://localhost:4000 node ./dist/bin/vip app
 VIP_PROXY="" API_HOST=http://localhost:4000 node ./dist/bin/vip -- wp option get home
 ```
 
+### Using debugger
+
+Who doesn't like a good console.log for debugging?
+Well, sometimes it's insufficient, luckily it's not too complicated to use a debugger.
+
+1. First, make sure to run the `npm run build:watch`, this will generate source maps
+2. Run the command you want via `node --inspect`, like so:  `node --inspect ./dist/bin/vip-dev-env-import-sql.js`
+3. Note the port the debugger is listening on:
+```
+Debugger listening on ws://127.0.0.1:9229/db6c03e9-2585-4a08-a1c6-1fee0295c9ff
+For help, see: https://nodejs.org/en/docs/inspector
+```
+4. In your editor of choice attach to the debugger. For VSCode: Hit 'Run and Debug' panel, hit the "gear" icon (open launch.json), make your `Attach` configuration entry to look like so:
+Make sure the `port` matches the port from step 3, and the `runtimeExecutable` matches the exact `node` executable you ran. If you use a version manager like `nvm`, its especially important to check this.
+
+```json
+	{
+		"name": "Attach",
+		"port": 9229,
+		"request": "attach",
+		"skipFiles": ["<node_internals>/**"],
+		"type": "node",
+		"runtimeExecutable": "/Users/user/.nvm/versions/node/v14.18.2/bin/node"
+	}
+```
+
+5. Set your breakpoints and whatnot, hit the play button.
+6. Confirm that you attached the debugger to continue command execution
+7. Squash them bugs 🐛🔨.
+8. [Optional but recommended] Pay it forward and implement a similar approach to other internal/external tooling.
 ### Adding commands
 
 * New command names should use the singular form (e.g. site vs sites).
@@ -43,13 +73,13 @@ New libraries should generally support both CLI and web contexts, though some ca
 
 Our release flow for VIP CLI follows this pattern:
 
-**_feature branch -> develop branch -> master branch -> NPM release_**
+**_feature branch -> develop branch -> trunk branch -> NPM release_**
 
 - For feature branches, please follow A8C branch naming conventions (e.g.- `add/data-sync-command`, `fix/subsite-launch-command`, etc.)
 - Include a Changelog for all npm version releases, including any minor or major versions
 - This is a public repository. Please do not include any internal links in PRs, changelogs, testing instructions, etc.
 - Merge changes from your feature branch to the `develop` branch
-- If you are ready to release your changes publicly, merge your changes from the `develop` branch to the `master` branch. All changes that are not ready to be public should be feature flagged or stay in the `develop` branch to avoid conflicts when releasing urgent fixes (not recommended).
+- If you are ready to release your changes publicly, merge your changes from the `develop` branch to the `trunk` branch. All changes that are not ready to be public should be feature flagged or stay in the `develop` branch to avoid conflicts when releasing urgent fixes (not recommended).
 - Finally, release your changes as a new minor or major NPM version. Ping in the #vip-platform channel to notify folks of a new release, but please feel free to release your changes without any blockers from the team. Any team member that is part of the Automattic NPM organization can release a new version; if you aren't a member, generic credentials are available in the Secret Store.
 
 ### Changelogs
@@ -78,7 +108,7 @@ Prepare the release by making sure that:
 
 1. All relevant PRs have been merged.
 1. The release has been tested across macOS, Windows, and Linux.
-1. The [changelog](https://github.com/Automattic/vip/blob/master/CHANGELOG.md) has been updated on `master`.
+1. The [changelog](https://github.com/Automattic/vip/blob/trunk/CHANGELOG.md) has been updated on `trunk`.
 1. All tests pass and your working directory is clean (we have pre-publish checks to catch this, just-in-case).
 
 #### Changelog Generator Hint:
@@ -90,15 +120,15 @@ gh pr list --search "is:merged sort:updated-desc closed:>$LAST_RELEASE_DATE" | s
 
 Then, let's publish:
 
-1. Make sure master branch is up to date `git pull`
+1. Make sure trunk branch is up to date `git pull`
 1. Set the version (via `npm version minor` or `npm version major` or `npm version patch`)
 1. For most regular releases, this will be `npm version minor`.
 1. Push the tag to GitHub (`git push --tags`)
-1. Push the master branch `git push`
+1. Push the trunk branch `git push`
 1. Make sure you're part of the Automattic organization in npm
 1. Publish the release to npm (`npm run publish-please --access public`) the script will do some extra checks (npm version, branch, etc) to ensure everything is correct. If all looks good, proceed.
 1. Edit [the release on GitHub](https://github.com/Automattic/vip/releases) to include a description of the changes and publish (this can just copy the details from the changelog).
-1. Push `master` changes (mostly the version bump) to `develop` (`git checkout develop && git merge master` )
+1. Push `trunk` changes (mostly the version bump) to `develop` (`git checkout develop && git merge trunk` )
 
 Once released, it's worth running `npm i -g @automattic/vip` to install / upgrade the released version to make sure everything looks good.
 
@@ -111,14 +141,14 @@ In order to do that, please follow this:
 1. Manually change the version in `package.json` and `package-lock.json` to a dev version. Example: `1.4.0-dev1`
 2. Go to publish-please's config in `.publishrc`
 3. Change the `publishTag` to `next` and `gitTag` to `false` (publish-please will expect the latest commit to have a git tag, but we don't want it in this case)
-4. Commit your changes to `master`
+4. Commit your changes to `trunk`
 5. Run `npm run publish-please`
 
 You can repeat this with every new version until you're happy with your version and ready to a public release. We currently don't support multiple branches for multiple versions. When it's the case, this process needs to be done for every version in every branch.
 
 ### Patching Old Releases
 
-There may be times when we need to push out a critical fix to the most recent release (or several past releases) such as for patching security issues or major bugs. This can be complicated by the fact that we may have some larger changes already merged into the `master` branch.
+There may be times when we need to push out a critical fix to the most recent release (or several past releases) such as for patching security issues or major bugs. This can be complicated by the fact that we may have some larger changes already merged into the `trunk` branch.
 
 For these cases:
 

package/README.md

@@ -8,6 +8,12 @@ First, install the package:
 npm install -g @automattic/vip
 ```
 
+The above command may fail in linux if you do not have `make` and `g++` installed. In that case, install them first:
+
+```
+sudo apt install make g++
+```
+
 Then, launch the command and follow the prompts:
 
 ```

package/assets/dev-env.lando.template.yml.ejs

@@ -40,7 +40,6 @@ services:
       command: run.sh
       working_dir: /wp
       environment:
-        STATSD: <%= statsd ? 'enable' : 'disable' %>
         XDEBUG: <%= xdebug ? 'enable' : 'disable' %>
 <% if ( xdebugConfig ) { %>
         XDEBUG_CONFIG: "<%= xdebugConfig %>"
@@ -67,7 +66,7 @@ services:
     type: compose
     services:
       image: mariadb:<%= mariadb %>
-      command: docker-entrypoint.sh mysqld --sql-mode=ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
+      command: docker-entrypoint.sh mysqld --sql-mode=ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION --max_allowed_packet=67M
       ports:
         - ":3306"
       environment:
@@ -96,7 +95,7 @@ services:
   elasticsearch:
     type: compose
     services:
-      image: elasticsearch:7.17.2
+      image: elasticsearch:7.17.8
       command: /usr/local/bin/docker-entrypoint.sh
       environment:
         ELASTICSEARCH_IS_DEDICATED_NODE: 'no'
@@ -112,13 +111,6 @@ services:
     volumes:
       search_data:
 <% } %>
-<% if ( statsd ) { %>
-  statsd:
-    type: compose
-    services:
-      image: ghcr.io/automattic/vip-container-images/statsd:v0.9.0
-      command: node stats.js /config/statsd-config.js
-<% } %>
 
   wordpress:
     type: compose
@@ -191,7 +183,7 @@ tooling:
     service: php
     description: "Connect to the DB using mysql client (e.g. allow to run imports)"
     cmd:
-      - mysql -hdatabase -uwordpress -pwordpress wordpress
+      - mysql -hdatabase -uwordpress -pwordpress -Dwordpress
 
 <% function wpVolumes() { %>
         - ./config:/wp/config

package/dist/bin/vip-dev-env-create.js

@@ -66,7 +66,7 @@ cmd.argv(process.argv, async (arg, opt) => {
   };
   await (0, _tracker.trackEvent)('dev_env_create_command_execute', trackingInfo);
   const startCommand = _chalk.default.bold((0, _devEnvironmentCli.getEnvironmentStartCommand)(slug));
-  const environmentAlreadyExists = (0, _devEnvironmentCore.doesEnvironmentExist)(slug);
+  const environmentAlreadyExists = await (0, _devEnvironmentCore.doesEnvironmentExist)((0, _devEnvironmentCore.getEnvironmentPath)(slug));
   if (environmentAlreadyExists) {
     const messageToShow = `Environment already exists\n\n\nTo start the environment run:\n\n${startCommand}\n\n` + `To create another environment use ${_chalk.default.bold('--slug')} option with a unique name.\n`;
     exit.withError(messageToShow);
@@ -94,5 +94,6 @@ cmd.argv(process.argv, async (arg, opt) => {
     await (0, _tracker.trackEvent)('dev_env_create_command_success', trackingInfo);
   } catch (error) {
     await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_create_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-destroy.js

@@ -15,8 +15,8 @@ var _chalk = _interopRequireDefault(require("chalk"));
 var _tracker = require("../lib/tracker");
 var _command = _interopRequireDefault(require("../lib/cli/command"));
 var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core");
-var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
 var _devEnvironment = require("../lib/constants/dev-environment");
+var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
 var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
@@ -45,5 +45,6 @@ const examples = [{
     await (0, _tracker.trackEvent)('dev_env_destroy_command_success', trackingInfo);
   } catch (error) {
     await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_destroy_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-exec.js

@@ -5,10 +5,6 @@
  * @format
  */
 
-/**
- * External dependencies
- */
-
 /**
  * Internal dependencies
  */
@@ -20,6 +16,7 @@ var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
 var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core");
 var _devEnvironment = require("../lib/constants/dev-environment");
 var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
+var _userError = _interopRequireDefault(require("../lib/user-error"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 const examples = [{
   usage: `${_devEnvironment.DEV_ENVIRONMENT_FULL_COMMAND} exec -- wp post list`,
@@ -36,10 +33,13 @@ const examples = [{
 }).option('slug', 'Custom name of the dev environment').option('force', 'Disabling validations before task execution', undefined, value => {
   var _value$toLowerCase;
   return 'false' !== (value === null || value === void 0 ? void 0 : (_value$toLowerCase = value.toLowerCase) === null || _value$toLowerCase === void 0 ? void 0 : _value$toLowerCase.call(value));
+}).option('quiet', 'Suppress output', undefined, value => {
+  var _value$toLowerCase2;
+  return 'false' !== (value === null || value === void 0 ? void 0 : (_value$toLowerCase2 = value.toLowerCase) === null || _value$toLowerCase2 === void 0 ? void 0 : _value$toLowerCase2.call(value));
 }).examples(examples).argv(process.argv, async (unmatchedArgs, opt) => {
   const slug = (0, _devEnvironmentCli.getEnvironmentName)(opt);
   const lando = await (0, _devEnvironmentLando.bootstrapLando)();
-  await (0, _devEnvironmentCli.validateDependencies)(lando, slug);
+  await (0, _devEnvironmentCli.validateDependencies)(lando, slug, opt.quiet);
   const trackingInfo = (0, _devEnvironmentCli.getEnvTrackingInfo)(slug);
   await (0, _tracker.trackEvent)('dev_env_exec_command_execute', trackingInfo);
   try {
@@ -53,12 +53,27 @@ const examples = [{
     if (argSplitterFound && argSplitterIx + 1 < process.argv.length) {
       arg = process.argv.slice(argSplitterIx + 1);
     }
-    const options = {
-      force: opt.force
-    };
-    await (0, _devEnvironmentCore.exec)(lando, slug, arg, options);
+    if (!opt.force) {
+      const isUp = await (0, _devEnvironmentLando.isEnvUp)(lando, (0, _devEnvironmentCore.getEnvironmentPath)(slug));
+      if (!isUp) {
+        throw new _userError.default('Environment needs to be started before running a command');
+      }
+    }
+    try {
+      await (0, _devEnvironmentCore.exec)(lando, slug, arg, {
+        stdio: 'inherit'
+      });
+    } catch (error) {
+      if (error instanceof _userError.default) {
+        throw error;
+      }
+
+      // Unfortunately, we are unable to get the exit code from Lando :-(
+      process.exitCode = 1;
+    }
     await (0, _tracker.trackEvent)('dev_env_exec_command_success', trackingInfo);
   } catch (error) {
-    (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_exec_command_error', trackingInfo);
+    await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_exec_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-import-media.js

@@ -19,7 +19,6 @@ var _command = _interopRequireDefault(require("../lib/cli/command"));
 var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
 var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core");
 var _devEnvironment = require("../lib/constants/dev-environment");
-var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 const examples = [{
   usage: `${_devEnvironment.DEV_ENVIRONMENT_FULL_COMMAND} import media path/to/wp-content/uploads`,
@@ -33,14 +32,13 @@ const examples = [{
 }).examples(examples).option('slug', 'Custom name of the dev environment').argv(process.argv, async (unmatchedArgs, opt) => {
   const [filePath] = unmatchedArgs;
   const slug = (0, _devEnvironmentCli.getEnvironmentName)(opt);
-  const lando = await (0, _devEnvironmentLando.bootstrapLando)();
-  await (0, _devEnvironmentCli.validateDependencies)(lando, slug);
   const trackingInfo = (0, _devEnvironmentCli.getEnvTrackingInfo)(slug);
   await (0, _tracker.trackEvent)('dev_env_import_media_command_execute', trackingInfo);
   try {
     await (0, _devEnvironmentCore.importMediaPath)(slug, filePath);
     await (0, _tracker.trackEvent)('dev_env_import_media_command_success', trackingInfo);
   } catch (error) {
-    (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_import_media_command_error', trackingInfo);
+    await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_import_media_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-import-sql.js

@@ -11,6 +11,7 @@
 "use strict";
 
 var _fs = _interopRequireDefault(require("fs"));
+var _chalk = _interopRequireDefault(require("chalk"));
 var _tracker = require("../lib/tracker");
 var _command = _interopRequireDefault(require("../lib/cli/command"));
 var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
@@ -18,6 +19,7 @@ var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core")
 var _devEnvironment = require("../lib/constants/dev-environment");
 var _sql = require("../lib/validations/sql");
 var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
+var _userError = _interopRequireDefault(require("../lib/user-error"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
  * Internal dependencies
@@ -49,11 +51,11 @@ const examples = [{
   const trackingInfo = (0, _devEnvironmentCli.getEnvTrackingInfo)(slug);
   await (0, _tracker.trackEvent)('dev_env_import_sql_command_execute', trackingInfo);
   try {
-    const {
-      resolvedPath,
-      inContainerPath
-    } = await (0, _devEnvironmentCore.resolveImportPath)(slug, fileName, searchReplace, inPlace);
+    const resolvedPath = await (0, _devEnvironmentCore.resolveImportPath)(slug, fileName, searchReplace, inPlace);
     if (!opt.skipValidate) {
+      if (!(0, _devEnvironmentLando.isEnvUp)(lando, (0, _devEnvironmentCore.getEnvironmentPath)(slug))) {
+        throw new _userError.default('Environment needs to be started first');
+      }
       const expectedDomain = `${slug}.vipdev.lndo.site`;
       await (0, _sql.validate)(resolvedPath, {
         isImport: false,
@@ -63,9 +65,28 @@ const examples = [{
         }
       });
     }
-    const importArg = ['wp', 'db', 'import', inContainerPath];
-    await (0, _devEnvironmentCore.exec)(lando, slug, importArg);
-    _fs.default.unlinkSync(resolvedPath);
+    const fd = await _fs.default.promises.open(resolvedPath, 'r');
+    const importArg = ['db', '--disable-auto-rehash'];
+    const origIsTTY = process.stdin.isTTY;
+    try {
+      /**
+       * When stdin is a TTY, Lando passes the `--tty` flag to Docker.
+       * This breaks our code when we pass the stream as stdin to Docker.
+       * exec() then fails with "the input device is not a TTY".
+       *
+       * Therefore, for the things to work, we have to pretend that stdin is not a TTY :-)
+       */
+      process.stdin.isTTY = false;
+      await (0, _devEnvironmentCore.exec)(lando, slug, importArg, {
+        stdio: [fd, 'pipe', 'pipe']
+      });
+      console.log(`${_chalk.default.green.bold('Success:')} Database imported.`);
+    } finally {
+      process.stdin.isTTY = origIsTTY;
+    }
+    if (searchReplace && searchReplace.length && !inPlace) {
+      _fs.default.unlinkSync(resolvedPath);
+    }
     const cacheArg = ['wp', 'cache', 'flush'];
     await (0, _devEnvironmentCore.exec)(lando, slug, cacheArg);
     try {
@@ -81,6 +102,7 @@ const examples = [{
     await (0, _devEnvironmentCore.exec)(lando, slug, addUserArg);
     await (0, _tracker.trackEvent)('dev_env_import_sql_command_success', trackingInfo);
   } catch (error) {
-    (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_import_sql_command_error', trackingInfo);
+    await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_import_sql_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-info.js

@@ -49,6 +49,7 @@ const examples = [{
     }
     await (0, _tracker.trackEvent)('dev_env_info_command_success', trackingInfo);
   } catch (error) {
-    (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_info_command_error', trackingInfo);
+    await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_info_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-list.js

@@ -27,6 +27,7 @@ const examples = [{
 }];
 (0, _command.default)().examples(examples).argv(process.argv, async () => {
   const lando = await (0, _devEnvironmentLando.bootstrapLando)();
+  lando.events.constructor.prototype.setMaxListeners(1024);
   await (0, _devEnvironmentCli.validateDependencies)(lando, '');
   const trackingInfo = {
     all: true
@@ -36,6 +37,7 @@ const examples = [{
     await (0, _devEnvironmentCore.printAllEnvironmentsInfo)(lando, {});
     await (0, _tracker.trackEvent)('dev_env_list_command_success', trackingInfo);
   } catch (error) {
-    (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_list_command_error', trackingInfo);
+    await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_list_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-start.js

@@ -67,5 +67,6 @@ const examples = [{
     await (0, _tracker.trackEvent)('dev_env_start_command_success', successTrackingInfo);
   } catch (error) {
     await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_start_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-stop.js

@@ -40,6 +40,7 @@ const examples = [{
     console.log(message);
     await (0, _tracker.trackEvent)('dev_env_stop_command_success', trackingInfo);
   } catch (error) {
-    (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_stop_command_error', trackingInfo);
+    await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_stop_command_error', trackingInfo);
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-dev-env-update.js

@@ -14,8 +14,8 @@ var _debug = _interopRequireDefault(require("debug"));
 var _chalk = _interopRequireDefault(require("chalk"));
 var _tracker = require("../lib/tracker");
 var _command = _interopRequireDefault(require("../lib/cli/command"));
-var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
 var _devEnvironment = require("../lib/constants/dev-environment");
+var _devEnvironmentCli = require("../lib/dev-environment/dev-environment-cli");
 var _devEnvironmentCore = require("../lib/dev-environment/dev-environment-core");
 var _devEnvironmentLando = require("../lib/dev-environment/dev-environment-lando");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -37,7 +37,7 @@ cmd.argv(process.argv, async (arg, opt) => {
   const trackingInfo = (0, _devEnvironmentCli.getEnvTrackingInfo)(slug);
   await (0, _tracker.trackEvent)('dev_env_update_command_execute', trackingInfo);
   try {
-    const environmentAlreadyExists = (0, _devEnvironmentCore.doesEnvironmentExist)(slug);
+    const environmentAlreadyExists = await (0, _devEnvironmentCore.doesEnvironmentExist)((0, _devEnvironmentCore.getEnvironmentPath)(slug));
     if (!environmentAlreadyExists) {
       throw new Error(_devEnvironment.DEV_ENVIRONMENT_NOT_FOUND);
     }
@@ -56,7 +56,6 @@ cmd.argv(process.argv, async (arg, opt) => {
       elasticsearch: currentInstanceData.elasticsearch,
       php: currentInstanceData.php || _devEnvironment.DEV_ENVIRONMENT_PHP_VERSIONS.default,
       mariadb: currentInstanceData.mariadb,
-      statsd: currentInstanceData.statsd,
       phpmyadmin: currentInstanceData.phpmyadmin,
       xdebug: currentInstanceData.xdebug,
       mailhog: currentInstanceData.mailhog,
@@ -77,9 +76,10 @@ cmd.argv(process.argv, async (arg, opt) => {
   } catch (error) {
     if ('ENOENT' === error.code) {
       const message = 'Environment was created before update was supported.\n\nTo update environment please destroy it and create a new one.';
-      (0, _devEnvironmentCli.handleCLIException)(new Error(message), 'dev_env_update_command_error', trackingInfo);
+      await (0, _devEnvironmentCli.handleCLIException)(new Error(message), 'dev_env_update_command_error', trackingInfo);
     } else {
-      (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_update_command_error', trackingInfo);
+      await (0, _devEnvironmentCli.handleCLIException)(error, 'dev_env_update_command_error', trackingInfo);
     }
+    process.exitCode = 1;
   }
 });

package/dist/bin/vip-import-sql.js

@@ -232,6 +232,14 @@ If you are confident the file does not contain unsupported statements, you can r
   // this can only be called after static validation of the SQL file
   return (0, _sql.getTableNames)();
 }
+function validateFilename(filename) {
+  const re = /^[a-z0-9\-\_\.]+$/i;
+
+  // Exits if filename contains anything outside a-z A-Z - _ .
+  if (!re.test(filename)) {
+    exit.withError('Error: The characters used in the name of a file for import are limited to [0-9,a-z,A-Z,-,_,.]');
+  }
+}
 const displayPlaybook = ({
   launched,
   tableNames,
@@ -347,6 +355,9 @@ const displayPlaybook = ({
   const launched = opts.env.launched;
   let fileNameToUpload = fileName;
 
+  // Exit if filename contains unsafe character
+  validateFilename(fileNameToUpload);
+
   // SQL file validations
   const tableNames = await validateAndGetTableNames({
     skipValidate,

package/dist/lib/cli/command.js

@@ -44,7 +44,16 @@ function uncaughtError(err) {
 process.on('uncaughtException', uncaughtError);
 process.on('unhandledRejection', uncaughtError);
 let _opts = {};
+let alreadyConfirmedDebugAttachment = false;
 _args.default.argv = async function (argv, cb) {
+  if (process.execArgv.includes('--inspect') && !alreadyConfirmedDebugAttachment) {
+    await (0, _enquirer.prompt)({
+      type: 'confirm',
+      name: 'confirm',
+      message: "\nAttach the debugger, once you see 'Debugger attached' above hit 'y' to continue"
+    });
+    alreadyConfirmedDebugAttachment = true;
+  }
   const parsedAlias = (0, _envAlias.parseEnvAliasFromArgv)(argv);
 
   // A usage option allows us to override the default usage text, which isn't

package/dist/lib/cli/exit.js

@@ -21,7 +21,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
  */
 
 function withError(message) {
-  console.log(`${_chalk.default.red('Error: ')} ${message.toString().replace(/^Error:\s*/, '')}`);
+  console.error(`${_chalk.default.red('Error: ')} ${message.toString().replace(/^Error:\s*/, '')}`);
 
   // Debug ouput is printed below error output both for information
   // hierarchy and to make it more likely that the user copies it to their