@automattic/eslint-plugin-wpvip 0.7.0 → 0.9.0

package/configs/javascript.js

@@ -42,6 +42,7 @@ module.exports = {
 		'no-compare-neg-zero': 'error',
 		// 'no-cond-assign': 'error', // extended below
 		'no-const-assign': 'error',
+		'no-constant-binary-expression': 'error',
 		'no-constant-condition': 'error',
 		'no-control-regex': 'error',
 		'no-debugger': 'error',
@@ -134,6 +135,22 @@ module.exports = {
 		'import/no-unresolved': 'error',
 		'unused-imports/no-unused-imports': 'warn',
 
+		// Enforce external / internal import groups and alphabetical ordering.
+		'import/order': [
+			'error',
+			{
+				'newlines-between': 'always',
+				alphabetize: {
+					order: 'asc',
+				},
+				groups: [
+					[ 'builtin', 'external' ],
+					[ 'index', 'internal', 'object', 'parent', 'sibling' ],
+					[ 'type' ],
+				],
+			},
+		],
+
 		// Enforce Unix linebreaks. Included here and not in "formatting" since it
 		// is not controversial and helps with interchange.
 		'linebreak-style': [ 'error', 'unix' ],
@@ -217,7 +234,6 @@ module.exports = {
 		'promise/avoid-new': 'off',
 		'promise/catch-or-return': 'off',
 		'promise/no-callback-in-promise': 'warn',
-		'promise/no-multiple-resolved': 'error',
 		'promise/no-native': 'off',
 		'promise/no-nesting': 'warn',
 		'promise/no-new-statics': 'error',
@@ -228,6 +244,11 @@ module.exports = {
 		'promise/prefer-await-to-callbacks': 'off',
 		'promise/prefer-await-to-then': 'off',
 		'promise/valid-params': 'error',
+
+		// This rule has been disabled because it is extremely slow:
+		// https://github.com/Automattic/vip-cli/pull/1534
+		//
+		// 'promise/no-multiple-resolved': 'error',
 	},
 
 	settings: {

package/configs/weak-javascript.js

@@ -53,12 +53,16 @@ module.exports = {
 
 				radix: 'warn',
 
-				'promise/no-multiple-resolved': 'warn',
 				'promise/no-new-statics': 'warn',
 				'promise/no-return-in-finally': 'warn',
 				'promise/no-return-wrap': 'warn',
 				'promise/param-names': 'warn',
 				'promise/valid-params': 'warn',
+
+				// This rule has been disabled because it is extremely slow:
+				// https://github.com/Automattic/vip-cli/pull/1534
+				//
+				// 'promise/no-multiple-resolved': 'warn',
 			},
 		},
 	],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.7.0",
+  "version": "0.9.0",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {
@@ -32,37 +32,37 @@
   },
   "homepage": "https://github.com/Automattic/eslint-config-wpvip#readme",
   "dependencies": {
-    "@babel/eslint-parser": "7.22.10",
-    "@rushstack/eslint-patch": "1.3.3",
-    "@typescript-eslint/eslint-plugin": "^6.0.0",
-    "@typescript-eslint/parser": "^6.0.0",
+    "@babel/eslint-parser": "7.23.3",
+    "@rushstack/eslint-patch": "1.6.0",
+    "@typescript-eslint/eslint-plugin": "6.12.0",
+    "@typescript-eslint/parser": "6.12.0",
     "eslint-config-prettier": "8.7.0",
-    "eslint-import-resolver-typescript": "3.5.3",
-    "eslint-plugin-import": "2.28.1",
-    "eslint-plugin-jest": "27.2.3",
-    "eslint-plugin-jsdoc": "40.0.2",
+    "eslint-import-resolver-typescript": "3.6.1",
+    "eslint-plugin-import": "2.29.0",
+    "eslint-plugin-jest": "27.6.0",
+    "eslint-plugin-jsdoc": "46.8.2",
     "eslint-plugin-json": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-promise": "6.1.1",
-    "eslint-plugin-react": "7.32.2",
+    "eslint-plugin-react": "7.33.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-security": "1.7.1",
     "eslint-plugin-unused-imports": "3.0.0",
     "find-package-json": "1.2.0",
-    "globals": "13.20.0"
+    "globals": "13.23.0"
   },
   "peerDependencies": {
     "eslint": ">=8"
   },
   "devDependencies": {
-    "@tsconfig/node18": "1.0.1",
-    "@types/eslint": "8.44.2",
-    "@types/jest": "29.5.0",
-    "eslint": "8.47.0",
-    "jest": "29.5.0",
+    "@tsconfig/node18": "18.2.2",
+    "@types/eslint": "8.44.7",
+    "@types/jest": "29.5.10",
+    "eslint": "8.54.0",
+    "jest": "29.7.0",
     "prettier": "npm:wp-prettier@2.8.5",
-    "ts-jest": "29.0.5",
-    "typescript": "4.9.5"
+    "ts-jest": "29.1.1",
+    "typescript": "5.3.2"
   }
 }

package/utils/is-package-installed.js

@@ -1,6 +1,13 @@
-const debugLog = require( './debug-log' );
+/**
+ * External dependencies
+ */
 const findPackageJson = require( 'find-package-json' );
 
+/**
+ * Internal dependencies
+ */
+const debugLog = require( './debug-log' );
+
 // Get a list of all package.json files in the current directory tree, ascending
 // up the tree from the current directory. Note that this code behaves differently
 // when it is installed as a package vs. when we are linting the code in this repo.