@automattic/eslint-plugin-wpvip 0.6.0 → 0.8.0

package/configs/javascript.js

@@ -134,6 +134,22 @@ module.exports = {
 		'import/no-unresolved': 'error',
 		'unused-imports/no-unused-imports': 'warn',
 
+		// Enforce external / internal import groups and alphabetical ordering.
+		'import/order': [
+			'error',
+			{
+				'newlines-between': 'always',
+				alphabetize: {
+					order: 'asc',
+				},
+				groups: [
+					[ 'builtin', 'external' ],
+					[ 'index', 'internal', 'object', 'parent', 'sibling' ],
+					[ 'type' ],
+				],
+			},
+		],
+
 		// Enforce Unix linebreaks. Included here and not in "formatting" since it
 		// is not controversial and helps with interchange.
 		'linebreak-style': [ 'error', 'unix' ],
@@ -168,6 +184,8 @@ module.exports = {
 
 		'no-lonely-if': 'error',
 
+		'no-implicit-coercion': 'error',
+
 		'no-mixed-operators': 'error',
 
 		'no-nested-ternary': 'error',
@@ -178,7 +196,14 @@ module.exports = {
 
 		'no-unused-expressions': 'error',
 
-		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
+		'no-unused-vars': [
+			'error',
+			{
+				argsIgnorePattern: '^_',
+				destructuredArrayIgnorePattern: '^_',
+				ignoreRestSiblings: true,
+			},
+		],
 
 		'no-useless-computed-key': 'error',
 
@@ -208,7 +233,6 @@ module.exports = {
 		'promise/avoid-new': 'off',
 		'promise/catch-or-return': 'off',
 		'promise/no-callback-in-promise': 'warn',
-		'promise/no-multiple-resolved': 'error',
 		'promise/no-native': 'off',
 		'promise/no-nesting': 'warn',
 		'promise/no-new-statics': 'error',
@@ -219,6 +243,11 @@ module.exports = {
 		'promise/prefer-await-to-callbacks': 'off',
 		'promise/prefer-await-to-then': 'off',
 		'promise/valid-params': 'error',
+
+		// This rule has been disabled because it is extremely slow:
+		// https://github.com/Automattic/vip-cli/pull/1534
+		//
+		// 'promise/no-multiple-resolved': 'error',
 	},
 
 	settings: {

package/configs/typescript.js

@@ -27,6 +27,16 @@ module.exports = {
 				// config, and is elevated to an error here.
 				'@typescript-eslint/no-explicit-any': 'error',
 
+				// Provide escape hatches around destructuring and arguments.
+				'@typescript-eslint/no-unused-vars': [
+					'error',
+					{
+						argsIgnorePattern: '^_',
+						destructuredArrayIgnorePattern: '^_',
+						ignoreRestSiblings: true,
+					},
+				],
+
 				// Disable some rules that TypeScript handles and are also a Performance
 				// issue. See:
 				// https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/linting/troubleshooting/Performance.md#eslint-plugin-import
@@ -43,9 +53,6 @@ module.exports = {
 				'@typescript-eslint/no-shadow': 'error',
 				'import/no-duplicates': 'error',
 
-				// Handled by TS itself.
-				'no-unused-vars': 'off',
-
 				// Empty classes are allowed if they are accompanied by a decorator.
 				// This is common in frameworks such as Angular / nest.js.
 				'@typescript-eslint/no-extraneous-class': [

package/configs/weak-javascript.js

@@ -53,12 +53,16 @@ module.exports = {
 
 				radix: 'warn',
 
-				'promise/no-multiple-resolved': 'warn',
 				'promise/no-new-statics': 'warn',
 				'promise/no-return-in-finally': 'warn',
 				'promise/no-return-wrap': 'warn',
 				'promise/param-names': 'warn',
 				'promise/valid-params': 'warn',
+
+				// This rule has been disabled because it is extremely slow:
+				// https://github.com/Automattic/vip-cli/pull/1534
+				//
+				// 'promise/no-multiple-resolved': 'warn',
 			},
 		},
 	],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.6.0",
+  "version": "0.8.0",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {
@@ -32,37 +32,37 @@
   },
   "homepage": "https://github.com/Automattic/eslint-config-wpvip#readme",
   "dependencies": {
-    "@babel/eslint-parser": "7.22.10",
-    "@rushstack/eslint-patch": "1.3.3",
-    "@typescript-eslint/eslint-plugin": "^6.0.0",
-    "@typescript-eslint/parser": "^6.0.0",
+    "@babel/eslint-parser": "7.22.15",
+    "@rushstack/eslint-patch": "1.5.1",
+    "@typescript-eslint/eslint-plugin": "6.9.1",
+    "@typescript-eslint/parser": "6.9.1",
     "eslint-config-prettier": "8.7.0",
-    "eslint-import-resolver-typescript": "3.5.3",
-    "eslint-plugin-import": "2.28.1",
-    "eslint-plugin-jest": "27.2.3",
-    "eslint-plugin-jsdoc": "40.0.2",
+    "eslint-import-resolver-typescript": "3.6.1",
+    "eslint-plugin-import": "2.29.0",
+    "eslint-plugin-jest": "27.6.0",
+    "eslint-plugin-jsdoc": "46.8.2",
     "eslint-plugin-json": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-promise": "6.1.1",
-    "eslint-plugin-react": "7.32.2",
+    "eslint-plugin-react": "7.33.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-security": "1.7.1",
     "eslint-plugin-unused-imports": "3.0.0",
     "find-package-json": "1.2.0",
-    "globals": "13.20.0"
+    "globals": "13.23.0"
   },
   "peerDependencies": {
     "eslint": ">=8"
   },
   "devDependencies": {
-    "@tsconfig/node18": "1.0.1",
-    "@types/eslint": "8.44.2",
-    "@types/jest": "29.5.0",
-    "eslint": "8.47.0",
-    "jest": "29.5.0",
+    "@tsconfig/node18": "18.2.2",
+    "@types/eslint": "8.44.6",
+    "@types/jest": "29.5.7",
+    "eslint": "8.52.0",
+    "jest": "29.7.0",
     "prettier": "npm:wp-prettier@2.8.5",
-    "ts-jest": "29.0.5",
-    "typescript": "4.9.5"
+    "ts-jest": "29.1.1",
+    "typescript": "5.2.2"
   }
 }

package/utils/is-package-installed.js

@@ -1,6 +1,13 @@
-const debugLog = require( './debug-log' );
+/**
+ * External dependencies
+ */
 const findPackageJson = require( 'find-package-json' );
 
+/**
+ * Internal dependencies
+ */
+const debugLog = require( './debug-log' );
+
 // Get a list of all package.json files in the current directory tree, ascending
 // up the tree from the current directory. Note that this code behaves differently
 // when it is installed as a package vs. when we are linting the code in this repo.
@@ -22,8 +29,8 @@ const parent =
 debugLog( `Found package.json: ${ parent.__path || 'none' }` );
 
 module.exports = function isPackageInstalled( packageName ) {
-	const isDevDependency = !! parent.devDependencies?.[ `${ packageName }` ];
-	const isProdDependency = !! parent.dependencies?.[ `${ packageName }` ];
+	const isDevDependency = Boolean( parent.devDependencies?.[ `${ packageName }` ] );
+	const isProdDependency = Boolean( parent.dependencies?.[ `${ packageName }` ] );
 
 	return isDevDependency || isProdDependency;
 };