@automattic/eslint-plugin-wpvip 0.6.0 → 0.7.0

package/configs/javascript.js

@@ -168,6 +168,8 @@ module.exports = {
 
 		'no-lonely-if': 'error',
 
+		'no-implicit-coercion': 'error',
+
 		'no-mixed-operators': 'error',
 
 		'no-nested-ternary': 'error',
@@ -178,7 +180,14 @@ module.exports = {
 
 		'no-unused-expressions': 'error',
 
-		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
+		'no-unused-vars': [
+			'error',
+			{
+				argsIgnorePattern: '^_',
+				destructuredArrayIgnorePattern: '^_',
+				ignoreRestSiblings: true,
+			},
+		],
 
 		'no-useless-computed-key': 'error',
 

package/configs/typescript.js

@@ -27,6 +27,16 @@ module.exports = {
 				// config, and is elevated to an error here.
 				'@typescript-eslint/no-explicit-any': 'error',
 
+				// Provide escape hatches around destructuring and arguments.
+				'@typescript-eslint/no-unused-vars': [
+					'error',
+					{
+						argsIgnorePattern: '^_',
+						destructuredArrayIgnorePattern: '^_',
+						ignoreRestSiblings: true,
+					},
+				],
+
 				// Disable some rules that TypeScript handles and are also a Performance
 				// issue. See:
 				// https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/linting/troubleshooting/Performance.md#eslint-plugin-import
@@ -43,9 +53,6 @@ module.exports = {
 				'@typescript-eslint/no-shadow': 'error',
 				'import/no-duplicates': 'error',
 
-				// Handled by TS itself.
-				'no-unused-vars': 'off',
-
 				// Empty classes are allowed if they are accompanied by a decorator.
 				// This is common in frameworks such as Angular / nest.js.
 				'@typescript-eslint/no-extraneous-class': [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {

package/utils/is-package-installed.js

@@ -22,8 +22,8 @@ const parent =
 debugLog( `Found package.json: ${ parent.__path || 'none' }` );
 
 module.exports = function isPackageInstalled( packageName ) {
-	const isDevDependency = !! parent.devDependencies?.[ `${ packageName }` ];
-	const isProdDependency = !! parent.dependencies?.[ `${ packageName }` ];
+	const isDevDependency = Boolean( parent.devDependencies?.[ `${ packageName }` ] );
+	const isProdDependency = Boolean( parent.dependencies?.[ `${ packageName }` ] );
 
 	return isDevDependency || isProdDependency;
 };