@automattic/eslint-plugin-wpvip 0.5.8 → 0.7.0

package/CONTRIBUTING.md

@@ -7,3 +7,44 @@ This repo provides custom ESLint rules (in `./rules`) and configs (`./configs`).
 ## Automated Testing
 
 This repo lints itself! Try to add code in `__fixtures__` that will produce errors, confirm that the errors are caught, then run `npm run jest:update-snapshot` to expect the errors.
+
+## Publishing a New Release
+
+The process to release to npm should be started when all pull requests intended for publishing have been merged and the software has been fully tested for publication. You can release either using GitHub Actions or locally.
+
+### Versioning Guidelines
+
+- `patch`: for non-breaking changes/bugfixes and small updates.
+- `minor`: for some new features, bug fixes, and other non-breaking changes.
+- `major`: for breaking changes.
+
+### Note on NPM token
+
+Publishing via the GitHub Action requires that the `NPM_TOKEN` be set correctly in GitHub Actions secrets. This should be an npm token generated for a bot user on [the npm @automattic org](https://www.npmjs.com/settings/automattic) that has publish access to this repo.
+
+### How To Release
+
+#### GitHub Actions (Preferred)
+
+This is the preferred method for pushing out the latest release. The workflow runs a bunch of validations, generates a build, bump versions + tags, pushes out to npm, and bumps to the next dev version.
+
+1. Initiate the [release process here](https://github.com/Automattic/eslint-config-wpvip/actions/workflows/npm-prepare-release.yml).
+1. On the right-hand side, select "Run Workflow".
+1. Pick your preferred version bump.
+1. Click `Run Workflow`.
+1. Wait for a pull request to appear. The pull request will update the version number and shall be assigned to you.
+1. When ready, merge the pull request. This will lead to a new version to be [published on npmjs.com](https://www.npmjs.com/package/@automattic/eslint-plugin-wpvip).
+1. Another pull request will be created to bump to a development version, also assigned to you. Merge it to finish the process.
+
+#### Local
+
+If GitHub Actions is down or not working for some reason or you need to push a release for a previous version (e.g. security release), you can still publish a new release.
+
+1. Check out the branch or commit you want to release using `git`.
+1. Run `npm run prepare` to generate the build.
+1. Create a new branch for the release: `git checkout -b release/vX.Y.Z` -- remember to update the version number in the branch name.
+1. Run`npm version <type>` to bump the version prior to publishing (see versioning types above).
+1. Commit the changes and create a pull request, then merge it in GitHub.
+1. Run`npm publish`.
+1. Create [a new release in Github](https://github.com/Automattic/eslint-config-wpvip/releases/new). Use the built-in "Generate Release Notes" to get release notes. Tag the version.
+1. Observe that the package has been released on GitHub and npmjs.com.

package/README.md

@@ -10,6 +10,10 @@ Install `eslint` and `@automattic/eslint-plugin-wpvip` to your project.
 npm install --save-dev eslint @automattic/eslint-plugin-wpvip
 ```
 
+## Contributing
+
+See [CONTRIBUTING.md](https://github.com/Automattic/eslint-config-wpvip/blob/trunk/CONTRIBUTING.md) for details on development, testing, publishing, etc.
+
 ## Configuration
 
 Create an `.eslintrc.js` file. **Note:** The `init` file allows you to avoid installing peer dependencies (available from `v0.5.0`).

package/configs/javascript.js

@@ -24,7 +24,7 @@ module.exports = {
 	/**
 	 * Note: We must explicitly add this plugin to use our custom rules.
 	 */
-	plugins: [ '@automattic/wpvip', 'import', 'promise' ],
+	plugins: [ '@automattic/wpvip', 'import', 'promise', 'unused-imports' ],
 
 	/**
 	 * Please include a short description of the rule. For rules that downgrade or
@@ -132,6 +132,7 @@ module.exports = {
 		],
 
 		'import/no-unresolved': 'error',
+		'unused-imports/no-unused-imports': 'warn',
 
 		// Enforce Unix linebreaks. Included here and not in "formatting" since it
 		// is not controversial and helps with interchange.
@@ -167,6 +168,8 @@ module.exports = {
 
 		'no-lonely-if': 'error',
 
+		'no-implicit-coercion': 'error',
+
 		'no-mixed-operators': 'error',
 
 		'no-nested-ternary': 'error',
@@ -177,7 +180,14 @@ module.exports = {
 
 		'no-unused-expressions': 'error',
 
-		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
+		'no-unused-vars': [
+			'error',
+			{
+				argsIgnorePattern: '^_',
+				destructuredArrayIgnorePattern: '^_',
+				ignoreRestSiblings: true,
+			},
+		],
 
 		'no-useless-computed-key': 'error',
 

package/configs/typescript.js

@@ -27,6 +27,16 @@ module.exports = {
 				// config, and is elevated to an error here.
 				'@typescript-eslint/no-explicit-any': 'error',
 
+				// Provide escape hatches around destructuring and arguments.
+				'@typescript-eslint/no-unused-vars': [
+					'error',
+					{
+						argsIgnorePattern: '^_',
+						destructuredArrayIgnorePattern: '^_',
+						ignoreRestSiblings: true,
+					},
+				],
+
 				// Disable some rules that TypeScript handles and are also a Performance
 				// issue. See:
 				// https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/linting/troubleshooting/Performance.md#eslint-plugin-import
@@ -40,11 +50,8 @@ module.exports = {
 				// Use TypeScript-specific rules.
 				'no-duplicate-imports': 'off',
 				'no-shadow': 'off',
-				'@typescript-eslint/no-duplicate-imports': 'error',
 				'@typescript-eslint/no-shadow': 'error',
-
-				// Handled by TS itself.
-				'no-unused-vars': 'off',
+				'import/no-duplicates': 'error',
 
 				// Empty classes are allowed if they are accompanied by a decorator.
 				// This is common in frameworks such as Angular / nest.js.

package/configs/weak-typescript.js

@@ -37,6 +37,8 @@ module.exports = {
 				'@typescript-eslint/restrict-template-expressions': 'warn',
 
 				'@typescript-eslint/unbound-method': 'warn',
+
+				'import/no-duplicates': 'warn',
 			},
 		},
 	],

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.5.8",
+  "version": "0.7.0",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {
-    "check-types": "tsc __tests__/**/*.ts",
+    "check-types": "tsc -p tsconfig.check.json",
     "cmd:format": "prettier --ignore-path .gitignore '**/*.(js|json|jsx|md|ts|tsx|yml|yaml)'",
     "cmd:jest": "npm run link-plugin && jest",
     "cmd:lint": "npm run link-plugin && eslint --ext 'js,jsx,ts,tsx'",
@@ -32,14 +32,14 @@
   },
   "homepage": "https://github.com/Automattic/eslint-config-wpvip#readme",
   "dependencies": {
-    "@babel/eslint-parser": "7.21.3",
-    "@rushstack/eslint-patch": "1.2.0",
-    "@typescript-eslint/eslint-plugin": "5.55.0",
-    "@typescript-eslint/parser": "5.55.0",
+    "@babel/eslint-parser": "7.22.10",
+    "@rushstack/eslint-patch": "1.3.3",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser": "^6.0.0",
     "eslint-config-prettier": "8.7.0",
     "eslint-import-resolver-typescript": "3.5.3",
-    "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-jest": "27.2.1",
+    "eslint-plugin-import": "2.28.1",
+    "eslint-plugin-jest": "27.2.3",
     "eslint-plugin-jsdoc": "40.0.2",
     "eslint-plugin-json": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.7.1",
@@ -48,6 +48,7 @@
     "eslint-plugin-react": "7.32.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-security": "1.7.1",
+    "eslint-plugin-unused-imports": "3.0.0",
     "find-package-json": "1.2.0",
     "globals": "13.20.0"
   },
@@ -56,9 +57,9 @@
   },
   "devDependencies": {
     "@tsconfig/node18": "1.0.1",
-    "@types/eslint": "8.37.0",
+    "@types/eslint": "8.44.2",
     "@types/jest": "29.5.0",
-    "eslint": "8.35.0",
+    "eslint": "8.47.0",
     "jest": "29.5.0",
     "prettier": "npm:wp-prettier@2.8.5",
     "ts-jest": "29.0.5",

package/tsconfig.check.json

@@ -0,0 +1,4 @@
+{
+  "extends": "./tsconfig.json",
+  "exclude": [ "__fixtures__" ]
+}

package/utils/is-package-installed.js

@@ -22,8 +22,8 @@ const parent =
 debugLog( `Found package.json: ${ parent.__path || 'none' }` );
 
 module.exports = function isPackageInstalled( packageName ) {
-	const isDevDependency = !! parent.devDependencies?.[ `${ packageName }` ];
-	const isProdDependency = !! parent.dependencies?.[ `${ packageName }` ];
+	const isDevDependency = Boolean( parent.devDependencies?.[ `${ packageName }` ] );
+	const isProdDependency = Boolean( parent.dependencies?.[ `${ packageName }` ] );
 
 	return isDevDependency || isProdDependency;
 };