@automattic/eslint-plugin-wpvip 0.5.5 → 0.5.7

package/configs/javascript.js

@@ -24,7 +24,7 @@ module.exports = {
 	/**
 	 * Note: We must explicitly add this plugin to use our custom rules.
 	 */
-	plugins: [ '@automattic/wpvip', 'import' ],
+	plugins: [ '@automattic/wpvip', 'import', 'promise' ],
 
 	/**
 	 * Please include a short description of the rule. For rules that downgrade or
@@ -202,6 +202,22 @@ module.exports = {
 		],
 
 		'wrap-iife': [ 'error', 'any' ],
+
+		'promise/always-return': 'off',
+		'promise/avoid-new': 'off',
+		'promise/catch-or-return': 'off',
+		'promise/no-callback-in-promise': 'warn',
+		'promise/no-multiple-resolved': 'error',
+		'promise/no-native': 'off',
+		'promise/no-nesting': 'warn',
+		'promise/no-new-statics': 'error',
+		'promise/no-promise-in-callback': 'warn',
+		'promise/no-return-in-finally': 'error',
+		'promise/no-return-wrap': 'error',
+		'promise/param-names': 'error',
+		'promise/prefer-await-to-callbacks': 'off',
+		'promise/prefer-await-to-then': 'off',
+		'promise/valid-params': 'error',
 	},
 
 	settings: {

package/configs/weak-javascript.js

@@ -52,6 +52,13 @@ module.exports = {
 				'one-var': 'warn',
 
 				radix: 'warn',
+
+				'promise/no-multiple-resolved': 'warn',
+				'promise/no-new-statics': 'warn',
+				'promise/no-return-in-finally': 'warn',
+				'promise/no-return-wrap': 'warn',
+				'promise/param-names': 'warn',
+				'promise/valid-params': 'warn',
 			},
 		},
 	],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.5.5",
+  "version": "0.5.7",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {
@@ -39,6 +39,7 @@
     "eslint-plugin-json": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-prettier": "4.2.1",
+    "eslint-plugin-promise": "6.1.1",
     "eslint-plugin-react": "7.32.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-security": "1.7.1",

package/utils/is-package-installed.js

@@ -1,8 +1,23 @@
 const debugLog = require( './debug-log' );
 const findPackageJson = require( 'find-package-json' );
 
+// Get a list of all package.json files in the current directory tree, ascending
+// up the tree from the current directory. Note that this code behaves differently
+// when it is installed as a package vs. when we are linting the code in this repo.
+//
+// When installed as a package, the current directory is inside node_modules and is
+// not the "package root" as we are thinking about it. In this case, we need to ignore
+// all package.json files that are inside node_modules directories.
+//
+// When we are linting the code in this repo, the current directory is not inside
+// node_modules and the first found "package.json" is the "package root."
+//
+// This problem is basically impossible to solve for all edge cases (like someone who
+// runs `npm run lint` from inside "node_modules") but this code should work for
+// most cases.
 const packages = [ ...findPackageJson( __dirname ) ];
-const parent = packages.pop() || {};
+const parent =
+	packages.find( pkg => ! pkg.__path.includes( '/node_modules/' ) ) || packages.pop() || {};
 
 debugLog( `Found package.json: ${ parent.__path || 'none' }` );