@automattic/eslint-plugin-wpvip 0.5.4 → 0.5.6

package/configs/javascript.js

@@ -24,7 +24,7 @@ module.exports = {
 	/**
 	 * Note: We must explicitly add this plugin to use our custom rules.
 	 */
-	plugins: [ '@automattic/wpvip', 'import' ],
+	plugins: [ '@automattic/wpvip', 'import', 'promise' ],
 
 	/**
 	 * Please include a short description of the rule. For rules that downgrade or
@@ -202,6 +202,22 @@ module.exports = {
 		],
 
 		'wrap-iife': [ 'error', 'any' ],
+
+		'promise/always-return': 'off',
+		'promise/avoid-new': 'off',
+		'promise/catch-or-return': 'off',
+		'promise/no-callback-in-promise': 'warn',
+		'promise/no-multiple-resolved': 'error',
+		'promise/no-native': 'off',
+		'promise/no-nesting': 'warn',
+		'promise/no-new-statics': 'error',
+		'promise/no-promise-in-callback': 'warn',
+		'promise/no-return-in-finally': 'error',
+		'promise/no-return-wrap': 'error',
+		'promise/param-names': 'error',
+		'promise/prefer-await-to-callbacks': 'off',
+		'promise/prefer-await-to-then': 'off',
+		'promise/valid-params': 'error',
 	},
 
 	settings: {

package/configs/weak-javascript.js

@@ -52,6 +52,13 @@ module.exports = {
 				'one-var': 'warn',
 
 				radix: 'warn',
+
+				'promise/no-multiple-resolved': 'warn',
+				'promise/no-new-statics': 'warn',
+				'promise/no-return-in-finally': 'warn',
+				'promise/no-return-wrap': 'warn',
+				'promise/param-names': 'warn',
+				'promise/valid-params': 'warn',
 			},
 		},
 	],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.5.4",
+  "version": "0.5.6",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {
@@ -39,6 +39,7 @@
     "eslint-plugin-json": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-prettier": "4.2.1",
+    "eslint-plugin-promise": "6.1.1",
     "eslint-plugin-react": "7.32.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-security": "1.7.1",

package/prettierrc.js

@@ -6,6 +6,6 @@ module.exports = {
 	printWidth: 100,
 	semi: true,
 	singleQuote: true,
-	trailingComma: 'all',
+	trailingComma: 'es5',
 	useTabs: true,
 };

package/rules/no-unguarded-get-range-at.js

@@ -11,7 +11,7 @@ module.exports = {
 	create( context ) {
 		return {
 			'CallExpression[callee.object.callee.property.name="getSelection"][callee.property.name="getRangeAt"]'(
-				node,
+				node
 			) {
 				context.report( {
 					node,

package/utils/is-package-installed.js

@@ -1,8 +1,7 @@
 const debugLog = require( './debug-log' );
 const findPackageJson = require( 'find-package-json' );
 
-const packages = [ ...findPackageJson( __dirname ) ];
-const parent = packages.pop() || {};
+const parent = findPackageJson( __dirname ).next()?.value || {};
 
 debugLog( `Found package.json: ${ parent.__path || 'none' }` );