@automattic/eslint-plugin-wpvip 0.4.9 → 0.4.11

package/.eslintrc.js

@@ -6,6 +6,7 @@ module.exports = {
 	extends: [
 		'plugin:eslint-plugin/recommended', // linting for eslint plugins!
 		'plugin:@automattic/wpvip/base',
+		'plugin:@automattic/wpvip/formatting',
 		'plugin:@automattic/wpvip/testing',
 		'plugin:@automattic/wpvip/typescript',
 	],

package/configs/formatting.js

@@ -4,6 +4,107 @@ module.exports = {
 	 * disable errors, include a brief justification or reasoning.
 	 */
 	rules: {
+		'array-bracket-spacing': [ 'error', 'always' ],
+
+		'arrow-parens': [ 'error', 'always' ],
+
+		'arrow-spacing': 'error',
+
+		'brace-style': [ 'error', '1tbs' ],
+
+		// Identifiers should be in camelCase. Object properties are excluded
+		// (including when destructuring) since they often come from external
+		// sources (like APIs).
+		camelcase: [
+			'error',
+			{
+				properties: 'never',
+				ignoreDestructuring: true,
+			},
+		],
+
+		'comma-dangle': [ 'error', 'always-multiline' ],
+
+		'comma-spacing': 'error',
+
+		'comma-style': [ 'error', 'last' ],
+
+		'computed-property-spacing': [ 'error', 'always' ],
+
+		curly: [ 'error', 'all' ],
+
+		'dot-notation': 'error',
+
+		// Files must end in a newline.
+		'eol-last': [ 'error', 'always' ],
+
+		'func-call-spacing': 'error',
+
+		indent: [ 'error', 'tab', { SwitchCase: 1 } ],
+
+		'key-spacing': 'error',
+
+		'keyword-spacing': 'error',
+
+		// Lines containing code should be a maximum of 200 characters in length.
+		'max-len': [
+			'warn',
+			{
+				code: 200,
+			},
+		],
+
+		'no-multi-spaces': 'error',
+
+		'no-multi-str': 'error',
+
+		'no-multiple-empty-lines': [ 'error', { max: 1 } ],
+
+		'no-trailing-spaces': 'error',
+
+		'no-whitespace-before-property': 'error',
+
+		'object-curly-spacing': [ 'error', 'always' ],
+
+		'object-shorthand': 'error',
+
+		'operator-linebreak': 'error',
+
+		'padded-blocks': [ 'error', 'never' ],
+
+		// Arrow functions should be used for function arguments and callbacks.
+		'prefer-arrow-callback': 'warn',
+
+		quotes: [
+			'error',
+			'single',
+			{ allowTemplateLiterals: true, avoidEscape: true },
+		],
+
+		'quote-props': [ 'error', 'as-needed' ],
+
+		semi: 'error',
+
+		'semi-spacing': 'error',
+
+		'space-before-blocks': [ 'error', 'always' ],
+
+		'space-before-function-paren': [
+			'error',
+			{ anonymous: 'never', named: 'never', asyncArrow: 'always' },
+		],
+
+		'space-in-parens': [ 'error', 'always' ],
+
+		'space-infix-ops': 'error',
+
+		'space-unary-ops': [ 'error', { overrides: { '!': true, yield: true } } ],
+
+		// Comments should always include consistent spacing for readability.
+		'spaced-comment': 'warn',
+
+		'template-curly-spacing': [ 'error', 'always' ],
+
 	},
 };
 

package/configs/index.js

@@ -9,5 +9,6 @@ module.exports = {
 	testing: require( './testing' ),
 	typescript: require( './typescript' ),
 	'weak-javascript': require( './weak-javascript' ),
+	'weak-testing': require( './weak-testing' ),
 	'weak-typescript': require( './weak-typescript' ),
 };

package/configs/javascript.js

@@ -39,7 +39,7 @@ module.exports = {
 		'no-case-declarations': 'error',
 		'no-class-assign': 'error',
 		'no-compare-neg-zero': 'error',
-		// 'no-cond-assign': 'error', // overridden below
+		// 'no-cond-assign': 'error', // extended below
 		'no-const-assign': 'error',
 		'no-constant-condition': 'error',
 		'no-control-regex': 'error',
@@ -50,7 +50,7 @@ module.exports = {
 		'no-dupe-else-if': 'error',
 		'no-dupe-keys': 'error',
 		'no-duplicate-case': 'error',
-		'no-empty': 'error',
+		// 'no-empty': 'error', // extended below
 		'no-empty-character-class': 'error',
 		'no-empty-pattern': 'error',
 		'no-ex-assign': 'error',
@@ -85,14 +85,14 @@ module.exports = {
 		'no-unsafe-negation': 'error',
 		'no-unsafe-optional-chaining': 'error',
 		'no-unused-labels': 'error',
-		// 'no-unused-vars': 'error', // overridden below
+		// 'no-unused-vars': 'error', // extended below
 		'no-useless-backreference': 'error',
 		'no-useless-catch': 'error',
 		'no-useless-escape': 'error',
 		'no-with': 'error',
 		'require-yield': 'error',
 		'use-isnan': 'error',
-		// 'valid-typeof': 'error', // overridden below
+		// 'valid-typeof': 'error', // extended below
 
 		// Async/await must not be used in a `.forEach` method, because the result
 		// will not be awaited in the outer scope.
@@ -110,12 +110,8 @@ module.exports = {
 		// Maximum cyclomatic complexity must not be above 20.
 		complexity: 'error',
 
-		'dot-notation': 'error',
-
 		eqeqeq: 'error',
 
-		'func-call-spacing': 'error',
-
 		// Identifiers should be between 2 and 40 characters in length in order to
 		// provide a concise semantic meaning.
 		'id-length': [
@@ -165,6 +161,8 @@ module.exports = {
 
 		'no-else-return': 'error',
 
+		'no-empty': [ 'error', { allowEmptyCatch: true } ],
+
 		'no-eq-null': 'error',
 
 		'no-eval': 'error',
@@ -173,12 +171,6 @@ module.exports = {
 
 		'no-mixed-operators': 'error',
 
-		'no-multi-spaces': 'error',
-
-		'no-multi-str': 'error',
-
-		'no-multiple-empty-lines': [ 'error', { max: 1 } ],
-
 		'no-nested-ternary': 'error',
 
 		'no-shadow': 'error',
@@ -197,18 +189,12 @@ module.exports = {
 
 		'no-var': 'error',
 
-		// Non-controversial formatting rule.
-		'no-whitespace-before-property': 'error',
-
 		'one-var': [ 'error', 'never' ],
 
 		'prefer-const': [ 'error', { destructuring: 'all' } ],
 
 		radix: 'error',
 
-		// Non-controversial formatting rule.
-		semi: 'error',
-
 		// The result of `typeof` must always be compared to a literal string.
 		'valid-typeof': [
 			'error',

package/configs/weak-javascript.js

@@ -7,9 +7,54 @@
  * temporary basis.
  */
 module.exports = {
-	/**
-	 * Downgrade rules from the base preset to "warn". Do not disable rules (set
-	 * to "off"). If a rule is already set to a warning, do not disable it.
-	 */
-	rules: {},
+	overrides: [
+		{
+			// Don't apply weak rules to TypeScript files.
+			files: [ '**/*.js', '**/*.jsx' ],
+
+			/**
+			 * Downgrade rules from the base preset to "warn". Do not disable rules (set
+			 * to "off"). If a rule is already set to a warning, do not disable it.
+			 */
+			rules: {
+				'@automattic/wpvip/no-unused-vars-before-return': 'warn',
+
+				complexity: 'warn',
+
+				eqeqeq: 'warn',
+
+				'object-shorthand': 'warn',
+
+				'no-async-promise-executor': 'warn',
+
+				'no-await-in-loop': 'warn',
+
+				'no-case-declarations': 'warn',
+
+				'no-dupe-else-if': 'warn',
+
+				'no-else-return': 'warn',
+
+				'no-eq-null': 'warn',
+
+				'no-lonely-if': 'warn',
+
+				'no-mixed-operators': 'warn',
+
+				'no-prototype-builtins': 'warn',
+
+				'no-shadow': 'warn',
+
+				'no-unused-vars': 'warn',
+
+				'no-useless-escape': 'warn',
+
+				'no-var': 'warn',
+
+				'one-var': 'warn',
+
+				radix: 'warn',
+			},
+		},
+	],
 };

package/configs/weak-testing.js

@@ -0,0 +1,24 @@
+/**
+ * "Weak" testing rules
+ * ====================
+ * These rules are intended for codebases that are transitioning to the stronger
+ * testing preset but need weaker rules to prevent a massive number of changes.
+ * They do not provide good protection or standardization, but can useful on a
+ * temporary basis.
+ */
+module.exports = {
+	/**
+	 * Downgrade rules from the testing preset to "warn". Do not disable rules
+	 * (set to "off"). If a rule is already set to a warning, do not disable it.
+	 */
+	rules: {
+		'jest/no-alias-methods': 'warn',
+
+		'jest/no-done-callback': 'warn',
+
+		'jest/no-conditional-expect': 'warn',
+
+		'jest/no-standalone-expect': 'warn',
+	},
+};
+

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.4.9",
+  "version": "0.4.11",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {