@automattic/eslint-plugin-wpvip 0.4.12 → 0.5.0

package/README.md

@@ -21,6 +21,7 @@ module.exports = {
 	extends: [
 		'plugin:@automattic/wpvip/recommended',
 	],
+	root: true,
 };
 ```
 

package/configs/typescript.js

@@ -18,11 +18,21 @@ module.exports = {
 
 			parser: '@typescript-eslint/parser',
 
+			parserOptions: {
+				project: './tsconfig.json',
+			},
+
 			rules: {
 				// TypeScript `any` type must not be used. This is a warning in the base
 				// config, and is elevated to an error here.
 				'@typescript-eslint/no-explicit-any': 'error',
 
+				// Disable some rules that TypeScript handles and are also a Performance
+				// issue. See:
+				// https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/linting/troubleshooting/Performance.md#eslint-plugin-import
+				'import/default': 'off',
+				'import/named': 'off',
+
 				// Don't require redundant JSDoc types in TypeScript files.
 				'jsdoc/require-param-type': 'off',
 				'jsdoc/require-returns-type': 'off',
@@ -42,10 +52,11 @@ module.exports = {
 	plugins: ['@typescript-eslint', 'jsdoc'],
 
 	settings: {
+		'import/parsers': {
+			'@typescript-eslint/parser': ['.ts', '.tsx'],
+		},
 		'import/resolver': {
-			node: {
-				extensions: ['.js', '.jsx', '.ts', '.tsx'],
-			},
+			typescript: {},
 		},
 	},
 };

package/configs/weak-typescript.js

@@ -13,7 +13,31 @@ module.exports = {
 			 * Downgrade rules from the base preset to "warn". Do not disable rules (set
 			 * to "off"). If a rule is already set to a warning, do not disable it.
 			 */
-			rules: {},
+			rules: {
+				'@typescript-eslint/no-explicit-any': 'warn',
+
+				'@typescript-eslint/no-floating-promises': 'warn',
+
+				'@typescript-eslint/no-misused-promises': 'warn',
+
+				'@typescript-eslint/no-unsafe-argument': 'warn',
+
+				'@typescript-eslint/no-unsafe-assignment': 'warn',
+
+				'@typescript-eslint/no-unsafe-call': 'warn',
+
+				'@typescript-eslint/no-unsafe-member-access': 'warn',
+
+				'@typescript-eslint/no-unsafe-return': 'warn',
+
+				'@typescript-eslint/require-await': 'warn',
+
+				'@typescript-eslint/restrict-plus-operands': 'warn',
+
+				'@typescript-eslint/restrict-template-expressions': 'warn',
+
+				'@typescript-eslint/unbound-method': 'warn',
+			},
 		},
 	],
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@automattic/eslint-plugin-wpvip",
-  "version": "0.4.12",
+  "version": "0.5.0",
   "description": "ESLint plugin for internal WordPress VIP projects",
   "main": "index.js",
   "scripts": {
@@ -30,6 +30,7 @@
     "@typescript-eslint/eslint-plugin": "5.55.0",
     "@typescript-eslint/parser": "5.55.0",
     "eslint-config-prettier": "8.7.0",
+    "eslint-import-resolver-typescript": "3.5.3",
     "eslint-plugin-import": "2.27.5",
     "eslint-plugin-jest": "27.2.1",
     "eslint-plugin-jsdoc": "40.0.2",

package/utils/is-package-installed.js

@@ -1,28 +1,8 @@
-const fs = require('node:fs');
 const debugLog = require('./debug-log');
 const findPackageJson = require('find-package-json');
 
-function findParent() {
-	const packages = [...findPackageJson()];
-	const firstPackage = packages.shift();
-
-	// A little hack to help us use this plugin to lint itself: When installed via
-	// NPM, .eslintrc.js will be missing (due to .npmignore).
-	if ('@automattic/eslint-plugin-wpvip' === firstPackage.name) {
-		const eslintRc = firstPackage.__path.replace(
-			/package\.json$/,
-			'.eslintrc.js'
-		);
-		// eslint-disable-next-line security/detect-non-literal-fs-filename
-		if (fs.statSync(eslintRc)) {
-			return firstPackage;
-		}
-	}
-
-	return packages.pop() || {};
-}
-
-const parent = findParent();
+const packages = [...findPackageJson(__dirname)];
+const parent = packages.pop() || {};
 
 debugLog(`Found package.json: ${parent.__path || 'none'}`);