@automattic/charts 2.0.1 → 3.1.0

package/src/providers/chart-context/global-charts-provider.tsx

@@ -8,6 +8,11 @@ import {
 	useLayoutEffect,
 	useRef,
 } from 'react';
+// Side-effect import: emits the `--a8c-charts-*` catalog, scoped to the `a8c-charts-scope` class applied to this component's wrapper below. Every chart either sits under a `GlobalChartsProvider` or auto-mounts its own, so importing it here guarantees the catalog always reaches the bundle.
+//
+// This must be a direct import of the stylesheet, not through a re-export barrel: a barrel `.ts` file doesn't match this package's `sideEffects` glob (only `*.css`/`*.scss` do), so tsdown/Rolldown treats an unused barrel import as side-effect-free and drops it — taking the nested stylesheet import with it. The file also can't be named `*.module.scss`: it declares zero CSS-module class names (only a `:where()`-wrapped selector), and `@tsdown/css` marks a `.module.*` file's generated JS proxy `moduleSideEffects: false` (tree-shakeable unless a class name is read); a plain stylesheet gets `moduleSideEffects: "no-treeshake"` instead, so it always ships. `tools/assert-charts-scope-emitted.ts` fails `pnpm run build` if this regresses — a passing test suite alone does not catch a dropped stylesheet.
+import '../../styles/chart-scope.scss';
+import { CHART_SCOPE_CLASS } from '../../styles/chart-scope-class';
 import {
 	getItemShapeStyles,
 	getSeriesBarStyles,
@@ -16,11 +21,15 @@ import {
 	resolveCssVariable,
 	normalizeColorToHex,
 } from '../../utils';
+// Imported from the module rather than the `chart-scope` barrel: the barrel also pulls `use-standalone-scope-class`, which imports `GlobalChartsContext` back from this file. That cycle resolves today only because the binding is read lazily inside the hook body.
+import { ChartScopeContext } from '../chart-scope/chart-scope-context';
 import { getChartColor, type ColorCache } from './private/get-chart-color';
+import { themeOverrideVars } from './private/theme-override-vars';
+import { withCatalogPointers } from './private/with-catalog-pointers';
 import { defaultTheme } from './themes';
 import type { GlobalChartsContextValue, ChartRegistration } from './types';
 import type { ChartTheme, CompleteChartTheme } from '../../types';
-import type { FC, ReactNode } from 'react';
+import type { CSSProperties, FC, ReactNode } from 'react';
 
 export const GlobalChartsContext = createContext< GlobalChartsContextValue | null >( null );
 
@@ -35,13 +44,33 @@ export const GlobalChartsProvider: FC< GlobalChartsProviderProps > = ( { childre
 	const [ hiddenSeries, setHiddenSeries ] = useState< Map< string, Set< string > > >(
 		() => new Map()
 	);
+	// Which charts have had their defaults seeded. Kept apart from `hiddenSeries`
+	// because that map drops a chart's entry once its hidden set empties, so an
+	// absent entry cannot tell "never seeded" from "the reader revealed the lot".
+	const seededCharts = useRef< Set< string > >( new Set() );
 
 	// Ref to the wrapper element for resolving scoped CSS variables
 	const wrapperRef = useRef< HTMLDivElement >( null );
+	const [ scopeNode, setScopeNode ] = useState< HTMLElement | null >( null );
+
+	const setWrapperNode = useCallback( ( node: HTMLDivElement | null ) => {
+		wrapperRef.current = node;
+		setScopeNode( node );
+	}, [] );
+
+	// themeOverrideVars reads the raw `theme` prop, never `providerTheme` — feeding it the restored theme below would make an overridden role's pointer look like a self-reference and drop the var (see themeOverrideVars' own doc comment).
+	const { vars: overrideVars, roles: overriddenRoles } = useMemo(
+		() => themeOverrideVars( theme ),
+		[ theme ]
+	);
 
 	const providerTheme: CompleteChartTheme = useMemo( () => {
-		return theme ? mergeThemes( defaultTheme, theme ) : defaultTheme;
-	}, [ theme ] );
+		if ( ! theme ) {
+			return defaultTheme;
+		}
+
+		return withCatalogPointers( mergeThemes( defaultTheme, theme ), overriddenRoles );
+	}, [ theme, overriddenRoles ] );
 
 	// Cache expensive color computations that only change when theme colors change
 	// Using useState + useLayoutEffect instead of useMemo to ensure CSS variables
@@ -186,11 +215,6 @@ export const GlobalChartsProvider: FC< GlobalChartsProviderProps > = ( { childre
 		[ colorCache, groupToColorMap ]
 	);
 
-	const resolveThemeColor = useCallback< GlobalChartsContextValue[ 'resolveThemeColor' ] >(
-		value => ( value ? normalizeColorToHex( value, wrapperRef.current, resolveCssVariable ) : '' ),
-		[]
-	);
-
 	const getElementStyles = useCallback< GlobalChartsContextValue[ 'getElementStyles' ] >(
 		( { data, index, overrideColor, legendShape } ) => {
 			const isSeriesData = data && typeof data === 'object' && 'data' in data && 'options' in data;
@@ -222,28 +246,90 @@ export const GlobalChartsProvider: FC< GlobalChartsProviderProps > = ( { childre
 		[ providerTheme, resolveColor ]
 	);
 
-	// Series visibility management methods
-	const toggleSeriesVisibility = useCallback( ( chartId: string, seriesLabel: string ) => {
-		setHiddenSeries( prev => {
-			const newMap = new Map( prev );
-			const chartHidden = newMap.get( chartId ) || new Set();
-			const newSet = new Set( chartHidden );
+	// Keep hidden-series updates and no-op detection consistent across setters.
+	const updateHiddenSeries = useCallback(
+		( chartId: string, update: ( current: Set< string > ) => Set< string > ) => {
+			setHiddenSeries( prev => {
+				const current = prev.get( chartId );
+				const next = update( new Set( current ?? [] ) );
 
-			if ( newSet.has( seriesLabel ) ) {
-				newSet.delete( seriesLabel );
-			} else {
-				newSet.add( seriesLabel );
-			}
+				if ( ! current && next.size === 0 ) {
+					return prev;
+				}
+
+				// Preserve identity for no-op updates.
+				if (
+					current &&
+					current.size === next.size &&
+					[ ...next ].every( label => current.has( label ) )
+				) {
+					return prev;
+				}
+
+				const newMap = new Map( prev );
+				if ( next.size === 0 ) {
+					newMap.delete( chartId );
+				} else {
+					newMap.set( chartId, next );
+				}
+
+				return newMap;
+			} );
+		},
+		[]
+	);
 
-			if ( newSet.size === 0 ) {
-				newMap.delete( chartId );
-			} else {
-				newMap.set( chartId, newSet );
+	const toggleSeriesVisibility = useCallback(
+		( chartId: string, seriesLabel: string ) => {
+			updateHiddenSeries( chartId, current => {
+				if ( current.has( seriesLabel ) ) {
+					current.delete( seriesLabel );
+				} else {
+					current.add( seriesLabel );
+				}
+				return current;
+			} );
+		},
+		[ updateHiddenSeries ]
+	);
+
+	const setSeriesVisibility = useCallback(
+		( chartId: string, seriesLabel: string, visible: boolean ) => {
+			updateHiddenSeries( chartId, current => {
+				if ( visible ) {
+					current.delete( seriesLabel );
+				} else {
+					current.add( seriesLabel );
+				}
+				return current;
+			} );
+		},
+		[ updateHiddenSeries ]
+	);
+
+	const setChartHiddenSeries = useCallback(
+		( chartId: string, seriesLabels: readonly string[] ) => {
+			updateHiddenSeries( chartId, () => new Set( seriesLabels ) );
+		},
+		[ updateHiddenSeries ]
+	);
+
+	const hasSeededChart = useCallback(
+		( chartId: string ) => seededCharts.current.has( chartId ),
+		[]
+	);
+
+	const seedChartHiddenSeries = useCallback(
+		( chartId: string, seriesLabels: readonly string[] ) => {
+			if ( seededCharts.current.has( chartId ) ) {
+				return;
 			}
 
-			return newMap;
-		} );
-	}, [] );
+			seededCharts.current.add( chartId );
+			setChartHiddenSeries( chartId, seriesLabels );
+		},
+		[ setChartHiddenSeries ]
+	);
 
 	const isSeriesVisible = useCallback(
 		( chartId: string, seriesLabel: string ) => {
@@ -269,8 +355,11 @@ export const GlobalChartsProvider: FC< GlobalChartsProviderProps > = ( { childre
 			getChartData,
 			theme: providerTheme,
 			getElementStyles,
-			resolveThemeColor,
 			toggleSeriesVisibility,
+			setSeriesVisibility,
+			setChartHiddenSeries,
+			seedChartHiddenSeries,
+			hasSeededChart,
 			isSeriesVisible,
 			getHiddenSeries,
 			isColorPaletteResolved,
@@ -282,8 +371,11 @@ export const GlobalChartsProvider: FC< GlobalChartsProviderProps > = ( { childre
 			getChartData,
 			providerTheme,
 			getElementStyles,
-			resolveThemeColor,
 			toggleSeriesVisibility,
+			setSeriesVisibility,
+			setChartHiddenSeries,
+			seedChartHiddenSeries,
+			hasSeededChart,
 			isSeriesVisible,
 			getHiddenSeries,
 			isColorPaletteResolved,
@@ -292,8 +384,13 @@ export const GlobalChartsProvider: FC< GlobalChartsProviderProps > = ( { childre
 
 	return (
 		<GlobalChartsContext.Provider value={ value }>
-			<div ref={ wrapperRef } style={ { display: 'contents' } }>
-				{ children }
+			<div
+				ref={ setWrapperNode }
+				className={ CHART_SCOPE_CLASS }
+				data-testid="charts-scope"
+				style={ { display: 'contents', ...overrideVars } as CSSProperties }
+			>
+				<ChartScopeContext.Provider value={ scopeNode }>{ children }</ChartScopeContext.Provider>
 			</div>
 		</GlobalChartsContext.Provider>
 	);

package/src/providers/chart-context/hooks/use-default-hidden-series.ts

@@ -0,0 +1,47 @@
+import { useEffect, useLayoutEffect, useMemo, useRef } from 'react';
+import { useGlobalChartsContext } from './use-global-charts-context';
+
+// Hide seeded series before paint without triggering React's SSR warning.
+const useIsomorphicLayoutEffect = typeof window !== 'undefined' ? useLayoutEffect : useEffect;
+
+/**
+ * Seeds a chart's hidden series once per chart ID, the first time the provider
+ * sees that ID.
+ *
+ * The provider owns the record of what has been seeded, not this hook: a
+ * mount-scoped one would re-apply the defaults on every remount, and a chart
+ * remounts for reasons the reader never thinks of as a new chart — switching
+ * between line and bar, tabbing away and back, a resize flipping tabs into a
+ * dropdown. Each of those would throw away the series they had just revealed.
+ *
+ * @param chartId      - The chart ID passed to the provider's visibility methods.
+ * @param seriesLabels - Labels to hide when this chart ID is first seen. Later values are ignored.
+ * @return The resolved hidden-series set.
+ */
+export const useDefaultHiddenSeries = (
+	chartId: string,
+	seriesLabels?: readonly string[]
+): Set< string > => {
+	const { getHiddenSeries, seedChartHiddenSeries, hasSeededChart } = useGlobalChartsContext();
+	// Read through a ref so the effect never depends on a new array identity.
+	const labelsRef = useRef( seriesLabels );
+	labelsRef.current = seriesLabels;
+	const hasSeriesLabels = seriesLabels !== undefined;
+	const shouldUseDefaults = hasSeriesLabels && ! hasSeededChart( chartId );
+
+	useIsomorphicLayoutEffect( () => {
+		if ( labelsRef.current === undefined ) {
+			return;
+		}
+		seedChartHiddenSeries( chartId, labelsRef.current );
+	}, [ chartId, hasSeriesLabels, seedChartHiddenSeries ] );
+
+	// getHiddenSeries hands out a fresh copy per call, so hold the set still between
+	// visibility changes. Charts derive their rendered series from it, and a new
+	// identity every render invalidates every memo downstream — including the one
+	// the accessible tooltip watches, which closes a tooltip mid-navigation.
+	return useMemo(
+		() => ( shouldUseDefaults ? new Set( labelsRef.current ) : getHiddenSeries( chartId ) ),
+		[ shouldUseDefaults, getHiddenSeries, chartId ]
+	);
+};

package/src/providers/chart-context/private/theme-override-vars.ts

@@ -0,0 +1,87 @@
+import type { ChartTheme } from '../../../types';
+
+// The consumer theme fields that correspond to an emitted catalog role, and the role each one overrides. Each role must be read by exactly the elements its field controlled before the role existed: `svgLabelSmall.fill` maps to the narrow `--a8c-charts-color-label-axis` rather than `--a8c-charts-color-label`, because the broad role is also read by legend labels, heatmap cell values, funnel labels and the line-chart tooltip, which that field never moved.
+const ROLE_FOR_FIELD: Array< [ string, ( theme: Partial< ChartTheme > ) => string | undefined ] > =
+	[
+		[ '--a8c-charts-color-background', theme => theme.backgroundColor ],
+		[ '--a8c-charts-color-grid', theme => theme.gridStyles?.stroke ],
+		[ '--a8c-charts-color-axis', theme => theme.xAxisLineStyles?.stroke ],
+		[ '--a8c-charts-color-tick', theme => theme.xTickLineStyles?.stroke ],
+		[ '--a8c-charts-color-label-axis', theme => theme.svgLabelSmall?.fill ],
+	];
+
+/**
+ * The variable a `theme` prop override is published as, one layer outside the role itself.
+ *
+ * `chart-scope.scss` declares each of these roles as `var(<role>-theme, <catalog default>)`, so an override that is invalid at computed-value time — a fallback-less `var()` naming a token the host never set — only invalidates this variable, and the role still resolves its mapped `--wpds-*` token. Published as the role directly, such a value took the role and every bare `var(<role>)` read site down with it.
+ *
+ * @param role - The catalog role being overridden.
+ * @return The custom property carrying the consumer's value.
+ */
+export const themeLayerVar = ( role: string ): string => `${ role }-theme`;
+
+/** Every role whose catalog entry must read a theme layer. `src/styles/test/chart-scope.test.ts` checks the stylesheet against this. */
+export const THEME_LAYERED_ROLES: readonly string[] = ROLE_FOR_FIELD.map( ( [ role ] ) => role );
+
+/**
+ * Whether a value reads the role it is being published for, which would make the catalog entry depend on itself.
+ *
+ * The dependency runs `<role>: var(<role>-theme, …)`, so a value naming `<role>` closes a cycle through the catalog entry. CSS marks every custom property in a cycle invalid at computed-value time — the role's own fallback is *not* used, so the token resolves to nothing and every chart loses that colour. Verified in Chrome: `--role-theme: var(--role, blue); --role: var(--role-theme, green)` leaves `--role` empty, not `green`.
+ *
+ * Three things this has to get right, none of which a plain substring test gets:
+ *
+ * `var()` permits whitespace after the opening paren, so testing for `var(<role>` misses `var( --a8c-charts-color-grid, … )`.
+ *
+ * Several roles are prefixes of others (`--a8c-charts-color-label` of `--a8c-charts-color-label-secondary`), and every role is a prefix of its own theme layer. A prefix match would read a legitimate cross-role pointer as a self-reference and silently drop the override, so the role must be followed by something that cannot continue an identifier — `-` included. A value naming `<role>-theme` is therefore not treated as a self-reference: that cycle is confined to the theme layer, which leaves the role free to fall back to the catalog default.
+ *
+ * `resolveCssVariable` also accepts a bare custom-property name with no `var()` wrapper (`--a8c-charts-color-grid`), so that is legal `theme` input too. It forms no cycle — custom properties accept arbitrary token streams — so it survives as a literal string and drops silently at the use site instead of falling back to the catalog default.
+ *
+ * @param value - The consumer's value for the field.
+ * @param role  - The catalog role this value would override.
+ * @return True when the value reads `role`, so it must not be published.
+ */
+const readsOwnRole = ( value: string, role: string ): boolean =>
+	value.trim() === role ||
+	new RegExp( `var\\(\\s*${ role.replace( /[.*+?^${}()|[\]\\]/g, '\\$&' ) }(?![\\w-])` ).test(
+		value
+	);
+
+export type ThemeOverrides = {
+	/** The custom properties to write on the provider wrapper. */
+	vars: Record< string, string >;
+	/** Every mapped role the consumer set a value for, whether or not it was published. */
+	roles: readonly string[];
+};
+
+/**
+ * Maps a sparse consumer theme onto the theme-layer variables its overridden catalog roles read, so CSS-painted and JS-resolved colours read one source.
+ *
+ * A value that reads the role it would override is left unpublished — that is the default theme's own pointer surviving `mergeThemes`, and publishing it would invalidate the role. The role is still reported in `roles`: `withCatalogPointers` restores its theme field to the catalog pointer either way, so CSS and visx agree on the catalog default rather than visx painting a literal CSS never sees.
+ *
+ * @param theme - The consumer's `theme` prop, before merging with the default theme.
+ * @return The wrapper's custom properties, and the roles the consumer overrode.
+ */
+export const themeOverrideVars = ( theme?: Partial< ChartTheme > ): ThemeOverrides => {
+	if ( ! theme ) {
+		return { vars: {}, roles: [] };
+	}
+
+	const vars: Record< string, string > = {};
+	const roles: string[] = [];
+
+	for ( const [ role, read ] of ROLE_FOR_FIELD ) {
+		const value = read( theme );
+
+		if ( typeof value !== 'string' || value === '' ) {
+			continue;
+		}
+
+		roles.push( role );
+
+		if ( ! readsOwnRole( value, role ) ) {
+			vars[ themeLayerVar( role ) ] = value;
+		}
+	}
+
+	return { vars, roles };
+};

package/src/providers/chart-context/private/with-catalog-pointers.ts

@@ -0,0 +1,50 @@
+import { defaultTheme } from '../themes';
+import type { CompleteChartTheme } from '../../../types';
+
+// Restores each overridden role's mapped theme field to the catalog pointer `defaultTheme` already carries for it, so the value comes from `themes.ts` itself rather than a second, hand-copied literal.
+const CATALOG_RESTORE_FOR_ROLE: Record<
+	string,
+	( theme: CompleteChartTheme ) => Partial< CompleteChartTheme >
+> = {
+	'--a8c-charts-color-background': () => ( { backgroundColor: defaultTheme.backgroundColor } ),
+	'--a8c-charts-color-grid': theme => ( {
+		gridStyles: { ...theme.gridStyles, stroke: defaultTheme.gridStyles.stroke },
+	} ),
+	'--a8c-charts-color-axis': theme => ( {
+		xAxisLineStyles: { ...theme.xAxisLineStyles, stroke: defaultTheme.xAxisLineStyles.stroke },
+	} ),
+	'--a8c-charts-color-tick': theme => ( {
+		xTickLineStyles: { ...theme.xTickLineStyles, stroke: defaultTheme.xTickLineStyles.stroke },
+	} ),
+	'--a8c-charts-color-label-axis': theme => ( {
+		svgLabelSmall: { ...theme.svgLabelSmall, fill: defaultTheme.svgLabelSmall.fill },
+	} ),
+};
+
+/**
+ * Restores the mapped theme fields of `overriddenRoles` to their catalog pointer, so the theme-layer variable `themeOverrideVars` writes on the provider wrapper is the only carrier for an overridden role — CSS and the JS bridge (`useXYChartTheme`) then resolve it through the same cascade instead of visx reading a baked literal that can disagree with a closer CSS override.
+ *
+ * This covers roles `themeOverrideVars` deliberately left unpublished as well as the ones it published. A value that reads its own role is not publishable, but leaving visx the consumer's literal is what the whole mechanism exists to prevent: `theme={ { gridStyles: { stroke: 'var(--brand, var(--a8c-charts-color-grid, red))' } } }` would have CSS paint the catalog default while visx painted `--brand`.
+ *
+ * Every field outside the five mapped roles is left exactly as `merged` provided it: those aren't published as theme-layer vars, so rewriting them would erase a consumer's override with no replacement carrier.
+ *
+ * @param merged          - The consumer theme merged onto `defaultTheme` (`mergeThemes` output).
+ * @param overriddenRoles - The catalog roles the consumer overrode, from `themeOverrideVars`.
+ * @return A new theme object; `merged` is not mutated.
+ */
+export const withCatalogPointers = (
+	merged: CompleteChartTheme,
+	overriddenRoles: readonly string[]
+): CompleteChartTheme => {
+	let result = merged;
+
+	for ( const role of overriddenRoles ) {
+		const restore = CATALOG_RESTORE_FOR_ROLE[ role ];
+
+		if ( restore ) {
+			result = { ...result, ...restore( result ) };
+		}
+	}
+
+	return result;
+};

package/src/providers/chart-context/test/chart-context.test.tsx

@@ -1728,6 +1728,148 @@ describe( 'ChartContext', () => {
 			// Should have empty set after all series are visible
 			expect( hidden.size ).toBe( 0 );
 		} );
+
+		it( 'setSeriesVisibility sets state absolutely rather than toggling', () => {
+			let contextValue: GlobalChartsContextValue;
+			const TestComponent = () => {
+				contextValue = useGlobalChartsContext();
+				return <div>Test</div>;
+			};
+
+			render(
+				<GlobalChartsProvider>
+					<TestComponent />
+				</GlobalChartsProvider>
+			);
+
+			act( () => {
+				contextValue.setSeriesVisibility( 'test-chart', 'Series 1', false );
+			} );
+			expect( contextValue.isSeriesVisible( 'test-chart', 'Series 1' ) ).toBe( false );
+
+			// Calling it again with the same value must not flip it back.
+			act( () => {
+				contextValue.setSeriesVisibility( 'test-chart', 'Series 1', false );
+			} );
+			expect( contextValue.isSeriesVisible( 'test-chart', 'Series 1' ) ).toBe( false );
+
+			act( () => {
+				contextValue.setSeriesVisibility( 'test-chart', 'Series 1', true );
+			} );
+			expect( contextValue.isSeriesVisible( 'test-chart', 'Series 1' ) ).toBe( true );
+		} );
+
+		it( 'setChartHiddenSeries replaces the hidden set rather than merging into it', () => {
+			let contextValue: GlobalChartsContextValue;
+			const TestComponent = () => {
+				contextValue = useGlobalChartsContext();
+				return <div>Test</div>;
+			};
+
+			render(
+				<GlobalChartsProvider>
+					<TestComponent />
+				</GlobalChartsProvider>
+			);
+
+			act( () => {
+				contextValue.setChartHiddenSeries( 'test-chart', [ 'Series 1', 'Series 2' ] );
+			} );
+			expect( contextValue.getHiddenSeries( 'test-chart' ) ).toEqual(
+				new Set( [ 'Series 1', 'Series 2' ] )
+			);
+
+			act( () => {
+				contextValue.setChartHiddenSeries( 'test-chart', [ 'Series 2' ] );
+			} );
+			expect( contextValue.isSeriesVisible( 'test-chart', 'Series 1' ) ).toBe( true );
+			expect( contextValue.isSeriesVisible( 'test-chart', 'Series 2' ) ).toBe( false );
+
+			act( () => {
+				contextValue.setChartHiddenSeries( 'test-chart', [] );
+			} );
+			expect( contextValue.getHiddenSeries( 'test-chart' ) ).toEqual( new Set() );
+		} );
+
+		it( 'setChartHiddenSeries leaves other charts alone', () => {
+			let contextValue: GlobalChartsContextValue;
+			const TestComponent = () => {
+				contextValue = useGlobalChartsContext();
+				return <div>Test</div>;
+			};
+
+			render(
+				<GlobalChartsProvider>
+					<TestComponent />
+				</GlobalChartsProvider>
+			);
+
+			act( () => {
+				contextValue.setChartHiddenSeries( 'chart-a', [ 'Series 1' ] );
+				contextValue.setChartHiddenSeries( 'chart-b', [ 'Series 2' ] );
+			} );
+
+			expect( contextValue.isSeriesVisible( 'chart-a', 'Series 1' ) ).toBe( false );
+			expect( contextValue.isSeriesVisible( 'chart-a', 'Series 2' ) ).toBe( true );
+			expect( contextValue.isSeriesVisible( 'chart-b', 'Series 2' ) ).toBe( false );
+		} );
+
+		it( 'a redundant setSeriesVisibility write does not change context identity or re-render', () => {
+			let contextValue: GlobalChartsContextValue;
+			let childUpdateTally = 0;
+			const TestComponent = () => {
+				contextValue = useGlobalChartsContext();
+				childUpdateTally++;
+				return <div>Test</div>;
+			};
+
+			render(
+				<GlobalChartsProvider>
+					<TestComponent />
+				</GlobalChartsProvider>
+			);
+
+			act( () => {
+				contextValue.setSeriesVisibility( 'test-chart', 'Series 1', false );
+			} );
+			const isSeriesVisibleAfterFirstWrite = contextValue.isSeriesVisible;
+			const tallyAfterFirstWrite = childUpdateTally;
+
+			// Redundant write: the series is already hidden, so this must be a no-op.
+			act( () => {
+				contextValue.setSeriesVisibility( 'test-chart', 'Series 1', false );
+			} );
+
+			expect( contextValue.isSeriesVisible ).toBe( isSeriesVisibleAfterFirstWrite );
+			expect( childUpdateTally ).toBe( tallyAfterFirstWrite );
+		} );
+
+		it( 'setting an already-empty hidden set does not create then delete a Map entry', () => {
+			let contextValue: GlobalChartsContextValue;
+			let childUpdateTally = 0;
+			const TestComponent = () => {
+				contextValue = useGlobalChartsContext();
+				childUpdateTally++;
+				return <div>Test</div>;
+			};
+
+			render(
+				<GlobalChartsProvider>
+					<TestComponent />
+				</GlobalChartsProvider>
+			);
+
+			const tallyBeforeWrite = childUpdateTally;
+			const isSeriesVisibleBefore = contextValue.isSeriesVisible;
+
+			// This chart has no hidden-series entry at all yet.
+			act( () => {
+				contextValue.setChartHiddenSeries( 'test-chart', [] );
+			} );
+
+			expect( childUpdateTally ).toBe( tallyBeforeWrite );
+			expect( contextValue.isSeriesVisible ).toBe( isSeriesVisibleBefore );
+		} );
 	} );
 
 	describe( 'GlobalChartsProvider - CSS Variable Support', () => {
@@ -2536,46 +2678,6 @@ describe( 'ChartContext', () => {
 				expect( afterRerenderColor ).toBe( '#ff0000' );
 			} );
 		} );
-
-		describe( 'resolveThemeColor', () => {
-			let contextValue: GlobalChartsContextValue;
-
-			const TestComponent = () => {
-				contextValue = useGlobalChartsContext();
-				return <div>Test</div>;
-			};
-
-			const mountProvider = () =>
-				render(
-					<GlobalChartsProvider>
-						<TestComponent />
-					</GlobalChartsProvider>
-				);
-
-			it( 'resolves a CSS variable against the provider scope, not the document root', () => {
-				window.getComputedStyle = jest.fn( ( element: Element ) => ( {
-					getPropertyValue: ( prop: string ) =>
-						prop === '--surface' && element !== document.documentElement ? '#1e1e1e' : '#ffffff',
-				} ) ) as unknown as typeof window.getComputedStyle;
-
-				mountProvider();
-
-				expect( contextValue.resolveThemeColor( 'var(--surface, #fff)' ) ).toBe( '#1e1e1e' );
-			} );
-
-			it( 'passes a resolved color through to hex', () => {
-				mountProvider();
-
-				expect( contextValue.resolveThemeColor( '#abcdef' ) ).toBe( '#abcdef' );
-				expect( contextValue.resolveThemeColor( 'rgb(255, 0, 0)' ) ).toBe( '#ff0000' );
-			} );
-
-			it( 'returns an empty string for an empty value', () => {
-				mountProvider();
-
-				expect( contextValue.resolveThemeColor( '' ) ).toBe( '' );
-			} );
-		} );
 	} );
 
 	describe( 'defaultTheme', () => {

package/src/providers/chart-context/test/chart-scope-class.test.tsx

@@ -0,0 +1,19 @@
+import { render, screen } from '@testing-library/react';
+import { CHART_SCOPE_CLASS } from '../../../styles/chart-scope-class';
+import { GlobalChartsProvider } from '../global-charts-provider';
+
+describe( 'GlobalChartsProvider wrapper', () => {
+	it( 'carries the a8c-charts-scope class and nothing that affects layout', () => {
+		render(
+			<GlobalChartsProvider>
+				<div>child</div>
+			</GlobalChartsProvider>
+		);
+
+		const wrapper = screen.getByTestId( 'charts-scope' );
+
+		expect( wrapper ).toHaveClass( CHART_SCOPE_CLASS );
+		// The catalog needs an element to sit on; `display: contents` is what keeps that element out of the consumer's layout.
+		expect( wrapper.style.cssText.replace( /\s/g, '' ) ).toBe( 'display:contents;' );
+	} );
+} );

package/src/providers/chart-context/test/sparse-theme.test.ts

@@ -0,0 +1,35 @@
+import { defaultTheme } from '../themes';
+
+const flatten = ( value: unknown ): string[] => {
+	if ( typeof value === 'string' ) {
+		return [ value ];
+	}
+	if ( Array.isArray( value ) ) {
+		return value.flatMap( flatten );
+	}
+	if ( value && typeof value === 'object' ) {
+		return Object.values( value ).flatMap( flatten );
+	}
+	return [];
+};
+
+describe( 'defaultTheme', () => {
+	const strings = flatten( defaultTheme );
+
+	it( 'holds no --wpds-* mapping — that lives only in the catalog stylesheet', () => {
+		expect( strings.filter( value => value.includes( '--wpds-' ) ) ).toEqual( [] );
+	} );
+
+	it( 'points every themed colour at an --a8c-charts-* catalog role', () => {
+		const varStrings = strings.filter( value => value.startsWith( 'var(' ) );
+
+		expect( varStrings.length ).toBeGreaterThan( 0 );
+		expect( varStrings.every( value => value.startsWith( 'var(--a8c-charts-' ) ) ).toBe( true );
+	} );
+
+	it( 'gives every catalog pointer a terminal literal for the SSR and jsdom paths', () => {
+		const varStrings = strings.filter( value => value.startsWith( 'var(--a8c-charts-' ) );
+
+		expect( varStrings.every( value => value.includes( ',' ) ) ).toBe( true );
+	} );
+} );