npm - @autofleet/settings - Versions diffs - 1.1.3 → 1.1.4 - Mend

@autofleet/settings 1.1.3 → 1.1.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/dist/index.js CHANGED Viewed

@@ -62,8 +62,11 @@ class SettingsManager {
             if (cacheValue !== undefined) {
                 if (waitingToNetwork === cacheValue) {
                     yield nextTick();
-                    return new Promise((resolve) => {
+                    return new Promise((resolve, reject) => {
                         this.networkEvents.once(cacheKey, (networkValue) => {
+                            if (networkValue instanceof Error && rejectOnFail) {
+                                return reject(networkValue);
+                            }
                             resolve(SettingsManager.readNetworkValue(networkValue, defaultValue));
                         });
                     });
@@ -87,7 +90,9 @@ class SettingsManager {
             catch (error) {
                 logger.error('Cant get setting from network', { error });
                 if (rejectOnFail) {
-                    throw new CannotGetNetworkValueError();
+                    const errorToThrow = new CannotGetNetworkValueError();
+                    this.networkEvents.emit(cacheKey, errorToThrow);
+                    throw errorToThrow;
                 }
             }
             this.networkEvents.emit(cacheKey, networkValue);

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@autofleet/settings",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "description": "",
   "main": "dist/index.js",
   "scripts": {

package/src/index.ts CHANGED Viewed

@@ -95,8 +95,11 @@ class SettingsManager {
     if (cacheValue !== undefined) {
       if (waitingToNetwork === cacheValue) {
         await nextTick();
-        return new Promise((resolve) => {
+        return new Promise((resolve, reject) => {
           this.networkEvents.once(cacheKey, (networkValue) => {
+            if (networkValue instanceof Error && rejectOnFail) {
+              return reject(networkValue);
+            }
             resolve(SettingsManager.readNetworkValue(networkValue, defaultValue));
           });
         });
@@ -121,7 +124,9 @@ class SettingsManager {
     } catch (error) {
       logger.error('Cant get setting from network', { error });
       if (rejectOnFail) {
-        throw new CannotGetNetworkValueError();
+        const errorToThrow = new CannotGetNetworkValueError();
+        this.networkEvents.emit(cacheKey, errorToThrow);
+        throw errorToThrow;
       }
     }