@autofleet/node-common 1.1.75 → 1.1.76

package/.npmignore

@@ -0,0 +1,4 @@
+node_modules
+logs
+coverage
+!.vscode/launch.json

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autofleet/node-common",
-  "version": "1.1.75",
+  "version": "1.1.76",
   "description": "",
   "scripts": {
     "coverage": "jest --coverage --forceExit --runInBand",

package/settings/index.js

@@ -82,7 +82,13 @@ class SettingsManager {
     }
 
     this.networkEvents.emit(cacheKey, networkValue);
-    const returnValue = SettingsManager.readNetworkValue(networkValue, defaultValue);
+    let returnValue;
+    try {
+      returnValue = SettingsManager.readNetworkValue(networkValue, defaultValue);
+    } catch (e) {
+      this.settingsCache.del(cacheKey);
+      throw e;
+    }
     this.settingsCache.set(cacheKey, returnValue, this.ttl);
     return returnValue;
   }

package/settings/index.test.js

@@ -119,6 +119,24 @@ describe('Settings', () => {
       .rejects.toEqual(new Error('Cannot find value from network or cache, default value is set to never'));
   });
 
+  it('Throws an error if network error and no default value and success the next time', async (done) => {
+    const settings = new Settings({
+      serviceUrl: `http://${serviceUrl}/`,
+    });
+
+    const f = () => settings.get('key1', settings.NEVER_DEFAULT_VALUE);
+    expect(f())
+      .rejects.toEqual(new Error('Cannot find value from network or cache, default value is set to never'));
+
+
+    setTimeout(async () => {
+      const m = mockSetting('key1', 'value1');
+      expect(await settings.get('key1', settings.NEVER_DEFAULT_VALUE)).toEqual('value1');
+      expect(m.isDone());
+      done();
+    }, 100);
+  });
+
   it('Values can be flushed', async () => {
     const m1 = mockSetting('key1', 'value1');
     const settings = new Settings({