@autofleet/node-common 1.1.4 → 1.1.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autofleet/node-common",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "description": "",
   "scripts": {
     "coverage": "jest --coverage --forceExit --runInBand",

package/settings/example.js

@@ -2,7 +2,7 @@
 const Settings = require('./index');
 
 const settings = new Settings({
-  serviceUrl: 'http://localhost:8085/',
+  serviceUrl: 'http://setting-ms.autofleet.io/',
 });
 
 const fleetId = 'e7bbfcad-98a8-421d-962f-fd1c7790c789';

package/settings/index.js

@@ -8,7 +8,7 @@ require('dotenv').config();
 const fiveMinutes = 60 * 5;
 
 module.exports = class SettingsManager {
-  constructor({ serviceUrl, ttl = fiveMinutes }) {
+  constructor({ serviceUrl, ttl = fiveMinutes } = {}) {
     const localServiceUrl = serviceUrl || process.env.SETTING_MS_SERVICE_HOST;
 
     this.ttl = ttl;
@@ -31,7 +31,7 @@ module.exports = class SettingsManager {
 
     let networkValue;
     try {
-      const networkReponse = await this.network.get(`/api/v1/setting/get-setting/${key}`, {
+      const networkReponse = await this.network.get(`/api/v1/settings/get-setting/${key}`, {
         params: {
           labels,
         },

package/settings/index.test.js

@@ -9,6 +9,26 @@ const mockSetting = (key, value, labels, response = 200) => nock(serviceUrl)
   .reply(response, { value });
 
 describe('Settings', () => {
+  it('Throws exeption if there is no defualt value', async () => {
+    const settings = new Settings({
+      serviceUrl,
+    });
+
+    expect(settings.get('key1'))
+      .rejects.toEqual(new Error('Can\'t get a key without defaultValue'));
+  });
+
+  it('Uses env.SETTING_MS_SERVICE_HOST as serivce host if no one defind', async () => {
+    const m = mockSetting('key1', 'value1');
+    process.env.SETTING_MS_SERVICE_HOST = serviceUrl;
+    const settings = new Settings();
+
+    const value = await settings.get('key1', 'dv');
+    expect(value).toEqual('value1');
+    expect(m.isDone()).toBeTruthy();
+    process.env.SETTING_MS_SERVICE_HOST = '';
+  });
+
   it('Get a key from server', async () => {
     const m = mockSetting('key1', 'value1');
     const settings = new Settings({