@autofleet/node-common 1.1.35 → 1.1.36

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/network/index.js CHANGED
@@ -62,7 +62,7 @@ module.exports = class Network {
62
62
  logger.info(`Finish Request: [${response.config.method.toUpperCase()} ${response.config.url}`);
63
63
  return response;
64
64
  }, (error) => {
65
- logger.error(`Finish Request with error: ${error.response.data.message}`);
65
+ logger.error('Finish Request with error', { status: error.status, data: error.response && error.response.data });
66
66
  throw error;
67
67
  });
68
68
  }
@@ -30,13 +30,14 @@ describe('Network', () => {
30
30
 
31
31
  it('Getting 404', async () => {
32
32
  const n = new Network({ serviceUrl: 'https://www.apple.com' });
33
- const response = await n.get('/resource', {
33
+
34
+ const action = async () => n.get('/resource', {
34
35
  query: {
35
36
  a: 'b',
36
37
  },
37
38
  });
38
- expect(response).toBeDefined();
39
- expect(response.data).not.toBeDefined();
39
+
40
+ expect(action()).rejects.toThrow(Error);
40
41
  });
41
42
 
42
43
  test('Retry 1 time', async () => {
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@autofleet/node-common",
3
- "version": "1.1.35",
3
+ "version": "1.1.36",
4
4
  "description": "",
5
5
  "scripts": {
6
6
  "coverage": "jest --coverage --forceExit --runInBand",
package/settings/index.js CHANGED
@@ -47,7 +47,7 @@ module.exports = class SettingsManager {
47
47
  });
48
48
  networkValue = networkReponse.data.value;
49
49
  } catch (error) {
50
- logger.error('Cant get setting from network', error);
50
+ logger.error('Cant get setting from network');
51
51
  }
52
52
 
53
53
  const returnValue = typeof networkValue !== 'undefined' ? networkValue : defaultValue;