@autofleet/node-common 1.1.21 → 1.1.22

package/events/index.js

@@ -7,8 +7,12 @@ const publish = (eventType, eventObj, debug = false) => {
   const projectId = process.env.PROJECT;
   const topic = process.env.TOPIC;
 
+  if (!topic || !projectId) {
+    return 'Missing project/topic';
+  }
+
   if (envv === 'development' && !debug) {
-    return 'not publishing in dev';
+    return 'Not publishing in dev';
   }
 
   const pubsubClient = new PubSub({ projectId });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autofleet/node-common",
-  "version": "1.1.21",
+  "version": "1.1.22",
   "description": "",
   "scripts": {
     "coverage": "jest --coverage --forceExit --runInBand",

package/settings/index.js

@@ -27,6 +27,10 @@ module.exports = class SettingsManager {
       throw new Error('Can\'t get a key without defaultValue');
     }
 
+    if (process.env.NODE_ENV === 'test') {
+      return defaultValue;
+    }
+
     const cacheKey = `${key}_${JSON.stringify(labels)}`;
     const cacheValue = this.settingsCache.get(cacheKey);
     if (cacheValue !== undefined) {

package/settings/index.test.js

@@ -1,6 +1,8 @@
 const nock = require('nock');
 const Settings = require('./index');
 
+process.env.NODE_ENV = 'node-common-test';
+
 const serviceUrl = 'localhost:8085';
 
 const mockSetting = (key, value, labels, response = 200) => nock(`http://${serviceUrl}/`)
@@ -107,4 +109,14 @@ describe('Settings', () => {
     expect(value2).toEqual('value2');
     expect(m2.isDone()).toBeTruthy();
   });
+  it('when NODE_ENV === test return the default value', async () => {
+    process.env.NODE_ENV = 'test';
+    const settings = new Settings({
+      serviceUrl: `http://${serviceUrl}/`,
+    });
+
+    const value = await settings.get('key1', 'dv');
+    expect(value).toEqual('dv');
+    process.env.NODE_ENV = 'node-common-test';
+  });
 });