@autofleet/node-common 1.1.11 → 1.1.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autofleet/node-common",
-  "version": "1.1.11",
+  "version": "1.1.12",
   "description": "",
   "scripts": {
     "coverage": "jest --coverage --forceExit --runInBand",

package/settings/index.js

@@ -23,7 +23,7 @@ module.exports = class SettingsManager {
   }
 
   async get(key, defaultValue, labels = []) {
-    if (!defaultValue) {
+    if (typeof defaultValue === 'undefined') {
       throw new Error('Can\'t get a key without defaultValue');
     }
 

package/settings/index.test.js

@@ -18,6 +18,22 @@ describe('Settings', () => {
       .rejects.toEqual(new Error('Can\'t get a key without defaultValue'));
   });
 
+  it('Can get 0 as default value', async () => {
+    const settings = new Settings({
+      serviceUrl: `http://${serviceUrl}/`,
+    });
+
+    expect(await settings.get('key1', 0)).toBe(0);
+  });
+
+  it('Can get false as default value', async () => {
+    const settings = new Settings({
+      serviceUrl: `http://${serviceUrl}/`,
+    });
+
+    expect(await settings.get('key1', false)).toBe(false);
+  });
+
   it('Uses env.SETTING_MS_SERVICE_HOST as serivce host if no one defind', async () => {
     const m = mockSetting('key1', 'value1');
     process.env.SETTING_MS_SERVICE_HOST = serviceUrl;