@autobusal/utilities 1.3.0 → 1.4.1

package/CHANGELOG.md

@@ -1,36 +1,45 @@
 # Changelog
 
-All notable changes to this package are documented here. This project follows [Keep a Changelog](https://keepachangelog.com/) and [Semantic Versioning](https://semver.org/).
 
-## 1.3.0
+## 1.4.1
 
-`getDayParts` — the same short date as `getFormattedShort`, but in its parts.
-One string cannot be shortened by CSS, and the seven-day strip needs to drop
-the month on a narrow screen so seven days fit without a scroller.
+### Changed
 
-## [1.2.0] - 2026-07-25
+- **Gender can be "not declared".** `getOptionsSex` gains it as the first
+  option and `getSex` reports it, instead of treating everything that is not
+  `1` as male — which is what three existing rows with no value were already
+  rendering as.
 
-### Added
+  Carried by `null`: the `visitors`.`sex` column has always been nullable, so
+  nothing migrated. The option's id is `''`, which Laravel's
+  `ConvertEmptyStringsToNull` turns into a real null on the way in, so "not
+  declared" is the *absence* of a value at every layer rather than a magic
+  number each one has to learn.
 
-- `GetChannelStatus(t)`: shared disabled/dedicated/main select values for
-  the Telegram and WhatsApp admin settings tabs (and any future per-label
-  messaging channel).
+  Deliberately not shared with the checkout passenger forms — those build
+  their own field, and gender there is a per-route requirement a carrier can
+  insist on. A profile is the person; a passenger record is what a carrier
+  demands in order to board them.
 
-## [1.1.2] - 2026-07-24
+## 1.4.0
 
 ### Added
 
-- New `sanitizeHtml(html)` helper (wraps DOMPurify) for sanitizing admin-authored CMS content (pages, articles, notifications, policies, affiliate terms, document previews) before rendering via `dangerouslySetInnerHTML`. Added `dompurify` as a dependency.
-
-## [1.1.1] - 2026-07-19
-
-### Added
+- **`check-backticks.mjs`**, moved here from the autobusal repo root so the
+  apps can run it too.
 
-- `form.tsx`: the `Validate` helper now supports a cross-field `matches:<otherField>` rule (e.g. password confirmation). It accepts an optional third argument, react-hook-form's `getValues` (`UseFormGetValues<any>`), and emits a `validate` callback that compares the field against the named field, failing with the `errors.matches` message on mismatch. When `getValues` is not supplied the rule passes rather than blocking the form, so single-field rules keep working unchanged.
-- `users.tsx` / `index.ts`: new `GetEnvironment(t)` helper exposing a payment-gateway `sandbox` / `production` mode selector (labels `admin_label.manage.environment.*`), following the same shape as `GetStatus`. It is now exported from the package index.
+  A backtick used as quoting inside a styled-components template *terminates
+  the template*. The bundler then reports a syntax error somewhere further
+  down, pointing at a line that is perfectly fine — so the search starts in
+  the wrong place every time. Per the script's own history that cost five
+  build failures in one session before anyone connected the two.
 
-### Fixed
+  It only ever guarded `packages`, and the trap is not confined there: it bit
+  `magus/src` the moment a public page grew its own styled-components, with
+  nothing watching. Each app's `prebuild` now runs it over its own `src`
+  (first, so a broken template stops the build before it spends minutes
+  copying files), and `publish.sh` still runs it over `packages`.
 
-- `users.tsx`: `GetStatus` now returns all four real statuses. Previously it listed only Available (`1`) and Unavailable (`0`), so records whose actual status was Suspended (`2`) or Pending (`3`) had no matching `<option>`; the admin select silently fell back to Available and an unrelated save could overwrite the real status with Available. Added `suspended` and `pending` options to keep it in sync with `DisplayStatus`.
+  One script with three callers, rather than a copy per repo that drifts.
 
-Authored by Ferjolt Ozuni. Consolidated from the magus and alvavel whitelabel patch sets into canonical @autobusal source (eliminates per-repo patch-package divergence).
+  Takes the directory to scan as its argument.

package/check-backticks.mjs

@@ -0,0 +1,91 @@
+#!/usr/bin/env node
+/**
+ * Refuse to publish a backtick used as quoting inside a styled-components
+ * template literal.
+ *
+ * Edited: Ferjolt Ozuni - Date: 2026-08-03
+ *
+ * A backtick inside a CSS comment TERMINATES the template string. What the
+ * bundler then reports is a syntax error somewhere further down, pointing at
+ * a line that is perfectly fine - so the search starts in the wrong place
+ * every time. It cost five build failures in a single session before anyone
+ * connected the two.
+ *
+ * TWO THINGS HERE ARE LEGITIMATE and must never be flagged, which is why
+ * this is not a plain grep:
+ *
+ *   - nested css`...` interpolations, which this codebase uses everywhere
+ *   - backticks in the JSDoc ABOVE a styled block, which are idiomatic and
+ *     sit outside the template entirely
+ *
+ * The bug is only ever the intersection: a backtick inside a comment that
+ * sits BETWEEN styled.x` and its closing `;
+ *
+ * Edited: Ferjolt Ozuni - Date: 2026-08-06
+ * Moved into @autobusal/utilities from the repo root, so the APPS can run it
+ * too. It only ever guarded `packages`, and the trap is not confined there:
+ * it bit magus/src the moment a public page grew its own styled-components,
+ * with nothing watching. Each app's prebuild now runs it over its own src,
+ * and publish.sh still runs it over packages - one script, three callers,
+ * rather than a copy per repo that drifts.
+ *
+ * Takes the directory to scan as its argument.
+ */
+import { readdirSync, readFileSync, statSync } from 'node:fs';
+import { join } from 'node:path';
+
+const OPEN = /styled(?:\.\w+|\([^)]*\))(?:<[^>]*>)?`/g;
+
+const walk = (dir) => readdirSync(dir).flatMap((entry) => {
+  const path = join(dir, entry);
+
+  if (entry === 'node_modules' || entry.startsWith('.')) {
+    return [];
+  }
+
+  if (statSync(path).isDirectory()) {
+    return walk(path);
+  }
+
+  return /\.tsx?$/.test(entry) ? [path] : [];
+});
+
+const found = [];
+
+for (const path of walk(process.argv[2] ?? 'packages')) {
+  const text = readFileSync(path, 'utf8');
+
+  for (const match of text.matchAll(OPEN)) {
+    const start = match.index + match[0].length;
+    const end = text.indexOf('`;', start);
+
+    if (end === -1) {
+      continue;
+    }
+
+    const base = text.slice(0, start).split('\n').length;
+    let comment = false;
+
+    text.slice(start, end).split('\n').forEach((line, n) => {
+      if (line.includes('/*')) {
+        comment = true;
+      }
+
+      if (comment && line.includes('`')) {
+        found.push(`${ path }:${ base + n }: ${ line.trim().slice(0, 72) }`);
+      }
+
+      if (line.includes('*/')) {
+        comment = false;
+      }
+    });
+  }
+}
+
+if (found.length > 0) {
+  console.error('Backtick in a comment inside a styled template - this breaks the build:');
+  found.forEach((line) => console.error(`  ${ line }`));
+  process.exit(1);
+}
+
+console.log('backticks: clean');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/utilities",
-  "version": "1.3.0",
+  "version": "1.4.1",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts",

package/passengers.ts

@@ -1,15 +1,45 @@
 import { TFunction } from 'i18next';
 
-export const getSex = (value: number): string => (
-  value === 1 ? 'female' : 'male'
-);
+/**
+ * Edited: Ferjolt Ozuni - Date: 2026-08-06
+ *
+ * Gender is OPTIONAL on a profile, and "not declared" is a real answer
+ * rather than a missing one.
+ *
+ * `null` carries it - `visitors`.`sex` has always been nullable and already
+ * held rows with no value, so nothing needed migrating. What was missing was
+ * any way to SAY it: the select offered Male and Female, the profile form
+ * defaulted to Male, and anybody who never touched the field was recorded as
+ * male. Three such rows existed already and rendered as "male" here, because
+ * this treated everything that was not 1 as male.
+ *
+ * Deliberately NOT shared with the passenger forms at checkout: those build
+ * their own field (routes-order's Gender), and gender there is a per-route
+ * requirement a carrier can insist on. A profile is the person; a passenger
+ * record is what a carrier demands in order to board them, and those are
+ * different questions.
+ */
+export const getSex = (value?: number | null): string => {
+  if (value === null || value === undefined) {
+    return 'undeclared';
+  }
+
+  return value === 1 ? 'female' : 'male';
+};
 
 export const getOptionsSex = (t: TFunction<'common'>) => ([
   {
+    // Empty rather than a third numeric code: Laravel's
+    // ConvertEmptyStringsToNull turns it into a real null on the way in, so
+    // "not declared" is the ABSENCE of a value at every layer rather than a
+    // magic number each of them has to learn.
+    id: '',
+    name: t('data.gender.undeclared', { ns: 'common' })
+  }, {
     id: 0,
     name: t('data.gender.male', { ns: 'common' })
   }, {
     id: 1,
     name: t('data.gender.female', { ns: 'common' })
   }
-]);
+]);