@autobusal/routes-order 1.6.0 → 1.6.2

package/CHANGELOG.md

@@ -3,6 +3,38 @@
 All notable changes to this package are documented here. This project follows
 [Keep a Changelog](https://keepachangelog.com/) and [Semantic Versioning](https://semver.org/).
 
+## [1.6.2] - 2026-07-30
+
+### Fixed
+
+- **The full 9-segment `/bus-lines/:from/:to/:departure/:_return/:type/:adults/:children/:babies`
+  URL only auto-searched if a `?type=submit` query param was also present**
+  (`Step1/Step1.tsx`) - set only when the in-app search form navigated here
+  itself. Every OTHER way of reaching this URL - obtapi's
+  `Route::linkPurchase()` (which generates exactly this path with no query
+  param), a shared link, a search engine crawling it - rendered nothing but
+  the empty search form despite the URL already carrying a complete search
+  spec. Now also auto-searches whenever `:departure` is present in the path,
+  which only the full 9-segment route ever populates.
+
+## [1.6.1] - 2026-07-27
+
+### Added
+
+- **External-provider "Book on {provider}" redirect (Mode A: search +
+  redirect).** `Found/Route/Route.tsx` now detects `data.external?.mode ===
+  'redirect'` (obtapi's `Libraries\External\Search\Merge`) and swaps the
+  usual "Select Route" button for a `t('routes_order.step2.route.book_on')`
+  button that opens the click-out endpoint
+  (`{VITE_API_OBT}/api/external/go/{offer_id}`) in a new tab instead of
+  calling `onSave` - external offers use a synthetic id the local checkout
+  pipeline can't resolve, so "select" is never wired for them. The operator
+  logo and route-code links are also repointed to the same click-out URL
+  (not the raw provider deep link) so every outbound path is logged for the
+  search->click funnel, and the local-only "Read Operator Policy" button is
+  hidden for external rows (no local policy content exists for them).
+  Requires `@autobusal/providers` ^1.3.7.
+
 ## [1.6.0] - 2026-07-25
 
 ### Added

package/Found/Route/Route.tsx

@@ -27,6 +27,17 @@ const Route = ({ data, type, t, onSave }: Props): JSX.Element => {
     <RouteFeature key={ index } item={ item } />
   ));
 
+  // Edited: Ferjolt Ozuni - Date: 2026-07-27
+  // Mode A (search + redirect): this row is an external-provider offer,
+  // not a local route - "select" would try to check out with a synthetic
+  // "ext:..." id, which the local pipeline can't resolve. Every outbound
+  // click goes through the click-out endpoint (not the raw deep link
+  // directly) so it's logged for the search->click funnel.
+  const isExternalRedirect = data.external?.mode === 'redirect';
+  const bookOnUrl = data.external
+    ? `${ import.meta.env.VITE_API_OBT }/api/external/go/${ data.external.offer_id }`
+    : undefined;
+
   return (
     <Container className="box" $type={ type }>
       { data.price.offer === true && <SpecialOffer>{ t('routes_order.step2.route.offer') }</SpecialOffer> }
@@ -34,7 +45,7 @@ const Route = ({ data, type, t, onSave }: Props): JSX.Element => {
 
       <Trip>
         <Company>
-          <LinkCompany to={ data.operator.link } target="_blank" rel="noopener noreferrer" title={ data.operator.company }><img src={ data.operator.logo_url || LOGO_FALLBACK } onError={ (e) => { e.currentTarget.onerror = null; e.currentTarget.src = LOGO_FALLBACK; } } alt={ data.operator.company } /></LinkCompany>
+          <LinkCompany to={ bookOnUrl ?? data.operator.link } target="_blank" rel="noopener noreferrer" title={ data.operator.company }><img src={ data.operator.logo_url || LOGO_FALLBACK } onError={ (e) => { e.currentTarget.onerror = null; e.currentTarget.src = LOGO_FALLBACK; } } alt={ data.operator.company } /></LinkCompany>
         </Company>
 
         <Location>
@@ -62,10 +73,10 @@ const Route = ({ data, type, t, onSave }: Props): JSX.Element => {
             text={
               <>
                 <RiBus2Line />
-                { t('routes_order.step2.route.select') }
+                { isExternalRedirect ? t('routes_order.step2.route.book_on', { provider: data.operator.company }) : t('routes_order.step2.route.select') }
               </>
             }
-            onClick={ () => onSave(data) }
+            onClick={ () => (isExternalRedirect && bookOnUrl ? window.open(bookOnUrl, '_blank', 'noopener,noreferrer') : onSave(data)) }
           />
         </Price>
       </Trip>
@@ -73,7 +84,7 @@ const Route = ({ data, type, t, onSave }: Props): JSX.Element => {
       <Details>
         <Detail>
           <TitleDetail>{ t('routes_order.step2.route.name') }</TitleDetail>
-          <LinkRoute to={ data.link } target="_blank" rel="noopener noreferrer">{ data.code }</LinkRoute>
+          <LinkRoute to={ bookOnUrl ?? data.link } target="_blank" rel="noopener noreferrer">{ data.code }</LinkRoute>
         </Detail>
 
         { customs && (
@@ -90,14 +101,16 @@ const Route = ({ data, type, t, onSave }: Props): JSX.Element => {
           </Detail>
         ) }
 
-        <Detail>
-          <TitleDetail>{ t('routes_order.step2.route.policies.title') }</TitleDetail>
+        { !data.external && (
+          <Detail>
+            <TitleDetail>{ t('routes_order.step2.route.policies.title') }</TitleDetail>
 
-          <ButtonPolicy type="button" onClick={ () => setPolicy(true) }>
-            <HiOutlineDocumentText />
-            { t('routes_order.step2.route.policies.view') }
-          </ButtonPolicy>
-        </Detail>
+            <ButtonPolicy type="button" onClick={ () => setPolicy(true) }>
+              <HiOutlineDocumentText />
+              { t('routes_order.step2.route.policies.view') }
+            </ButtonPolicy>
+          </Detail>
+        ) }
       </Details>
 
       { data.trip.features_data.length > 0 && (
@@ -110,7 +123,7 @@ const Route = ({ data, type, t, onSave }: Props): JSX.Element => {
         </Features>
       ) }
 
-      { policy && <Policy id={ data.id } t={ t } onClose={ () => setPolicy(false) } /> }
+      { policy && typeof data.id === 'number' && <Policy id={ data.id } t={ t } onClose={ () => setPolicy(false) } /> }
     </Container>
   );
 };

package/Step1/Step1.tsx

@@ -25,7 +25,17 @@ const Step1 = ({ value, redirected, t, onSave }: Props): JSX.Element => {
 
   const prepared = prepare(value, params, searchParams, data.preferences.defaultLocations);
 
-  const isSubmitted = searchParams.get('type') === 'submit';
+  // Two ways this page ends up with a complete search spec:
+  // 1. `?type=submit` - set by the in-app search form (home/Main/Main.tsx)
+  //    when it navigates here itself.
+  // 2. `:departure` present in the URL path - the full 9-segment route
+  //    (/bus-lines/:from/:to/:departure/:_return/:type/:adults/:children/:babies)
+  //    already carries a complete search spec with no query param needed.
+  //    This is how obtapi's Route::linkPurchase() generates links, and how
+  //    anyone (a search engine, a shared link) reaches this URL directly -
+  //    previously only case 1 triggered a search, so every one of those
+  //    deep links rendered nothing but the empty search form.
+  const isSubmitted = searchParams.get('type') === 'submit' || params.departure !== undefined;
 
   useEffect(() => {
     if (isSubmitted && !redirected) {

package/Step4/Step4.tsx

@@ -40,8 +40,13 @@ const Step4 = ({ values, step1, step2, step3, isPartner, t, onSave, onBack }: Pr
     ...(step3 !== undefined ? (step3.trip?.passenger_fields ?? DEFAULT_FIELDS) : [])
   ]));
 
-  const busFrom = useBusOccupied(step1.departure, step2.id);
-  const busTo = useBusOccupied(step1._return, step3?.id);
+  // Edited: Ferjolt Ozuni - Date: 2026-07-27
+  // FoundData.id is widened to (number | string) for external-provider
+  // offers (Mode A: search + redirect), but those never reach Step4 -
+  // Found/Route.tsx's CTA opens the provider's click-out link for them
+  // instead of calling onSave, so a real local numeric id is guaranteed here.
+  const busFrom = useBusOccupied(step1.departure, step2.id as number);
+  const busTo = useBusOccupied(step1._return, step3?.id as (number | undefined));
 
   if (busFrom === undefined || busTo === undefined) {
     return <Loading t={ t } />;

package/Step5/Coupons/Coupons.tsx

@@ -21,7 +21,12 @@ interface Props {
 const Coupons = ({ current, step2, t, total, onApplied }: Props): (JSX.Element | null) => {
   const { register, handleSubmit, formState: { errors } } = useForm<CouponForm>();
 
-  const { mutate: SearchCoupons, isPending } = useGetCoupon(step2.id, total.value);
+  // Edited: Ferjolt Ozuni - Date: 2026-07-27
+  // step2.id is only a synthetic string for external-provider offers
+  // (Mode A: search + redirect), and those never reach Step5/checkout -
+  // Found/Route.tsx's CTA redirects to the provider instead of calling
+  // onSave, so a real local numeric id is guaranteed here.
+  const { mutate: SearchCoupons, isPending } = useGetCoupon(step2.id as number, total.value);
 
   const onSubmit = (data: CouponForm): void => {
     SearchCoupons(data, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/routes-order",
-  "version": "1.6.0",
+  "version": "1.6.2",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"