@autobusal/routes-order 1.34.1 → 1.34.3

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.34.3 - 2026-08-29
+
+- Staff sellers (agent/subagent/operator/employee/admin) get an OPTIONAL passenger email box at checkout, so a counter-sold ticket reaches the passenger instead of only the seller and operator (audit A4-05, owner decision). obtapi already read {type}{i}_email/_notify_email; it now validates them too.
+
+## 1.34.2 - 2026-08-29
+
+- With more than one card gateway available, each Credit Card button carries its processor's name - they used to render byte-identical (audit A0-06).
+
 # Changelog
 
 ## 1.34.0 (2026-08-29)

package/Checkout/Checkout.tsx

@@ -442,6 +442,14 @@ const Checkout = ({ values, step1, step2, step3, isPartner, t, onStore, onBack }
             values={ values }
             step1={ step1 }
             fields={ fields }
+            /*
+             * Claude - 2026-08-29 (audit A4-05, owner decision): only staff
+             * are asked. They are the sellers with no billing block - see
+             * `gaps` above - so this optional box is the only way a
+             * counter-sold ticket reaches the passenger directly instead of
+             * landing solely with the agent and the operator.
+             */
+            askEmail={ UserData !== undefined && ['agent', 'subagent', 'operator', 'employee', 'admin'].includes(UserData.type) }
             busFrom={ busFrom }
             busTo={ busTo }
             saved={ saved }

package/Step4/Passenger/Passenger.tsx

@@ -15,6 +15,15 @@ interface Props {
   number: number
   values?: PersonData
   fields: string[]
+  /**
+   * Claude - 2026-08-29 (audit A4-05, owner decision): staff selling at the
+   * counter get an OPTIONAL email box per passenger. They are the only
+   * sellers with no billing block (an agent or operator writes no
+   * orders_contact row), so without it a walk-in customer's ticket reached
+   * only the agent and the operator and had to be Re-Sent by hand. Optional
+   * on purpose: a counter sale often has no email to give.
+   */
+  askEmail?: boolean
   withReturn: boolean
   busFrom: OccupiedData
   busTo: OccupiedData
@@ -47,7 +56,7 @@ interface Props {
 // telegram render ONLY when the route requires them - and are then
 // required. Name and date of birth stay mandatory always. `fields` is the
 // union of both legs on a return trip (see Step4).
-const Passenger = ({ type, number, values, fields, withReturn, busFrom, busTo, pickedFrom, pickedTo, saved, savedMax, seatsOptional, seatsFee, t, errors, refs, onSeatSelect, onUpdate }: Props): JSX.Element => {
+const Passenger = ({ type, number, values, fields, askEmail, withReturn, busFrom, busTo, pickedFrom, pickedTo, saved, savedMax, seatsOptional, seatsFee, t, errors, refs, onSeatSelect, onUpdate }: Props): JSX.Element => {
   const name = `${ type }${ number }`;
 
   const names = {
@@ -65,7 +74,13 @@ const Passenger = ({ type, number, values, fields, withReturn, busFrom, busTo, p
     // Edited: Claude - Date: 2026-08-20
     // "Remember this passenger" - obtapi reads `{type}{i}_save` alongside
     // the `_fn` / `_pass` fields this form already posts.
-    save: `${ name }_save`
+    save: `${ name }_save`,
+
+    // the counter-sale email (audit A4-05). obtapi already reads
+    // `{type}{i}_email` + `_notify_email` - see Orders\Make\Tickets - it
+    // was only the web form that never offered them.
+    email: `${ name }_email`,
+    notifyEmail: `${ name }_notify_email`
   };
 
   const has = (field: string): boolean => fields.includes(field);
@@ -340,6 +355,31 @@ const Passenger = ({ type, number, values, fields, withReturn, busFrom, busTo, p
         </div>
       ) }
 
+      { askEmail && (
+        <div className="column">
+          <div className="row">
+            <label htmlFor={ id(names.email) }>{ t('routes_order.step4.email') }</label>
+
+            <input
+              type="email"
+              key={ `${ names.email }-${ applied }` }
+              id={ id(names.email) }
+              defaultValue={ start(names.email, undefined) }
+              { ...refs(names.email, Validate('email|max_length:255', t)) }
+            />
+
+            { Display(errors[names.email]) }
+
+            { /* the ticket goes to this address as well as to the seller -
+                 obtapi gates the per-passenger copy on `_notify_email`, so
+                 an address typed here has to arrive with the flag set */ }
+            <input type="hidden" value="1" { ...refs(names.notifyEmail) } />
+
+            <Notice>{ t('routes_order.step4.email_notice') }</Notice>
+          </div>
+        </div>
+      ) }
+
       { (has('whatsapp') || has('telegram')) && (
         <div className="column">
           { has('whatsapp') && (

package/Step4/Passengers/Display.tsx

@@ -8,6 +8,8 @@ interface Props {
   type: 'adult' | 'child' | 'baby'
   amount: number
   fields: string[]
+  /** staff sellers are offered an optional passenger email (audit A4-05) */
+  askEmail?: boolean
   withReturn: boolean
   values?: PersonData
   busFrom: OccupiedData
@@ -25,7 +27,7 @@ interface Props {
   onUpdate: (name: string, value: (string | number)) => void
 }
 
-const Display = ({ type, amount, fields, withReturn, values, busFrom, busTo, pickedFrom, pickedTo, saved, savedMax, seatsOptional, seatsFee, t, errors, refs, onSeatSelect, onUpdate }: Props): JSX.Element[] => {
+const Display = ({ type, amount, fields, askEmail, withReturn, values, busFrom, busTo, pickedFrom, pickedTo, saved, savedMax, seatsOptional, seatsFee, t, errors, refs, onSeatSelect, onUpdate }: Props): JSX.Element[] => {
   const passengers: JSX.Element[] = [];
 
   for (let i = 1; i <= amount; i++) {
@@ -35,6 +37,7 @@ const Display = ({ type, amount, fields, withReturn, values, busFrom, busTo, pic
         type={ type }
         number={ i }
         fields={ fields }
+        askEmail={ askEmail }
         withReturn={ withReturn }
         values={ values }
         busFrom={ busFrom }

package/Step4/Passengers/Passengers.tsx

@@ -11,6 +11,8 @@ interface Props {
   values?: PersonData
   step1: RoutesSearchForm
   fields: string[]
+  /** staff sellers are offered an optional passenger email (audit A4-05) */
+  askEmail?: boolean
   busFrom: OccupiedData
   busTo: OccupiedData
   /**
@@ -38,7 +40,7 @@ interface Props {
   onUpdate: (name: string, value: (string | number)) => void
 }
 
-const Passengers = ({ values, step1, fields, busFrom, busTo, saved, savedMax, seatsOptional, seatsFee, onPickedCount, t, errors, refs, onUpdate }: Props): JSX.Element => {
+const Passengers = ({ values, step1, fields, askEmail, busFrom, busTo, saved, savedMax, seatsOptional, seatsFee, onPickedCount, t, errors, refs, onUpdate }: Props): JSX.Element => {
   const [ pickedFrom, setPickedFrom ] = useState<number[]>([]);
   const [ pickedTo, setPickedTo ] = useState<number[]>([]);
 
@@ -84,6 +86,7 @@ const Passengers = ({ values, step1, fields, busFrom, busTo, saved, savedMax, se
         type="adult"
         amount={ step1.adults }
         fields={ fields }
+        askEmail={ askEmail }
         withReturn={ step1.type === 'return' }
         values={ values }
         busFrom={ busFrom }
@@ -105,6 +108,7 @@ const Passengers = ({ values, step1, fields, busFrom, busTo, saved, savedMax, se
         type="child"
         amount={ step1.children }
         fields={ fields }
+        askEmail={ askEmail }
         withReturn={ step1.type === 'return' }
         values={ values }
         busFrom={ busFrom }
@@ -126,6 +130,7 @@ const Passengers = ({ values, step1, fields, busFrom, busTo, saved, savedMax, se
         type="baby"
         amount={ step1.babies }
         fields={ fields }
+        askEmail={ askEmail }
         withReturn={ step1.type === 'return' }
         values={ values }
         busFrom={ busFrom }

package/Step5/Payments/Payments.tsx

@@ -42,6 +42,22 @@ const Payments = ({ selected, isPartner, routeId, total, currency, t, onChange }
 
   const available = getAvailablePayments(data, isPartner);
 
+  /*
+   * Claude - 2026-08-29 (audit A0-06, medium): a brand with several card
+   * gateways rendered N byte-identical "Credit Card" buttons - same icon,
+   * same words - so the buyer could not tell the options apart (and could
+   * not know which processor's surcharge they were accepting). With more
+   * than one card option each button now carries its processor's name;
+   * a single card gateway keeps the plain label it always had.
+   */
+  const CARD_GATEWAYS = ['bkt', 'stripe', 'mollie', 'raiffeisen', 'nexi'] as const;
+  const cardCount = isPartner ? CARD_GATEWAYS.length : CARD_GATEWAYS.filter(gateway => data?.[gateway]).length;
+  const CARD_NAMES: Record<string, string> = { bkt: 'BKT', stripe: 'Stripe', mollie: 'Mollie', raiffeisen: 'Raiffeisen', nexi: 'Nexi' };
+  const cardLabel = (gateway: string): string => (
+    cardCount > 1 ? `${ t('routes_order.step5.actions.card') } (${ CARD_NAMES[gateway] })` : t('routes_order.step5.actions.card')
+  );
+
+
   useEffect(() => {
     if (isSuccess) {
       const found = Object.keys(data).find(item => {
@@ -121,35 +137,35 @@ const Payments = ({ selected, isPartner, routeId, total, currency, t, onChange }
           { (data?.bkt || isPartner) && (
             <ButtonPayment type="button" $selected={ selected === 'bkt' } onClick={ () => onChange('bkt') }>
               <AiOutlineCreditCard />
-              { t('routes_order.step5.actions.card') }{ fee('bkt') }
+              { cardLabel('bkt') }{ fee('bkt') }
             </ButtonPayment>
           ) }
 
           { (data?.stripe || isPartner) && (
             <ButtonPayment type="button" $selected={ selected === 'stripe' } onClick={ () => onChange('stripe') }>
               <AiOutlineCreditCard />
-              { t('routes_order.step5.actions.card') }{ fee('stripe') }
+              { cardLabel('stripe') }{ fee('stripe') }
             </ButtonPayment>
           ) }
 
           { (data?.mollie || isPartner) && (
             <ButtonPayment type="button" $selected={ selected === 'mollie' } onClick={ () => onChange('mollie') }>
               <AiOutlineCreditCard />
-              { t('routes_order.step5.actions.card') }{ fee('mollie') }
+              { cardLabel('mollie') }{ fee('mollie') }
             </ButtonPayment>
           ) }
 
           { (data?.raiffeisen || isPartner) && (
             <ButtonPayment type="button" $selected={ selected === 'raiffeisen' } onClick={ () => onChange('raiffeisen') }>
               <AiOutlineCreditCard />
-              { t('routes_order.step5.actions.card') }{ fee('raiffeisen') }
+              { cardLabel('raiffeisen') }{ fee('raiffeisen') }
             </ButtonPayment>
           ) }
 
           { (data?.nexi || isPartner) && (
             <ButtonPayment type="button" $selected={ selected === 'nexi' } onClick={ () => onChange('nexi') }>
               <AiOutlineCreditCard />
-              { t('routes_order.step5.actions.card') }{ fee('nexi') }
+              { cardLabel('nexi') }{ fee('nexi') }
             </ButtonPayment>
           ) }
         </ContainerPayments>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/routes-order",
-  "version": "1.34.1",
+  "version": "1.34.3",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"