@autobusal/providers 1.41.3 → 1.41.5

package/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 1.41.5 - 2026-08-30
+
+- PriceData gains `base`/`base_display` - what this party would have paid before a dynamic reduction, present only on a reduction.
+
+## 1.41.4 - 2026-08-29
+
+- useGetMenu SUBSCRIBES to the language rather than only keying on it (audit A6-73). `i18next.language` was read during render and nothing re-rendered on a switch, so the i18n strings changed instantly while the admin-managed menu labels stayed in the previous language until a full reload.
+
+- SettingsData.preferences gains `legal` (company, address, city, VAT number) for the footer, and FoundData gains `stops` - the itinerary between the searched cities, with midnight offsets.
+
 ## 1.41.3 - 2026-08-29
 
 - UserData gains shipping_enabled (published by Auth\Export for operator/employee accounts) so menus can hide the Shipments module honestly (audit A1-37).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/providers",
-  "version": "1.41.3",
+  "version": "1.41.5",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"

package/services.ts

@@ -1,5 +1,6 @@
 import { useSuspenseQuery, UseSuspenseQueryResult } from '@tanstack/react-query';
 import i18next from 'i18next';
+import { useTranslation } from 'react-i18next';
 import apiClient from './Queries/apiClient';
 import { SettingsData, MenuData } from './types/settings';
 import useMenuStore from './stores/menu';
@@ -31,8 +32,31 @@ export const useGetMenu = (): UseSuspenseQueryResult<MenuData> => {
    * a later switch never refetched it. Keying on the active language makes a
    * switch load - and cache - that language's labels.
    */
+  /*
+   * Claude - 2026-08-29 (audit A6-73, low)
+   *
+   * SUBSCRIBED to the language, not merely keyed on it.
+   *
+   * The key above was right and could do nothing on its own:
+   * `i18next.language` is read during render, and nothing here re-rendered
+   * when it changed - so after switching to Albanian the i18n-file strings
+   * changed instantly while the admin-managed menu labels stayed in English
+   * until the next full page load. A visibly half-translated header after
+   * every switch, which is worse than either language on its own.
+   *
+   * useTranslation re-renders its component on i18next's `languageChanged`,
+   * which is what makes the key take a new value and the query refetch. The
+   * `t` it returns is deliberately unused; the subscription is the point.
+   *
+   * `resolvedLanguage` rather than `language`: a switch to a regional code
+   * ("en-GB") resolves to the base language that is actually loaded, and
+   * keying on the unresolved one would refetch identical labels under a
+   * second key.
+   */
+  const { i18n } = useTranslation();
+
   return useSuspenseQuery({
-    queryKey: ['get-menu', i18next.language],
+    queryKey: ['get-menu', i18n.resolvedLanguage ?? i18next.language],
     queryFn: async () => (
       await apiClient
         .get('/api/menus/get')

package/types/routes.ts

@@ -147,6 +147,30 @@ export interface FoundData extends Omit<RouteData, 'locations' | 'id'> {
   // Optional because external-provider offers don't report one; a filter
   // must read "missing" as unknown, never as direct.
   stops_count?: number
+
+  /**
+   * Claude - 2026-08-29 (audit A3-02h)
+   *
+   * The calls this service makes between the searched cities, boarding stop
+   * first and destination last - so the card can DRAW the itinerary rather
+   * than only count it. `day` is how many midnights have passed by the time
+   * the coach reaches that stop (0 at boarding, always), which is what lets
+   * an overnight timetable be read without its clock times appearing to run
+   * backwards.
+   *
+   * Optional: an external-provider offer reports no itinerary and an older
+   * obtapi sends none, so the card must draw nothing rather than an empty
+   * list.
+   */
+  stops?: {
+    city: string
+    stop: string | null
+    arrival: string
+    departure: string
+    day: number
+    douane: boolean
+  }[]
+
   // Edited: Ferjolt Ozuni - Date: 2026-08-01
   // Edited: Ferjolt Ozuni - Date: 2026-08-03
   // Minutes until this coach leaves, for TODAY's searches only - null on
@@ -193,6 +217,22 @@ export interface PriceData {
   display: string
   offer?: boolean
   value: number
+
+  /**
+   * What this party would have paid before a dynamic price rule reduced it.
+   *
+   * Claude - 2026-08-30 (roadmap P5, ruled by Ferjolt). Present ONLY on a
+   * reduction: "for a price rise, just the price; if the price drops, the
+   * standard fare cut through, and the actual price discounted". A surcharge
+   * deliberately publishes nothing here, so there is no "was" figure lying
+   * around for a card to render as a discount that never happened.
+   *
+   * It is a real total for the passengers being quoted - the same arithmetic
+   * as `value`, run against the pre-modifier fares - not a list price nobody
+   * was offered.
+   */
+  base?: number
+  base_display?: string
   from: LocationData
   to: LocationData
   adult: number

package/types/settings.ts

@@ -108,6 +108,26 @@ export interface SettingsData {
 
     operatorId?: number
 
+    /**
+     * Who legally operates this site.
+     *
+     * Claude - 2026-08-29 (audit A6-71). The trading name in `company` is not
+     * the entity: the footer read "© BusMagus 2026 Albania" and the public
+     * site named no company, address or tax number anywhere, though all
+     * three are on every invoice. Exactly four fields, chosen server-side -
+     * the same settings column holds the fiscal signing secrets and is never
+     * passed through whole (see Settings\ViewController).
+     *
+     * Optional, and each field optional within it: a brand that has not
+     * filled its legal block in shows what it has and nothing more.
+     */
+    legal?: {
+      company?: string
+      address?: string
+      city?: string
+      nipt?: string
+    }
+
     languages: {
       available: string[]
       default: string