@autobusal/providers 1.40.1 → 1.40.2

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 1.40.2
+
+### Fixed
+
+- **A missing blog/help/page slug showed the "system error" screen, not a
+  404.** The public content screens load through `useSuspenseQuery`, whose
+  throw the ErrorBoundary rendered as a system error for every case; a 404
+  (unknown slug) or 422 (the articles endpoint's "invalid slug" on an
+  absent/unpublished article) is now shown as the styled 404. (Audit
+  CMS-01f/CMS-03d.)
+- **The public navigation menu was always English.** obtapi localises the
+  labels off `Content-Language` - sent correctly - but the menu was cached
+  under a language-blind key, so it loaded once and a language switch never
+  refetched it. Keyed on the active language. (Audit CMS-07b.)
+
 ## 1.37.11
 
 ### Added

package/Errors/ErrorBoundary.tsx

@@ -5,11 +5,29 @@ interface Props {
   children: JSX.Element[] | JSX.Element
 }
 
-class ErrorBoundary extends React.Component<Props> {
-  state = { hasError: false };
+/*
+ * Edited: Claude - Date: 2026-08-22 (audit findings CMS-01f / CMS-03d)
+ *
+ * A missing blog article, help article or static page is a 404, not a system
+ * error. The public content screens load through useSuspenseQuery, which
+ * throws the axios error up here; this boundary rendered the generic "system
+ * error" page for every throw, so a mistyped or deleted slug told the visitor
+ * something had broken on our side. An HTTP 404 (unknown slug) or 422 (the
+ * articles endpoint's "selected slug is invalid" on an unpublished/absent
+ * article) is the content not being there - shown as the styled 404. Anything
+ * else is still a real error.
+ */
+function isMissing(error: unknown): boolean {
+  const status = (error as { response?: { status?: number } })?.response?.status;
 
-  static getDerivedStateFromError() {
-    return { hasError: true };
+  return status === 404 || status === 422;
+}
+
+class ErrorBoundary extends React.Component<Props, { hasError: boolean; missing: boolean }> {
+  state = { hasError: false, missing: false };
+
+  static getDerivedStateFromError(error: unknown) {
+    return { hasError: true, missing: isMissing(error) };
   }
 
   componentDidCatch(error: Error, info: React.ErrorInfo): void {
@@ -18,11 +36,11 @@ class ErrorBoundary extends React.Component<Props> {
 
   render() {
     if (this.state.hasError) {
-      return <Message type="error" />;
+      return <Message type={ this.state.missing ? 'not_found' : 'error' } />;
     }
 
     return this.props.children;
   }
 }
 
-export default ErrorBoundary;
+export default ErrorBoundary;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/providers",
-  "version": "1.40.1",
+  "version": "1.40.2",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"

package/services.ts

@@ -1,4 +1,5 @@
 import { useSuspenseQuery, UseSuspenseQueryResult } from '@tanstack/react-query';
+import i18next from 'i18next';
 import apiClient from './Queries/apiClient';
 import { SettingsData, MenuData } from './types/settings';
 import useMenuStore from './stores/menu';
@@ -20,8 +21,18 @@ export const useGetSettings = (): UseSuspenseQueryResult<SettingsData> => (
 export const useGetMenu = (): UseSuspenseQueryResult<MenuData> => {
   const menuStore = useMenuStore();
 
+  /*
+   * Edited: Claude - Date: 2026-08-22 (audit finding CMS-07b)
+   *
+   * The language belongs in the key. obtapi localises the menu labels off
+   * Content-Language, which the client and BFF both send correctly - but the
+   * result was cached under a language-blind key, so the menu was fetched
+   * once (in whatever language was active at bootstrap, usually English) and
+   * a later switch never refetched it. Keying on the active language makes a
+   * switch load - and cache - that language's labels.
+   */
   return useSuspenseQuery({
-    queryKey: ['get-menu'],
+    queryKey: ['get-menu', i18next.language],
     queryFn: async () => (
       await apiClient
         .get('/api/menus/get')