@autobusal/operator-routes 1.5.1 → 1.6.0

package/CHANGELOG.md

@@ -1,5 +1,31 @@
 # Changelog
 
+## 1.6.0
+
+### Added
+
+- **The stops taken off a route can be put back.** Withdrawal never destroyed
+  anything - the stop's row, its price rows and the fares on them all survive
+  - and both the API endpoint and this package's `useRestoreLocation` hook
+  had existed since it shipped. Nothing rendered them: the locations response
+  filters on `active`, so a withdrawn stop was never mentioned and no screen
+  could offer to bring one back. From the operator's side a withdrawal was
+  invisible and permanent, which is the one thing it was built not to be.
+  The section appears only when the route has something to restore.
+
+## 1.5.2
+
+### Removed
+
+- **The confirm dialog in front of removing a stop.** It asked the question
+  the withdrawal panel already asks - the panel names the stop, lists
+  everybody still travelling through it and has its own button - and it
+  answered one part wrongly, warning that the fares would have to be entered
+  again. That stopped being true when calibration began reconciling price
+  rows instead of rebuilding them: measured on a ten-stop route, withdrawing
+  a stop keeps fourteen of sixteen fares and drops only the two legs through
+  the stop itself.
+
 ## 1.3.3
 
 ### Fixed

package/Locations/Browse/Actions.tsx

@@ -24,11 +24,29 @@ const Actions = ({ item, loading, t, onMove, onDelete }: Props): JSX.Element =>
     onMove(order);
   };
 
-  const onAskDelete = (): void => {
-    if (window.confirm(t('locations_manage.actions.delete', { ns: 'common' }))) {
-      onDelete();
-    }
-  };
+  /*
+   * Edited: Claude - Date: 2026-08-22
+   *
+   * No window.confirm here any more. Removing a stop opens the withdrawal
+   * panel, which names the stop, lists everybody still travelling through
+   * it, and has its own explicit button - a far better confirmation than a
+   * browser dialog, and the dialog now stood in front of it saying "YOU WILL
+   * NEED TO ADD THE PRICES AGAIN", which stopped being true when
+   * Locations\Calibration started reconciling price rows instead of
+   * rebuilding them. Measured: withdrawing a stop from a ten-stop route kept
+   * fourteen of sixteen fares, losing only the two legs through the stop
+   * itself.
+   *
+   * So it was a second gate that asked the same question twice and got the
+   * answer wrong once. The panel asks it properly.
+   *
+   * `locations_manage.actions.delete` is deliberately still in obtapi's
+   * language files. obtapi deploys BEFORE the frontends, so for the length
+   * of that window the previous bundle is still calling it - and a missing
+   * key renders as the key itself, which is what the dialog showed when it
+   * was removed. It now says something true and is simply read by nobody
+   * once this bundle lands.
+   */
 
   return (
     <ContainerActions>
@@ -80,7 +98,7 @@ const Actions = ({ item, loading, t, onMove, onDelete }: Props): JSX.Element =>
             </>
           }
           noMargin
-          onClick={ onAskDelete }
+          onClick={ onDelete }
         />
       </Group>
     </ContainerActions>

package/Locations/Manage.tsx

@@ -5,6 +5,7 @@ import { usePage, useBreadcrumbs } from '@autobusal/hooks';
 import Add from './Add/Add';
 import Propose from './Propose/Propose';
 import Browse from './Browse/Browse';
+import Withdrawn from './Withdrawn/Withdrawn';
 import { useGetLocations, useGetStops } from './services';
 
 interface Props {
@@ -61,6 +62,13 @@ const Manage = ({ url, t }: Props): JSX.Element => {
       <Report margin={ 15 } question={ t('locations_manage.report', { ns: 'common' }) } type="location" t={ t } />
 
       <Browse routeId={ id } data={ data?.locations } t={ t } onReload={ onReload } />
+
+      { /* Claude - 2026-08-22: the stops taken off this route. Withdrawal
+           keeps everything - the row, the price rows, the fares - so it is
+           reversible, and the endpoint and hook to reverse it already
+           existed. Nothing rendered them, so a withdrawn stop was invisible
+           and permanent from here. Renders nothing when there are none. */ }
+      <Withdrawn routeId={ id } data={ data?.withdrawn } t={ t } onReload={ onReload } />
     </Meta>
   );
 };

package/Locations/Withdrawn/Withdrawn.tsx

@@ -0,0 +1,74 @@
+import { TFunction } from 'i18next';
+import { FiRotateCcw } from 'react-icons/fi';
+import { success } from '@autobusal/utilities';
+import { LocationData } from '@autobusal/providers/types/locations';
+import { useRestoreLocation } from '../services';
+import { Section, Lead, Row, Where, Restore } from './styles';
+
+interface Props {
+  routeId: number
+  data?: LocationData[]
+  t: TFunction<'normal'>
+  onReload: () => void
+}
+
+/**
+ * The stops taken off this route, and the way to put one back.
+ *
+ * Claude - Date: 2026-08-22
+ *
+ * Withdrawal never destroys anything - the stop's row, its price rows and
+ * the fares on them all survive, which is what lets a ticket sold through it
+ * still say where its passenger boarded. That makes it reversible by
+ * construction, and obtapi has had the endpoint and this package has had the
+ * `useRestoreLocation` hook since the day withdrawal shipped.
+ *
+ * Nothing rendered them. `locations` filters on `active`, so the response
+ * never mentioned a withdrawn stop and no screen could offer to bring one
+ * back: from the operator's side a withdrawal was invisible and permanent,
+ * which is the one thing it was built not to be. This is the missing half.
+ *
+ * Shown only when there is something to show - an operator who has never
+ * withdrawn a stop should not be told about a concept they have not met.
+ */
+const Withdrawn = ({ routeId, data, t, onReload }: Props): JSX.Element | null => {
+  const { mutate: Restoring, isPending } = useRestoreLocation(routeId);
+
+  if (!data?.length) {
+    return null;
+  }
+
+  const restore = (id: number): void => {
+    Restoring(id, {
+      onSuccess: () => {
+        success(t('locations_manage.withdrawn.restored', { ns: 'common' }));
+
+        onReload();
+      }
+    });
+  };
+
+  return (
+    <Section className="box">
+      <h4>{ t('locations_manage.withdrawn.title', { ns: 'common' }) }</h4>
+
+      <Lead>{ t('locations_manage.withdrawn.lead', { ns: 'common' }) }</Lead>
+
+      { data.map(item => (
+        <Row key={ item.id }>
+          <Where>
+            <strong>{ item.city?.name }</strong>
+            <span>{ item.stop?.name }</span>
+          </Where>
+
+          <Restore type="button" disabled={ isPending } onClick={ () => restore(item.id) }>
+            <FiRotateCcw />
+            { t('locations_manage.withdrawn.restore', { ns: 'common' }) }
+          </Restore>
+        </Row>
+      )) }
+    </Section>
+  );
+};
+
+export default Withdrawn;

package/Locations/Withdrawn/styles.ts

@@ -0,0 +1,55 @@
+import styled from 'styled-components';
+
+export const Section = styled.div`
+  margin-bottom: 15px;
+`;
+
+export const Lead = styled.p`
+  margin-bottom: 12px;
+  font-size: ${ props => props.theme.size.xs };
+  opacity: .8;
+`;
+
+export const Row = styled.div`
+  display: flex;
+  flex-wrap: wrap;
+  align-items: center;
+  justify-content: space-between;
+  gap: 10px;
+  padding: 8px 0;
+  border-top: 1px solid ${ props => props.theme.background.neutral };
+`;
+
+export const Where = styled.div`
+  font-size: ${ props => props.theme.size.xs };
+  min-width: 0;
+
+  strong {
+    display: block;
+  }
+
+  span {
+    display: block;
+    opacity: .7;
+    word-break: break-word;
+  }
+`;
+
+export const Restore = styled.button`
+  background: none;
+  border: 1px solid ${ props => props.theme.background.neutral };
+  border-radius: 3px;
+  padding: 5px 12px;
+  cursor: pointer;
+  font-size: ${ props => props.theme.size.xs };
+
+  svg {
+    margin-right: 6px;
+    vertical-align: -2px;
+  }
+
+  &:disabled {
+    opacity: .5;
+    cursor: default;
+  }
+`;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/operator-routes",
-  "version": "1.5.1",
+  "version": "1.6.0",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"