@autobusal/operator-routes 1.3.1 → 1.3.3

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## 1.3.3
+
+### Fixed
+
+- **The ticket-language dropdown offered a country code and three options.**
+  It listed the two content languages plus Greek as `gr` - the code for the
+  country; the language is `el` - so an operator choosing it got English
+  tickets and no error to say so. Now all fifteen languages the API can
+  print, under their own names and their real codes.
+
+## 1.3.2
+
+### Added
+
+- **A stop added in a multi-zone country says so.** Times are stored local
+  to their stop, and a country with no zone recorded falls back to the
+  application's clock - a duration that reads plausibly and is wrong by
+  hours. The API now answers `warning: 'timezone'` and the operator is told,
+  because the operator is who sees the wrong number and would otherwise
+  "fix" it by editing times that are correct as stored.
+
+### Fixed
+
+- **`useAddLocation` returns its response.** It was awaited and discarded,
+  so `onSuccess` received undefined - harmless while the endpoint answered
+  with an empty object, and it would have swallowed the warning above.
+
 ## [1.3.1] - 2026-08-07
 
 ### Fixed

package/Locations/Add/Add.tsx

@@ -2,7 +2,7 @@ import { TFunction } from 'i18next';
 import { useForm } from 'react-hook-form';
 import { FiPlus } from 'react-icons/fi';
 import { Button } from '@autobusal/common';
-import { Validate, Display, success } from '@autobusal/utilities';
+import { Validate, Display, success, notify } from '@autobusal/utilities';
 import Loading from './Loading';
 import { getStops } from '../utilities';
 import { Container, Title, ContainerAdd, Choose, Notice } from './styles';
@@ -28,9 +28,26 @@ const Add = ({ routeId, t, onReload }: Props): JSX.Element => {
 
   const onSubmit = (data: AddForm): void => {
     Save(data, {
-      onSuccess: () => {
+      onSuccess: (response) => {
         success(t('locations_manage.messages.added', { ns: 'common' }));
 
+        /*
+         * Edited: Ferjolt Ozuni - Date: 2026-08-07
+         *
+         * The stop was added - this is a caveat, not a failure, so it comes
+         * after the success and does not stop the reload.
+         *
+         * It is worth saying out loud because the consequence is a wrong
+         * NUMBER rather than an error: times at this stop fall back to our
+         * clock, so a duration can read short or long by hours. An operator
+         * who sees that without being told why is likely to correct it by
+         * editing the stored times, and that turns something we can fix
+         * centrally into data nobody can untangle later.
+         */
+        if (response?.warning === 'timezone') {
+          notify(t('locations_manage.messages.timezone', { ns: 'common' }));
+        }
+
         onReload();
       }
     });

package/Locations/services.ts

@@ -2,7 +2,7 @@ import { UseMutationResult, UseQueryResult, UseSuspenseQueryResult, useMutation,
 import { apiClient } from '@autobusal/providers';
 import { RouteData } from '@autobusal/providers/types/routes';
 import { CountryData } from '@autobusal/providers/types/locations';
-import { AddForm, LocationForm } from './types';
+import { AddForm, AddResponse, LocationForm } from './types';
 
 export const useGetLocations = (id: number): UseSuspenseQueryResult<RouteData> => (
   useSuspenseQuery({
@@ -36,19 +36,27 @@ export const useGetStops = (routeId: number): UseQueryResult<CountryData[]> => (
   })
 );
 
-export const useAddLocation = (id: number): UseMutationResult<void, Error, AddForm, unknown> => (
+/*
+ * Edited: Ferjolt Ozuni - Date: 2026-08-07
+ *
+ * Returns the response instead of discarding it. It was awaited and thrown
+ * away, so `onSuccess` was handed undefined - which was invisible while the
+ * endpoint answered with an empty object, and would have quietly swallowed
+ * the `warning` it can now carry.
+ */
+export const useAddLocation = (id: number): UseMutationResult<AddResponse, Error, AddForm, unknown> => (
   useMutation({
     mutationKey: ['operator-locations-add', { id }],
-    mutationFn: async (data: AddForm) => {
-      await apiClient
+    mutationFn: async (data: AddForm) => (
+      apiClient
         .post('/api/locations/operator/add', {
           ...data,
           id
         })
         .then(response => (
-          response.data
+          response.data as AddResponse
         ))
-    }
+    )
   })
 );
 

package/Locations/types.ts

@@ -2,6 +2,19 @@ export interface AddForm {
   group_id: string
 }
 
+/**
+ * What adding a stop answers with.
+ *
+ * Empty on the ordinary path. `warning` is a CODE rather than a sentence -
+ * the API has no business writing operator-facing prose in fifteen
+ * languages - and 'timezone' means the stop's country spans several zones,
+ * so the times shown for it fall back to the application's clock rather
+ * than its own.
+ */
+export interface AddResponse {
+  warning?: 'timezone'
+}
+
 export interface LocationForm {
   tomorrow: number
   departure: string

package/Manage.tsx

@@ -155,7 +155,7 @@ const Manage = ({ url, t }: Props): JSX.Element => {
           label: t('operator_routes.manage.language', { ns: 'common' }),
           name: 'language',
           type: 'select',
-          values: getLanguagesExtended(),
+          values: getLanguagesExtended(t),
           value: data?.language ?? 'en',
           rules: 'required'
         }, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/operator-routes",
-  "version": "1.3.1",
+  "version": "1.3.3",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"

package/utilities.tsx

@@ -1,6 +1,5 @@
 import { TFunction } from 'i18next';
 import { IoGlobeOutline } from 'react-icons/io5';
-import { getLanguages } from '@autobusal/utilities';
 import { DropdownData } from '@autobusal/providers/types/other';
 import { ViewData } from '@autobusal/common/Viewer/types';
 
@@ -34,16 +33,39 @@ const getOptionsTypes = (t: TFunction<'common'>): DropdownData[] => ([
   }
 ]);
 
-export const getLanguagesExtended = (): DropdownData[] => {
-  const languages = getLanguages();
+/**
+ * The languages a TICKET can be printed in.
+ *
+ * Edited: Ferjolt Ozuni - Date: 2026-08-07
+ *
+ * This used to be the two CONTENT languages plus Greek bolted on as 'gr'.
+ * Two things were wrong with that.
+ *
+ * 'gr' is the country code for Greece; the language code is 'el'. The API
+ * resolves this value to a directory under lang/, there is no lang/gr, so an
+ * operator who picked "Gr" got English tickets and no error anywhere to say
+ * so. One route in the database had the same fault spelled 'al' for Albanian
+ * (which is 'sq') - see the 2026_08_07_150000 migration.
+ *
+ * And the list was three long while the API ships ticket translations in
+ * fifteen. An operator running a Tirana-Milan coach could not choose Italian
+ * for a document their passengers have to read at a border.
+ *
+ * Named from `languages.*`, which already holds all fifteen under their
+ * correct codes and in their own language - so the codes cannot drift from
+ * the ones the API accepts, and an operator picks "Italiano" rather than
+ * decoding "It".
+ */
+const TICKET_LANGUAGES = [
+  'sq', 'en', 'bg', 'bs', 'de', 'el', 'es', 'fr', 'hr', 'it', 'me', 'mk', 'ro', 'sl', 'sr'
+];
 
-  languages.push({
-    name: 'Gr',
-    id: 'gr'
-  });
-
-  return languages;
-};
+export const getLanguagesExtended = (t: TFunction<'normal'>): DropdownData[] => (
+  TICKET_LANGUAGES.map(id => ({
+    id,
+    name: t(`languages.${ id }`, { ns: 'common' })
+  }))
+);
 
 export const getTemplates = (t: TFunction<'normal'>): DropdownData[] => ([
   {