npm - @autobusal/common - Versions diffs - 1.8.2 → 1.9.0 - Mend

@autobusal/common 1.8.2 → 1.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

package/Button/Button.tsx CHANGED Viewed

@@ -11,9 +11,15 @@ interface Props {
   noMargin?: boolean
   maxWidth?: number
   onClick?: any
+  // Edited: Ferjolt Ozuni - Date: 2026-07-31
+  // A native <button name value> pair - lets a form with more than one
+  // submit-type action (e.g. Viewer's 'save' vs 'test') tell them apart via
+  // the submit event's `submitter`, without any extra state.
+  name?: string
+  value?: string
 }
-const Button = ({ type, size, loading, active, subtype, text, noMargin, maxWidth, onClick }: Props) => (
+const Button = ({ type, size, loading, active, subtype, text, noMargin, maxWidth, onClick, name, value }: Props) => (
   <ButtonStyled
     $size={ size }
     type={ loading ? 'button' : type }
@@ -22,6 +28,8 @@ const Button = ({ type, size, loading, active, subtype, text, noMargin, maxWidth
     $margin={ noMargin ? false : true }
     $maxWidth={ maxWidth }
     onClick={ onClick }
+    name={ name }
+    value={ value }
   >
     { loading ? <RiLoader2Fill /> : text }
   </ButtonStyled>

package/CHANGELOG.md CHANGED Viewed

@@ -3,6 +3,50 @@
 All notable changes to `@autobusal/common` are documented here. This project follows
 [Keep a Changelog](https://keepachangelog.com/) and [Semantic Versioning](https://semver.org/).
+## [1.9.0] - 2026-07-31
+### Added
+- **`Viewer`/`Actions`/`Button` support a second submit-type action** via an
+  optional `onTest` prop on `Viewer` and a new `'test'` entry in its
+  `actions` array. A form with two submit buttons can't otherwise tell
+  which one triggered submission - `Button` now forwards a native
+  `name`/`value` pair, and `Viewer`'s `onSubmit` reads the submit event's
+  `submitter` to route to `onTest` instead of `onSave` when the 'test'
+  button was clicked, while keeping the exact same current form values.
+  First consumer: `@autobusal/admin-label` 1.10.0's "Test" button on the
+  SMTP settings tab.
+## [1.8.3] - 2026-07-31
+### Fixed
+- **`Meta.tsx`'s `useSoleMetaOwnership` no longer runs on every render.**
+  It fired on every render of every `<Meta>` usage (136 call sites, no
+  dependency array) and directly removed `<head>` children via raw DOM
+  `.remove()` calls each time. The duplicate-tag problem it exists for -
+  React's `createRoot` not reconciling against tags baked into the
+  prerendered static HTML - can only exist before React's first render;
+  every render after that, `<title>`/`<meta>`/`<link>` in `<head>` are
+  exclusively React 19's own hoisting mechanism's doing, and it already
+  correctly swaps them out as components mount/unmount with no help
+  needed. Re-running this raw removal on every navigation instead raced
+  that hoisting: it could delete a node mid-transition that React's own
+  reconciler still held a reference to, and the next time React tried to
+  remove or replace that now-detached node, `parentNode` was null and it
+  threw an uncaught `TypeError: Cannot read properties of null (reading
+  'removeChild')` - not render-phase, so no `ErrorBoundary` catches it,
+  silently aborting whatever navigation was in flight (URL updates,
+  page never re-renders). This is the actual root cause of the frozen-
+  navigation bug worked around piecemeal in `@autobusal/providers`
+  1.6.6-1.6.8, `@autobusal/hooks` 1.3.1, and `@autobusal/auth`
+  1.5.2-1.5.4 - all of which targeted `GoogleReCaptchaProvider` as a
+  contributing trigger, but the crash reproduced identically with that
+  provider removed entirely, on ~any route rendering `<Meta>`. Now
+  scoped to a module-level flag so the cleanup runs exactly once, on the
+  app's first `<Meta>` mount - it does its one real job (wiping stale
+  prerendered tags before first paint) and never touches the DOM again.
 ## [1.8.2] - 2026-07-30
 ### Fixed

package/Meta.tsx CHANGED Viewed

@@ -52,8 +52,40 @@ const withBrand = (value: string): string => (brand ? `${ value } - ${ brand }`
 // them, since nothing here can claim the page has one.
 type OwnedTag = { selector: string, attr: 'text' | string, value?: string };
+// Edited: Ferjolt Ozuni - Date: 2026-07-31
+// Bug: this ran on EVERY render of EVERY <Meta> usage (no dependency array),
+// removing head children via raw DOM .remove() calls each time. But the
+// duplicate-tag problem this exists for is a ONE-TIME artifact of the
+// prerendered static HTML `createRoot` never reconciles against - it can
+// only exist before React's first render. Every render after that, these
+// tags are exclusively React 19's own hoisting mechanism's doing, and
+// React already correctly swaps them out as components mount/unmount with
+// no help needed. Re-running this raw removal on every subsequent
+// navigation raced that hoisting instead: this effect could delete a
+// <title>/<meta> node mid-transition that React's own reconciler still
+// held a reference to (e.g. while the outgoing page's <Meta> was still
+// completing its unmount), leaving React's fiber pointing at a detached
+// node - the next time React tried to remove or replace it, `parentNode`
+// was null and it threw an uncaught `TypeError: Cannot read properties of
+// null (reading 'removeChild')`. That's not render-phase, so no
+// ErrorBoundary catches it, and it silently aborted whatever navigation
+// was in flight: the URL would update but the page never re-rendered -
+// reproduced on ~every route that renders <Meta>, i.e. nearly every page.
+// Scoping the cleanup to the app's first-ever <Meta> mount (module-scope
+// flag, not per-component-instance state, since every route mounts a NEW
+// Meta instance) keeps it doing its one real job - wiping stale prerendered
+// tags before React's first paint - without ever again running once React
+// is the sole owner of this part of the DOM.
+let hasCleanedPrerenderedTags = false;
 const useSoleMetaOwnership = (tags: OwnedTag[]): void => {
   useEffect(() => {
+    if (hasCleanedPrerenderedTags) {
+      return;
+    }
+    hasCleanedPrerenderedTags = true;
     tags.forEach(({ selector, attr, value }) => {
       const elements = [...document.querySelectorAll(`head > ${ selector }`)];

package/Viewer/Actions.tsx CHANGED Viewed

@@ -1,6 +1,6 @@
 import { TFunction } from 'i18next';
 import { BiEditAlt, BiTrash, BiSend } from 'react-icons/bi';
-import { RiSave2Line, RiCheckFill, RiSearchLine } from 'react-icons/ri';
+import { RiSave2Line, RiCheckFill, RiSearchLine, RiMailSendLine } from 'react-icons/ri';
 import { BsPlusCircleFill } from 'react-icons/bs';
 import Button from '../Button/Button';
 import { ContainerActions } from './styles';
@@ -41,6 +41,21 @@ const Actions = ({ id, available, pending, t, onDelete }: Props): JSX.Element =>
     });
   }
+  // Edited: Ferjolt Ozuni - Date: 2026-07-31
+  // A second submit-type action alongside 'save' (e.g. "Test SMTP") - the
+  // name/value pair lets Viewer's onSubmit tell which button was actually
+  // clicked via the submit event's `submitter`, since a form with two
+  // submit buttons can't otherwise distinguish them.
+  if (available.includes('test')) {
+    options.push({
+      label: t('table.actions.test', { ns: 'common' }),
+      icon: <RiMailSendLine />,
+      type: 'submit',
+      name: 'intent',
+      value: 'test'
+    });
+  }
   if (available.includes('send')) {
     options.push({
       label: t('table.actions.send', { ns: 'common' }),
@@ -93,6 +108,8 @@ const Actions = ({ id, available, pending, t, onDelete }: Props): JSX.Element =>
       loading={ pending }
       noMargin
       onClick={ item.handler }
+      name={ item.name }
+      value={ item.value }
     />
   ));

package/Viewer/Viewer.tsx CHANGED Viewed

@@ -16,11 +16,16 @@ interface Props {
   t: TFunction<'common'>
   onSave?: (data: any) => void
   onDelete?: (data?: any) => void
+  // Edited: Ferjolt Ozuni - Date: 2026-07-31
+  // Optional second submit-type action (actions={['save', 'test']}) - e.g.
+  // the SMTP tab's "Test" button, which needs the same current form values
+  // as save but must call a different handler instead of persisting.
+  onTest?: (data: any) => void
 }
-const Viewer = ({ id, type, data, fetching, pending, actions, t, onSave, onDelete }: Props): JSX.Element => {
+const Viewer = ({ id, type, data, fetching, pending, actions, t, onSave, onDelete, onTest }: Props): JSX.Element => {
   const { register, handleSubmit, formState: { errors }, setValue } = useForm<any>();
   if (fetching) {
     return <Loading t={ t } />;
   }
@@ -37,7 +42,18 @@ const Viewer = ({ id, type, data, fetching, pending, actions, t, onSave, onDelet
     />
   ));
-  const onSubmit = (data: any): void => {
+  const onSubmit = (data: any, event?: React.BaseSyntheticEvent): void => {
+    // A form with two submit buttons can't tell which one triggered
+    // submission except via the native SubmitEvent's `submitter` - the
+    // 'test' button is the only one with a name/value pair (see Actions.tsx).
+    const submitter = (event?.nativeEvent as SubmitEvent | undefined)?.submitter as (HTMLButtonElement | undefined);
+    if (submitter?.value === 'test' && onTest !== undefined) {
+      onTest(data);
+      return;
+    }
     if (onSave !== undefined) {
       onSave(data);
     }

package/Viewer/types.ts CHANGED Viewed

@@ -19,4 +19,6 @@ export interface ActionData {
   type?: 'submit'
   subtype?: 'delete'
   handler?: () => void
+  name?: string
+  value?: string
 }

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/common",
-  "version": "1.8.2",
+  "version": "1.9.0",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"