@autobusal/common 1.27.1 → 1.27.3

package/CHANGELOG.md

@@ -1,5 +1,38 @@
 # Changelog
 
+## 1.27.3
+
+### Fixed
+
+- **The birth-date picker offered today, which the API refuses.** obtapi
+  validates with `before:today`, so the calendar was letting you choose an
+  answer and then calling it wrong. It now stops at yesterday.
+
+  The year steps back too when yesterday fell in the previous one: the
+  maximum is built from `today.getFullYear() + limits.max.year`, so on 1
+  January a month/day of 31 December would otherwise have resolved to the
+  coming 31 December rather than the one just gone. Checked against 1
+  January, 1 March and a leap year.
+
+## 1.27.2
+
+### Fixed
+
+- **A birth date no longer defaults to today.** `Calendar` pre-fills with
+  today when given no value, which is right for every other use of it — a
+  departure, a report range, a broadcast day — and wrong for exactly one:
+  nobody is born today. On the profile-completion form it meant anybody who
+  filled in the fields that *looked* empty saved a date of birth of today,
+  silently, and that is the field a passenger's age is judged by when they
+  book. Reproduced end to end: the row saved `dob = <today>`.
+
+  `type="dob"` now starts empty so the field reads as unanswered. The picker
+  still opens on the current month — `createDate('')` is an Invalid Date and
+  the grid built from it renders as nothing — but that anchor is display
+  only; what the form submits stays empty until a day is clicked, and
+  obtapi's new `required|date_format:d/m/Y|before:today` says so if it is
+  left that way.
+
 
 ## 1.27.1
 

package/Calendar/Calendar.tsx

@@ -32,7 +32,24 @@ interface Props {
 
 const Calendar = ({ type, name, defaultValue, t, validation, minDate, refs, onUpdate, onChange }: Props): JSX.Element => {
   const [ show, setShow ] = useState<boolean>(false);
-  const [ prepared, setPrepared ] = useState<string>(defaultValue ?? prepareDate(new Date()));
+
+  /**
+   * Edited: Ferjolt Ozuni - Date: 2026-08-06
+   * A BIRTH DATE does not default to today.
+   *
+   * Defaulting to today is right for every other use of this picker - a
+   * departure, a report range, a broadcast day - and wrong for exactly one:
+   * nobody is born today. On the profile-completion form it meant anybody
+   * who filled in the fields that LOOKED empty saved a date of birth of
+   * today, silently, and that is the field a passenger's age is judged by
+   * when they book. Reproduced end to end: the row saved dob = today.
+   *
+   * Empty instead, so the field reads as unanswered and the API's
+   * `required|date_format:d/m/Y|before:today` says so if it is left that way.
+   */
+  const [ prepared, setPrepared ] = useState<string>(
+    defaultValue ?? (type === 'dob' ? '' : prepareDate(new Date()))
+  );
   const [ selected, setSelected ] = useState<string>(prepared);
 
   const ref = useRef<HTMLDivElement>(null);
@@ -57,7 +74,11 @@ const Calendar = ({ type, name, defaultValue, t, validation, minDate, refs, onUp
       { show && (
         <Picker
           type={ type }
-          value={ prepared }
+          // An empty birth date still needs a month to OPEN on: createDate('')
+          // is an Invalid Date and the grid built from it renders as nothing.
+          // The anchor is display only - what the form submits stays empty
+          // until a day is actually clicked.
+          value={ prepared || prepareDate(new Date()) }
           selected={ selected }
           minDate={ minDate }
           t={ t }

package/Calendar/utilities/settings.ts

@@ -82,8 +82,23 @@ export const getLimits = (type: ('picker' | 'dob' | 'date')): CalendarLimit => {
   if (type === 'dob') {
     limits.min.year = 100;
 
-    limits.max.month = today.getMonth();
-    limits.max.day = today.getDate();
+    // Edited: Ferjolt Ozuni - Date: 2026-08-06
+    // Up to YESTERDAY, not today. obtapi validates a birth date with
+    // `before:today`, and somebody filling in this form was not born this
+    // morning - offering a day the API will refuse is a calendar that lets
+    // you choose an answer and then calls it wrong.
+    //
+    // The year is stepped back too when yesterday fell in the previous one,
+    // because max.time below is built from `today.getFullYear() +
+    // limits.max.year`: on 1 January, month 11 / day 31 without this would
+    // resolve to the coming 31 December rather than the one just gone.
+    const yesterday = new Date(today.getTime());
+
+    yesterday.setDate(yesterday.getDate() - 1);
+
+    limits.max.year = yesterday.getFullYear() - today.getFullYear();
+    limits.max.month = yesterday.getMonth();
+    limits.max.day = yesterday.getDate();
   }
 
   if (type === 'picker') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autobusal/common",
-  "version": "1.27.1",
+  "version": "1.27.3",
   "author": "Ferjolt Ozuni",
   "type": "module",
   "main": "index.ts"