@auto-engineer/server-implementer 1.90.0 → 1.96.0

package/ketchup-plan.md

@@ -1,9 +1,14 @@
-# Ketchup Plan: Prevent implementer AI from redefining imported types
+# Ketchup Plan: Fix implementer context/prompt gaps
 
 ## TODO
 
+(none)
+
 ## DONE
 
+- [x] Burst 9: Add discriminated union narrowing guidance to prompts (f43a84c9)
+- [x] Burst 8: Load full shared directory into implementer context (e8f42abf)
+
 - [x] Burst 7: Add implementer prompt guardrails for phantom enums and hardcoded projections (14d8cbda)
 - [x] Burst 6: Fix `_state` reference in decide.ts.ejs instruction comment (dff8f329)
 - [x] Burst 5: Fix singleton projection instructions in projection.ts.ejs (3271cfe4)

package/package.json

@@ -18,8 +18,8 @@
     "debug": "^4.3.4",
     "fast-glob": "^3.3.3",
     "vite": "^5.4.1",
-    "@auto-engineer/model-factory": "1.90.0",
-    "@auto-engineer/message-bus": "1.90.0"
+    "@auto-engineer/model-factory": "1.96.0",
+    "@auto-engineer/message-bus": "1.96.0"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",
@@ -29,9 +29,9 @@
     "glob": "^11.0.3",
     "tsx": "^4.20.3",
     "typescript": "^5.8.3",
-    "@auto-engineer/cli": "1.90.0"
+    "@auto-engineer/cli": "1.96.0"
   },
-  "version": "1.90.0",
+  "version": "1.96.0",
   "scripts": {
     "build": "tsc && tsx ../../scripts/fix-esm-imports.ts",
     "test": "vitest run --reporter=dot",

package/src/agent/runSlice.ts

@@ -7,6 +7,7 @@ import fg from 'fast-glob';
 import { SYSTEM_PROMPT } from '../prompts/systemPrompt';
 import { buildShadowWarning } from '../utils/detectImportedTypeShadowing';
 import { extractCodeBlock } from '../utils/extractCodeBlock';
+import { loadSharedContext } from '../utils/loadSharedContext';
 import { runTests } from './runTests';
 
 type TestAndTypecheckResult = {
@@ -108,6 +109,12 @@ async function loadContextFiles(sliceDir: string): Promise<Record<string, string
     const absPath = path.join(sliceDir, file);
     context[file] = await readFile(absPath, 'utf-8');
   }
+
+  const sharedContent = await loadSharedContext(sliceDir);
+  if (sharedContent) {
+    context['domain-shared-types.ts'] = sharedContent;
+  }
+
   return context;
 }
 

package/src/commands/implement-slice.ts

@@ -7,6 +7,7 @@ import { generateText } from 'ai';
 import createDebug from 'debug';
 import fg from 'fast-glob';
 import { buildShadowWarning } from '../utils/detectImportedTypeShadowing';
+import { loadSharedContext } from '../utils/loadSharedContext';
 
 const debug = createDebug('auto:server-implementer:slice');
 const debugHandler = createDebug('auto:server-implementer:slice:handler');
@@ -109,10 +110,9 @@ async function loadContextFiles(sliceDir: string): Promise<Record<string, string
     context[file] = await readFile(absPath, 'utf-8');
   }
 
-  const sharedTypesPath = path.resolve(sliceDir, '../../../shared/types.ts');
-  if (existsSync(sharedTypesPath)) {
-    const sharedTypesContent = await readFile(sharedTypesPath, 'utf-8');
-    context['domain-shared-types.ts'] = sharedTypesContent;
+  const sharedContent = await loadSharedContext(sliceDir);
+  if (sharedContent) {
+    context['domain-shared-types.ts'] = sharedContent;
   }
 
   return context;
@@ -174,6 +174,7 @@ Key rules:
 - Keep implementations minimal and idiomatic.
 - CRITICAL: When assigning values to enum-typed fields, use the enum constant name from domain-shared-types.ts. For example, if Status enum has IN_PROGRESS = 'in_progress', use Status.IN_PROGRESS not 'in_progress'.
 - Derive all output values from inputs (event.data, command.data, state) or generate at runtime. Never reproduce literal values from test examples.
+- When the State type is a discriminated union (e.g., type State = NotInitialized | Initialized), narrow the discriminant before accessing variant-specific properties. Example: if (_state.status === 'initialized') { ... _state.goalId ... }
 
 Avoid:
 - Adding new dependencies.

package/src/prompts/systemPrompt.ts

@@ -27,6 +27,7 @@ Key rules:
 - If a test exists, make it pass.
 - Keep implementations minimal and idiomatic.
 - Derive all output values from inputs (event.data, command.data, state) or generate at runtime. Never reproduce literal values from test examples.
+- When the State type is a discriminated union (e.g., type State = NotInitialized | Initialized), narrow the discriminant before accessing variant-specific properties. Example: if (_state.status === 'initialized') { ... _state.goalId ... }
 
 Avoid:
 - Adding new dependencies.

package/src/utils/loadSharedContext.specs.ts

@@ -0,0 +1,53 @@
+import fs from 'node:fs/promises';
+import path from 'node:path';
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+import { loadSharedContext } from './loadSharedContext';
+
+describe('loadSharedContext', () => {
+  let tmpDir: string;
+  let sliceDir: string;
+  let sharedDir: string;
+
+  beforeEach(async () => {
+    tmpDir = await fs.mkdtemp(path.join(import.meta.dirname, '.tmp-'));
+    sharedDir = path.join(tmpDir, 'shared');
+    sliceDir = path.join(tmpDir, 'src', 'slices', 'some-slice');
+    await fs.mkdir(sliceDir, { recursive: true });
+  });
+
+  afterEach(async () => {
+    await fs.rm(tmpDir, { recursive: true, force: true });
+  });
+
+  it('returns undefined when shared directory does not exist', async () => {
+    expect(await loadSharedContext(sliceDir)).toBe(undefined);
+  });
+
+  it('returns undefined when shared directory has no .ts files', async () => {
+    await fs.mkdir(sharedDir, { recursive: true });
+    await fs.writeFile(path.join(sharedDir, 'readme.md'), '# Readme');
+
+    expect(await loadSharedContext(sliceDir)).toBe(undefined);
+  });
+
+  it('concatenates all .ts files from shared directory sorted by name', async () => {
+    await fs.mkdir(sharedDir, { recursive: true });
+    await fs.writeFile(path.join(sharedDir, 'types.ts'), 'export type Foo = string;');
+    await fs.writeFile(path.join(sharedDir, 'enums.ts'), 'export enum Bar { A = "a" }');
+
+    const result = await loadSharedContext(sliceDir);
+
+    expect(result).toBe(
+      '// File: shared/enums.ts\nexport enum Bar { A = "a" }\n\n// File: shared/types.ts\nexport type Foo = string;',
+    );
+  });
+
+  it('returns content for a single .ts file', async () => {
+    await fs.mkdir(sharedDir, { recursive: true });
+    await fs.writeFile(path.join(sharedDir, 'types.ts'), 'export type X = number;');
+
+    const result = await loadSharedContext(sliceDir);
+
+    expect(result).toBe('// File: shared/types.ts\nexport type X = number;');
+  });
+});

package/src/utils/loadSharedContext.ts

@@ -0,0 +1,18 @@
+import { existsSync } from 'node:fs';
+import { readFile } from 'node:fs/promises';
+import path from 'node:path';
+import fg from 'fast-glob';
+
+export async function loadSharedContext(sliceDir: string): Promise<string | undefined> {
+  const sharedDir = path.resolve(sliceDir, '../../../shared');
+  if (!existsSync(sharedDir)) return undefined;
+
+  const sharedFiles = await fg(['*.ts'], { cwd: sharedDir });
+  if (sharedFiles.length === 0) return undefined;
+
+  const contents: string[] = [];
+  for (const file of sharedFiles.sort()) {
+    contents.push(`// File: shared/${file}\n${await readFile(path.join(sharedDir, file), 'utf-8')}`);
+  }
+  return contents.join('\n\n');
+}