@auto-engineer/server-implementer 1.129.0 → 1.131.0

package/package.json

@@ -18,8 +18,8 @@
     "debug": "^4.3.4",
     "fast-glob": "^3.3.3",
     "vite": "^5.4.1",
-    "@auto-engineer/model-factory": "1.129.0",
-    "@auto-engineer/message-bus": "1.129.0"
+    "@auto-engineer/model-factory": "1.131.0",
+    "@auto-engineer/message-bus": "1.131.0"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",
@@ -29,9 +29,9 @@
     "glob": "^11.0.3",
     "tsx": "^4.20.3",
     "typescript": "^5.8.3",
-    "@auto-engineer/cli": "1.129.0"
+    "@auto-engineer/cli": "1.131.0"
   },
-  "version": "1.129.0",
+  "version": "1.131.0",
   "scripts": {
     "build": "tsc && tsx ../../scripts/fix-esm-imports.ts",
     "test": "vitest run --reporter=dot",

package/src/agent/runSlice.ts

@@ -7,6 +7,7 @@ import fg from 'fast-glob';
 import { SYSTEM_PROMPT } from '../prompts/systemPrompt';
 import { buildContextSections } from '../utils/buildContextSections';
 import { buildShadowWarning } from '../utils/detectImportedTypeShadowing';
+import { buildTypeAssertionWarning } from '../utils/detectTypeAssertions';
 import { extractCodeBlock } from '../utils/extractCodeBlock';
 import { findFilesToImplement } from '../utils/findFilesToImplement';
 import { loadContextFiles } from '../utils/loadContextFiles';
@@ -169,9 +170,20 @@ export async function runTestsAndTypecheck(sliceDir: string): Promise<TestAndTyp
   const testResult = await runTests(sliceDir, rootDir);
   const typecheckResult = await runTypecheck(sliceDir, rootDir);
   const shadowResult = await detectShadowsInSlice(sliceDir);
-  const failedTypecheckFiles = [...typecheckResult.failedTypecheckFiles, ...shadowResult.failedFiles];
-  const typecheckErrors = [typecheckResult.typecheckErrors, shadowResult.errors].filter(Boolean).join('\n');
-  const hasErrors = !testResult.success || !typecheckResult.success || shadowResult.errors.length > 0;
+  const assertionResult = await detectAssertionsInSlice(sliceDir);
+  const failedTypecheckFiles = [
+    ...typecheckResult.failedTypecheckFiles,
+    ...shadowResult.failedFiles,
+    ...assertionResult.failedFiles,
+  ];
+  const typecheckErrors = [typecheckResult.typecheckErrors, shadowResult.errors, assertionResult.errors]
+    .filter(Boolean)
+    .join('\n');
+  const hasErrors =
+    !testResult.success ||
+    !typecheckResult.success ||
+    shadowResult.errors.length > 0 ||
+    assertionResult.errors.length > 0;
   return {
     success: !hasErrors,
     failedTestFiles: testResult.failedTestFiles,
@@ -196,6 +208,21 @@ export async function detectShadowsInSlice(sliceDir: string): Promise<{ errors:
   return { errors: errors.join('\n'), failedFiles };
 }
 
+export async function detectAssertionsInSlice(sliceDir: string): Promise<{ errors: string; failedFiles: string[] }> {
+  const files = await fg(['*.ts'], { cwd: sliceDir, ignore: ['*.spec.ts', '*.specs.ts', '*.test.ts'] });
+  const errors: string[] = [];
+  const failedFiles: string[] = [];
+  for (const file of files) {
+    const content = await readFile(path.join(sliceDir, file), 'utf-8');
+    const warning = buildTypeAssertionWarning(content, file);
+    if (warning.length > 0) {
+      errors.push(warning);
+      failedFiles.push(path.join(sliceDir, file));
+    }
+  }
+  return { errors: errors.join('\n'), failedFiles };
+}
+
 async function retryFailedTests(sliceDir: string, flow: string, result: TestAndTypecheckResult) {
   let contextFiles = await loadContextFiles(sliceDir);
   for (let attempt = 1; attempt <= 5; attempt++) {

package/src/utils/detectTypeAssertions.specs.ts

@@ -0,0 +1,73 @@
+import { describe, expect, it } from 'vitest';
+import { buildTypeAssertionWarning, detectTypeAssertions } from './detectTypeAssertions';
+
+describe('detectTypeAssertions', () => {
+  it('returns empty array for clean code', () => {
+    const code = `
+const state: State = { name: 'Alice' };
+const x = 1;
+`;
+    expect(detectTypeAssertions(code)).toEqual([]);
+  });
+
+  it('detects {} as State', () => {
+    const code = `const state = {} as State;`;
+    expect(detectTypeAssertions(code)).toEqual(['as State (line 1)']);
+  });
+
+  it('detects x as any', () => {
+    const code = `const x = value as any;`;
+    expect(detectTypeAssertions(code)).toEqual(['as any (line 1)']);
+  });
+
+  it('detects value as unknown as Type', () => {
+    const code = `const x = value as unknown as MyType;`;
+    expect(detectTypeAssertions(code)).toEqual(['as MyType (line 1)', 'as unknown (line 1)']);
+  });
+
+  it('skips as const', () => {
+    const code = `const arr = [1, 2, 3] as const;`;
+    expect(detectTypeAssertions(code)).toEqual([]);
+  });
+
+  it('handles assertions inside functions', () => {
+    const code = `
+function process() {
+  const x = {} as State;
+  return x;
+}
+`;
+    expect(detectTypeAssertions(code)).toEqual(['as State (line 3)']);
+  });
+
+  it('detects multiple assertions across lines', () => {
+    const code = `
+const a = {} as State;
+const b = value as any;
+`;
+    expect(detectTypeAssertions(code)).toEqual(['as State (line 2)', 'as any (line 3)']);
+  });
+});
+
+describe('buildTypeAssertionWarning', () => {
+  it('returns empty string for clean code', () => {
+    const code = `const x: State = { name: 'Alice' };`;
+    expect(buildTypeAssertionWarning(code)).toBe('');
+  });
+
+  it('returns CONTRACT VIOLATION string for violations', () => {
+    const code = `const state = {} as State;`;
+    const result = buildTypeAssertionWarning(code, 'state.ts');
+    expect(result).toBe(
+      "CONTRACT VIOLATION in state.ts: Forbidden type assertions found: [as State (line 1)]. Use properly typed variables instead of 'as' casts.",
+    );
+  });
+
+  it('returns CONTRACT VIOLATION without file path when not provided', () => {
+    const code = `const state = {} as State;`;
+    const result = buildTypeAssertionWarning(code);
+    expect(result).toBe(
+      "CONTRACT VIOLATION: Forbidden type assertions found: [as State (line 1)]. Use properly typed variables instead of 'as' casts.",
+    );
+  });
+});

package/src/utils/detectTypeAssertions.ts

@@ -0,0 +1,27 @@
+import ts from 'typescript';
+
+export function detectTypeAssertions(code: string): string[] {
+  const sourceFile = ts.createSourceFile('check.ts', code, ts.ScriptTarget.Latest, true, ts.ScriptKind.TS);
+  const violations: string[] = [];
+
+  function visit(node: ts.Node): void {
+    if (ts.isAsExpression(node)) {
+      const typeText = node.type.getText(sourceFile).trim();
+      if (typeText !== 'const') {
+        const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile));
+        violations.push(`as ${typeText} (line ${line + 1})`);
+      }
+    }
+    ts.forEachChild(node, visit);
+  }
+
+  visit(sourceFile);
+  return violations;
+}
+
+export function buildTypeAssertionWarning(code: string, filePath?: string): string {
+  const violations = detectTypeAssertions(code);
+  if (violations.length === 0) return '';
+  const location = filePath !== undefined ? ` in ${filePath}` : '';
+  return `CONTRACT VIOLATION${location}: Forbidden type assertions found: [${violations.join(', ')}]. Use properly typed variables instead of 'as' casts.`;
+}