@auto-ai/agent 2.1.120 → 2.1.122

package/dist/ws-test.html

@@ -2901,7 +2901,7 @@
         </button>
       </div>
       <p id="mcpItemConfigHint" class="tool-files-sub" style="margin: 0 1rem 0.5rem; line-height: 1.4">
-        标准 mcp.json 单条 server 配置（与 Cursor mcp.json 相同）：<code>{ "command": "...", "args": [...], "env": {...} }</code>。保存后写入 agent .mcp.json 的 <code>mcpServers.&lt;serverName&gt;</code>。
+        标准 mcp.json 单条 server 配置（与 Cursor mcp.json 相同）：<code>{ "command": "...", "args": [...], "env": {...} }</code>。runtime MCP 保存到当前包目录 <code>.mcp.json</code>；remote MCP 保存到 agent <code>.mcp.json</code>。
       </p>
       <textarea id="mcpItemConfigEditor" class="agent-md-editor" spellcheck="false" placeholder="加载中…"></textarea>
       <div class="agent-md-modal-foot">
@@ -3228,7 +3228,6 @@
         <div class="schedule-manage-toolbar">
           <button type="button" class="btn-system-settings" id="btnScheduleRefresh">刷新</button>
           <button type="button" class="btn-system-settings" id="btnScheduleCreateToggle">新建任务</button>
-          <button type="button" class="btn-system-settings" id="btnScheduleGeelibPreset">Geelib 巡检</button>
         </div>
         <div id="scheduleCreateForm" class="schedule-create-form" hidden>
           <div class="schedule-create-row">
@@ -3403,7 +3402,6 @@
       const btnScheduleManageModalClose = $('btnScheduleManageModalClose')
       const btnScheduleRefresh = $('btnScheduleRefresh')
       const btnScheduleCreateToggle = $('btnScheduleCreateToggle')
-      const btnScheduleGeelibPreset = $('btnScheduleGeelibPreset')
       const scheduleCreateForm = $('scheduleCreateForm')
       const scheduleSessionSelect = $('scheduleSessionSelect')
       const schedulePromptInput = $('schedulePromptInput')
@@ -3964,9 +3962,17 @@
       }
       const SHOW_TEAMMATE_EXIT_LIFECYCLE = true
       let renderScheduled = false
+      /** HTTP 历史回放进行中：暂存实时 conversation.delta，避免与回放竞态写乱 transcript 下标 */
+      let sessionReplayInProgress = false
+      const pendingConversationDeltaEnvelopes = []
 
       function sourceAgentPayloadToText(payload) {
         if (!payload || typeof payload !== 'object') return ''
+        if (payload.state === 'console') {
+          const consoleLine =
+            typeof payload.message === 'string' ? payload.message.trim() : ''
+          if (consoleLine) return consoleLine
+        }
         const t = typeof payload.type === 'string' ? payload.type : 'unknown'
         if (t === 'turn.terminal') {
           const resultText = typeof payload.resultText === 'string' ? payload.resultText : ''
@@ -4058,6 +4064,44 @@
         return buffer
       }
 
+      /**
+       * 业务语义：conversation.delta 的 index 是 transcript 全局下标（续聊时可能远大于当前 buffer 长度）。
+       * 必须把槽位扩到 index 再写入，禁止把 index=206 的消息 push 到 buffer[0]。
+       */
+      function padRunBufferThroughIndex(runBuffer, index) {
+        while (runBuffer.length <= index) {
+          runBuffer.push(null)
+        }
+      }
+
+      function applyConversationDeltaToRunBuffer(runBuffer, action, index, runMessage) {
+        if (index < 0) return
+        if (action === 'message_removed') {
+          if (index < runBuffer.length) {
+            runBuffer.splice(index, 1)
+          }
+          return
+        }
+        if (action === 'message_added') {
+          if (index <= runBuffer.length) {
+            runBuffer.splice(index, 0, runMessage)
+          } else {
+            padRunBufferThroughIndex(runBuffer, index - 1)
+            runBuffer.push(runMessage)
+          }
+          return
+        }
+        padRunBufferThroughIndex(runBuffer, index)
+        runBuffer[index] = runMessage
+      }
+
+      function flushPendingConversationDeltas() {
+        const pending = pendingConversationDeltaEnvelopes.splice(0)
+        for (let i = 0; i < pending.length; i++) {
+          applyWsEnvelopeV3(pending[i])
+        }
+      }
+
       function isNearBottom(el) {
         if (!el) return true
         const gap = el.scrollHeight - (el.scrollTop + el.clientHeight)
@@ -4298,12 +4342,20 @@
             if (t === 'user') {
               const body = extractMessageBody(m)
               if (!body.trim()) continue
+              const isToolResult =
+                Array.isArray(m.message && m.message.content) &&
+                m.message.content.some(function (block) {
+                  return block && block.type === 'tool_result'
+                })
               const div = document.createElement('div')
               div.className = 'chat-msg chat-msg-user'
               applyScheduledMsgClass(div, isScheduled)
               const lab = document.createElement('div')
               lab.className = 'chat-msg-label'
-              lab.textContent = formatScheduledLabel('User · agent=' + messageAgent, isScheduled)
+              lab.textContent = formatScheduledLabel(
+                (isToolResult ? 'Tool Result' : 'User') + ' · agent=' + messageAgent,
+                isScheduled,
+              )
               const bodyEl = document.createElement('div')
               bodyEl.className = 'chat-user-body'
               setMessageBodyEl(bodyEl, body)
@@ -4314,12 +4366,20 @@
             } else if (t === 'assistant') {
               const body = extractMessageBody(m)
               if (!body.trim()) continue
+              const isToolCall =
+                Array.isArray(m.message && m.message.content) &&
+                m.message.content.some(function (block) {
+                  return block && block.type === 'tool_use'
+                })
               const div = document.createElement('div')
               div.className = 'chat-msg chat-msg-assistant'
               applyScheduledMsgClass(div, isScheduled)
               const lab = document.createElement('div')
               lab.className = 'chat-msg-label'
-              lab.textContent = formatScheduledLabel('Assistant · agent=' + messageAgent, isScheduled)
+              lab.textContent = formatScheduledLabel(
+                (isToolCall ? 'Tool Call' : 'Assistant') + ' · agent=' + messageAgent,
+                isScheduled,
+              )
               const md = document.createElement('div')
               md.className = 'chat-md'
               md.innerHTML = renderMd(body)
@@ -4584,6 +4644,8 @@
         chatState.streamByRun.clear()
         chatState.sourceAgentMessages = []
         chatState.seenEventIds.clear()
+        sessionReplayInProgress = false
+        pendingConversationDeltaEnvelopes.length = 0
         autoScrollState.mode = 'STICKY_BOTTOM'
         if (logEl) logEl.textContent = ''
         requestRenderChat()
@@ -4665,13 +4727,17 @@
       function applyWsEnvelopeV3(data) {
         if (!data || typeof data !== 'object') return false
         if (data.protocolVersion !== 3) return false
+        const runId = typeof data.runId === 'string' ? data.runId : 'main'
+        const payload = data.data && typeof data.data === 'object' ? data.data : {}
+        const type = typeof data.type === 'string' ? data.type : 'unknown'
+        if (type === 'conversation.delta' && sessionReplayInProgress) {
+          pendingConversationDeltaEnvelopes.push(data)
+          return true
+        }
         if (typeof data.eventId === 'string' && data.eventId) {
           if (chatState.seenEventIds.has(data.eventId)) return true
           chatState.seenEventIds.add(data.eventId)
         }
-        const runId = typeof data.runId === 'string' ? data.runId : 'main'
-        const payload = data.data && typeof data.data === 'object' ? data.data : {}
-        const type = typeof data.type === 'string' ? data.type : 'unknown'
         if (type === 'conversation.delta') {
           const action = typeof payload.action === 'string' ? payload.action : ''
           const index = Number.isInteger(payload.index) ? payload.index : -1
@@ -4688,32 +4754,7 @@
                 : '',
             arrivalSeq: ++chatState.eventClock,
           }
-          if (action === 'message_removed') {
-            if (index >= 0 && index < runBuffer.length) {
-              runBuffer.splice(index, 1)
-            }
-          } else if (action === 'message_added') {
-            if (index >= 0) {
-              if (index >= runBuffer.length) {
-                runBuffer.push(runMessage)
-              } else {
-                runBuffer.splice(index, 0, runMessage)
-              }
-            }
-          } else if (
-            action === 'message_updated' ||
-            action === 'tool_call' ||
-            action === 'tool_result' ||
-            action === 'message_completed'
-          ) {
-            if (index >= 0) {
-              if (index >= runBuffer.length) {
-                runBuffer.push(runMessage)
-              } else {
-                runBuffer[index] = runMessage
-              }
-            }
-          }
+          applyConversationDeltaToRunBuffer(runBuffer, action, index, runMessage)
           requestRenderChat()
           return true
         }
@@ -4814,8 +4855,14 @@
           if (typeof payload.sessionId === 'string' && payload.sessionId) {
             sessionIdInput.value = payload.sessionId
             sessionIdInput.placeholder = '留空下次新建'
-            if (window.__lastSessions) renderSessionList(window.__lastSessions)
-            else updateMainHeader()
+            void loadSessions()
+            if (pendingSessionOverrides) {
+              void flushPendingSessionOverridesIfAny()
+            } else {
+              void loadSessionOverridesIntoComposer()
+            }
+          } else {
+            updateMainHeader()
           }
           return true
         }
@@ -4827,6 +4874,8 @@
           const phase = typeof payload.phase === 'string' ? payload.phase : ''
           if (phase === 'idle') {
             if (serverReady) setStatus('已就绪。', 'ready')
+            // 一轮 prompt 收尾后 transcript 已落盘，刷新列表以更新页签 firstPrompt/summary
+            void loadSessions()
           } else if (phase) {
             setStatus('查询阶段: ' + phase + '…', '')
           }
@@ -5162,6 +5211,8 @@
       async function loadSessionReplayViaHttp(sessionId) {
         const sid = typeof sessionId === 'string' ? sessionId.trim() : ''
         if (!sid) return
+        sessionReplayInProgress = true
+        pendingConversationDeltaEnvelopes.length = 0
         try {
           const r = await fetch(buildSessionReplayUrl(sid))
           const data = await r.json()
@@ -5174,7 +5225,6 @@
           for (let i = 0; i < envelopes.length; i++) {
             applyWsEnvelopeV3(envelopes[i])
           }
-          requestRenderChat()
           logLine('session-replay-http', {
             sessionId: sid,
             messageCount: data.messageCount,
@@ -5183,6 +5233,10 @@
         } catch (e) {
           logLine('session-replay-http', String(e))
           setStatus('历史回放失败: ' + e, 'err')
+        } finally {
+          sessionReplayInProgress = false
+          flushPendingConversationDeltas()
+          requestRenderChat()
         }
       }
 
@@ -5254,20 +5308,6 @@
         }
       }
 
-      /** Geelib 定时巡检快捷模板：/geelib poll，每分钟循环 */
-      function applyGeelibSchedulePreset() {
-        if (scheduleCreateForm) scheduleCreateForm.hidden = false
-        populateScheduleSessionSelect()
-        if (schedulePromptInput) schedulePromptInput.value = '/geelib poll'
-        document.querySelectorAll('input[name="scheduleTriggerMode"]').forEach(function (el) {
-          el.checked = el.value === 'cron'
-        })
-        if (scheduleDelayRow) scheduleDelayRow.hidden = true
-        if (scheduleCronRow) scheduleCronRow.hidden = false
-        if (scheduleCronInput) scheduleCronInput.value = '* * * * *'
-        if (scheduleRecurringInput) scheduleRecurringInput.checked = true
-      }
-
       /** 渲染定时任务表格 */
       function renderScheduleTaskTable(tasks, timezone) {
         if (!scheduleTaskTableBody || !scheduleManageEmpty) return
@@ -5536,12 +5576,6 @@
         return u.toString()
       }
 
-      function buildToolBaseListUrl() {
-        const u = new URL('/api/tools/base-list', httpOriginForApi() + '/')
-        u.searchParams.set('agent', currentAgentParam())
-        return u.toString()
-      }
-
       function buildToolInstalledListUrl() {
         const u = new URL('/api/tools/installed-list', httpOriginForApi() + '/')
         u.searchParams.set('agent', currentAgentParam())
@@ -6781,19 +6815,6 @@
               runId: data.runId,
               seq: data.seq,
             })
-            if (
-              data.type === 'session.meta' &&
-              data.data &&
-              typeof data.data === 'object' &&
-              data.data.sessionId
-            ) {
-              void loadSessions()
-              if (pendingSessionOverrides) {
-                void flushPendingSessionOverridesIfAny()
-              } else {
-                void loadSessionOverridesIntoComposer()
-              }
-            }
             updateButtons()
             return
           }
@@ -7913,8 +7934,7 @@
 
         if (kind === 'tools') {
           const toolPickerState = {
-            activeTab: 'base',
-            baseRows: [],
+            activeTab: 'installed',
             installedRows: [],
             cloudRows: [],
             cloudQuery: '',
@@ -7951,17 +7971,28 @@
                 if (!x.r.ok) throw new Error(x.b.message || x.r.statusText)
                 const tools = Array.isArray(x.b.tools) ? x.b.tools : []
                 return tools.map(function (t) {
-                  return { id: t.name, t: t }
+                  const pkg = t.packageName ? String(t.packageName) : ''
+                  const layer = t.layer === 'system' || t.layer === 'agent' ? t.layer : ''
+                  const layerTag = layer === 'system' ? ' [系统]' : layer === 'agent' ? ' [Agent]' : ''
+                  return {
+                    id: t.name,
+                    t: t,
+                    packageId: pkg,
+                    deletable: t.deletable === true,
+                    layerTag: layerTag,
+                  }
                 })
               })
           }
-          const makeManageRow = function (row, canDelete) {
+          const makeManageRow = function (row) {
             const id = row.id
+            const canDelete = row.deletable === true
+            const packageId = row.packageId || ''
             const div = document.createElement('div')
             div.className = 'agent-picker-item'
             const labelEl = document.createElement('div')
             labelEl.className = 'agent-picker-item-label'
-            labelEl.textContent = toolLabel(row)
+            labelEl.textContent = toolLabel(row) + (row.layerTag || '')
             div.appendChild(labelEl)
             const actions = document.createElement('div')
             actions.className = 'agent-picker-actions'
@@ -7976,13 +8007,13 @@
               renderToolsRows()
             })
             actions.appendChild(toggleBtn)
-            if (canDelete) {
+            if (canDelete && packageId) {
               const exportBtn = document.createElement('button')
               exportBtn.type = 'button'
               exportBtn.className = 'btn-picker-action'
               exportBtn.textContent = '导出'
               exportBtn.addEventListener('click', function () {
-                window.open(buildRuntimeToolExportUrl(id), '_blank', 'noopener')
+                window.open(buildRuntimeToolExportUrl(packageId), '_blank', 'noopener')
               })
               actions.appendChild(exportBtn)
             }
@@ -7990,10 +8021,13 @@
             delBtn.type = 'button'
             delBtn.className = 'btn-picker-action is-delete'
             delBtn.textContent = '删除'
-            delBtn.disabled = !canDelete
+            delBtn.disabled = !canDelete || !packageId
+            if (!canDelete) {
+              delBtn.title = '系统内置工具不可删除'
+            }
             delBtn.addEventListener('click', function () {
               if (delBtn.disabled) return
-              fetch(buildRuntimeToolDeleteUrl(id), { method: 'DELETE' })
+              fetch(buildRuntimeToolDeleteUrl(packageId), { method: 'DELETE' })
                 .then(function (r) {
                   return r.json().catch(function () { return {} }).then(function (b) { return { r: r, b: b } })
                 })
@@ -8011,111 +8045,21 @@
             div.appendChild(actions)
             return div
           }
-          const loadCloudRows = function () { return Promise.resolve() }
           const renderToolsRows = function () {
             if (!agentPickerList) return
             agentPickerList.innerHTML = ''
-            renderPickerHeaderTabs(
-              [
-                { id: 'base', label: '基础工具' },
-                { id: 'installed', label: '已安装工具' },
-              ],
-              toolPickerState.activeTab,
-              function (id) {
-                toolPickerState.activeTab = id
-                renderToolsRows()
-              },
-            )
-            if (toolPickerState.activeTab === 'base') {
-              const rows = toolPickerState.baseRows
-              if (!rows.length) {
-                agentPickerList.appendChild(document.createTextNode('（暂无）'))
-                return
-              }
-              for (let i = 0; i < rows.length; i++) agentPickerList.appendChild(makeManageRow(rows[i], false))
+            const rows = toolPickerState.installedRows
+            if (!rows.length) {
+              agentPickerList.appendChild(document.createTextNode('（暂无已安装工具）'))
               return
             }
-            if (toolPickerState.activeTab === 'installed') {
-              const rows = toolPickerState.installedRows
-              if (!rows.length) {
-                agentPickerList.appendChild(document.createTextNode('（暂无）'))
-                return
-              }
-              for (let i = 0; i < rows.length; i++) agentPickerList.appendChild(makeManageRow(rows[i], true))
-              return
-            }
-            const cloudSearch = document.createElement('input')
-            cloudSearch.type = 'search'
-            cloudSearch.className = 'agent-picker-cloud-search'
-            cloudSearch.placeholder = '搜索云端工具…'
-            cloudSearch.value = toolPickerState.cloudQuery
-            cloudSearch.oninput = function () {
-              toolPickerState.cloudQuery = cloudSearch.value.trim()
-              toolPickerState.cloudPage = 1
-              void loadCloudRows()
-            }
-            agentPickerList.appendChild(cloudSearch)
-            agentPickerList.appendChild(createCloudPager({
-              page: toolPickerState.cloudPage,
-              totalPages: toolPickerState.cloudTotalPages,
-              loading: toolPickerState.cloudLoading,
-            }, function (nextPage) {
-              toolPickerState.cloudPage = nextPage
-              void loadCloudRows()
-            }))
-            if (toolPickerState.cloudError) {
-              agentPickerList.appendChild(document.createTextNode('加载失败：' + toolPickerState.cloudError))
-              return
-            }
-            if (!toolPickerState.cloudRows.length) {
-              agentPickerList.appendChild(document.createTextNode(toolPickerState.cloudLoading ? '加载中…' : '（无匹配项）'))
-              return
-            }
-            for (let i = 0; i < toolPickerState.cloudRows.length; i++) {
-              const item = toolPickerState.cloudRows[i]
-              const row = document.createElement('div')
-              row.className = 'agent-picker-item'
-              const label = document.createElement('div')
-              label.className = 'agent-picker-item-label'
-              label.textContent = item.title + ' · ' + item.toolName + (item.description ? ' — ' + item.description : '')
-              row.appendChild(label)
-              const actions = document.createElement('div')
-              actions.className = 'agent-picker-actions'
-              const opBtn = document.createElement('button')
-              opBtn.type = 'button'
-              opBtn.className = 'btn-picker-action' + (item.installed ? ' is-delete' : '')
-              const running = !!toolPickerState.loadingMap[item.id]
-              opBtn.disabled = running
-              opBtn.textContent = running ? '处理中…' : item.installed ? '卸载' : '安装'
-              opBtn.addEventListener('click', function () {
-                if (opBtn.disabled) return
-                toolPickerState.loadingMap[item.id] = true
-                renderToolsRows()
-                const req = item.installed
-                  ? fetch(buildRuntimeToolDeleteUrl(item.packageId), { method: 'DELETE' })
-                  : Promise.reject(new Error('云端工具安装接口已下线'))
-                req
-                  .then(function (r) { return r.json().catch(function () { return {} }).then(function (b) { return { r: r, b: b } }) })
-                  .then(function (x) {
-                    if (!x.r.ok) throw new Error(x.b.message || x.r.statusText)
-                    restartCurrentSessionSubprocessWithReason(item.installed ? 'cloud-tool-uninstall' : 'cloud-tool-install')
-                    return refreshToolPickerRows()
-                  })
-                  .catch(function (e) { window.alert((item.installed ? '卸载' : '安装') + '失败: ' + e) })
-                  .finally(function () { delete toolPickerState.loadingMap[item.id]; renderToolsRows() })
-              })
-              actions.appendChild(opBtn)
-              row.appendChild(actions)
-              agentPickerList.appendChild(row)
+            for (let i = 0; i < rows.length; i++) {
+              agentPickerList.appendChild(makeManageRow(rows[i]))
             }
           }
           refreshToolPickerRows = function () {
-            return Promise.all([
-              fetchToolRows(buildToolBaseListUrl),
-              fetchToolRows(buildToolInstalledListUrl),
-            ]).then(function (allRows) {
-              toolPickerState.baseRows = allRows[0]
-              toolPickerState.installedRows = allRows[1]
+            return fetchToolRows(buildToolInstalledListUrl).then(function (rows) {
+              toolPickerState.installedRows = rows
               renderToolsRows()
             })
           }
@@ -9114,11 +9058,6 @@
           if (!scheduleCreateForm.hidden) populateScheduleSessionSelect()
         })
       }
-      if (btnScheduleGeelibPreset) {
-        btnScheduleGeelibPreset.addEventListener('click', function () {
-          applyGeelibSchedulePreset()
-        })
-      }
       if (btnScheduleCreateCancel && scheduleCreateForm) {
         btnScheduleCreateCancel.addEventListener('click', function () {
           scheduleCreateForm.hidden = true
@@ -9331,16 +9270,15 @@
           agentEnvSessionTabStrip.setAttribute('aria-label', '环境变量、编辑 agent.md、设置')
           agentEnvSessionTabStrip.removeAttribute('hidden')
         }
-        if (!agentEnvSchema.length) {
-          void loadProjectEnvDefaults().then(function () {
-            const latestEnvObj =
-              agentConfigState.env && typeof agentConfigState.env === 'object'
-                ? agentConfigState.env
-                : {}
-            agentEnvFieldValues = buildAgentEnvFieldValues(latestEnvObj)
-            renderAgentEnvList()
-          })
-        }
+        /** 每次打开设置弹窗都拉最新 schema，避免后端新增字段后页面仍用旧缓存。 */
+        void loadProjectEnvDefaults().then(function () {
+          const latestEnvObj =
+            agentConfigState.env && typeof agentConfigState.env === 'object'
+              ? agentConfigState.env
+              : {}
+          agentEnvFieldValues = buildAgentEnvFieldValues(latestEnvObj)
+          renderAgentEnvList()
+        })
         renderAgentEnvHeaderTabs()
         syncAgentEnvTabPanels()
         agentEnvModal.classList.add('is-open')

package/mcps-runtime/claude-geelib-channel/.mcp.json

@@ -0,0 +1,18 @@
+{
+  "mcpServers": {
+    "geelib": {
+      "command": "node",
+      "args": [
+        "${CLAUDE_PLUGIN_ROOT}/server/boot.mjs"
+      ],
+      "env": {
+        "GEELIB_USER": "${GEELIB_USER}",
+        "GEELIB_PASSWD": "${GEELIB_PASSWD}",
+        "GEELIB_BASE_URL": "${GEELIB_BASE_URL:-https://geelib.qihoo.net}",
+        "GEELIB_SUB_ID": "${GEELIB_SUB_ID}",
+        "GEELIB_STATE_DIR": "${WS_AGENTS_ROOT}/mcps-runtime/claude-geelib-channel/.state",
+        "GEELIB_POLL_INTERVAL_MS": "${GEELIB_POLL_INTERVAL_MS:-60000}"
+      }
+    }
+  }
+}

package/mcps-runtime/claude-geelib-channel/server/boot.mjs

@@ -0,0 +1,32 @@
+import { mkdirSync, appendFileSync } from 'node:fs'
+import { dirname, join } from 'node:path'
+import { homedir } from 'node:os'
+
+const stateDir =
+  process.env.GEELIB_STATE_DIR ||
+  join(homedir(), '.claude', 'channels', 'geelib')
+const bootLog = join(stateDir, 'boot.log')
+mkdirSync(dirname(bootLog), { recursive: true })
+
+function log(line) {
+  appendFileSync(bootLog, `${new Date().toISOString()} ${line}\n`, {
+    encoding: 'utf8',
+    mode: 0o600,
+    flag: 'a',
+  })
+}
+
+log(`[BOOT] geelib-channel boot.mjs start pid=${process.pid}`)
+log(
+  `[BOOT] env GEELIB_STATE_DIR=${process.env.GEELIB_STATE_DIR || ''} GEELIB_POLL_INTERVAL_MS=${process.env.GEELIB_POLL_INTERVAL_MS || ''} GEELIB_SUB_ID=${process.env.GEELIB_SUB_ID || ''}`,
+)
+
+process.on('uncaughtException', err => {
+  log(`[BOOT] uncaughtException ${err?.stack || err}`)
+})
+process.on('unhandledRejection', err => {
+  log(`[BOOT] unhandledRejection ${err?.stack || err}`)
+})
+
+await import('./index.mjs')
+log('[BOOT] imported index.mjs successfully')