@australiangreens/eslint-plugin-ag-internal 0.2.1 → 0.3.0

package/README.md

@@ -60,9 +60,6 @@ _warnings_. This may be changed in the future.
 -   [import plugin](https://www.npmjs.com/package/eslint-plugin-import-esm)'s
     recommended rules with the addition of 2 strict rules.
 
--   [import](https://www.npmjs.com/package/eslint-plugin-import-esm)
-    typescript rules. **TODO: Move to typescript config**.
-
 ### recommended
 
 All the rules from recommendedJsOnly with the addition of the following:
@@ -73,6 +70,9 @@ All the rules from recommendedJsOnly with the addition of the following:
 -   [tsdoc plugin](https://www.npmjs.com/package/eslint-plugin-tsdoc)'s single
     `tsdoc/syntax` rule enabled as _error_.
 
+-   [import](https://www.npmjs.com/package/eslint-plugin-import-esm)
+    typescript rules.
+
 ## recommendedReactJsOnly
 
 recommendedJsOnly with the addition of the following:

package/dist/configs/javascript.d.ts

@@ -1,3 +1,4 @@
 import { Linter } from 'eslint';
-declare const config: Linter.Config[];
-export default config;
+export declare const importPluginChange: Linter.Config;
+declare const _default: Linter.Config<Linter.RulesRecord>[];
+export default _default;

package/dist/configs/javascript.js

@@ -1,7 +1,7 @@
 import jsEslint from '@eslint/js';
 import importPlugin from 'eslint-plugin-import';
 import { pluginName } from '../util.js';
-const config = [
+const javascriptRulesMinusImportPluginChange = [
     jsEslint.configs.recommended,
     {
         name: `${pluginName()}/eslint`,
@@ -18,25 +18,19 @@ const config = [
         },
     },
     importPlugin.flatConfigs.recommended,
-    // TODO: Is it possible to move the typescript stuff out of here and still work?
-    importPlugin.flatConfigs.typescript,
-    {
-        name: `${pluginName()}/import`,
-        rules: {
-            // These are not incuded in the recommended config, we treat as errors
-            'import/newline-after-import': 'error',
-            'import/no-unresolved': 'error',
-            // These are warnings in recommended, we treat as errors
-            'import/no-named-as-default': 'error',
-            'import/no-named-as-default-member': 'error',
-            'import/no-duplicates': 'error',
-        },
-        settings: {
-            'import/resolver': {
-                typescript: true,
-                node: true,
-            },
-        },
-    },
 ];
-export default config;
+// We use this pattern so we don't need to define the rules both here and in
+// typescript.ts
+export const importPluginChange = {
+    name: `${pluginName()}/import`,
+    rules: {
+        // These are not incuded in the recommended config, we treat as errors
+        'import/newline-after-import': 'error',
+        'import/no-unresolved': 'error',
+        // These are warnings in recommended, we treat as errors
+        'import/no-named-as-default': 'error',
+        'import/no-named-as-default-member': 'error',
+        'import/no-duplicates': 'error',
+    },
+};
+export default [...javascriptRulesMinusImportPluginChange, importPluginChange];

package/dist/configs/typescript.js

@@ -1,6 +1,8 @@
+import importPlugin from 'eslint-plugin-import';
 import tsdocPlugin from 'eslint-plugin-tsdoc';
 import { configs as tsEslintConfigs } from 'typescript-eslint';
 import { pluginName } from '../util.js';
+import { importPluginChange } from './javascript.js';
 const config = [
     ...tsEslintConfigs.recommended,
     {
@@ -36,5 +38,15 @@ const config = [
             'tsdoc/syntax': 'error',
         },
     },
+    importPlugin.flatConfigs.typescript,
+    {
+        ...importPluginChange,
+        settings: {
+            'import/resolver': {
+                typescript: true,
+                node: true,
+            },
+        },
+    },
 ];
 export default config;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@australiangreens/eslint-plugin-ag-internal",
-  "version": "0.2.1",
+  "version": "0.3.0",
   "private": false,
   "type": "module",
   "homepage": "https://github.com/australiangreens/eslint-plugin-ag-internal#readme",