@aurodesignsystem/auro-library 5.13.2 → 5.13.3

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Semantic Release Automated Changelog
 
+## [5.13.3](https://github.com/AlaskaAirlines/auro-library/compare/v5.13.2...v5.13.3) (2026-08-07)
+
+
+### Bug Fixes
+
+* **floatingUI:** suppress Escape keydown for modal dialogs to prevent CloseWatcher force-close AB[#1613688](https://github.com/AlaskaAirlines/auro-library/issues/1613688) ([efd81c5](https://github.com/AlaskaAirlines/auro-library/commit/efd81c5fd96f4d02253e4ce76b4e7a2ddb8d25c7))
+
 ## [5.13.2](https://github.com/AlaskaAirlines/auro-library/compare/v5.13.1...v5.13.2) (2026-07-28)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aurodesignsystem/auro-library",
-  "version": "5.13.2",
+  "version": "5.13.3",
   "description": "This repository holds shared scripts, utilities, and workflows utilized across repositories along the Auro Design System.",
   "repository": {
     "type": "git",

package/scripts/runtime/floatingUI.mjs

@@ -778,6 +778,24 @@ export default class AuroFloatingUI {
       if (!this.showing) {
         if (!element.modal) {
           this.setupHideHandlers();
+        } else {
+          if (this.keyDownHandler) {
+            document.removeEventListener("keydown", this.keyDownHandler);
+          }
+          this.keyDownHandler = (evt) => {
+            if (evt.key === "Escape" && element.isPopoverVisible) {
+              // Intercept at keydown so CloseWatcher never sees the keystroke.
+              // Canceling `cancel` alone is insufficient — a second Esc with no
+              // intervening user activation triggers the anti-trap and fires `close`
+              // directly, bypassing any `cancel` preventDefault (AB#1613688).
+              // stopImmediatePropagation is intentional: it prevents other document
+              // keydown handlers (e.g. consumer code, auro-dialog) from also acting
+              // on Escape while the modal owns the key.
+              evt.preventDefault();
+              evt.stopImmediatePropagation();
+            }
+          };
+          document.addEventListener("keydown", this.keyDownHandler);
         }
         this.showing = true;
         element.isPopoverVisible = true;

package/scripts/runtime/floatingUI.test.js

@@ -295,6 +295,85 @@ describe("AuroFloatingUI", () => {
   });
 });
 
+describe("AuroFloatingUI modal Escape suppression (AB#1613688)", () => {
+  let host;
+  let bib;
+  let floatingUI;
+  let hideBibSpy;
+
+  beforeEach(() => {
+    host = document.createElement("div");
+    bib = document.createElement("div");
+    host.bib = bib;
+    host.modal = true;
+    host.isPopoverVisible = false;
+    host.triggerChevron = document.createElement("span");
+    document.body.append(host, bib);
+
+    AuroFloatingUI.openingQueue = [];
+    document.expandedAuroFloater = null;
+
+    floatingUI = new AuroFloatingUI(host, "dialog");
+    hideBibSpy = sinon.spy(floatingUI, "hideBib");
+  });
+
+  afterEach(() => {
+    floatingUI.cleanupHideHandlers();
+    sinon.restore();
+    AuroFloatingUI.isMousePressed = false;
+    AuroFloatingUI.openingQueue = [];
+    document.expandedAuroFloater = null;
+    host?.remove();
+    bib?.remove();
+  });
+
+  it("registers a keydown handler and skips setupHideHandlers when modal=true", () => {
+    const setupHideHandlersSpy = sinon.spy(floatingUI, "setupHideHandlers");
+
+    floatingUI.showBib();
+
+    expect(setupHideHandlersSpy.called).to.be.false;
+    expect(floatingUI.keyDownHandler).to.be.a("function");
+    expect(floatingUI.showing).to.be.true;
+  });
+
+  it("does not call hideBib when Escape is pressed while modal dialog is open", () => {
+    floatingUI.showBib();
+
+    document.dispatchEvent(
+      new KeyboardEvent("keydown", {
+        key: "Escape",
+        bubbles: true,
+        cancelable: true,
+      }),
+    );
+
+    expect(hideBibSpy.called).to.be.false;
+  });
+
+  it("calls preventDefault on Escape keydown while modal dialog is open", () => {
+    floatingUI.showBib();
+
+    const escEvent = new KeyboardEvent("keydown", {
+      key: "Escape",
+      bubbles: true,
+      cancelable: true,
+    });
+    const preventDefaultSpy = sinon.spy(escEvent, "preventDefault");
+    document.dispatchEvent(escEvent);
+
+    expect(preventDefaultSpy.calledOnce).to.be.true;
+  });
+
+  it("removes the modal Escape keydown handler via cleanupHideHandlers", () => {
+    floatingUI.showBib();
+    expect(floatingUI.keyDownHandler).to.be.a("function");
+
+    floatingUI.cleanupHideHandlers();
+    expect(floatingUI.keyDownHandler).to.be.null;
+  });
+});
+
 describe("AuroFloatingUI.openingQueue and topOpeningFloatingUI", () => {
   let floatingUI1;
   let floatingUI2;