@aurodesignsystem/auro-library 5.11.1 → 5.11.3

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Semantic Release Automated Changelog
 
+## [5.11.3](https://github.com/AlaskaAirlines/auro-library/compare/v5.11.2...v5.11.3) (2026-03-31)
+
+
+### Bug Fixes
+
+* correct focus local check for shadow DOM ([e713cfc](https://github.com/AlaskaAirlines/auro-library/commit/e713cfc07f1be4809c97e05af97b89050478e988))
+
+## [5.11.2](https://github.com/AlaskaAirlines/auro-library/compare/v5.11.1...v5.11.2) (2026-03-17)
+
+
+### Bug Fixes
+
+* prevent dropdown from closing on click for noToggle elements AB[#1494298](https://github.com/AlaskaAirlines/auro-library/issues/1494298) ([4d23b40](https://github.com/AlaskaAirlines/auro-library/commit/4d23b4082c8e22d9a865ba51b702f70185cfd455))
+* return comment ([d2b315c](https://github.com/AlaskaAirlines/auro-library/commit/d2b315c0ca08d724ac6239d0e25b6127173f990e))
+* simplify hideBib logic with early returns for readability ([bd4038d](https://github.com/AlaskaAirlines/auro-library/commit/bd4038dce05969e18e87910a234344f95c729ac2))
+
 ## [5.11.1](https://github.com/AlaskaAirlines/auro-library/compare/v5.11.0...v5.11.1) (2026-03-04)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aurodesignsystem/auro-library",
-  "version": "5.11.1",
+  "version": "5.11.3",
   "description": "This repository holds shared scripts, utilities, and workflows utilized across repositories along the Auro Design System.",
   "repository": {
     "type": "git",

package/scripts/runtime/floatingUI.mjs

@@ -331,11 +331,10 @@ export default class AuroFloatingUI {
       return;
     }
 
-    const { activeElement } = document;
     // if focus is still inside of trigger or bib, do not close
     if (
-      this.element.contains(activeElement) ||
-      this.element.bib?.contains(activeElement)
+      this.element.matches(":focus") ||
+      this.element.matches(":focus-within")
     ) {
       return;
     }
@@ -488,19 +487,32 @@ export default class AuroFloatingUI {
    * @param {String} eventType - The event type that triggered the hiding action.
    */
   hideBib(eventType = "unknown") {
-    if (!this.element.disabled && !this.element.noToggle) {
-      this.lockScroll(false);
-      this.element.triggerChevron?.removeAttribute("data-expanded");
+    if (this.element.disabled) {
+      return;
+    }
 
-      if (this.element.isPopoverVisible) {
-        this.element.isPopoverVisible = false;
-      }
-      if (this.showing) {
-        this.cleanupHideHandlers();
-        this.showing = false;
-        this.dispatchEventDropdownToggle(eventType);
-      }
+    // noToggle dropdowns should not close when the trigger is clicked (the
+    // "toggle" behavior), but they CAN still close via other interactions like
+    // Escape key or focus loss.
+    if (this.element.noToggle && eventType === "click") {
+      return;
     }
+
+    this.lockScroll(false);
+    this.element.triggerChevron?.removeAttribute("data-expanded");
+
+    if (this.element.isPopoverVisible) {
+      this.element.isPopoverVisible = false;
+    }
+    if (this.showing) {
+      this.cleanupHideHandlers();
+      this.showing = false;
+      this.dispatchEventDropdownToggle(eventType);
+    }
+
+    // Only clear the global reference if the bib was actually hidden.
+    // Clearing it when hideBib is blocked (e.g. noToggle + click) corrupts
+    // the singleton state so other dropdowns can't detect this one is still open.
     document.expandedAuroFloater = null;
   }
 

package/scripts/runtime/floatingUI.test.js

@@ -0,0 +1,102 @@
+import { expect } from "@open-wc/testing";
+import sinon from "sinon";
+import AuroFloatingUI from "./floatingUI.mjs";
+
+describe("AuroFloatingUI", () => {
+  let host;
+  let bib;
+  let floatingUI;
+  let hideBibSpy;
+
+  beforeEach(() => {
+    host = document.createElement("div");
+    bib = document.createElement("div");
+    host.bib = bib;
+    host.triggerChevron = document.createElement("span");
+
+    document.body.append(host, bib);
+
+    AuroFloatingUI.isMousePressed = false;
+    floatingUI = new AuroFloatingUI(host, "dropdown");
+    hideBibSpy = sinon.spy(floatingUI, "hideBib");
+  });
+
+  afterEach(() => {
+    sinon.restore();
+    AuroFloatingUI.isMousePressed = false;
+    host?.remove();
+    bib?.remove();
+  });
+
+  it("does not hide when the host matches focus-within", () => {
+    const checkedSelectors = [];
+
+    sinon.stub(host, "matches").callsFake((selector) => {
+      checkedSelectors.push(selector);
+
+      if (selector === ":focus") {
+        return false;
+      }
+
+      if (selector === ":focus-within") {
+        return true;
+      }
+
+      return false;
+    });
+
+    floatingUI.handleFocusLoss();
+
+    expect(checkedSelectors).to.deep.equal([":focus", ":focus-within"]);
+    expect(hideBibSpy.called).to.be.false;
+  });
+
+  it("does not hide when the host matches focus", () => {
+    const checkedSelectors = [];
+
+    sinon.stub(host, "matches").callsFake((selector) => {
+      checkedSelectors.push(selector);
+
+      if (selector === ":focus") {
+        return true;
+      }
+
+      return false;
+    });
+
+    floatingUI.handleFocusLoss();
+
+    expect(checkedSelectors).to.deep.equal([":focus"]);
+    expect(hideBibSpy.called).to.be.false;
+  });
+
+  it("does not hide when the bib is fullscreen", () => {
+    const checkedSelectors = [];
+
+    bib.setAttribute("isfullscreen", "");
+
+    sinon.stub(host, "matches").callsFake((selector) => {
+      checkedSelectors.push(selector);
+      return false;
+    });
+
+    floatingUI.handleFocusLoss();
+
+    expect(checkedSelectors).to.deep.equal([":focus", ":focus-within"]);
+    expect(hideBibSpy.called).to.be.false;
+  });
+
+  it("hides with a keydown event when the host no longer has focus", () => {
+    const checkedSelectors = [];
+
+    sinon.stub(host, "matches").callsFake((selector) => {
+      checkedSelectors.push(selector);
+      return false;
+    });
+
+    floatingUI.handleFocusLoss();
+
+    expect(checkedSelectors).to.deep.equal([":focus", ":focus-within"]);
+    expect(hideBibSpy.calledOnceWithExactly("keydown")).to.be.true;
+  });
+});