@aurodesignsystem-dev/auro-formkit 0.0.0-pr1508.0 → 0.0.0-pr1508.2

package/components/input/dist/base-input.d.ts

@@ -382,59 +382,49 @@ export default class BaseInput extends AuroElement {
             reflect: boolean;
         };
     };
+    activeLabel: boolean;
+    /** @private */
+    private allowedInputTypes;
     appearance: string;
+    /** @private */
+    private dateFormatMap;
     disabled: boolean;
+    /** @private */
+    private domHandler;
+    dvInputOnly: boolean;
+    hasValue: boolean;
+    hideLabelVisually: boolean;
+    icon: boolean;
+    /** @private */
+    private inputIconName;
+    /** @private */
+    private label;
     locale: string;
     max: any;
     maxLength: any;
     min: any;
     minLength: any;
-    required: boolean;
+    noValidate: boolean;
     onDark: boolean;
+    _rawMaskValue: string | undefined;
+    required: boolean;
     setCustomValidityForType: string | undefined;
-    size: string;
+    /** @private */
+    private setSelectionInputTypes;
     shape: string;
+    /** @private */
+    private showPassword;
+    size: string;
+    touched: boolean;
+    /** @private */
+    private uniqueId;
+    /** @private */
+    private util;
+    /** @private */
+    private validation;
+    /** @private */
+    private validationCCLength;
     value: any;
-    /**
-     * Internal Defaults.
-     * @private
-     * @returns {void}
-     */
-    private _initializePrivateDefaults;
-    activeLabel: boolean | undefined;
-    icon: boolean | undefined;
-    dvInputOnly: boolean | undefined;
-    hideLabelVisually: boolean | undefined;
-    noValidate: boolean | undefined;
-    _rawMaskValue: string | undefined;
-    touched: boolean | undefined;
-    util: any;
-    validation: AuroFormValidation | undefined;
-    inputIconName: any;
-    showPassword: boolean | undefined;
-    validationCCLength: number | undefined;
-    hasValue: boolean | undefined;
-    label: string | undefined;
-    allowedInputTypes: string[] | undefined;
-    dateFormatMap: {
-        'mm/dd/yyyy': string;
-        'dd/mm/yyyy': string;
-        'yyyy/mm/dd': string;
-        'yyyy/dd/mm': string;
-        'mm/yy': string;
-        'yy/mm': string;
-        'mm/yyyy': string;
-        'yyyy/mm': string;
-        yy: string;
-        yyyy: string;
-        mm: string;
-        dd: string;
-        'dd/mm': string;
-        'mm/dd': string;
-    } | undefined;
-    domHandler: any;
-    setSelectionInputTypes: string[] | undefined;
-    uniqueId: any;
     /**
      * Read-only Date object representation of `value` for full date formats.
      * @returns {Date|undefined}
@@ -455,6 +445,7 @@ export default class BaseInput extends AuroElement {
     inputElement: HTMLInputElement | null | undefined;
     labelElement: HTMLLabelElement | null | undefined;
     inputId: string | undefined;
+    format: any;
     ValidityMessageOverride: any;
     /**
      * Patches the input element to dispatch an 'input' event whenever its value is set programmatically.
@@ -477,7 +468,6 @@ export default class BaseInput extends AuroElement {
      * @returns {void}
      */
     updated(changedProperties: Map<string, any>): void;
-    format: any;
     skipNextProgrammaticInputEvent: boolean | undefined;
     /**
      * @private
@@ -600,4 +590,3 @@ export default class BaseInput extends AuroElement {
     private matchInputValueToCreditCard;
 }
 import { AuroElement } from '../../layoutElement/src/auroElement.js';
-import AuroFormValidation from '@aurodesignsystem/form-validation';

package/components/input/dist/index.js

@@ -4383,15 +4383,17 @@ class AuroFormValidation {
         );
       }
 
-      // If there is a second input in the elem and that value is undefined or an empty string set hasValue to false;
-      if (this.auroInputElements?.length === 2) {
-        if (!this.auroInputElements[1].value || this.auroInputElements[1].length === 0) {
+      const isCombobox = this.runtimeUtils.elementMatch(elem, 'auro-combobox');
+
+      // If there is a second input in the elem and that value is undefined or an empty string set hasValue to false.
+      // Skip for combobox: its second auro-input is the fullscreen-bib mirror of the same value, not an independent
+      // field (datepicker is the intended consumer — start/end are independently required).
+      if (this.auroInputElements?.length === 2 && !isCombobox) {
+        if (!this.auroInputElements[1].value || this.auroInputElements[1].value.length === 0) {
           hasValue = false;
         }
       }
 
-      const isCombobox = this.runtimeUtils.elementMatch(elem, 'auro-combobox');
-
       if (isCombobox) {
 
         if (!elem.persistInput || elem.behavior === "filter") {
@@ -10327,6 +10329,13 @@ class AuroInputUtilities {
    * @returns {string | undefined}
    */
   toFormattedValue(valueObject, format) {
+    // Exposed publicly via `AuroInputUtil.toFormattedValue`, so a missing
+    // `format` argument has to fail gracefully rather than throw on
+    // `format.toLowerCase()`. Treat any falsy value (undefined, null, '')
+    // as "no format → no display value".
+    if (!format) {
+      return undefined;
+    }
     const normalizedFormat = format.toLowerCase();
     const maskOptions = this.getMaskOptions('date', normalizedFormat);
 
@@ -10478,76 +10487,19 @@ class BaseInput extends AuroElement {
   constructor() {
     super();
 
-    this.appearance = "default";
-    this.disabled = false;
-    this.layout = 'classic';
-    this.locale = 'en-US';
-    this.max = undefined;
-    this.maxLength = undefined;
-    this.min = undefined;
-    this.minLength = undefined;
-    this.required = false;
-    this.onDark = false;
-    this.setCustomValidityForType = undefined;
-    this.size = 'lg';
-    this.shape = 'classic';
-    this.value = undefined;
-
-    this._initializePrivateDefaults();
-  }
-
-  /**
-   * Internal Defaults.
-   * @private
-   * @returns {void}
-   */
-  _initializePrivateDefaults() {
+    // Single-source initialization. Alphabetized so duplicate or stale
+    // defaults are immediately obvious on a diff. Every field is assigned
+    // exactly once here (previously the constructor + the old
+    // `_initializePrivateDefaults` overlapped — both wrote ~14 of the same
+    // fields and double-allocated `util` and `validation`, discarding the
+    // first instance). `validation` is now allocated exactly once; `util`
+    // is seeded here with an en-US default and then rebuilt in
+    // `connectedCallback` once the consumer-resolved locale is available,
+    // so a parent (datepicker/combobox) calling `validate()` synchronously
+    // during its own update cycle sees a populated util instance.
     this.activeLabel = false;
-    this.appearance = "default";
-    this.icon = false;
-    this.disabled = false;
-    this.dvInputOnly = false;
-    this.hideLabelVisually = false;
-    this.max = undefined;
-    this.maxLength = undefined;
-    this.min = undefined;
-    this.minLength = undefined;
-    this.noValidate = false;
-    this.onDark = false;
-    this.required = false;
-    this.setCustomValidityForType = undefined;
-
-    // Used for storing raw values returned from input mask.
-    this._rawMaskValue = undefined;
-
-    /**
-     * @private
-     */
-    this.layout = 'classic';
-
-    /**
-     * @private
-     */
-    this.shape = 'classic';
-
-    /**
-     * @private
-     */
-    this.size = 'lg';
-
-    this.touched = false;
-    this.util = new AuroInputUtilities({
-      locale: "en-US",
-      format: this.format
-    });
-    this.validation = new AuroFormValidation();
-    this.inputIconName = undefined;
-    this.showPassword = false;
-    this.validationCCLength = undefined;
-    this.hasValue = false;
-    this.label = 'Input label is undefined';
-
 
+    /** @private */
     this.allowedInputTypes = [
       "text",
       "number",
@@ -10556,7 +10508,9 @@ class BaseInput extends AuroElement {
       "credit-card",
       "tel"
     ];
-    this.icon = false;
+    this.appearance = "default";
+
+    /** @private */
     this.dateFormatMap = {
       'mm/dd/yyyy': 'dateMMDDYYYY',
       'dd/mm/yyyy': 'dateDDMMYYYY',
@@ -10573,27 +10527,62 @@ class BaseInput extends AuroElement {
       'dd/mm': 'dateDDMM',
       'mm/dd': 'dateMMDD'
     };
+    this.disabled = false;
+
+    /** @private */
     this.domHandler = new DomHandler();
     this.dvInputOnly = false;
     this.hasValue = false;
+    this.hideLabelVisually = false;
+    this.icon = false;
+
+    /** @private */
     this.inputIconName = undefined;
+
+    /** @private */
     this.label = 'Input label is undefined';
+    this.layout = 'classic';
+    this.locale = 'en-US';
+    this.max = undefined;
+    this.maxLength = undefined;
+    this.min = undefined;
+    this.minLength = undefined;
     this.noValidate = false;
-    this._rawMaskValue = undefined; // Used for storing raw values returned from input mask.
+    this.onDark = false;
+    // Raw values returned from the input mask before model normalization.
+    this._rawMaskValue = undefined;
+    this.required = false;
+    this.setCustomValidityForType = undefined;
+    // Credit Card is intentionally excluded — its mask manages the cursor
+    // itself, and listing it here caused cursor placement issues in Safari.
+    /** @private */
     this.setSelectionInputTypes = [
       "text",
       "password",
       "email"
-    ]; // Credit Card is not included as this caused cursor placement issues in Safari.
+    ];
+    this.shape = 'classic';
+
+    /** @private */
     this.showPassword = false;
+    this.size = 'lg';
     this.touched = false;
+
+    /** @private */
     this.uniqueId = new UniqueId().create();
+
+    /** @private */
     this.util = new AuroInputUtilities({
       locale: this.locale,
       format: this.format
     });
+
+    /** @private */
     this.validation = new AuroFormValidation();
+
+    /** @private */
     this.validationCCLength = undefined;
+    this.value = undefined;
   }
 
   // function to define props used within the scope of this component
@@ -11097,6 +11086,15 @@ class BaseInput extends AuroElement {
 
     this.inputId = this.id ? `${this.id}-input` : window.crypto.randomUUID();
 
+    // Normalize the format token to lowercase so case-mixed values supplied
+    // via attribute (e.g. `format="MM/DD/YYYY"`) hit the `dateFormatMap`
+    // lookup inside `setCustomHelpTextMessage`. Without this, an uppercase
+    // format silently misses the map and leaves `setCustomValidityForType`
+    // unset.
+    if (this.format) {
+      this.format = this.format.toLowerCase();
+    }
+
     // use validity message override if declared when initializing the component
     if (this.hasAttribute('setCustomValidity')) {
       this.ValidityMessageOverride = this.setCustomValidity;
@@ -11180,6 +11178,13 @@ class BaseInput extends AuroElement {
 
     if (typeToI18n.includes(this.type)) {
       this.setCustomValidityForType = i18n(this.lang, this.type);
+    // COVERAGE: this `else if` branch is unreachable in WTR. connectedCallback
+    // (L682) calls configureDataForType, which at L1266-1268 assigns
+    // `this.format = this.util.getDateMaskFromLocale().toLowerCase()` for any
+    // type=date input whose `format` attribute is unset. That runs before
+    // firstUpdated invokes setCustomHelpTextMessage, so `!this.format` is
+    // always false here. Retained as a defensive fallback; the whole function
+    // is @deprecated per AB#1557296 and slated for removal.
     } else if (!this.format && this.type === 'date') {
       this.setCustomValidityForType = i18n(this.lang, 'dateMMDDYYYY');
     } else if (this.dateFormatMap[this.format]) {
@@ -11469,6 +11474,38 @@ class BaseInput extends AuroElement {
       this.touched = true;
       this.validation.validate(this);
     }
+
+    // Prevents cursor jumping in Safari. Setting `this.value` triggers a Lit
+    // update that can re-render the input and reset the native cursor; we
+    // capture the caret position before that update commits and restore it
+    // via `setSelectionRange` once the update has flushed. Gated on
+    // `setSelectionInputTypes` so credit-card (and other masked types whose
+    // formatter manages the cursor itself) doesn't get a competing write.
+    // Capture the caret position INSIDE the gate — reading `selectionStart`
+    // on input types that don't support text selection (number, email in
+    // some browsers) throws InvalidStateError, which would crash all input
+    // handling. Wrap the read in try/catch belt-and-suspenders even though
+    // the gated types currently support it, since the list is a public
+    // property a consumer could mutate.
+    if (this.setSelectionInputTypes.includes(this.type)) {
+      let selectionStart = null;
+      try {
+        ({ selectionStart } = this.inputElement);
+      } catch (error) { // eslint-disable-line no-unused-vars
+        return;
+      }
+      if (typeof selectionStart !== 'number') {
+        return;
+      }
+      this.updateComplete.then(() => {
+        try {
+          this.inputElement.setSelectionRange(selectionStart, selectionStart);
+        } catch (error) { // eslint-disable-line no-unused-vars
+          // Some input types (number/email in certain UAs) throw on
+          // setSelectionRange; swallow and let the native cursor stand.
+        }
+      });
+    }
   }
 
   /**
@@ -11602,7 +11639,7 @@ class BaseInput extends AuroElement {
    */
   get placeholderStr() {
     if (!this.placeholder && this.type === 'date') {
-      return this.format ? this.format.toUpperCase() : 'MM/DD/YYYY';
+      return this.format.toUpperCase();
     }
     return this.placeholder || "";
   }
@@ -12093,7 +12130,7 @@ class AuroHelpText extends LitElement {
   }
 }
 
-var formkitVersion = '202606231948';
+var formkitVersion = '202607010104';
 
 // Copyright (c) 2025 Alaska Airlines. All right reserved. Licensed under the Apache-2.0 license
 // See LICENSE in the project root for license information.
@@ -12596,6 +12633,7 @@ class AuroInput extends BaseInput {
         <${this.buttonTag}
           @click="${this.handleClickShowPassword}"
           appearance="${this.onDark ? 'inverse' : this.appearance}"
+          aria-pressed="${this.showPassword ? 'true' : 'false'}"
           class="notificationBtn passwordBtn"
           shape="circle"
           size="sm"
@@ -12669,25 +12707,29 @@ class AuroInput extends BaseInput {
    * @returns {html} - Returns HTML for the help text and error message.
    */
   renderHtmlHelpText() {
+    // Single `<p>` with stable identity across validity transitions —
+    // previously two distinct templates (valid vs invalid) caused Lit to
+    // replace the node entirely on a flip, and VoiceOver wouldn't
+    // re-announce because the live-region element it was watching had been
+    // removed and a new one inserted. Keeping one node means the `role`,
+    // `aria-live`, and text content all change in-place, which AT does
+    // observe and announce.
+    const isError = this.validity && this.validity !== 'valid';
     return html$1`
-      ${!this.validity || this.validity === undefined || this.validity === 'valid'
-        ? html$1`
-          <${this.helpTextTag}
-            appearance="${this.onDark ? 'inverse' : this.appearance}">
-            <p id="${this.uniqueId}" part="helpText">
-              <slot name="helpText">${this.getHelpText()}</slot>
-            </p>
-          </${this.helpTextTag}>
-        `
-        : html$1`
-          <${this.helpTextTag} error
-            appearance="${this.onDark ? 'inverse' : this.appearance}">
-            <p id="${this.uniqueId}" role="alert" aria-live="assertive" part="helpText">
-              ${this.errorMessage}
-            </p>
-          </${this.helpTextTag}>
-        `
+      <${this.helpTextTag}
+        appearance="${this.onDark ? 'inverse' : this.appearance}"
+        ?error=${isError}>
+        <p
+          id="${this.uniqueId}"
+          part="helpText"
+          role="${ifDefined(isError ? 'alert' : undefined)}"
+          aria-live="${ifDefined(isError ? 'assertive' : undefined)}">
+          ${isError
+        ? this.errorMessage
+        : html$1`<slot name="helpText">${this.getHelpText()}</slot>`
       }
+        </p>
+      </${this.helpTextTag}>
     `;
   }
 
@@ -12834,6 +12876,15 @@ function formatISODate(isoStr, format) {
   try {
     const date = dateFormatter.stringToDateInstance(isoStr);
 
+    // `stringToDateInstance` returns an `Invalid Date` for malformed strings
+    // and `null` for non-string input — it does NOT throw. Without this
+    // guard, `getFullYear()`/`getMonth()`/`getDate()` on an Invalid Date
+    // yield `NaN`, and `String(NaN).padStart(4, '0')` produces literals
+    // like "0NaN/0NaN/0NaN" instead of `undefined`.
+    if (!(date instanceof Date) || Number.isNaN(date.getTime())) {
+      return undefined;
+    }
+
     const year = String(date.getFullYear()).padStart(4, '0');
     const month = String(date.getMonth() + 1).padStart(2, '0');
     const day = String(date.getDate()).padStart(2, '0');
@@ -12844,7 +12895,10 @@ function formatISODate(isoStr, format) {
       replace(/mm/iu, month).
       replace(/dd/iu, day);
   } catch (err) {
-    // If the input string is not a valid date, return undefined
+    // Defensive: the Date-returning path is guarded above, but `parseDate`
+    // (inside `stringToDateInstance`) could throw on pathological input
+    // future-library-versions might introduce. Treat any thrown error as
+    // "not a valid date" and return undefined.
     return undefined;
   }
 }