@aurodesignsystem-dev/auro-formkit 0.0.0-pr1431.3 → 0.0.0-pr1433.0

package/components/menu/dist/index.js

@@ -591,7 +591,7 @@ class AuroMenuOption extends AuroElement {
       this.setAttribute('aria-selected', this.selected.toString());
 
       // Update menu service selection state if this isn't an internal update
-      if (this.internalUpdateInProgress !== true) {
+      if (this.internalUpdateInProgress !== true && this.menuService) {
         this.menuService[this.selected ? 'selectOption' : 'deselectOption'](this);
       }
     }
@@ -626,9 +626,10 @@ class AuroMenuOption extends AuroElement {
   }
 
   disconnectedCallback() {
-    if (this.menuService) {
-      this.menuService.unsubscribe(this.handleMenuChange);
-      this.menuService.removeMenuOption(this);
+    const { menuService } = this;
+    if (menuService) {
+      menuService.unsubscribe(this.handleMenuChange);
+      menuService.removeMenuOption(this);
     }
   }
 
@@ -797,9 +798,11 @@ class AuroMenuOption extends AuroElement {
    * @private
    */
   handleMouseEnter() {
-    if (!this.disabled) {
-      this.menuService.setHighlightedOption(this);
+    const { menuService } = this;
+    if (!menuService || this.disabled) {
+      return;
     }
+    menuService.setHighlightedOption(this);
   }
 
   /**
@@ -1203,10 +1206,15 @@ class MenuService {
       return;
     }
 
+    const before = this.selectedOptions || [];
     const optionsSet = new Set(optionsToDeselect);
-    this.selectedOptions = (this.selectedOptions || [])
-      .filter(opt => !optionsSet.has(opt));
+    const after = before.filter(opt => !optionsSet.has(opt));
 
+    if (this.optionsArraysMatch(after, before)) {
+      return;
+    }
+
+    this.selectedOptions = after;
     this.stageUpdate();
   }
 
@@ -1302,6 +1310,16 @@ class MenuService {
         return;
       }
 
+      const hostValue = this.host && this.host.value;
+      const hostHasValue = hostValue !== undefined &&
+        hostValue !== null &&
+        (!Array.isArray(hostValue) || hostValue.length > 0) &&
+        (typeof hostValue !== 'string' || hostValue.trim() !== '');
+
+      if (hostHasValue && this._pendingValue != null) {
+        return;
+      }
+
       this.clearPendingValue();
 
       if (this.selectedOptions.length > 0) {
@@ -1482,6 +1500,9 @@ class MenuService {
     this.notify({ type: 'optionsChange', options: this._menuOptions });
 
     if (this._pendingValue != null) {
+      // Reset the retry count so a new option registration gives a fresh
+      // budget — the initial retries fired before delayed options arrived.
+      this._pendingRetryCount = 0;
       this.queuePendingValue(this._pendingValue);
     }
   }
@@ -1826,7 +1847,11 @@ class AuroMenu extends AuroElement {
    * @returns {string} - Returns the label of the currently selected option(s).
    */
   get currentLabel() {
-    return this.menuService.currentLabel;
+    const { menuService } = this;
+    if (!menuService) {
+      return '';
+    }
+    return menuService.currentLabel;
   };
 
   /**
@@ -1849,7 +1874,12 @@ class AuroMenu extends AuroElement {
    * @param {number} value - Sets the index of the currently active option.
    */
   set index(value) {
-    this.menuService.setHighlightedIndex(value);
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+
+    menuService.setHighlightedIndex(value);
   }
 
   /**
@@ -1871,7 +1901,11 @@ class AuroMenu extends AuroElement {
    * @returns {String|Array<String>}
    */
   get formattedValue() {
-    return this.menuService.currentValue;
+    const { menuService } = this;
+    if (!menuService) {
+      return '';
+    }
+    return menuService.currentValue;
   }
 
   /**
@@ -1915,7 +1949,11 @@ class AuroMenu extends AuroElement {
    * @param {HTMLElement} option - The option to set as active.
    */
   updateActiveOption(option) {
-    this.menuService.setHighlightedOption(option);
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+    menuService.setHighlightedOption(option);
   }
 
   /**
@@ -1943,7 +1981,8 @@ class AuroMenu extends AuroElement {
     if (event.type === 'valueChange') {
 
       // New option is array value or first option with fallback to undefined for empty array in all cases
-      const newOption = this.multiSelect && event.options.length ? event.options : event.options[0] || undefined;
+      const options = event.options || [];
+      const newOption = this.multiSelect && options.length ? options : options[0] || undefined;
       const newValue = event.stringValue;
 
       // Check if the option or value has actually changed
@@ -1952,8 +1991,11 @@ class AuroMenu extends AuroElement {
         this.setInternalValue(newValue);
       }
 
-      // Notify components of selection change
-      this.notifySelectionChange(event);
+      // Notify components of selection change (pass normalized options to avoid undefined iterability errors)
+      this.notifySelectionChange({
+        ...event,
+        options
+      });
     }
 
     if (event.type === 'highlightChange') {
@@ -1976,7 +2018,11 @@ class AuroMenu extends AuroElement {
    * @returns {Array<HTMLElement>}
    */
   get selectedOptions() {
-    return this.menuService ? this.menuService.selectedOptions : [];
+    const { menuService } = this;
+    if (!menuService) {
+      return [];
+    }
+    return menuService.selectedOptions;
   }
 
   /**
@@ -1984,7 +2030,11 @@ class AuroMenu extends AuroElement {
    * @returns {HTMLElement|null}
    */
   get selectedOption() {
-    return this.menuService ? this.menuService.selectedOptions[0] : null;
+    const { menuService } = this;
+    if (!menuService) {
+      return null;
+    }
+    return menuService.selectedOptions[0] || null;
   }
 
   // Lifecycle Methods
@@ -2028,7 +2078,11 @@ class AuroMenu extends AuroElement {
     // keys are not yet resolved (framework mount-order race), selectByValue
     // queues a bounded retry automatically via queuePendingValue.
     if (changedProperties.has('value') && !this.internalUpdateInProgress) {
-      this.menuService.selectByValue(this.value);
+      const { menuService } = this;
+      if (!menuService) {
+        return;
+      }
+      menuService.selectByValue(this.value);
     }
 
     // Handle loading state changes
@@ -2093,7 +2147,11 @@ class AuroMenu extends AuroElement {
    * @protected
    */
   makeSelection() {
-    this.menuService.selectHighlightedOption();
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+    menuService.selectHighlightedOption();
   }
 
   /**
@@ -2112,7 +2170,11 @@ class AuroMenu extends AuroElement {
    * @public
    */
   reset() {
-    this.menuService.reset();
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+    menuService.reset();
 
     // Dispatch reset event
     dispatchMenuEvent(this, 'auroMenu-selectValueReset');
@@ -2147,10 +2209,14 @@ class AuroMenu extends AuroElement {
    * @protected
    */
   navigateOptions(direction) {
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
     if (direction === 'up') {
-      this.menuService.highlightPrevious();
+      menuService.highlightPrevious();
     } else if (direction === 'down') {
-      this.menuService.highlightNext();
+      menuService.highlightNext();
     }
   }
 

package/components/menu/dist/registered.js

@@ -538,7 +538,7 @@ class AuroMenuOption extends AuroElement {
       this.setAttribute('aria-selected', this.selected.toString());
 
       // Update menu service selection state if this isn't an internal update
-      if (this.internalUpdateInProgress !== true) {
+      if (this.internalUpdateInProgress !== true && this.menuService) {
         this.menuService[this.selected ? 'selectOption' : 'deselectOption'](this);
       }
     }
@@ -573,9 +573,10 @@ class AuroMenuOption extends AuroElement {
   }
 
   disconnectedCallback() {
-    if (this.menuService) {
-      this.menuService.unsubscribe(this.handleMenuChange);
-      this.menuService.removeMenuOption(this);
+    const { menuService } = this;
+    if (menuService) {
+      menuService.unsubscribe(this.handleMenuChange);
+      menuService.removeMenuOption(this);
     }
   }
 
@@ -744,9 +745,11 @@ class AuroMenuOption extends AuroElement {
    * @private
    */
   handleMouseEnter() {
-    if (!this.disabled) {
-      this.menuService.setHighlightedOption(this);
+    const { menuService } = this;
+    if (!menuService || this.disabled) {
+      return;
     }
+    menuService.setHighlightedOption(this);
   }
 
   /**
@@ -1150,10 +1153,15 @@ class MenuService {
       return;
     }
 
+    const before = this.selectedOptions || [];
     const optionsSet = new Set(optionsToDeselect);
-    this.selectedOptions = (this.selectedOptions || [])
-      .filter(opt => !optionsSet.has(opt));
+    const after = before.filter(opt => !optionsSet.has(opt));
 
+    if (this.optionsArraysMatch(after, before)) {
+      return;
+    }
+
+    this.selectedOptions = after;
     this.stageUpdate();
   }
 
@@ -1249,6 +1257,16 @@ class MenuService {
         return;
       }
 
+      const hostValue = this.host && this.host.value;
+      const hostHasValue = hostValue !== undefined &&
+        hostValue !== null &&
+        (!Array.isArray(hostValue) || hostValue.length > 0) &&
+        (typeof hostValue !== 'string' || hostValue.trim() !== '');
+
+      if (hostHasValue && this._pendingValue != null) {
+        return;
+      }
+
       this.clearPendingValue();
 
       if (this.selectedOptions.length > 0) {
@@ -1429,6 +1447,9 @@ class MenuService {
     this.notify({ type: 'optionsChange', options: this._menuOptions });
 
     if (this._pendingValue != null) {
+      // Reset the retry count so a new option registration gives a fresh
+      // budget — the initial retries fired before delayed options arrived.
+      this._pendingRetryCount = 0;
       this.queuePendingValue(this._pendingValue);
     }
   }
@@ -1773,7 +1794,11 @@ class AuroMenu extends AuroElement {
    * @returns {string} - Returns the label of the currently selected option(s).
    */
   get currentLabel() {
-    return this.menuService.currentLabel;
+    const { menuService } = this;
+    if (!menuService) {
+      return '';
+    }
+    return menuService.currentLabel;
   };
 
   /**
@@ -1796,7 +1821,12 @@ class AuroMenu extends AuroElement {
    * @param {number} value - Sets the index of the currently active option.
    */
   set index(value) {
-    this.menuService.setHighlightedIndex(value);
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+
+    menuService.setHighlightedIndex(value);
   }
 
   /**
@@ -1818,7 +1848,11 @@ class AuroMenu extends AuroElement {
    * @returns {String|Array<String>}
    */
   get formattedValue() {
-    return this.menuService.currentValue;
+    const { menuService } = this;
+    if (!menuService) {
+      return '';
+    }
+    return menuService.currentValue;
   }
 
   /**
@@ -1862,7 +1896,11 @@ class AuroMenu extends AuroElement {
    * @param {HTMLElement} option - The option to set as active.
    */
   updateActiveOption(option) {
-    this.menuService.setHighlightedOption(option);
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+    menuService.setHighlightedOption(option);
   }
 
   /**
@@ -1890,7 +1928,8 @@ class AuroMenu extends AuroElement {
     if (event.type === 'valueChange') {
 
       // New option is array value or first option with fallback to undefined for empty array in all cases
-      const newOption = this.multiSelect && event.options.length ? event.options : event.options[0] || undefined;
+      const options = event.options || [];
+      const newOption = this.multiSelect && options.length ? options : options[0] || undefined;
       const newValue = event.stringValue;
 
       // Check if the option or value has actually changed
@@ -1899,8 +1938,11 @@ class AuroMenu extends AuroElement {
         this.setInternalValue(newValue);
       }
 
-      // Notify components of selection change
-      this.notifySelectionChange(event);
+      // Notify components of selection change (pass normalized options to avoid undefined iterability errors)
+      this.notifySelectionChange({
+        ...event,
+        options
+      });
     }
 
     if (event.type === 'highlightChange') {
@@ -1923,7 +1965,11 @@ class AuroMenu extends AuroElement {
    * @returns {Array<HTMLElement>}
    */
   get selectedOptions() {
-    return this.menuService ? this.menuService.selectedOptions : [];
+    const { menuService } = this;
+    if (!menuService) {
+      return [];
+    }
+    return menuService.selectedOptions;
   }
 
   /**
@@ -1931,7 +1977,11 @@ class AuroMenu extends AuroElement {
    * @returns {HTMLElement|null}
    */
   get selectedOption() {
-    return this.menuService ? this.menuService.selectedOptions[0] : null;
+    const { menuService } = this;
+    if (!menuService) {
+      return null;
+    }
+    return menuService.selectedOptions[0] || null;
   }
 
   // Lifecycle Methods
@@ -1975,7 +2025,11 @@ class AuroMenu extends AuroElement {
     // keys are not yet resolved (framework mount-order race), selectByValue
     // queues a bounded retry automatically via queuePendingValue.
     if (changedProperties.has('value') && !this.internalUpdateInProgress) {
-      this.menuService.selectByValue(this.value);
+      const { menuService } = this;
+      if (!menuService) {
+        return;
+      }
+      menuService.selectByValue(this.value);
     }
 
     // Handle loading state changes
@@ -2040,7 +2094,11 @@ class AuroMenu extends AuroElement {
    * @protected
    */
   makeSelection() {
-    this.menuService.selectHighlightedOption();
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+    menuService.selectHighlightedOption();
   }
 
   /**
@@ -2059,7 +2117,11 @@ class AuroMenu extends AuroElement {
    * @public
    */
   reset() {
-    this.menuService.reset();
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
+    menuService.reset();
 
     // Dispatch reset event
     dispatchMenuEvent(this, 'auroMenu-selectValueReset');
@@ -2094,10 +2156,14 @@ class AuroMenu extends AuroElement {
    * @protected
    */
   navigateOptions(direction) {
+    const { menuService } = this;
+    if (!menuService) {
+      return;
+    }
     if (direction === 'up') {
-      this.menuService.highlightPrevious();
+      menuService.highlightPrevious();
     } else if (direction === 'down') {
-      this.menuService.highlightNext();
+      menuService.highlightNext();
     }
   }
 

package/components/radio/demo/api.min.js

@@ -1645,7 +1645,7 @@ class AuroHelpText extends i$2 {
   }
 }
 
-var formkitVersion = '202604091453';
+var formkitVersion = '202604100244';
 
 // Copyright (c) Alaska Air. All right reserved. Licensed under the Apache-2.0 license
 // See LICENSE in the project root for license information.

package/components/radio/demo/index.min.js

@@ -1620,7 +1620,7 @@ class AuroHelpText extends i$2 {
   }
 }
 
-var formkitVersion = '202604091453';
+var formkitVersion = '202604100244';
 
 // Copyright (c) Alaska Air. All right reserved. Licensed under the Apache-2.0 license
 // See LICENSE in the project root for license information.

package/components/radio/dist/index.js

@@ -1573,7 +1573,7 @@ class AuroHelpText extends LitElement {
   }
 }
 
-var formkitVersion = '202604091453';
+var formkitVersion = '202604100244';
 
 // Copyright (c) Alaska Air. All right reserved. Licensed under the Apache-2.0 license
 // See LICENSE in the project root for license information.

package/components/radio/dist/registered.js

@@ -1573,7 +1573,7 @@ class AuroHelpText extends LitElement {
   }
 }
 
-var formkitVersion = '202604091453';
+var formkitVersion = '202604100244';
 
 // Copyright (c) Alaska Air. All right reserved. Licensed under the Apache-2.0 license
 // See LICENSE in the project root for license information.