@attalabs/vinaya 0.19.0 → 0.19.2

package/dist/checks/bin/check-brief-shape.js

@@ -562,6 +562,12 @@ function factsFromLegacyMilestone(milestone) {
     lifecycle: milestone.state === "closed" ? "complete" : "active"
   };
 }
+function resolveLegacyFacts(milestone, labelIssues) {
+  if (milestone.state === "closed" && labelIssues.length > 0) {
+    return { goal: milestone.description ?? "", lifecycle: lifecycleFromIssues(labelIssues) };
+  }
+  return factsFromLegacyMilestone(milestone);
+}
 function lifecycleFromIssues(issues) {
   if (issues.length === 0)
     return "planned";
@@ -578,9 +584,9 @@ function goalFromMilestones(milestones, slug) {
 function findMilestoneForSlug(owner, repo, slug) {
   const milestones = ghApiGet(`repos/${owner}/${repo}/milestones?state=all&per_page=100`);
   const legacy = matchesLegacyMilestone(milestones, slug);
-  if (legacy)
-    return factsFromLegacyMilestone(legacy);
   const issues = ghIssueListByLabel(owner, repo, trancheLabel(slug));
+  if (legacy)
+    return resolveLegacyFacts(legacy, issues);
   return { goal: goalFromMilestones(milestones, slug), lifecycle: lifecycleFromIssues(issues) };
 }
 
@@ -2767,16 +2773,18 @@ function checkDeadBranchPush(input) {
 }
 // ../../packages/aeg-core/src/reader-resolvable-prose.ts
 var SHIPS_PREFIX = "aeg-root/";
-var SHIPS_ARCHIVE_PREFIX = "aeg-root/tranches/completed/";
+function shipsArchivePrefix(shipsPrefix) {
+  return `${shipsPrefix}tranches/completed/`;
+}
 function isSpecFile2(path) {
   return path.startsWith("apps/") && path.includes("/specs/") && path.endsWith(".md");
 }
 function isClaudeMdFile(path) {
   return path === "CLAUDE.md" || path.endsWith("/CLAUDE.md");
 }
-function classifyProseFile(path, readerFacingPrefix, readerFacingSuffix) {
-  if (path.startsWith(SHIPS_PREFIX)) {
-    return path.startsWith(SHIPS_ARCHIVE_PREFIX) ? "internal" : "ships";
+function classifyProseFile(path, readerFacingPrefix, readerFacingSuffix, shipsPrefix = SHIPS_PREFIX) {
+  if (path.startsWith(shipsPrefix)) {
+    return path.startsWith(shipsArchivePrefix(shipsPrefix)) ? "internal" : "ships";
   }
   if (path.startsWith(readerFacingPrefix) && path.endsWith(readerFacingSuffix)) {
     return "reader-facing";
@@ -2811,7 +2819,7 @@ function legacySlugPattern(legacySlugs) {
   const alternation = legacySlugs.map((s) => s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")).join("|");
   return new RegExp(`(^|[^a-zA-Z0-9\\n-])(${alternation})([^a-zA-Z0-9\\n-]|$)`, "g");
 }
-function checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs = []) {
+function checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs = [], shipsPrefix = SHIPS_PREFIX) {
   const findings = [];
   const legacyPattern = legacySlugPattern(legacySlugs);
   const patterns = [
@@ -2820,7 +2828,7 @@ function checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuff
     ...legacyPattern ? [{ pattern: legacyPattern, what: "an internal tranche slug", group: 2 }] : []
   ];
   for (const file of files) {
-    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix);
+    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix, shipsPrefix);
     if (!cls || !SWEPT_CLASSES.has(cls))
       continue;
     const scrubbed = stripNonProse(file.path, file.content);
@@ -2866,10 +2874,10 @@ function definesOrLinksGlossary(content, term) {
     return true;
   return /docs\/glossary|glossary\.md/i.test(content);
 }
-function checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix) {
+function checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, shipsPrefix = SHIPS_PREFIX) {
   const findings = [];
   for (const file of files) {
-    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix);
+    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix, shipsPrefix);
     if (!cls || !SWEPT_CLASSES.has(cls))
       continue;
     const scrubbed = stripNonProse(file.path, file.content);
@@ -2888,10 +2896,10 @@ function checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, read
   }
   return findings;
 }
-function checkReaderResolvableProse(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, legacySlugs = []) {
+function checkReaderResolvableProse(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, legacySlugs = [], shipsPrefix = SHIPS_PREFIX) {
   return [
-    ...checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs),
-    ...checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix)
+    ...checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs, shipsPrefix),
+    ...checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, shipsPrefix)
   ];
 }
 function parseGlossaryTerms(glossaryContent) {
@@ -2905,6 +2913,101 @@ function parseGlossaryTerms(glossaryContent) {
   }
   return terms;
 }
+// ../../packages/aeg-core/src/retired-vocabulary.ts
+var RETIRED_PATTERNS = [
+  String.raw`\bD-[0-9]{3}\b`,
+  "D-(###|NNN|nnn|xxx)",
+  "decision (entry|logged)",
+  "decision-log entry",
+  "decision log entry",
+  "decision log(s|ged|ging)?([^a-z]|$)",
+  "decision-log",
+  "decision entr",
+  "decisions? (are |is )?logged",
+  "log entries",
+  String.raw`decisions\.md`,
+  "decisions-legacy",
+  "CONTRADICTION",
+  "assumes Tier 3",
+  "Lock: ?YES",
+  "Lock: ?NO",
+  "lock approvals?",
+  "approves locks",
+  "Conforms to lock",
+  "Challenges lock",
+  "checkDecisionNumbersFresh",
+  String.raw`roles/team-leader\.md`,
+  String.raw`\(,`,
+  String.raw`,\)`,
+  String.raw`\(\.\)`
+];
+var RETIRED_EXEMPT_SUBSTRINGS = [
+  "docs/decisions-legacy.md",
+  "apps/herald-ai/docs/",
+  "apps/vada-ai/docs/",
+  "aeg-root/tranches/completed/",
+  "packages/aeg-core/src/docs/published-prose",
+  "packages/aeg-core/src/retired-vocabulary.test.ts",
+  "packages/aeg-core/src/retired-vocabulary.ts",
+  "/fixtures/",
+  "/node_modules/",
+  "/.next/",
+  "/.turbo/"
+];
+var PATTERN_EXEMPT = {
+  [String.raw`\bD-[0-9]{3}\b`]: ["./CLAUDE.md"],
+  [String.raw`decisions\.md`]: [
+    "docs-index.md",
+    "apps/vada-ai/specs/legacy/README.md",
+    "apps/vada-ai/specs/vada-product-spec.md",
+    "apps/vada-ai/web/CLAUDE.md",
+    "apps/vada-ai/CLAUDE.md"
+  ],
+  "decisions-legacy": [
+    "packages/aeg-core/src/file-classify.ts",
+    "packages/aeg-core/src/file-classify.test.ts",
+    "packages/aeg-core/src/pr-tier.test.ts",
+    "docs-index.md",
+    ".claude/skills/database/SKILL.md",
+    ".claude/skills/vada-architecture/SKILL.md",
+    "apps/vada-ai/specs/vada-byok-principles.md",
+    "apps/vada-ai/web/CLAUDE.md",
+    "apps/vada-ai/CLAUDE.md"
+  ],
+  CONTRADICTION: ["apps/vada-ai/specs/vada-reviewers-spec.md"]
+};
+function lineNumbers(content, pattern) {
+  const out = [];
+  const lines = content.split(`
+`);
+  for (let i = 0;i < lines.length; i++) {
+    if (pattern.test(lines[i] ?? ""))
+      out.push(i + 1);
+  }
+  return out;
+}
+function scanRetiredVocabulary(files) {
+  const findings = [];
+  for (const file of files) {
+    if (RETIRED_EXEMPT_SUBSTRINGS.some((e) => file.path.includes(e)))
+      continue;
+    for (const pattern of RETIRED_PATTERNS) {
+      const patternExempt = PATTERN_EXEMPT[pattern] ?? [];
+      if (patternExempt.some((e) => file.path.includes(e)))
+        continue;
+      const re = new RegExp(pattern);
+      for (const line of lineNumbers(file.content, re)) {
+        findings.push({
+          file: file.path,
+          line,
+          pattern,
+          message: `claims a retired AEG mechanism is still live (matches /${pattern}/)`
+        });
+      }
+    }
+  }
+  return findings;
+}
 // ../../packages/aeg-core/src/dispatch-gate.ts
 function isHandClosedByRecognizedPrincipal(dep, principalAllowlist) {
   return dep.issueState === "closed" && dep.stateReason === "completed" && isPrincipal(dep.closedByActor ?? null, principalAllowlist);

package/dist/checks/bin/check-closes-n.js

@@ -565,6 +565,12 @@ function factsFromLegacyMilestone(milestone) {
     lifecycle: milestone.state === "closed" ? "complete" : "active"
   };
 }
+function resolveLegacyFacts(milestone, labelIssues) {
+  if (milestone.state === "closed" && labelIssues.length > 0) {
+    return { goal: milestone.description ?? "", lifecycle: lifecycleFromIssues(labelIssues) };
+  }
+  return factsFromLegacyMilestone(milestone);
+}
 function lifecycleFromIssues(issues) {
   if (issues.length === 0)
     return "planned";
@@ -581,9 +587,9 @@ function goalFromMilestones(milestones, slug) {
 function findMilestoneForSlug(owner, repo, slug) {
   const milestones = ghApiGet(`repos/${owner}/${repo}/milestones?state=all&per_page=100`);
   const legacy = matchesLegacyMilestone(milestones, slug);
-  if (legacy)
-    return factsFromLegacyMilestone(legacy);
   const issues = ghIssueListByLabel(owner, repo, trancheLabel(slug));
+  if (legacy)
+    return resolveLegacyFacts(legacy, issues);
   return { goal: goalFromMilestones(milestones, slug), lifecycle: lifecycleFromIssues(issues) };
 }
 
@@ -2770,16 +2776,18 @@ function checkDeadBranchPush(input) {
 }
 // ../../packages/aeg-core/src/reader-resolvable-prose.ts
 var SHIPS_PREFIX = "aeg-root/";
-var SHIPS_ARCHIVE_PREFIX = "aeg-root/tranches/completed/";
+function shipsArchivePrefix(shipsPrefix) {
+  return `${shipsPrefix}tranches/completed/`;
+}
 function isSpecFile2(path) {
   return path.startsWith("apps/") && path.includes("/specs/") && path.endsWith(".md");
 }
 function isClaudeMdFile(path) {
   return path === "CLAUDE.md" || path.endsWith("/CLAUDE.md");
 }
-function classifyProseFile(path, readerFacingPrefix, readerFacingSuffix) {
-  if (path.startsWith(SHIPS_PREFIX)) {
-    return path.startsWith(SHIPS_ARCHIVE_PREFIX) ? "internal" : "ships";
+function classifyProseFile(path, readerFacingPrefix, readerFacingSuffix, shipsPrefix = SHIPS_PREFIX) {
+  if (path.startsWith(shipsPrefix)) {
+    return path.startsWith(shipsArchivePrefix(shipsPrefix)) ? "internal" : "ships";
   }
   if (path.startsWith(readerFacingPrefix) && path.endsWith(readerFacingSuffix)) {
     return "reader-facing";
@@ -2814,7 +2822,7 @@ function legacySlugPattern(legacySlugs) {
   const alternation = legacySlugs.map((s) => s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")).join("|");
   return new RegExp(`(^|[^a-zA-Z0-9\\n-])(${alternation})([^a-zA-Z0-9\\n-]|$)`, "g");
 }
-function checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs = []) {
+function checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs = [], shipsPrefix = SHIPS_PREFIX) {
   const findings = [];
   const legacyPattern = legacySlugPattern(legacySlugs);
   const patterns = [
@@ -2823,7 +2831,7 @@ function checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuff
     ...legacyPattern ? [{ pattern: legacyPattern, what: "an internal tranche slug", group: 2 }] : []
   ];
   for (const file of files) {
-    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix);
+    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix, shipsPrefix);
     if (!cls || !SWEPT_CLASSES.has(cls))
       continue;
     const scrubbed = stripNonProse(file.path, file.content);
@@ -2869,10 +2877,10 @@ function definesOrLinksGlossary(content, term) {
     return true;
   return /docs\/glossary|glossary\.md/i.test(content);
 }
-function checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix) {
+function checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, shipsPrefix = SHIPS_PREFIX) {
   const findings = [];
   for (const file of files) {
-    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix);
+    const cls = classifyProseFile(file.path, readerFacingPrefix, readerFacingSuffix, shipsPrefix);
     if (!cls || !SWEPT_CLASSES.has(cls))
       continue;
     const scrubbed = stripNonProse(file.path, file.content);
@@ -2891,10 +2899,10 @@ function checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, read
   }
   return findings;
 }
-function checkReaderResolvableProse(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, legacySlugs = []) {
+function checkReaderResolvableProse(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, legacySlugs = [], shipsPrefix = SHIPS_PREFIX) {
   return [
-    ...checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs),
-    ...checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix)
+    ...checkUnresolvableReferences(files, readerFacingPrefix, readerFacingSuffix, legacySlugs, shipsPrefix),
+    ...checkUndefinedVocabulary(files, glossaryTerms, readerFacingPrefix, readerFacingSuffix, shipsPrefix)
   ];
 }
 function parseGlossaryTerms(glossaryContent) {
@@ -2908,6 +2916,101 @@ function parseGlossaryTerms(glossaryContent) {
   }
   return terms;
 }
+// ../../packages/aeg-core/src/retired-vocabulary.ts
+var RETIRED_PATTERNS = [
+  String.raw`\bD-[0-9]{3}\b`,
+  "D-(###|NNN|nnn|xxx)",
+  "decision (entry|logged)",
+  "decision-log entry",
+  "decision log entry",
+  "decision log(s|ged|ging)?([^a-z]|$)",
+  "decision-log",
+  "decision entr",
+  "decisions? (are |is )?logged",
+  "log entries",
+  String.raw`decisions\.md`,
+  "decisions-legacy",
+  "CONTRADICTION",
+  "assumes Tier 3",
+  "Lock: ?YES",
+  "Lock: ?NO",
+  "lock approvals?",
+  "approves locks",
+  "Conforms to lock",
+  "Challenges lock",
+  "checkDecisionNumbersFresh",
+  String.raw`roles/team-leader\.md`,
+  String.raw`\(,`,
+  String.raw`,\)`,
+  String.raw`\(\.\)`
+];
+var RETIRED_EXEMPT_SUBSTRINGS = [
+  "docs/decisions-legacy.md",
+  "apps/herald-ai/docs/",
+  "apps/vada-ai/docs/",
+  "aeg-root/tranches/completed/",
+  "packages/aeg-core/src/docs/published-prose",
+  "packages/aeg-core/src/retired-vocabulary.test.ts",
+  "packages/aeg-core/src/retired-vocabulary.ts",
+  "/fixtures/",
+  "/node_modules/",
+  "/.next/",
+  "/.turbo/"
+];
+var PATTERN_EXEMPT = {
+  [String.raw`\bD-[0-9]{3}\b`]: ["./CLAUDE.md"],
+  [String.raw`decisions\.md`]: [
+    "docs-index.md",
+    "apps/vada-ai/specs/legacy/README.md",
+    "apps/vada-ai/specs/vada-product-spec.md",
+    "apps/vada-ai/web/CLAUDE.md",
+    "apps/vada-ai/CLAUDE.md"
+  ],
+  "decisions-legacy": [
+    "packages/aeg-core/src/file-classify.ts",
+    "packages/aeg-core/src/file-classify.test.ts",
+    "packages/aeg-core/src/pr-tier.test.ts",
+    "docs-index.md",
+    ".claude/skills/database/SKILL.md",
+    ".claude/skills/vada-architecture/SKILL.md",
+    "apps/vada-ai/specs/vada-byok-principles.md",
+    "apps/vada-ai/web/CLAUDE.md",
+    "apps/vada-ai/CLAUDE.md"
+  ],
+  CONTRADICTION: ["apps/vada-ai/specs/vada-reviewers-spec.md"]
+};
+function lineNumbers(content, pattern) {
+  const out = [];
+  const lines = content.split(`
+`);
+  for (let i = 0;i < lines.length; i++) {
+    if (pattern.test(lines[i] ?? ""))
+      out.push(i + 1);
+  }
+  return out;
+}
+function scanRetiredVocabulary(files) {
+  const findings = [];
+  for (const file of files) {
+    if (RETIRED_EXEMPT_SUBSTRINGS.some((e) => file.path.includes(e)))
+      continue;
+    for (const pattern of RETIRED_PATTERNS) {
+      const patternExempt = PATTERN_EXEMPT[pattern] ?? [];
+      if (patternExempt.some((e) => file.path.includes(e)))
+        continue;
+      const re = new RegExp(pattern);
+      for (const line of lineNumbers(file.content, re)) {
+        findings.push({
+          file: file.path,
+          line,
+          pattern,
+          message: `claims a retired AEG mechanism is still live (matches /${pattern}/)`
+        });
+      }
+    }
+  }
+  return findings;
+}
 // ../../packages/aeg-core/src/dispatch-gate.ts
 function isHandClosedByRecognizedPrincipal(dep, principalAllowlist) {
   return dep.issueState === "closed" && dep.stateReason === "completed" && isPrincipal(dep.closedByActor ?? null, principalAllowlist);