@atproto/lex-schema 0.0.4 → 0.0.6

package/src/schema/permission-set.test.ts

@@ -1,11 +1,12 @@
-import { asNsid } from '../core.js'
+import { describe, expect, it } from 'vitest'
+import { asNsidString } from '../core.js'
 import { PermissionSet } from './permission-set.js'
 import { Permission } from './permission.js'
 
 describe('PermissionSet', () => {
   describe('constructor', () => {
     it('creates a PermissionSet instance with all parameters', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.post:write', {}),
@@ -24,7 +25,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with minimal options', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -39,7 +40,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with empty permissions array', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [] as const
       const options = {}
 
@@ -50,7 +51,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with title only', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.like:read', {}),
       ] as const
@@ -65,7 +66,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with detail only', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.like:read', {}),
       ] as const
@@ -80,7 +81,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with localized titles', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -102,7 +103,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with localized details', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -124,7 +125,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet instance with all options including localization', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.post:write', {}),
@@ -165,7 +166,7 @@ describe('PermissionSet', () => {
 
   describe('property immutability', () => {
     it('options object itself is mutable', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -181,7 +182,7 @@ describe('PermissionSet', () => {
 
   describe('with multiple permissions', () => {
     it('creates a PermissionSet with multiple read permissions', () => {
-      const nsid = asNsid('app.bsky.oauth.read')
+      const nsid = asNsidString('app.bsky.oauth.read')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.like:read', {}),
@@ -211,7 +212,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet with mixed read/write permissions', () => {
-      const nsid = asNsid('app.bsky.oauth.full')
+      const nsid = asNsidString('app.bsky.oauth.full')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.post:write', {}),
@@ -229,7 +230,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a PermissionSet with a single permission', () => {
-      const nsid = asNsid('app.bsky.oauth.limited')
+      const nsid = asNsidString('app.bsky.oauth.limited')
       const permissions = [
         new Permission('app.bsky.actor.profile:read', {}),
       ] as const
@@ -249,7 +250,7 @@ describe('PermissionSet', () => {
 
   describe('edge cases', () => {
     it('handles very long NSID', () => {
-      const nsid = asNsid(
+      const nsid = asNsidString(
         'com.example.very.long.namespace.identifier.oauth.permissions',
       )
       const permissions = [new Permission('resource:action', {})] as const
@@ -261,7 +262,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles long title strings', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -277,7 +278,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles long detail strings', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -293,7 +294,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles multiple language codes in title:lang', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -319,7 +320,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles undefined values in title:lang', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -342,7 +343,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles undefined values in detail:lang', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -363,7 +364,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles special characters in title', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -379,7 +380,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles special characters in detail', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -396,7 +397,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles unicode characters in title', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -410,7 +411,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles empty strings in title', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -424,7 +425,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles empty strings in detail', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -438,7 +439,7 @@ describe('PermissionSet', () => {
     })
 
     it('handles large number of permissions', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = Array.from(
         { length: 100 },
         (_, i) => new Permission(`resource${i}:action`, {}),
@@ -453,7 +454,7 @@ describe('PermissionSet', () => {
 
   describe('real-world permission set examples', () => {
     it('creates a feed management permission set', () => {
-      const nsid = asNsid('app.bsky.oauth.feed')
+      const nsid = asNsidString('app.bsky.oauth.feed')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.post:write', {}),
@@ -483,7 +484,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a read-only permission set', () => {
-      const nsid = asNsid('app.bsky.oauth.readonly')
+      const nsid = asNsidString('app.bsky.oauth.readonly')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.like:read', {}),
@@ -504,7 +505,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a profile management permission set', () => {
-      const nsid = asNsid('app.bsky.oauth.profile')
+      const nsid = asNsidString('app.bsky.oauth.profile')
       const permissions = [
         new Permission('app.bsky.actor.profile:read', {}),
         new Permission('app.bsky.actor.profile:write', {}),
@@ -531,7 +532,7 @@ describe('PermissionSet', () => {
     })
 
     it('creates a minimal permission set', () => {
-      const nsid = asNsid('app.bsky.oauth.minimal')
+      const nsid = asNsidString('app.bsky.oauth.minimal')
       const permissions = [
         new Permission('app.bsky.actor.profile:read', {}),
       ] as const
@@ -549,7 +550,7 @@ describe('PermissionSet', () => {
 
   describe('permission validation', () => {
     it('validates that permissions are Permission instances', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permission1 = new Permission('app.bsky.feed.post:read', {})
       const permission2 = new Permission('app.bsky.feed.post:write', {})
       const permissions = [permission1, permission2] as const
@@ -562,7 +563,7 @@ describe('PermissionSet', () => {
     })
 
     it('preserves permission resource strings', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
         new Permission('app.bsky.feed.like:write', {}),
@@ -584,7 +585,7 @@ describe('PermissionSet', () => {
     })
 
     it('preserves permission options', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissionOptions = { custom: 'value' }
       const permissions = [
         new Permission('app.bsky.feed.post:read', permissionOptions),
@@ -599,7 +600,7 @@ describe('PermissionSet', () => {
 
   describe('option variations', () => {
     it('accepts title without detail', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -616,7 +617,7 @@ describe('PermissionSet', () => {
     })
 
     it('accepts detail without title', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -635,7 +636,7 @@ describe('PermissionSet', () => {
     })
 
     it('accepts title:lang without title', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const
@@ -656,7 +657,7 @@ describe('PermissionSet', () => {
     })
 
     it('accepts detail:lang without detail', () => {
-      const nsid = asNsid('app.bsky.oauth.permissions')
+      const nsid = asNsidString('app.bsky.oauth.permissions')
       const permissions = [
         new Permission('app.bsky.feed.post:read', {}),
       ] as const

package/src/schema/permission.test.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it } from 'vitest'
 import { Permission } from './permission.js'
 
 describe('Permission', () => {

package/src/schema/procedure.test.ts

@@ -1,12 +1,8 @@
+import { describe, expect, it } from 'vitest'
 import { ObjectSchema } from './object.js'
 import { ParamsSchema } from './params.js'
 import { Payload } from './payload.js'
-import {
-  InferProcedureInputBody,
-  InferProcedureOutputBody,
-  InferProcedureParameters,
-  Procedure,
-} from './procedure.js'
+import { Procedure } from './procedure.js'
 import { StringSchema } from './string.js'
 
 describe('Procedure', () => {
@@ -288,62 +284,6 @@ describe('Procedure', () => {
     })
   })
 
-  describe('type inference helpers', () => {
-    it('infers procedure parameters type', () => {
-      const parameters = new ParamsSchema({
-        limit: new StringSchema({}),
-      })
-      const procedure = new Procedure(
-        'com.example.list',
-        parameters,
-        new Payload(undefined, undefined),
-        new Payload(undefined, undefined),
-        undefined,
-      )
-
-      type Params = InferProcedureParameters<typeof procedure>
-      // Type test - this will fail at compile time if inference is wrong
-      const params: Params = { limit: 'test' }
-      expect(params).toBeDefined()
-    })
-
-    it('infers procedure input body type', () => {
-      const inputSchema = new ObjectSchema({
-        text: new StringSchema({}),
-      })
-      const procedure = new Procedure(
-        'com.example.create',
-        new ParamsSchema({}),
-        new Payload('application/json', inputSchema),
-        new Payload(undefined, undefined),
-        undefined,
-      )
-
-      type InputBody = InferProcedureInputBody<typeof procedure>
-      // Type test - this will fail at compile time if inference is wrong
-      const input: InputBody = { text: 'hello' }
-      expect(input).toBeDefined()
-    })
-
-    it('infers procedure output body type', () => {
-      const outputSchema = new ObjectSchema({
-        uri: new StringSchema({}),
-      })
-      const procedure = new Procedure(
-        'com.example.get',
-        new ParamsSchema({}),
-        new Payload(undefined, undefined),
-        new Payload('application/json', outputSchema),
-        undefined,
-      )
-
-      type OutputBody = InferProcedureOutputBody<typeof procedure>
-      // Type test - this will fail at compile time if inference is wrong
-      const output: OutputBody = { uri: 'at://did:plc:abc/post/123' }
-      expect(output).toBeDefined()
-    })
-  })
-
   describe('property access', () => {
     it('provides access to all properties', () => {
       const nsid = 'com.example.test'

package/src/schema/procedure.ts

@@ -1,28 +1,16 @@
 import { NsidString } from '../core.js'
-import { Infer } from '../validation.js'
 import { ParamsSchema } from './params.js'
-import { InferPayloadBody, Payload } from './payload.js'
-
-export type InferProcedureParameters<Q extends Procedure> =
-  Q extends Procedure<any, infer P extends ParamsSchema, any> ? Infer<P> : never
-
-export type InferProcedureInputBody<Q extends Procedure> =
-  Q extends Procedure<any, any, infer I extends Payload, any>
-    ? InferPayloadBody<I>
-    : never
-
-export type InferProcedureOutputBody<Q extends Procedure> =
-  Q extends Procedure<any, any, any, infer O extends Payload>
-    ? InferPayloadBody<O>
-    : never
+import { Payload } from './payload.js'
 
 export class Procedure<
-  TNsid extends NsidString = any,
-  TParameters extends ParamsSchema = any,
-  TInputPayload extends Payload = any,
-  TOutputPayload extends Payload = any,
-  TErrors extends undefined | readonly string[] = any,
+  TNsid extends NsidString = NsidString,
+  TParameters extends ParamsSchema = ParamsSchema,
+  TInputPayload extends Payload = Payload,
+  TOutputPayload extends Payload = Payload,
+  TErrors extends undefined | readonly string[] = undefined | readonly string[],
 > {
+  readonly type = 'procedure' as const
+
   constructor(
     readonly nsid: TNsid,
     readonly parameters: TParameters,

package/src/schema/query.test.ts

@@ -1,16 +1,17 @@
-import { asNsid } from '../core.js'
+import { describe, expect, it } from 'vitest'
+import { asNsidString } from '../core.js'
 import { IntegerSchema } from './integer.js'
 import { ObjectSchema } from './object.js'
 import { OptionalSchema } from './optional.js'
 import { ParamsSchema } from './params.js'
 import { Payload } from './payload.js'
-import { InferQueryOutputBody, InferQueryParameters, Query } from './query.js'
+import { Query } from './query.js'
 import { StringSchema } from './string.js'
 
 describe('Query', () => {
   describe('constructor', () => {
     it('creates a Query instance with all parameters', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({
         feed: new StringSchema({ format: 'at-uri' }),
         limit: new OptionalSchema(
@@ -35,7 +36,7 @@ describe('Query', () => {
     })
 
     it('creates a Query instance without errors', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({
         feed: new StringSchema({ format: 'at-uri' }),
       })
@@ -56,7 +57,7 @@ describe('Query', () => {
     })
 
     it('creates a Query instance with empty parameters', () => {
-      const nsid = asNsid('app.bsky.actor.getProfile')
+      const nsid = asNsidString('app.bsky.actor.getProfile')
       const parameters = new ParamsSchema({})
       const output = new Payload(
         'application/json',
@@ -74,7 +75,7 @@ describe('Query', () => {
 
   describe('properties', () => {
     it('has nsid property', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({})
       const output = new Payload('application/json', undefined)
 
@@ -85,7 +86,7 @@ describe('Query', () => {
     })
 
     it('has parameters property', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({
         feed: new StringSchema({ format: 'at-uri' }),
       })
@@ -98,7 +99,7 @@ describe('Query', () => {
     })
 
     it('has output property', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({})
       const output = new Payload('application/json', undefined)
 
@@ -109,7 +110,7 @@ describe('Query', () => {
     })
 
     it('has errors property', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({})
       const output = new Payload('application/json', undefined)
       const errors = ['NotFound', 'RateLimitExceeded'] as const
@@ -123,7 +124,7 @@ describe('Query', () => {
 
   describe('with complex parameters', () => {
     it('creates a Query with multiple parameter types', () => {
-      const nsid = asNsid('app.bsky.feed.searchPosts')
+      const nsid = asNsidString('app.bsky.feed.searchPosts')
       const parameters = new ParamsSchema({
         q: new StringSchema({ minLength: 1 }),
         limit: new OptionalSchema(
@@ -151,7 +152,7 @@ describe('Query', () => {
 
   describe('with various output payloads', () => {
     it('creates a Query with undefined output payload', () => {
-      const nsid = asNsid('app.bsky.actor.getProfile')
+      const nsid = asNsidString('app.bsky.actor.getProfile')
       const parameters = new ParamsSchema({
         actor: new StringSchema({ format: 'at-identifier' }),
       })
@@ -165,7 +166,7 @@ describe('Query', () => {
     })
 
     it('creates a Query with JSON payload', () => {
-      const nsid = asNsid('app.bsky.actor.getProfile')
+      const nsid = asNsidString('app.bsky.actor.getProfile')
       const parameters = new ParamsSchema({
         actor: new StringSchema({ format: 'at-identifier' }),
       })
@@ -185,7 +186,7 @@ describe('Query', () => {
     })
 
     it('creates a Query with text payload', () => {
-      const nsid = asNsid('app.bsky.feed.getPost')
+      const nsid = asNsidString('app.bsky.feed.getPost')
       const parameters = new ParamsSchema({
         uri: new StringSchema({ format: 'at-uri' }),
       })
@@ -200,7 +201,7 @@ describe('Query', () => {
 
   describe('with different error configurations', () => {
     it('creates a Query with a single error', () => {
-      const nsid = asNsid('app.bsky.feed.getPost')
+      const nsid = asNsidString('app.bsky.feed.getPost')
       const parameters = new ParamsSchema({})
       const output = new Payload('application/json', undefined)
       const errors = ['NotFound'] as const
@@ -211,7 +212,7 @@ describe('Query', () => {
     })
 
     it('creates a Query with multiple errors', () => {
-      const nsid = asNsid('app.bsky.feed.getPost')
+      const nsid = asNsidString('app.bsky.feed.getPost')
       const parameters = new ParamsSchema({})
       const output = new Payload('application/json', undefined)
       const errors = ['NotFound', 'Unauthorized', 'RateLimitExceeded'] as const
@@ -226,7 +227,7 @@ describe('Query', () => {
     })
 
     it('creates a Query with empty errors array', () => {
-      const nsid = asNsid('app.bsky.feed.getPost')
+      const nsid = asNsidString('app.bsky.feed.getPost')
       const parameters = new ParamsSchema({})
       const output = new Payload('application/json', undefined)
       const errors = [] as const
@@ -237,56 +238,9 @@ describe('Query', () => {
     })
   })
 
-  describe('type inference', () => {
-    it('InferQueryParameters correctly infers parameter types', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
-      const parameters = new ParamsSchema({
-        feed: new StringSchema({ format: 'at-uri' }),
-        limit: new OptionalSchema(new IntegerSchema({})),
-      })
-      const output = new Payload('application/json', undefined)
-
-      const query = new Query(nsid, parameters, output, undefined)
-
-      type Params = InferQueryParameters<typeof query>
-
-      // Type-level test - this should compile without errors
-      const params: Params = {
-        feed: 'at://did:plc:abc123/app.bsky.feed.post/xyz',
-        limit: 50,
-      }
-
-      expect(params.feed).toBeDefined()
-    })
-
-    it('InferQueryOutputBody correctly infers output body type', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
-      const parameters = new ParamsSchema({})
-      const output = new Payload(
-        'application/json',
-        new ObjectSchema({
-          cursor: new OptionalSchema(new StringSchema({})),
-          feed: new StringSchema({ format: 'at-uri' }),
-        }),
-      )
-
-      const query = new Query(nsid, parameters, output, undefined)
-
-      type OutputBody = InferQueryOutputBody<typeof query>
-
-      // Type-level test - this should compile without errors
-      const outputBody: OutputBody = {
-        cursor: 'abc123',
-        feed: 'at://did:plc:abc123/app.bsky.feed.post/xyz',
-      }
-
-      expect(outputBody.feed).toBeDefined()
-    })
-  })
-
   describe('edge cases', () => {
     it('handles very long NSID', () => {
-      const nsid = asNsid(
+      const nsid = asNsidString(
         'com.example.very.long.namespace.identifier.method.name',
       )
       const parameters = new ParamsSchema({})
@@ -298,7 +252,7 @@ describe('Query', () => {
     })
 
     it('handles query with all optional parameters', () => {
-      const nsid = asNsid('app.bsky.feed.search')
+      const nsid = asNsidString('app.bsky.feed.search')
       const parameters = new ParamsSchema({
         q: new OptionalSchema(new StringSchema({})),
         limit: new OptionalSchema(new IntegerSchema({})),
@@ -312,7 +266,7 @@ describe('Query', () => {
     })
 
     it('handles query with complex nested output schema', () => {
-      const nsid = asNsid('app.bsky.feed.getTimeline')
+      const nsid = asNsidString('app.bsky.feed.getTimeline')
       const parameters = new ParamsSchema({})
       const output = new Payload(
         'application/json',
@@ -335,7 +289,7 @@ describe('Query', () => {
 
   describe('real-world query examples', () => {
     it('creates a getFeedSkeleton query', () => {
-      const nsid = asNsid('app.bsky.feed.getFeedSkeleton')
+      const nsid = asNsidString('app.bsky.feed.getFeedSkeleton')
       const parameters = new ParamsSchema({
         feed: new StringSchema({ format: 'at-uri' }),
         limit: new OptionalSchema(
@@ -357,7 +311,7 @@ describe('Query', () => {
     })
 
     it('creates a searchPosts query', () => {
-      const nsid = asNsid('app.bsky.feed.searchPosts')
+      const nsid = asNsidString('app.bsky.feed.searchPosts')
       const parameters = new ParamsSchema({
         q: new StringSchema({ minLength: 1, maxLength: 300 }),
         limit: new OptionalSchema(
@@ -382,7 +336,7 @@ describe('Query', () => {
     })
 
     it('creates a getProfile query', () => {
-      const nsid = asNsid('app.bsky.actor.getProfile')
+      const nsid = asNsidString('app.bsky.actor.getProfile')
       const parameters = new ParamsSchema({
         actor: new StringSchema({ format: 'at-identifier' }),
       })