@atproto/common 0.5.13 → 0.5.14

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @atproto/common
 
+## 0.5.14
+
+### Patch Changes
+
+- [#4689](https://github.com/bluesky-social/atproto/pull/4689) [`f7c2610`](https://github.com/bluesky-social/atproto/commit/f7c26103a6d4e24e5bedbb6fd908be140420e0dd) Thanks [@matthieusieben](https://github.com/matthieusieben)! - Remove unnecessary validation of already properly formatted ISO date string
+
+- Updated dependencies [[`52834ab`](https://github.com/bluesky-social/atproto/commit/52834aba182da8df3611fd9dff924e6c6a3973a7), [`f7c2610`](https://github.com/bluesky-social/atproto/commit/f7c26103a6d4e24e5bedbb6fd908be140420e0dd), [`f7c2610`](https://github.com/bluesky-social/atproto/commit/f7c26103a6d4e24e5bedbb6fd908be140420e0dd), [`52834ab`](https://github.com/bluesky-social/atproto/commit/52834aba182da8df3611fd9dff924e6c6a3973a7)]:
+  - @atproto/lex-data@0.0.13
+  - @atproto/common-web@0.4.18
+  - @atproto/lex-cbor@0.0.14
+
 ## 0.5.13
 
 ### Patch Changes

package/dist/dates.d.ts

@@ -1,2 +1,2 @@
-export declare function toSimplifiedISOSafe(dateStr: string): `${string}-${string}-${string}T${string}:${string}:${string}Z`;
+export declare function toSimplifiedISOSafe(dateStr: string): string;
 //# sourceMappingURL=dates.d.ts.map

package/dist/dates.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dates.d.ts","sourceRoot":"","sources":["../src/dates.ts"],"names":[],"mappings":"AAIA,wBAAgB,mBAAmB,CAAC,OAAO,EAAE,MAAM,kEAWlD"}
+{"version":3,"file":"dates.d.ts","sourceRoot":"","sources":["../src/dates.ts"],"names":[],"mappings":"AAEA,wBAAgB,mBAAmB,CAAC,OAAO,EAAE,MAAM,UAiBlD"}

package/dist/dates.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.toSimplifiedISOSafe = toSimplifiedISOSafe;
-const iso_datestring_validator_1 = require("iso-datestring-validator");
 // Normalize date strings to simplified ISO so that the lexical sort preserves temporal sort.
 // Rather than failing on an invalid date format, returns valid unix epoch.
 function toSimplifiedISOSafe(dateStr) {
@@ -10,8 +9,12 @@ function toSimplifiedISOSafe(dateStr) {
         return new Date(0).toISOString();
     }
     const iso = date.toISOString();
-    if (!(0, iso_datestring_validator_1.isValidISODateString)(iso)) {
-        // Occurs in rare cases, e.g. where resulting UTC year is negative. These also don't preserve lexical sort.
+    // Date.toISOString() always returns `YYYY-MM-DDTHH:mm:ss.sssZ` or
+    // `±YYYYYY-MM-DDTHH:mm:ss.sssZ`
+    // (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)
+    // However, the leading `±` and 6 digit year can break lexical sorting, so we
+    // need to catch those cases and return a safe value.
+    if (iso.startsWith('-') || iso.startsWith('+')) {
         return new Date(0).toISOString();
     }
     return iso; // YYYY-MM-DDTHH:mm:ss.sssZ

package/dist/dates.js.map

@@ -1 +1 @@
-{"version":3,"file":"dates.js","sourceRoot":"","sources":["../src/dates.ts"],"names":[],"mappings":";;AAIA,kDAWC;AAfD,uEAA+D;AAE/D,6FAA6F;AAC7F,2EAA2E;AAC3E,SAAgB,mBAAmB,CAAC,OAAe;IACjD,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,OAAO,CAAC,CAAA;IAC9B,IAAI,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;QAC1B,OAAO,IAAI,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;IAClC,CAAC;IACD,MAAM,GAAG,GAAG,IAAI,CAAC,WAAW,EAAE,CAAA;IAC9B,IAAI,CAAC,IAAA,+CAAoB,EAAC,GAAG,CAAC,EAAE,CAAC;QAC/B,2GAA2G;QAC3G,OAAO,IAAI,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;IAClC,CAAC;IACD,OAAO,GAAG,CAAA,CAAC,2BAA2B;AACxC,CAAC","sourcesContent":["import { isValidISODateString } from 'iso-datestring-validator'\n\n// Normalize date strings to simplified ISO so that the lexical sort preserves temporal sort.\n// Rather than failing on an invalid date format, returns valid unix epoch.\nexport function toSimplifiedISOSafe(dateStr: string) {\n  const date = new Date(dateStr)\n  if (isNaN(date.getTime())) {\n    return new Date(0).toISOString()\n  }\n  const iso = date.toISOString()\n  if (!isValidISODateString(iso)) {\n    // Occurs in rare cases, e.g. where resulting UTC year is negative. These also don't preserve lexical sort.\n    return new Date(0).toISOString()\n  }\n  return iso // YYYY-MM-DDTHH:mm:ss.sssZ\n}\n"]}
+{"version":3,"file":"dates.js","sourceRoot":"","sources":["../src/dates.ts"],"names":[],"mappings":";;AAEA,kDAiBC;AAnBD,6FAA6F;AAC7F,2EAA2E;AAC3E,SAAgB,mBAAmB,CAAC,OAAe;IACjD,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,OAAO,CAAC,CAAA;IAC9B,IAAI,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;QAC1B,OAAO,IAAI,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;IAClC,CAAC;IACD,MAAM,GAAG,GAAG,IAAI,CAAC,WAAW,EAAE,CAAA;IAE9B,kEAAkE;IAClE,gCAAgC;IAChC,sGAAsG;IACtG,6EAA6E;IAC7E,qDAAqD;IACrD,IAAI,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;QAC/C,OAAO,IAAI,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;IAClC,CAAC;IAED,OAAO,GAAG,CAAA,CAAC,2BAA2B;AACxC,CAAC","sourcesContent":["// Normalize date strings to simplified ISO so that the lexical sort preserves temporal sort.\n// Rather than failing on an invalid date format, returns valid unix epoch.\nexport function toSimplifiedISOSafe(dateStr: string) {\n  const date = new Date(dateStr)\n  if (isNaN(date.getTime())) {\n    return new Date(0).toISOString()\n  }\n  const iso = date.toISOString()\n\n  // Date.toISOString() always returns `YYYY-MM-DDTHH:mm:ss.sssZ` or\n  // `±YYYYYY-MM-DDTHH:mm:ss.sssZ`\n  // (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)\n  // However, the leading `±` and 6 digit year can break lexical sorting, so we\n  // need to catch those cases and return a safe value.\n  if (iso.startsWith('-') || iso.startsWith('+')) {\n    return new Date(0).toISOString()\n  }\n\n  return iso // YYYY-MM-DDTHH:mm:ss.sssZ\n}\n"]}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atproto/common",
-  "version": "0.5.13",
+  "version": "0.5.14",
   "license": "MIT",
   "description": "Shared web-platform-friendly code for atproto libraries",
   "keywords": [
@@ -18,12 +18,11 @@
     "node": ">=18.7.0"
   },
   "dependencies": {
-    "iso-datestring-validator": "^2.2.2",
     "multiformats": "^9.9.0",
     "pino": "^8.21.0",
-    "@atproto/common-web": "^0.4.17",
-    "@atproto/lex-cbor": "^0.0.13",
-    "@atproto/lex-data": "^0.0.12"
+    "@atproto/common-web": "^0.4.18",
+    "@atproto/lex-cbor": "^0.0.14",
+    "@atproto/lex-data": "^0.0.13"
   },
   "devDependencies": {
     "jest": "^28.1.2",

package/src/dates.ts

@@ -1,5 +1,3 @@
-import { isValidISODateString } from 'iso-datestring-validator'
-
 // Normalize date strings to simplified ISO so that the lexical sort preserves temporal sort.
 // Rather than failing on an invalid date format, returns valid unix epoch.
 export function toSimplifiedISOSafe(dateStr: string) {
@@ -8,9 +6,15 @@ export function toSimplifiedISOSafe(dateStr: string) {
     return new Date(0).toISOString()
   }
   const iso = date.toISOString()
-  if (!isValidISODateString(iso)) {
-    // Occurs in rare cases, e.g. where resulting UTC year is negative. These also don't preserve lexical sort.
+
+  // Date.toISOString() always returns `YYYY-MM-DDTHH:mm:ss.sssZ` or
+  // `±YYYYYY-MM-DDTHH:mm:ss.sssZ`
+  // (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)
+  // However, the leading `±` and 6 digit year can break lexical sorting, so we
+  // need to catch those cases and return a safe value.
+  if (iso.startsWith('-') || iso.startsWith('+')) {
     return new Date(0).toISOString()
   }
+
   return iso // YYYY-MM-DDTHH:mm:ss.sssZ
 }