@atproto/bsky 0.0.249 → 0.0.251

package/tests/__snapshots__/feed-generation.test.ts.snap

@@ -366,7 +366,6 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "viewer": {},
   },
   {
-    "acceptsInteractions": true,
     "cid": "cids(3)",
     "creator": {
       "associated": {
@@ -404,9 +403,9 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
         "muted": false,
       },
     },
-    "description": "Has acceptsInteractions set to true",
+    "description": "Returns a post with skeletonReasonPin",
     "did": "user(0)",
-    "displayName": "Accepts Interactions",
+    "displayName": "Pinned",
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 0,
@@ -414,7 +413,55 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "viewer": {},
   },
   {
+    "acceptsInteractions": true,
     "cid": "cids(4)",
+    "creator": {
+      "associated": {
+        "activitySubscription": {
+          "allowSubscriptions": "followers",
+        },
+      },
+      "avatar": "https://bsky.public.url/img/avatar/plain/user(2)/cids(1)",
+      "createdAt": "1970-01-01T00:00:00.000Z",
+      "description": "its me!",
+      "did": "user(1)",
+      "displayName": "ali",
+      "handle": "alice.test",
+      "indexedAt": "1970-01-01T00:00:00.000Z",
+      "labels": [
+        {
+          "cid": "cids(2)",
+          "cts": "1970-01-01T00:00:00.000Z",
+          "src": "user(1)",
+          "uri": "record(3)",
+          "val": "self-label-a",
+        },
+        {
+          "cid": "cids(2)",
+          "cts": "1970-01-01T00:00:00.000Z",
+          "src": "user(1)",
+          "uri": "record(3)",
+          "val": "self-label-b",
+        },
+      ],
+      "viewer": {
+        "blockedBy": false,
+        "followedBy": "record(2)",
+        "following": "record(1)",
+        "muted": false,
+      },
+    },
+    "description": "Has acceptsInteractions set to true",
+    "did": "user(0)",
+    "displayName": "Accepts Interactions",
+    "indexedAt": "1970-01-01T00:00:00.000Z",
+    "labels": [],
+    "likeCount": 0,
+    "uri": "record(5)",
+    "viewer": {},
+  },
+  {
+    "cid": "cids(5)",
     "contentMode": "app.bsky.feed.defs#contentModeVideo",
     "creator": {
       "associated": {
@@ -458,11 +505,11 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 0,
-    "uri": "record(5)",
+    "uri": "record(6)",
     "viewer": {},
   },
   {
-    "cid": "cids(5)",
+    "cid": "cids(6)",
     "creator": {
       "associated": {
         "activitySubscription": {
@@ -505,11 +552,11 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 0,
-    "uri": "record(6)",
+    "uri": "record(7)",
     "viewer": {},
   },
   {
-    "cid": "cids(6)",
+    "cid": "cids(7)",
     "creator": {
       "associated": {
         "activitySubscription": {
@@ -552,11 +599,11 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 0,
-    "uri": "record(7)",
+    "uri": "record(8)",
     "viewer": {},
   },
   {
-    "cid": "cids(7)",
+    "cid": "cids(8)",
     "creator": {
       "associated": {
         "activitySubscription": {
@@ -599,11 +646,11 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 0,
-    "uri": "record(8)",
+    "uri": "record(9)",
     "viewer": {},
   },
   {
-    "cid": "cids(8)",
+    "cid": "cids(9)",
     "creator": {
       "associated": {
         "activitySubscription": {
@@ -646,11 +693,11 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 0,
-    "uri": "record(9)",
+    "uri": "record(10)",
     "viewer": {},
   },
   {
-    "cid": "cids(9)",
+    "cid": "cids(10)",
     "creator": {
       "associated": {
         "activitySubscription": {
@@ -693,9 +740,9 @@ exports[`feed generation > getActorFeeds fetches feed generators by actor. 1`] =
     "indexedAt": "1970-01-01T00:00:00.000Z",
     "labels": [],
     "likeCount": 2,
-    "uri": "record(10)",
+    "uri": "record(11)",
     "viewer": {
-      "like": "record(11)",
+      "like": "record(12)",
     },
   },
 ]

package/tests/data-plane/thread-mutes.test.ts

@@ -43,6 +43,7 @@ describe('thread mutes', () => {
         ),
       },
     )
+    await network.processAll()
   })
 
   it('notes that threads are muted in viewer state', async () => {
@@ -137,6 +138,7 @@ describe('thread mutes', () => {
         ),
       },
     )
+    await network.processAll()
   })
 
   it('no longer notes that threads are muted in viewer state after unmuting', async () => {

package/tests/feed-generation.test.ts

@@ -41,6 +41,7 @@ describe('feed generation', () => {
   let feedUriNeedsAuth: string
   let feedUriContentModeVideo: string
   let feedUriAcceptsInteractions: string
+  let feedUriPinned: string
   let starterPackRef: { uri: string; cid: string }
 
   beforeAll(async () => {
@@ -77,6 +78,7 @@ describe('feed generation', () => {
       'app.bsky.feed.generator',
       'accepts-interactions',
     )
+    const pinnedUri = AtUri.make(alice, 'app.bsky.feed.generator', 'pinned')
     gen = await network.createFeedGen({
       [allUri.toString()]: feedGenHandler('all'),
       [evenUri.toString()]: feedGenHandler('even'),
@@ -91,6 +93,7 @@ describe('feed generation', () => {
       [acceptsInteractionsUri.toString()]: feedGenHandler(
         'accepts-interactions',
       ),
+      [pinnedUri.toString()]: feedGenHandler('pinned'),
     })
 
     const feedSuggestions = [
@@ -210,6 +213,16 @@ describe('feed generation', () => {
         },
         sc.getHeaders(alice),
       )
+    const pinned = await pdsAgent.api.app.bsky.feed.generator.create(
+      { repo: alice, rkey: 'pinned' },
+      {
+        did: gen.did,
+        displayName: 'Pinned',
+        description: 'Returns a post with skeletonReasonPin',
+        createdAt: new Date().toISOString(),
+      },
+      sc.getHeaders(alice),
+    )
     await network.processAll()
     await network.bsky.ctx.dataplane.takedownRecord({
       recordUri: prime.uri,
@@ -226,6 +239,7 @@ describe('feed generation', () => {
     feedUriNeedsAuth = needsAuth.uri
     feedUriContentModeVideo = contentModeVideo.uri
     feedUriAcceptsInteractions = acceptsInteraction.uri
+    feedUriPinned = pinned.uri
   })
 
   it('feed gen records can be updated', async () => {
@@ -269,15 +283,16 @@ describe('feed generation', () => {
 
     const paginatedAll = results(await paginateAll(paginator))
 
-    expect(paginatedAll.length).toEqual(8)
+    expect(paginatedAll.length).toEqual(9)
     expect(paginatedAll[0].uri).toEqual(feedUriOdd)
-    expect(paginatedAll[1].uri).toEqual(feedUriAcceptsInteractions)
-    expect(paginatedAll[2].uri).toEqual(feedUriContentModeVideo)
-    expect(paginatedAll[3].uri).toEqual(feedUriNeedsAuth)
-    expect(paginatedAll[4].uri).toEqual(feedUriBadPaginationCursor)
-    expect(paginatedAll[5].uri).toEqual(feedUriBadPaginationLimit)
-    expect(paginatedAll[6].uri).toEqual(feedUriEven)
-    expect(paginatedAll[7].uri).toEqual(feedUriAll)
+    expect(paginatedAll[1].uri).toEqual(feedUriPinned)
+    expect(paginatedAll[2].uri).toEqual(feedUriAcceptsInteractions)
+    expect(paginatedAll[3].uri).toEqual(feedUriContentModeVideo)
+    expect(paginatedAll[4].uri).toEqual(feedUriNeedsAuth)
+    expect(paginatedAll[5].uri).toEqual(feedUriBadPaginationCursor)
+    expect(paginatedAll[6].uri).toEqual(feedUriBadPaginationLimit)
+    expect(paginatedAll[7].uri).toEqual(feedUriEven)
+    expect(paginatedAll[8].uri).toEqual(feedUriAll)
     expect(paginatedAll.map((fg) => fg.uri)).not.toContain(feedUriPrime) // taken-down
     expect(forSnapshot(paginatedAll)).toMatchSnapshot()
   })
@@ -813,6 +828,21 @@ describe('feed generation', () => {
       )
     })
 
+    it('propagates skeletonReasonPin as ReasonPin.', async () => {
+      const feed = await agent.api.app.bsky.feed.getFeed(
+        { feed: feedUriPinned },
+        {
+          headers: await network.serviceHeaders(
+            alice,
+            ids.AppBskyFeedGetFeed,
+            gen.did,
+          ),
+        },
+      )
+      expect(feed.data.feed).toHaveLength(1)
+      expect(AppBskyFeedDefs.isReasonPin(feed.data.feed[0].reason)).toBe(true)
+    })
+
     it('returns an upstream failure error when the feed is down.', async () => {
       await gen.close() // @NOTE must be last test
       const tryGetFeed = agent.api.app.bsky.feed.getFeed(
@@ -838,9 +868,25 @@ describe('feed generation', () => {
         | 'bad-pagination-limit'
         | 'bad-pagination-cursor'
         | 'needs-auth'
-        | 'accepts-interactions',
+        | 'accepts-interactions'
+        | 'pinned',
     ): SkeletonHandler =>
     async ({ req, params }) => {
+      if (feedName === 'pinned') {
+        return {
+          encoding: 'application/json',
+          body: {
+            feed: [
+              {
+                post: sc.posts[sc.dids.alice][0].ref.uriStr,
+                reason: {
+                  $type: 'app.bsky.feed.defs#skeletonReasonPin',
+                },
+              },
+            ],
+          } satisfies app.bsky.feed.getFeedSkeleton.$OutputBody,
+        }
+      }
       if (feedName === 'needs-auth' && !req.headers.authorization) {
         throw new AuthRequiredError('This feed requires auth')
       }

package/tests/stash.test.ts

@@ -44,7 +44,12 @@ describe('private data', () => {
   })
 
   beforeEach(async () => network.processAll())
-  afterEach(async () => clearPrivateData(network.bsky.db))
+  afterEach(async () => {
+    // Drain pending bsync ops before clearing, so a stale op can't land after
+    // the reset.
+    await network.processAll()
+    await clearPrivateData(network.bsky.db)
+  })
   afterAll(async () => network?.close())
 
   describe('create', () => {

package/tests/views/age-assurance-v2.test.ts

@@ -170,6 +170,9 @@ describe('age assurance v2 views', () => {
 
   afterEach(async () => {
     vi.resetAllMocks()
+    // Drain in-flight bsync ops before resetting state directly, so an op from
+    // a test that doesn't read it back can't leak into the next test.
+    await network.processAll()
     await clearPrivateData(db)
     await clearActorAgeAssurance(db)
   })

package/tests/views/age-assurance.test.ts

@@ -97,6 +97,9 @@ describe('age assurance views', () => {
   })
 
   afterEach(async () => {
+    // Drain pending bsync ops before clearing, so a stale op can't land after
+    // the reset.
+    await network.processAll()
     await clearPrivateData(db)
     await clearActorAgeAssurance(db)
   })
@@ -225,6 +228,7 @@ describe('age assurance views', () => {
       externalPayload,
       status,
     })
+    await network.processAll()
     const finalizedState = await getAgeAssurance(actor)
     expect(finalizedState).toStrictEqual({
       status: 'assured',
@@ -264,6 +268,7 @@ describe('age assurance views', () => {
         `${redirectUrl}?actorDid=${encodeURIComponent(actorDid)}&result=success`,
       )
 
+      await network.processAll()
       const state2 = await getAgeAssurance(actorDid)
       expect(state2).toStrictEqual({
         status: 'assured',
@@ -288,6 +293,7 @@ describe('age assurance views', () => {
         `${redirectUrl}?result=unknown`,
       )
 
+      await network.processAll()
       const state = await getAgeAssurance(actorDid)
       expect(state).toStrictEqual({
         status: 'pending',
@@ -323,6 +329,7 @@ describe('age assurance views', () => {
       })
       expect(webhookRes.status).toBe(200)
 
+      await network.processAll()
       const state2 = await getAgeAssurance(actorDid)
       expect(state2).toStrictEqual({
         status: 'assured',
@@ -346,6 +353,7 @@ describe('age assurance views', () => {
       })
       expect(webhookRes.status).toBe(500)
 
+      await network.processAll()
       const state = await getAgeAssurance(actorDid)
       expect(state).toStrictEqual({
         status: 'pending',

package/tests/views/bookmarks.test.ts

@@ -56,6 +56,9 @@ describe('appview bookmarks views', () => {
 
   afterEach(async () => {
     vi.resetAllMocks()
+    // Drain pending bsync ops before clearing, so a stale op can't land after
+    // the reset.
+    await network.processAll()
     await clearPrivateData(db)
     await clearBookmarks(db)
   })
@@ -114,6 +117,7 @@ describe('appview bookmarks views', () => {
 
       await create(bob, sc.posts[bob][0].ref)
       await create(bob, sc.posts[carol][0].ref)
+      await network.processAll()
 
       const { data: dataAlice } = await get(alice)
       expect(dataAlice.bookmarks).toHaveLength(3)
@@ -126,10 +130,12 @@ describe('appview bookmarks views', () => {
       const uri = sc.posts[alice][0].ref
 
       await create(alice, uri)
+      await network.processAll()
       const { data: data0 } = await get(alice)
       expect(data0.bookmarks).toHaveLength(1)
 
       await create(alice, uri)
+      await network.processAll()
       const { data: data1 } = await get(alice)
       expect(data1.bookmarks).toHaveLength(1)
     })
@@ -147,12 +153,14 @@ describe('appview bookmarks views', () => {
       await create(alice, sc.posts[alice][0].ref)
       await create(alice, sc.posts[bob][0].ref)
       await create(alice, sc.posts[carol][0].ref)
+      await network.processAll()
 
       const { data: dataBefore } = await get(alice)
       expect(dataBefore.bookmarks).toHaveLength(3)
 
       await del(alice, sc.posts[alice][0].ref)
       await del(alice, sc.posts[carol][0].ref)
+      await network.processAll()
 
       const { data: dataAfter } = await get(alice)
       expect(dataAfter.bookmarks).toHaveLength(1)
@@ -161,12 +169,17 @@ describe('appview bookmarks views', () => {
     it('is idempotent', async () => {
       const uri = sc.posts[alice][0].ref
       await create(alice, uri)
+      // deleteBookmark resolves the bookmark's key from indexed state, so the
+      // create must be indexed before the delete is issued.
+      await network.processAll()
 
       await del(alice, uri)
+      await network.processAll()
       const { data: data0 } = await get(alice)
       expect(data0.bookmarks).toHaveLength(0)
 
       await del(alice, uri)
+      await network.processAll()
       const { data: data1 } = await get(alice)
       expect(data1.bookmarks).toHaveLength(0)
     })
@@ -192,12 +205,14 @@ describe('appview bookmarks views', () => {
       expect(postBefore.viewer?.bookmarked).toBe(false)
 
       await create(alice, ref)
+      await network.processAll()
       const postAfterCreate = await getPost(alice, ref)
       expect(postAfterCreate.viewer?.bookmarked).toBe(true)
       const postAfterCreateForBob = await getPost(bob, ref)
       expect(postAfterCreateForBob.viewer?.bookmarked).toBe(false)
 
       await del(alice, ref)
+      await network.processAll()
       const postAfterDel = await getPost(alice, ref)
       expect(postAfterDel.viewer?.bookmarked).toBe(false)
     })
@@ -210,16 +225,19 @@ describe('appview bookmarks views', () => {
 
       await create(alice, uri)
       await create(carol, uri)
+      await network.processAll()
       const postAfterCreate = await getPost(alice, uri)
       expect(postAfterCreate.bookmarkCount).toBe(2)
       const postAfterCreateForBob = await getPost(bob, uri)
       expect(postAfterCreateForBob.bookmarkCount).toBe(2)
 
       await del(alice, uri)
+      await network.processAll()
       const postAfterAliceDel = await getPost(alice, uri)
       expect(postAfterAliceDel.bookmarkCount).toBe(1)
 
       await del(carol, uri)
+      await network.processAll()
       const postAfterCarolDel = await getPost(carol, uri)
       expect(postAfterCarolDel.bookmarkCount).toBe(0)
     })
@@ -232,6 +250,7 @@ describe('appview bookmarks views', () => {
       await create(alice, sc.posts[carol][0].ref)
       await create(alice, sc.posts[dan][0].ref)
       await create(alice, sc.posts[dan][1].ref)
+      await network.processAll()
 
       const results = (out: AppBskyBookmarkGetBookmarks.OutputSchema[]) =>
         out.flatMap((res) => res.bookmarks)

package/tests/views/drafts.test.ts

@@ -48,8 +48,13 @@ describe('appview drafts views', () => {
   })
 
   beforeEach(async () => network.processAll())
-  afterEach(async () => vi.resetAllMocks())
-  afterEach(async () => clearDrafts(network.bsky.db))
+  afterEach(async () => {
+    vi.resetAllMocks()
+    // Drain in-flight bsync operations before resetting state directly,
+    // otherwise a late-applied op can resurrect state after the reset.
+    await network.processAll()
+    await clearDrafts(network.bsky.db)
+  })
   afterAll(async () => network?.close())
 
   const makeDraft = (): AppBskyDraftDefs.Draft => ({
@@ -113,6 +118,7 @@ describe('appview drafts views', () => {
 
       await create(bob, makeDraft())
       await create(bob, makeDraft())
+      await network.processAll()
 
       const { data: dataAlice } = await get(alice)
       expect(dataAlice.drafts).toHaveLength(3)
@@ -131,6 +137,7 @@ describe('appview drafts views', () => {
       }
 
       await create(alice, draft)
+      await network.processAll()
       const { data } = await get(alice)
       expect(data.drafts).toHaveLength(1)
       expect(data.drafts[0].draft.posts).toHaveLength(3)
@@ -159,6 +166,7 @@ describe('appview drafts views', () => {
       }
 
       await create(alice, draft1)
+      await network.processAll()
       const { data: data0 } = await get(alice)
       expect(data0.drafts).toHaveLength(1)
       expect(data0.drafts[0].draft.posts[0].text).toBe('First version')
@@ -170,6 +178,7 @@ describe('appview drafts views', () => {
       }
 
       await update(alice, draft2)
+      await network.processAll()
       const { data: data1 } = await get(alice)
       expect(data1.drafts).toHaveLength(1)
       expect(data1.drafts[0].draft.posts[0].text).toBe('Updated version')
@@ -182,6 +191,7 @@ describe('appview drafts views', () => {
       }
 
       await update(alice, nonExistingDraft)
+      await network.processAll()
       const { data } = await get(alice)
       expect(data.drafts).toHaveLength(0)
     })
@@ -192,6 +202,7 @@ describe('appview drafts views', () => {
       await create(alice, makeDraft())
       await create(alice, makeDraft())
       await create(alice, makeDraft())
+      await network.processAll()
 
       const { data: dataBefore } = await get(alice)
       expect(dataBefore.drafts).toHaveLength(3)
@@ -202,6 +213,7 @@ describe('appview drafts views', () => {
 
       await del(alice, draft1Id)
       await del(alice, draft3Id)
+      await network.processAll()
 
       const { data: dataAfter } = await get(alice)
       expect(dataAfter.drafts).toHaveLength(1)
@@ -210,16 +222,19 @@ describe('appview drafts views', () => {
 
     it('is idempotent', async () => {
       await create(alice, makeDraft())
+      await network.processAll()
 
       const { data: data0 } = await get(alice)
       expect(data0.drafts).toHaveLength(1)
       const draftId = data0.drafts[0].id
 
       await del(alice, draftId)
+      await network.processAll()
       const { data: data1 } = await get(alice)
       expect(data1.drafts).toHaveLength(0)
 
       await del(alice, draftId)
+      await network.processAll()
       const { data: data2 } = await get(alice)
       expect(data2.drafts).toHaveLength(0)
     })
@@ -235,6 +250,7 @@ describe('appview drafts views', () => {
       await create(alice, makeDraft())
       await create(alice, makeDraft())
       await create(bob, makeDraft())
+      await network.processAll()
 
       const { data: dataAlice } = await get(alice)
       expect(dataAlice.drafts).toHaveLength(2)
@@ -246,6 +262,7 @@ describe('appview drafts views', () => {
     it('includes timestamps', async () => {
       const beforeCreate = new Date()
       await create(alice, makeDraft())
+      await network.processAll()
       const afterCreate = new Date()
 
       const { data } = await get(alice)
@@ -264,6 +281,7 @@ describe('appview drafts views', () => {
       for (let i = 0; i < 7; i++) {
         await create(alice, makeDraft())
       }
+      await network.processAll()
 
       const results = (out: AppBskyDraftGetDrafts.OutputSchema[]) =>
         out.flatMap((res) => res.drafts)
@@ -319,6 +337,7 @@ describe('appview drafts views', () => {
 
     it('round-trips a draft with embedGallery', async () => {
       await create(alice, galleryDraft(3))
+      await network.processAll()
       const { data } = await get(alice)
       expect(data.drafts).toHaveLength(1)
 
@@ -335,6 +354,7 @@ describe('appview drafts views', () => {
 
     it('updates a draft to add a gallery', async () => {
       await create(alice, { posts: [{ text: 'text only' }] })
+      await network.processAll()
       const { data: before } = await get(alice)
       expect(before.drafts).toHaveLength(1)
       expect(before.drafts[0].draft.posts[0].embedGallery).toBeUndefined()
@@ -344,6 +364,7 @@ describe('appview drafts views', () => {
         id: draftId,
         draft: galleryDraft(2),
       })
+      await network.processAll()
 
       const { data: after } = await get(alice)
       expect(after.drafts).toHaveLength(1)
@@ -353,6 +374,7 @@ describe('appview drafts views', () => {
 
     it('updates a draft to change gallery items', async () => {
       await create(alice, galleryDraft(2))
+      await network.processAll()
       const { data: before } = await get(alice)
       expect(before.drafts[0].draft.posts[0].embedGallery?.items).toHaveLength(
         2,
@@ -363,6 +385,7 @@ describe('appview drafts views', () => {
         id: draftId,
         draft: galleryDraft(5),
       })
+      await network.processAll()
 
       const { data: after } = await get(alice)
       const post = after.drafts[0].draft.posts[0]

package/tests/views/mute-lists.test.ts

@@ -334,6 +334,7 @@ describe('bsky views with mutes from mute lists', () => {
         ),
       },
     )
+    await network.processAll()
 
     const res = await agent.api.app.bsky.graph.getListMutes(
       {},
@@ -392,6 +393,7 @@ describe('bsky views with mutes from mute lists', () => {
         ),
       },
     )
+    await network.processAll()
 
     const res = await agent.api.app.bsky.graph.getListMutes(
       {},

package/tests/views/mutes.test.ts

@@ -275,6 +275,7 @@ describe('mute views', () => {
         encoding: 'application/json',
       },
     )
+    await network.processAll()
 
     const { data: final } = await agent.api.app.bsky.graph.getMutes(
       {},