@atproto/bsky 0.0.245 → 0.0.247

package/tests/seed/known-followers.ts

@@ -1,8 +1,9 @@
 import { SeedClient, TestNetwork, TestNetworkNoAppView } from '@atproto/dev-env'
+import type { HandleString } from '@atproto/syntax'
 
 export type User = {
   email: string
-  handle: string
+  handle: HandleString
   password: string
   displayName: string
   description: string

package/tests/seed/postgates.ts

@@ -1,10 +1,11 @@
 import { SeedClient, TestNetwork, TestNetworkNoAppView } from '@atproto/dev-env'
+import type { DidString, HandleString } from '@atproto/syntax'
 
 export type User = {
   id: string
-  did: string
+  did: DidString
   email: string
-  handle: string
+  handle: HandleString
   password: string
   displayName: string
   description: string

package/tests/views/account-deactivation.test.ts

@@ -1,13 +1,14 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 
 describe('bsky account deactivation', () => {
   let network: TestNetwork
   let agent: AtpAgent
   let sc: SeedClient
 
-  let alice: string
+  let alice: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/actor-likes.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AtUri, AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 
 describe('bsky actor likes feed views', () => {
   let network: TestNetwork
@@ -9,9 +10,9 @@ describe('bsky actor likes feed views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/author-feed.test.ts

@@ -14,6 +14,7 @@ import {
   ids,
 } from '@atproto/api'
 import { SeedClient, TestNetwork, authorFeedSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { uriToDid } from '../../src/util/uris.js'
 import {
   forSnapshot,
@@ -32,11 +33,11 @@ describe('pds author feed views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
-  let eve: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
+  let eve: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/block-lists.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AtUri, AtpAgent, ids } from '@atproto/api'
 import { RecordRef, SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { forSnapshot } from '../_util.js'
 
 describe('pds views with blocking from block lists', () => {
@@ -10,10 +11,10 @@ describe('pds views with blocking from block lists', () => {
   let sc: SeedClient
   let aliceReplyToDan: { ref: RecordRef }
 
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({
@@ -232,7 +233,7 @@ describe('pds views with blocking from block lists', () => {
     )
     expect(
       resDan.data.feed.some((post) =>
-        [bob, carol].includes(post.post.author.did),
+        [bob, carol].includes(post.post.author.did as DidString),
       ),
     ).toBeFalsy()
   })
@@ -616,7 +617,7 @@ describe('pds views with blocking from block lists', () => {
     )
     expect(
       resDan.data.feed.some((post) =>
-        [bob, carol].includes(post.post.author.did),
+        [bob, carol].includes(post.post.author.did as DidString),
       ),
     ).toBeTruthy()
   })
@@ -653,7 +654,7 @@ describe('pds views with blocking from block lists', () => {
     )
     expect(
       resDan.data.feed.some((post) =>
-        [bob, carol].includes(post.post.author.did),
+        [bob, carol].includes(post.post.author.did as DidString),
       ),
     ).toBeTruthy()
   })

package/tests/views/blocks.test.ts

@@ -8,6 +8,7 @@ import {
   ids,
 } from '@atproto/api'
 import { RecordRef, SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { assertIsThreadViewPost, forSnapshot } from '../_util.js'
 
 describe('pds views with blocking', () => {
@@ -19,10 +20,10 @@ describe('pds views with blocking', () => {
   let aliceReplyToDan: { ref: RecordRef }
   let carolReplyToDan: { ref: RecordRef }
 
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
   let danBlockUri: string
 
   beforeAll(async () => {

package/tests/views/bookmarks.test.ts

@@ -20,6 +20,7 @@ import {
   ids,
 } from '@atproto/api'
 import { RecordRef, SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { forSnapshot, paginateAll } from '../_util.js'
 
 type Database = TestNetwork['bsky']['db']
@@ -31,10 +32,10 @@ describe('appview bookmarks views', () => {
   let db: Database
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/feed-hidden-replies.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { Users, feedHiddenRepliesSeed } from '../seed/feed-hidden-replies.js'
 
 describe('feed hidden replies', () => {
@@ -44,7 +45,7 @@ describe('feed hidden replies', () => {
           createdAt: new Date().toISOString(),
           hiddenReplies: [B.ref.uriStr],
         },
-        sc.getHeaders(A.ref.uri.host),
+        sc.getHeaders(A.ref.uri.host as DidString),
       )
 
       await network.processAll()
@@ -87,7 +88,7 @@ describe('feed hidden replies', () => {
           createdAt: new Date().toISOString(),
           hiddenReplies: [B.ref.uriStr],
         },
-        sc.getHeaders(A.ref.uri.host),
+        sc.getHeaders(A.ref.uri.host as DidString),
       )
 
       await network.processAll()
@@ -175,7 +176,7 @@ describe('feed hidden replies', () => {
           createdAt: new Date().toISOString(),
           hiddenReplies: [C.ref.uriStr],
         },
-        sc.getHeaders(A.ref.uri.host),
+        sc.getHeaders(A.ref.uri.host as DidString),
       )
       await network.processAll()
       const D = await sc.reply(users.viewer.did, A.ref, C.ref, `D`)
@@ -234,7 +235,7 @@ describe('feed hidden replies', () => {
           repo: A.ref.uri.host,
           rkey: A.ref.uri.rkey,
         },
-        sc.getHeaders(A.ref.uri.host),
+        sc.getHeaders(A.ref.uri.host as DidString),
       )
       await network.processAll()
     })

package/tests/views/feed-view-post.test.ts

@@ -2,6 +2,7 @@ import assert from 'node:assert'
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AppBskyFeedDefs, AtUri, AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 
 /**
  * The frontend computes feed slices for display using at-most one
@@ -23,10 +24,10 @@ describe('pds thread views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/get-suggested-onboarding-users.test.ts

@@ -11,12 +11,13 @@ import {
   ids,
 } from '@atproto/api'
 import { SeedClient, TestNetwork } from '@atproto/dev-env'
+import type { DidString, HandleString } from '@atproto/syntax'
 
 type User = {
   id: string
-  did: string
+  did: DidString
   email: string
-  handle: string
+  handle: HandleString
   password: string
   displayName: string
   description: string

package/tests/views/internal-actor.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AppBskyActorDefs, AtpAgent } from '@atproto/api'
 import { SeedClient, TestNetwork } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { knownFollowersSeed } from '../seed/known-followers.js'
 
 describe('internal actor views', () => {
@@ -8,7 +9,7 @@ describe('internal actor views', () => {
   let pdsAgent: AtpAgent
   let seedClient: SeedClient
 
-  let dids: Record<string, string>
+  let dids: Record<string, DidString>
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/known-followers.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { knownFollowersSeed } from '../seed/known-followers.js'
 
 describe('known followers (social proof)', () => {
@@ -9,7 +10,7 @@ describe('known followers (social proof)', () => {
   let pdsAgent: AtpAgent
   let seedClient: SeedClient
 
-  let dids: Record<string, string>
+  let dids: Record<string, DidString>
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/labeler-service.test.ts

@@ -8,6 +8,7 @@ import {
   ids,
 } from '@atproto/api'
 import { RecordRef, SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { forSnapshot, stripViewerFromLabeler } from '../_util.js'
 
 describe('labeler service views', () => {
@@ -17,9 +18,9 @@ describe('labeler service views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
 
   let aliceService: RecordRef
 

package/tests/views/likes.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AppBskyFeedGetLikes, AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork, likesSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import {
   constantDate,
   forSnapshot,
@@ -14,10 +15,10 @@ describe('pds like views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
-  let frankie: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let frankie: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({

package/tests/views/list-feed.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AppBskyFeedGetListFeed, AtpAgent, ids } from '@atproto/api'
 import { RecordRef, SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import {
   forSnapshot,
   paginateAll,
@@ -14,9 +15,9 @@ describe('list feed views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
 
   let listRef: RecordRef
 
@@ -52,7 +53,9 @@ describe('list feed views', () => {
 
     // all posts are from alice or bob
     expect(
-      res.data.feed.every((row) => [alice, bob].includes(row.post.author.did)),
+      res.data.feed.every((row) =>
+        [alice, bob].includes(row.post.author.did as DidString),
+      ),
     ).toBeTruthy()
   })
 

package/tests/views/mute-lists.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AtUri, AtpAgent, ids } from '@atproto/api'
 import { RecordRef, SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { forSnapshot } from '../_util.js'
 
 describe('bsky views with mutes from mute lists', () => {
@@ -9,10 +10,10 @@ describe('bsky views with mutes from mute lists', () => {
   let pdsAgent: AtpAgent
   let sc: SeedClient
 
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({
@@ -132,7 +133,9 @@ describe('bsky views with mutes from mute lists', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBe(false)
   })
 
@@ -144,7 +147,9 @@ describe('bsky views with mutes from mute lists', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBe(false)
   })
 
@@ -163,7 +168,9 @@ describe('bsky views with mutes from mute lists', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBe(false)
   })
 
@@ -216,7 +223,7 @@ describe('bsky views with mutes from mute lists', () => {
     )
     expect(
       res.data.notifications.some((notif) =>
-        [bob, carol].includes(notif.author.did),
+        [bob, carol].includes(notif.author.did as DidString),
       ),
     ).toBeFalsy()
   })
@@ -238,7 +245,7 @@ describe('bsky views with mutes from mute lists', () => {
       },
     )
     for (const actor of res.data.actors) {
-      if ([bob, carol].includes(actor.did)) {
+      if ([bob, carol].includes(actor.did as DidString)) {
         expect(actor.viewer?.muted).toBe(true)
         expect(actor.viewer?.mutedByList?.uri).toEqual(listUri)
       } else {
@@ -468,7 +475,9 @@ describe('bsky views with mutes from mute lists', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBeTruthy()
   })
 
@@ -490,7 +499,9 @@ describe('bsky views with mutes from mute lists', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBeTruthy()
   })
 })

package/tests/views/mutes.test.ts

@@ -6,18 +6,23 @@ import {
   basicSeed,
   usersBulkSeed,
 } from '@atproto/dev-env'
+import type {
+  AtIdentifierString,
+  DidString,
+  HandleString,
+} from '@atproto/syntax'
 import { forSnapshot, paginateAll } from '../_util.js'
 
 describe('mute views', () => {
   let network: TestNetwork
   let agent: AtpAgent
   let sc: SeedClient
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
 
-  let mutes: string[]
+  let mutes: AtIdentifierString[]
 
   beforeAll(async () => {
     network = await TestNetwork.create({
@@ -87,7 +92,9 @@ describe('mute views', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBe(false)
   })
 
@@ -102,7 +109,9 @@ describe('mute views', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBe(false)
   })
 
@@ -121,7 +130,9 @@ describe('mute views', () => {
       },
     )
     expect(
-      res.data.feed.some((post) => [bob, carol].includes(post.post.author.did)),
+      res.data.feed.some((post) =>
+        [bob, carol].includes(post.post.author.did as DidString),
+      ),
     ).toBe(false)
   })
 
@@ -167,7 +178,7 @@ describe('mute views', () => {
     )
     expect(
       res.data.notifications.some((notif) =>
-        [bob, carol].includes(notif.author.did),
+        [bob, carol].includes(notif.author.did as DidString),
       ),
     ).toBeFalsy()
   })
@@ -191,7 +202,10 @@ describe('mute views', () => {
       },
     )
     for (const actor of res.data.actors) {
-      if (mutes.includes(actor.did) || mutes.includes(actor.handle)) {
+      if (
+        mutes.includes(actor.did as DidString) ||
+        mutes.includes(actor.handle as HandleString)
+      ) {
         expect(actor.viewer?.muted).toBe(true)
       } else {
         expect(actor.viewer?.muted).toBe(false)

package/tests/views/notifications.test.ts

@@ -23,6 +23,7 @@ import {
   basicSeed,
   seedThreadV2,
 } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { delayCursor } from '../../src/api/app/bsky/notification/listNotifications.js'
 import { Namespaces } from '../../src/stash.js'
 import { forSnapshot, paginateAll } from '../_util.js'
@@ -38,15 +39,15 @@ describe('notification views', () => {
   let sc: SeedClient
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
-  let dan: string
-  let eve: string
-  let fred: string
-  let greg: string
-  let han: string
-  let blocked: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
+  let dan: DidString
+  let eve: DidString
+  let fred: DidString
+  let greg: DidString
+  let han: DidString
+  let blocked: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({
@@ -853,7 +854,7 @@ describe('notification views', () => {
     let delayNetwork: TestNetwork
     let delayAgent: AtpAgent
     let delaySc: SeedClient
-    let delayAlice: string
+    let delayAlice: DidString
 
     beforeAll(async () => {
       delayNetwork = await TestNetwork.create({
@@ -1252,7 +1253,7 @@ describe('notification views', () => {
       return profiles.sort((a, b) => (a.handle > b.handle ? 1 : -1))
     }
 
-    const declare = async (actor: string, value: string) => {
+    const declare = async (actor: DidString, value: string) => {
       await pdsAgent.com.atproto.repo.createRecord(
         {
           repo: actor,
@@ -1267,8 +1268,8 @@ describe('notification views', () => {
     }
 
     const put = async (
-      actor: string,
-      subject: string,
+      actor: DidString,
+      subject: DidString,
       val: AppBskyNotificationDefs.ActivitySubscription,
     ) =>
       agent.app.bsky.notification.putActivitySubscription(
@@ -1285,7 +1286,7 @@ describe('notification views', () => {
       )
 
     const list = async (
-      actor: string,
+      actor: DidString,
       params?: AppBskyNotificationListActivitySubscriptions.QueryParams,
     ) =>
       agent.app.bsky.notification.listActivitySubscriptions(params ?? {}, {

package/tests/views/post-search.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest'
 import { AppBskyFeedSearchPosts, AtpAgent, ids } from '@atproto/api'
 import { SeedClient, TestNetwork, basicSeed } from '@atproto/dev-env'
+import type { DidString } from '@atproto/syntax'
 import { DatabaseSchema } from '../../src/index.js'
 
 const TAG_HIDE = 'hide'
@@ -17,9 +18,9 @@ describe('appview search', () => {
   let nonTaggedResults: string[]
 
   // account dids, for convenience
-  let alice: string
-  let bob: string
-  let carol: string
+  let alice: DidString
+  let bob: DidString
+  let carol: DidString
 
   beforeAll(async () => {
     network = await TestNetwork.create({