@atomiqlabs/lp-lib 16.0.7 → 16.0.9

package/dist/swaps/assertions/FromBtcAmountAssertions.js

@@ -138,7 +138,7 @@ class FromBtcAmountAssertions extends AmountAssertions_1.AmountAssertions {
             this.checkBtcAmountInBounds(requestedAmount.amount);
             amountBD = requestedAmount.amount - amountBDgas;
             swapFee = fees.baseFee + ((amountBD * fees.feePPM + 999999n) / 1000000n);
-            if (amountBD < 0n) {
+            if (amountBD - swapFee < 0n) {
                 throw {
                     code: 20003,
                     msg: "Amount too low!",
@@ -163,6 +163,11 @@ class FromBtcAmountAssertions extends AmountAssertions_1.AmountAssertions {
             totalInToken = await this.swapPricing.getFromBtcSwapAmount(amountBD - swapFee, requestedAmount.token, chainIdentifier, null, requestedAmount.pricePrefetch);
             signal.throwIfAborted();
         }
+        if (totalInToken < 0n)
+            throw {
+                code: 20003,
+                msg: "Amount too low!"
+            };
         return {
             amountBD,
             swapFee,

package/dist/swaps/escrow/tobtc_abstract/ToBtcAbs.js

@@ -586,6 +586,11 @@ class ToBtcAbs extends ToBtcBaseSwapHandler_1.ToBtcBaseSwapHandler {
                 return resp;
             }, abortController.signal);
             metadata.times.priceCalculated = Date.now();
+            if (amountBD < 600n)
+                throw {
+                    code: "20019",
+                    msg: "Swap output amount is below bitcoin dust (600 sats)!"
+                };
             const claimHash = this.getHash(chainIdentifier, parsedBody.address, parsedBody.confirmations, parsedBody.nonce, amountBD).toString("hex");
             //Add grace period another time, so the user has 1 hour to commit
             const expirySeconds = this.getExpiryFromCLTV(parsedBody.confirmationTarget, parsedBody.confirmations) + this.config.gracePeriod;

package/dist/swaps/escrow/tobtcln_abstract/ToBtcLnAbs.d.ts

@@ -167,11 +167,10 @@ export declare class ToBtcLnAbs extends ToBtcBaseSwapHandler<ToBtcLnSwapAbs, ToB
      * Checks if the newly submitted PR has the same parameters (destination, cltv_delta, routes) as the initial dummy
      *  invoice sent for exactIn swap quote
      *
-     * @param pr
+     * @param parsedRequest
      * @param parsedAuth
-     * @throws {DefinedRuntimeError} will throw an error if the details don't match
      */
-    private checkPaymentRequestMatchesInitial;
+    private isPaymentRequestMatchingInitial;
     startRestServer(restServer: Express): void;
     init(): Promise<void>;
     getInfoData(): any;

package/dist/swaps/escrow/tobtcln_abstract/ToBtcLnAbs.js

@@ -537,26 +537,13 @@ class ToBtcLnAbs extends ToBtcBaseSwapHandler_1.ToBtcBaseSwapHandler {
      * Checks if the newly submitted PR has the same parameters (destination, cltv_delta, routes) as the initial dummy
      *  invoice sent for exactIn swap quote
      *
-     * @param pr
+     * @param parsedRequest
      * @param parsedAuth
-     * @throws {DefinedRuntimeError} will throw an error if the details don't match
      */
-    async checkPaymentRequestMatchesInitial(pr, parsedAuth) {
-        const parsedRequest = await this.lightning.parsePaymentRequest(pr);
-        if (parsedRequest.destination !== parsedAuth.initialInvoice.destination ||
-            parsedRequest.cltvDelta !== parsedAuth.initialInvoice.cltvDelta ||
-            parsedRequest.mtokens !== parsedAuth.amount * 1000n) {
-            throw {
-                code: 20102,
-                msg: "Provided PR doesn't match initial!"
-            };
-        }
-        if (!(0, ILightningWallet_1.routesMatch)(parsedRequest.routes, parsedAuth.initialInvoice.routes)) {
-            throw {
-                code: 20102,
-                msg: "Provided PR doesn't match initial (routes)!"
-            };
-        }
+    isPaymentRequestMatchingInitial(parsedRequest, parsedAuth) {
+        return parsedRequest.destination === parsedAuth.initialInvoice.destination &&
+            parsedRequest.cltvDelta === parsedAuth.initialInvoice.cltvDelta &&
+            (0, ILightningWallet_1.routesMatch)(parsedRequest.routes, parsedAuth.initialInvoice.routes);
     }
     startRestServer(restServer) {
         restServer.use(this.path + "/payInvoiceExactIn", (0, ServerParamDecoder_1.serverParamDecoder)(10 * 1000));
@@ -583,7 +570,25 @@ class ToBtcLnAbs extends ToBtcBaseSwapHandler_1.ToBtcBaseSwapHandler {
             const abortSignal = responseStream.getAbortSignal();
             //Check request params
             const { parsedPR, halfConfidence } = await this.checkPaymentRequest(parsedAuth.chainIdentifier, parsedBody.pr);
-            await this.checkPaymentRequestMatchesInitial(parsedBody.pr, parsedAuth);
+            if (parsedPR.mtokens !== parsedAuth.amount * 1000n)
+                throw {
+                    code: 20102,
+                    msg: "Provided PR doesn't match requested (amount)!"
+                };
+            if (!this.isPaymentRequestMatchingInitial(parsedPR, parsedAuth)) {
+                //The provided payment request doesn't match the parameters from the initial one, try to probe/route again
+                // with the same max fee parameters
+                const currentTimestamp = BigInt(Math.floor(Date.now() / 1000));
+                const { networkFee, confidence } = await this.checkAndGetNetworkFee(parsedAuth.amount, parsedAuth.quotedNetworkFee, parsedAuth.swapExpiry, currentTimestamp, parsedBody.pr, parsedAuth.metadata, abortSignal);
+                this.logger.info("REST: /payInvoiceExactIn: re-checked network fee for exact-in swap," +
+                    " reqId: " + parsedBody.reqId +
+                    " initialNetworkFee: " + parsedAuth.quotedNetworkFee.toString(10) +
+                    " newNetworkFee: " + networkFee.toString(10) +
+                    " oldConfidence: " + parsedAuth.confidence.toString(10) +
+                    " newConfidence: " + confidence.toString(10) +
+                    " invoice: " + parsedBody.pr);
+                parsedAuth.confidence = confidence;
+            }
             const metadata = parsedAuth.metadata;
             const sequence = base_1.BigIntBufferUtils.fromBuffer((0, crypto_1.randomBytes)(8));
             const { swapContract, signer } = this.getChain(parsedAuth.chainIdentifier);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atomiqlabs/lp-lib",
-  "version": "16.0.7",
+  "version": "16.0.9",
   "description": "Main functionality implementation for atomiq LP node",
   "main": "./dist/index.js",
   "types:": "./dist/index.d.ts",

package/src/swaps/assertions/FromBtcAmountAssertions.ts

@@ -201,7 +201,7 @@ export class FromBtcAmountAssertions extends AmountAssertions {
             this.checkBtcAmountInBounds(requestedAmount.amount);
             amountBD = requestedAmount.amount - amountBDgas;
             swapFee = fees.baseFee + ((amountBD * fees.feePPM + 999_999n) / 1000000n);
-            if(amountBD < 0n) {
+            if(amountBD - swapFee < 0n) {
                 throw {
                     code: 20003,
                     msg: "Amount too low!",
@@ -229,6 +229,11 @@ export class FromBtcAmountAssertions extends AmountAssertions {
             signal.throwIfAborted();
         }
 
+        if(totalInToken < 0n) throw {
+            code: 20003,
+            msg: "Amount too low!"
+        };
+
         return {
             amountBD,
             swapFee,

package/src/swaps/escrow/tobtc_abstract/ToBtcAbs.ts

@@ -708,6 +708,11 @@ export class ToBtcAbs extends ToBtcBaseSwapHandler<ToBtcSwapAbs, ToBtcSwapState>
             }, abortController.signal);
             metadata.times.priceCalculated = Date.now();
 
+            if(amountBD < 600n) throw {
+                code: "20019",
+                msg: "Swap output amount is below bitcoin dust (600 sats)!"
+            };
+
             const claimHash = this.getHash(chainIdentifier, parsedBody.address, parsedBody.confirmations, parsedBody.nonce, amountBD).toString("hex");
 
             //Add grace period another time, so the user has 1 hour to commit

package/src/swaps/escrow/tobtcln_abstract/ToBtcLnAbs.ts

@@ -666,30 +666,13 @@ export class ToBtcLnAbs extends ToBtcBaseSwapHandler<ToBtcLnSwapAbs, ToBtcLnSwap
      * Checks if the newly submitted PR has the same parameters (destination, cltv_delta, routes) as the initial dummy
      *  invoice sent for exactIn swap quote
      *
-     * @param pr
+     * @param parsedRequest
      * @param parsedAuth
-     * @throws {DefinedRuntimeError} will throw an error if the details don't match
      */
-    private async checkPaymentRequestMatchesInitial(pr: string, parsedAuth: ExactInAuthorization): Promise<void> {
-        const parsedRequest = await this.lightning.parsePaymentRequest(pr);
-
-        if(
-            parsedRequest.destination!==parsedAuth.initialInvoice.destination ||
-            parsedRequest.cltvDelta!==parsedAuth.initialInvoice.cltvDelta ||
-            parsedRequest.mtokens!==parsedAuth.amount * 1000n
-        ) {
-            throw {
-                code: 20102,
-                msg: "Provided PR doesn't match initial!"
-            };
-        }
-
-        if(!routesMatch(parsedRequest.routes, parsedAuth.initialInvoice.routes)) {
-            throw {
-                code: 20102,
-                msg: "Provided PR doesn't match initial (routes)!"
-            };
-        }
+    private isPaymentRequestMatchingInitial(parsedRequest: ParsedPaymentRequest, parsedAuth: ExactInAuthorization): boolean {
+        return parsedRequest.destination===parsedAuth.initialInvoice.destination &&
+            parsedRequest.cltvDelta===parsedAuth.initialInvoice.cltvDelta &&
+            routesMatch(parsedRequest.routes, parsedAuth.initialInvoice.routes);
     }
 
     startRestServer(restServer: Express) {
@@ -721,7 +704,27 @@ export class ToBtcLnAbs extends ToBtcBaseSwapHandler<ToBtcLnSwapAbs, ToBtcLnSwap
 
             //Check request params
             const {parsedPR, halfConfidence} = await this.checkPaymentRequest(parsedAuth.chainIdentifier, parsedBody.pr);
-            await this.checkPaymentRequestMatchesInitial(parsedBody.pr, parsedAuth);
+            if(parsedPR.mtokens!==parsedAuth.amount*1000n) throw {
+                code: 20102,
+                msg: "Provided PR doesn't match requested (amount)!"
+            };
+            if(!this.isPaymentRequestMatchingInitial(parsedPR, parsedAuth)) {
+                //The provided payment request doesn't match the parameters from the initial one, try to probe/route again
+                // with the same max fee parameters
+                const currentTimestamp: bigint = BigInt(Math.floor(Date.now()/1000));
+                const {networkFee, confidence} = await this.checkAndGetNetworkFee(
+                    parsedAuth.amount, parsedAuth.quotedNetworkFee, parsedAuth.swapExpiry,
+                    currentTimestamp, parsedBody.pr, parsedAuth.metadata, abortSignal
+                );
+                this.logger.info("REST: /payInvoiceExactIn: re-checked network fee for exact-in swap,"+
+                    " reqId: "+parsedBody.reqId+
+                    " initialNetworkFee: "+parsedAuth.quotedNetworkFee.toString(10)+
+                    " newNetworkFee: "+networkFee.toString(10)+
+                    " oldConfidence: "+parsedAuth.confidence.toString(10)+
+                    " newConfidence: "+confidence.toString(10)+
+                    " invoice: "+parsedBody.pr);
+                parsedAuth.confidence = confidence;
+            }
 
             const metadata = parsedAuth.metadata;