@atomicfinance/types 4.0.0 → 4.0.2

package/.yalc/@node-dlc/messaging/coverage/lcov-report/lib/messages/OrderAccept.ts.html

@@ -23,16 +23,16 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">84.78% </span>
+                <span class="strong">83.02% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>39/46</span>
+                <span class='fraction'>44/53</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">16.67% </span>
+                <span class="strong">21.43% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>1/6</span>
+                <span class='fraction'>3/14</span>
             </div>
         
             
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">84.44% </span>
+                <span class="strong">82.69% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>38/45</span>
+                <span class='fraction'>43/52</span>
             </div>
         
             
@@ -216,10 +216,24 @@
 <a name='L157'></a><a href='#L157'>157</a>
 <a name='L158'></a><a href='#L158'>158</a>
 <a name='L159'></a><a href='#L159'>159</a>
-<a name='L160'></a><a href='#L160'>160</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">1x</span>
+<a name='L160'></a><a href='#L160'>160</a>
+<a name='L161'></a><a href='#L161'>161</a>
+<a name='L162'></a><a href='#L162'>162</a>
+<a name='L163'></a><a href='#L163'>163</a>
+<a name='L164'></a><a href='#L164'>164</a>
+<a name='L165'></a><a href='#L165'>165</a>
+<a name='L166'></a><a href='#L166'>166</a>
+<a name='L167'></a><a href='#L167'>167</a>
+<a name='L168'></a><a href='#L168'>168</a>
+<a name='L169'></a><a href='#L169'>169</a>
+<a name='L170'></a><a href='#L170'>170</a>
+<a name='L171'></a><a href='#L171'>171</a>
+<a name='L172'></a><a href='#L172'>172</a>
+<a name='L173'></a><a href='#L173'>173</a>
+<a name='L174'></a><a href='#L174'>174</a>
+<a name='L175'></a><a href='#L175'>175</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
-<span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -250,6 +264,8 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
@@ -273,10 +289,18 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">4x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">4x</span>
+<span class="cline-any cline-yes">4x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">4x</span>
+<span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -307,10 +331,16 @@
 <span class="cline-any cline-yes">8x</span>
 <span class="cline-any cline-yes">8x</span>
 <span class="cline-any cline-yes">8x</span>
-<span class="cline-any cline-yes">8x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">8x</span>
+<span class="cline-any cline-yes">8x</span>
+<span class="cline-any cline-yes">8x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">8x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -378,7 +408,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { BufferReader, BufferWriter } from '@node-dlc/bufio';
 &nbsp;
 import { MessageType } from '../MessageType';
-import { getTlv } from '../serialize/getTlv';
 import { IDlcMessage } from './DlcMessage';
 import {
   IOrderNegotiationFieldsV0JSON,
@@ -407,9 +436,11 @@ export class OrderAccept implements IDlcMessage {
       'hex',
     );
 &nbsp;
-    // Handle OrderNegotiationFields - will be parsed during deserialization if needed
-<span class="cstat-no" title="statement not covered" >    instance.negotiationFields =</span>
-      json.negotiationFields || json.negotiation_fields;
+    // Handle OrderNegotiationFields - optional field
+<span class="cstat-no" title="statement not covered" >    if (json.negotiationFields || json.negotiation_fields) {</span>
+<span class="cstat-no" title="statement not covered" >      instance.negotiationFields =</span>
+        json.negotiationFields || json.negotiation_fields;
+    }
 &nbsp;
 <span class="cstat-no" title="statement not covered" >    return instance;</span>
   }
@@ -432,9 +463,17 @@ export class OrderAccept implements IDlcMessage {
     }
 &nbsp;
     instance.tempOrderId = reader.readBytes(32);
-    instance.negotiationFields = OrderNegotiationFields.deserialize(
-      getTlv(reader),
-    );
+&nbsp;
+    // Check if negotiation_fields is present
+    const hasNegotiationFields = reader.readUInt8();
+    <span class="missing-if-branch" title="else path not taken" >E</span>if (hasNegotiationFields === 0x01) {
+      // Read the remaining bytes as negotiationFields (not TLV format)
+      const remainingLength = buf.length - reader.position;
+      const remainingBytes = reader.readBytes(remainingLength);
+      instance.negotiationFields = OrderNegotiationFields.deserialize(
+        remainingBytes,
+      );
+    }
 &nbsp;
     return instance;
   }
@@ -446,7 +485,7 @@ export class OrderAccept implements IDlcMessage {
 &nbsp;
   public tempOrderId: Buffer;
 &nbsp;
-  public negotiationFields: OrderNegotiationFields;
+  public negotiationFields?: OrderNegotiationFields;
 &nbsp;
   /**
    * Converts order_accept to JSON
@@ -455,7 +494,7 @@ export class OrderAccept implements IDlcMessage {
 <span class="cstat-no" title="statement not covered" >    return {</span>
       type: this.type,
       tempOrderId: this.tempOrderId.toString('hex'),
-      negotiationFields: this.negotiationFields.toJSON(),
+      negotiationFields: this.negotiationFields?.toJSON(),
     };
   }
 &nbsp;
@@ -466,7 +505,14 @@ export class OrderAccept implements IDlcMessage {
     const writer = new BufferWriter();
     writer.writeUInt16BE(this.type);
     writer.writeBytes(this.tempOrderId);
-    writer.writeBytes(this.negotiationFields.serialize());
+&nbsp;
+    // negotiation_fields is optional
+    <span class="missing-if-branch" title="else path not taken" >E</span>if (this.negotiationFields) {
+      writer.writeUInt8(0x01); // present
+      writer.writeBytes(this.negotiationFields.serialize());
+    } else {
+<span class="cstat-no" title="statement not covered" >      writer.writeUInt8(0x00); </span>// absent
+    }
 &nbsp;
     return writer.toBuffer();
   }
@@ -475,9 +521,8 @@ export class OrderAccept implements IDlcMessage {
 export interface IOrderAcceptJSON {
   type: number;
   tempOrderId: string;
-  negotiationFields:
-    | IOrderNegotiationFieldsV0JSON
-    | IOrderNegotiationFieldsV1JSON;
+  negotiationFields?: // Now optional
+  IOrderNegotiationFieldsV0JSON | IOrderNegotiationFieldsV1JSON;
 }
 &nbsp;
 export class OrderAcceptContainer {
@@ -541,7 +586,7 @@ export class OrderAcceptContainer {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Jun 26 2025 23:34:07 GMT-0700 (Pacific Daylight Saving Time)
+                at Sat Jul 19 2025 20:06:33 GMT-0700 (Pacific Daylight Saving Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/.yalc/@node-dlc/messaging/coverage/lcov-report/lib/messages/OrderIrcInfo.ts.html

@@ -364,7 +364,7 @@ export interface IOrderIrcInfoJSON {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Jun 26 2025 23:34:07 GMT-0700 (Pacific Daylight Saving Time)
+                at Sat Jul 19 2025 20:06:33 GMT-0700 (Pacific Daylight Saving Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/.yalc/@node-dlc/messaging/coverage/lcov-report/lib/messages/OrderMetadata.ts.html

@@ -421,7 +421,7 @@ export interface IOrderMetadataJSON {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Jun 26 2025 23:34:07 GMT-0700 (Pacific Daylight Saving Time)
+                at Sat Jul 19 2025 20:06:33 GMT-0700 (Pacific Daylight Saving Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>