@atomic-testing/component-driver-mui-v9 0.88.0 → 0.90.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atomic-testing/component-driver-mui-v9",
-  "version": "0.88.0",
+  "version": "0.90.0",
   "description": "Component driver for Material-UI v9",
   "repository": {
     "type": "git",
@@ -28,10 +28,10 @@
     "@emotion/react": "^11.14.0",
     "@emotion/styled": "^11.14.1",
     "@mui/material": "^9.0.0",
-    "@atomic-testing/core": "0.88.0",
-    "@atomic-testing/dom-core": "0.88.0",
-    "@atomic-testing/react-18": "0.88.0",
-    "@atomic-testing/component-driver-html": "0.88.0"
+    "@atomic-testing/core": "0.90.0",
+    "@atomic-testing/dom-core": "0.90.0",
+    "@atomic-testing/react-18": "0.90.0",
+    "@atomic-testing/component-driver-html": "0.90.0"
   },
   "devDependencies": {
     "@types/react": ">=18.0.0",

package/src/components/DialogDriver.ts

@@ -35,11 +35,11 @@ export class DialogDriver<ContentT extends ScenePart> extends ContainerDriver<Co
     });
   }
 
-  override overriddenParentLocator(): Optional<PartLocator> {
+  static override overriddenParentLocator(): Optional<PartLocator> {
     return dialogRootLocator;
   }
 
-  override overrideLocatorRelativePosition(): Optional<LocatorRelativePosition> {
+  static override overrideLocatorRelativePosition(): Optional<LocatorRelativePosition> {
     return 'Same';
   }
 

package/src/components/DrawerDriver.ts

@@ -52,11 +52,11 @@ export class DrawerDriver<ContentT extends ScenePart> extends OverlayDriver<Cont
     });
   }
 
-  override overriddenParentLocator(): Optional<PartLocator> {
+  static override overriddenParentLocator(): Optional<PartLocator> {
     return drawerRootLocator;
   }
 
-  override overrideLocatorRelativePosition(): Optional<LocatorRelativePosition> {
+  static override overrideLocatorRelativePosition(): Optional<LocatorRelativePosition> {
     return 'Same';
   }
 

package/src/components/MenuDriver.ts

@@ -32,11 +32,11 @@ export class MenuDriver extends ComponentDriver<typeof parts> {
     });
   }
 
-  override overriddenParentLocator(): Optional<PartLocator> {
+  static override overriddenParentLocator(): Optional<PartLocator> {
     return menuRootLocator;
   }
 
-  override overrideLocatorRelativePosition(): Optional<LocatorRelativePosition> {
+  static override overrideLocatorRelativePosition(): Optional<LocatorRelativePosition> {
     return 'Same';
   }
 

package/src/components/OverlayDriver.ts

@@ -11,8 +11,8 @@ const defaultTransitionDuration = 250;
  * `closeByBackdrop`.
  *
  * Subclasses supply {@link getSurfaceLocator} (the element whose visibility means
- * "open") and, when the overlay is portal-rendered, override
- * `overriddenParentLocator()`/`overrideLocatorRelativePosition()` to re-root.
+ * "open") and, when the overlay is portal-rendered, override the static
+ * `overriddenParentLocator()`/`overrideLocatorRelativePosition()` portal hooks to re-root.
  *
  * `closeByEscape` is intentionally absent: keyboard dismissal needs a key-press
  * primitive the `Interactor` interface does not yet expose, which would have to be

package/src/components/RatingDriver.ts

@@ -1,7 +1,6 @@
 import { HTMLRadioButtonGroupDriver } from '@atomic-testing/component-driver-html';
 import {
   byCssClass,
-  byCssSelector,
   byInputType,
   byValue,
   ComponentDriver,
@@ -92,24 +91,17 @@ export class RatingDriver extends ComponentDriver<typeof parts> implements IInpu
       return true;
     }
 
-    // Clearing (value == null) reuses MUI's "click the selected star again to
-    // reset" behaviour by re-clicking the current value's label. This resets the
-    // rating in real browsers but not in jsdom, where MUI's clear path depends on
-    // pointer coordinates that jsdom does not provide; the empty radio (`value=""`)
-    // that jsdom could click has no `<label>` and is not reliably clickable in
-    // browsers. A fully portable clear needs a coordinate-free click primitive on
-    // the Interactor. TODO(#68): revisit once that primitive exists.
-    const valueToClick = value ?? currentValue;
-    if (valueToClick == null) {
-      return true;
-    }
-
-    const targetLocator = locatorUtil.append(this.parts.choices.locator, byValue(valueToClick.toString(), 'Same'));
+    // Activate the visually-hidden `<input type="radio">` whose `value` attribute
+    // matches the target — the empty-string radio (MUI's "no rating") for a clear.
+    // `activate` is coordinate-free, so it reaches inputs a positional click cannot:
+    // the half-star label for fractional values is zero-width and unclickable in a
+    // real browser (#86), and the clear radio has no `<label>` at all (#68). This
+    // unifies integer, fractional, and clear on one portable path.
+    const targetValue = value == null ? '' : value.toString();
+    const targetLocator = locatorUtil.append(this.parts.choices.locator, byValue(targetValue, 'Same'));
     const targetExists = await this.interactor.exists(targetLocator);
     if (targetExists) {
-      const id = await this.interactor.getAttribute(targetLocator, 'id');
-      const labelLocator = locatorUtil.append(this.locator, byCssSelector(`label[for="${id}"]`));
-      await this.interactor.click(labelLocator);
+      await this.interactor.activate(targetLocator);
     }
     // TODO: throw error if the value does not exist
     return targetExists;

package/src/errors/MenuItemNotFoundError.ts

@@ -1,17 +1,13 @@
-import { ComponentDriver, ErrorBase } from '@atomic-testing/core';
+import { ComponentDriver, ItemNotFoundError } from '@atomic-testing/core';
 
 export const MenuItemNotFoundErrorId = 'MenuItemNotFoundError';
 
-function getErrorMessage(label: string): string {
-  return `Cannot find menu item with label: ${label}`;
-}
-
-export class MenuItemNotFoundError extends ErrorBase {
+export class MenuItemNotFoundError extends ItemNotFoundError {
   constructor(
     public readonly label: string,
-    public readonly driver: ComponentDriver<any>
+    driver: ComponentDriver<any>
   ) {
-    super(getErrorMessage(label), driver);
+    super(label, driver, `Cannot find menu item with label: ${label}`);
     this.name = MenuItemNotFoundErrorId;
   }
 }