@atlisp/lint 0.1.5 → 0.1.8

package/dist/checks/multiple-setq.js

@@ -12,7 +12,7 @@ function checkMultipleSetqAst(ast, file) {
     const issues = [];
     // Find all parent lists that contain at least one setq
     const parents = new Set();
-    const setqNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'setq'));
+    const setqNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'setq'));
     for (const n of setqNodes) {
         if (n.parent)
             parents.add(n.parent);

package/dist/checks/no-return.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkNoReturn(content: string, file: string): Issue[];
+//# sourceMappingURL=no-return.d.ts.map

package/dist/checks/no-return.js

@@ -0,0 +1,51 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkNoReturn = checkNoReturn;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkNoReturn(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    let inDefun = false;
+    let defunName = '';
+    let defunStart = 0;
+    let depth = 0;
+    let hasReturn = false;
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        if (!inDefun) {
+            const m = stripped.match(/\(defun\s+(\S+)/);
+            if (m) {
+                inDefun = true;
+                defunName = m[1];
+                defunStart = i + 1;
+                depth = 0;
+                hasReturn = false;
+            }
+        }
+        if (inDefun) {
+            for (const ch of stripped) {
+                if (ch === '(')
+                    depth++;
+                else if (ch === ')')
+                    depth--;
+            }
+            if (stripped.trim().startsWith('(') && !stripped.includes('defun'))
+                hasReturn = true;
+            if (depth === 0 && defunName && !defunName.startsWith('c:')) {
+                if (!hasReturn) {
+                    issues.push({
+                        file,
+                        line: defunStart,
+                        severity: 'warn',
+                        rule: 'no_return',
+                        message: (0, locale_1.t)('no_return', defunName),
+                    });
+                }
+                inDefun = false;
+            }
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=no-return.js.map

package/dist/checks/nth-usage.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkNthUsage(content: string, file: string): Issue[];
+//# sourceMappingURL=nth-usage.d.ts.map

package/dist/checks/nth-usage.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkNthUsage = checkNthUsage;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkNthUsage(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        if (/\(nth\s+0\b/.test(stripped)) {
+            issues.push({ file, line: i + 1, severity: 'warn', rule: 'nth_usage', message: (0, locale_1.t)('nth_usage') });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=nth-usage.js.map

package/dist/checks/quote-style.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkQuoteStyle(content: string, file: string): Issue[];
+//# sourceMappingURL=quote-style.d.ts.map

package/dist/checks/quote-style.js

@@ -0,0 +1,25 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkQuoteStyle = checkQuoteStyle;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkQuoteStyle(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        // Detect (quote ...) that could be '
+        const m = stripped.match(/\(quote\s+/);
+        if (m) {
+            issues.push({
+                file,
+                line: i + 1,
+                severity: 'warn',
+                rule: 'quote_style',
+                message: (0, locale_1.t)('quote_style'),
+            });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=quote-style.js.map

package/dist/checks/quote-vs-function.js

@@ -22,7 +22,7 @@ function checkQuoteVsFunction(content, file) {
 }
 function checkQuoteVsFunctionAst(ast, file) {
     const issues = [];
-    const quotedLambdas = (0, parser_1.astFindAll)(ast, (n) => {
+    const quotedLambdas = (0, parser_1.astFindAll)(ast, n => {
         if (!(0, parser_1.astIsList)(n, 'quote'))
             return false;
         if (!n.children || n.children.length < 2)

package/dist/checks/recursive-call.js

@@ -10,7 +10,7 @@ function checkRecursiveCall(content, file) {
 }
 function checkRecursiveCallAst(ast, file) {
     const issues = [];
-    const defuns = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'defun'));
+    const defuns = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'defun'));
     for (const defun of defuns) {
         if (!defun.children || defun.children.length < 3)
             continue;

package/dist/checks/redundant-if.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkRedundantIf(content: string, file: string): Issue[];
+//# sourceMappingURL=redundant-if.d.ts.map

package/dist/checks/redundant-if.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkRedundantIf = checkRedundantIf;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkRedundantIf(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        if (/\((if|when|unless)\s+\S+\s+\(progn\b/.test(stripped)) {
+            issues.push({ file, line: i + 1, severity: 'warn', rule: 'redundant_if', message: (0, locale_1.t)('redundant_if') });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=redundant-if.js.map

package/dist/checks/redundant-let.js

@@ -10,7 +10,7 @@ function checkRedundantLet(content, file) {
 }
 function checkRedundantLetAst(ast, file) {
     const issues = [];
-    const letNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'let'));
+    const letNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'let'));
     for (const node of letNodes) {
         if (!node.children || node.children.length < 2)
             continue;

package/dist/checks/redundant-nil-else.js

@@ -11,7 +11,7 @@ function checkRedundantNilElse(content, file) {
 function checkRedundantNilElseAst(ast, file) {
     const issues = [];
     // Find (if cond then nil) — else branch is nil which is the default
-    const ifNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'if'));
+    const ifNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'if'));
     for (const node of ifNodes) {
         if (!node.children || node.children.length !== 4)
             continue;

package/dist/checks/redundant-progn.js

@@ -10,7 +10,7 @@ function checkRedundantProgn(content, file) {
 }
 function checkRedundantPrognAst(ast, file) {
     const issues = [];
-    const prognNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'progn'));
+    const prognNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'progn'));
     for (const node of prognNodes) {
         if (!node.children)
             continue;

package/dist/checks/redundant-quotes.js

@@ -11,7 +11,7 @@ function checkRedundantQuotes(content, file) {
 function checkRedundantQuotesAst(ast, file) {
     const issues = [];
     // ''x → (quote (quote x)) — nested quote
-    const doubleQuotes = (0, parser_1.astFindAll)(ast, (n) => {
+    const doubleQuotes = (0, parser_1.astFindAll)(ast, n => {
         if (!(0, parser_1.astIsList)(n, 'quote'))
             return false;
         if (!n.children || n.children.length < 2)

package/dist/checks/redundant-setq.js

@@ -10,7 +10,7 @@ function checkRedundantSetq(content, file) {
 }
 function checkRedundantSetqAst(ast, file) {
     const issues = [];
-    const setqNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'setq'));
+    const setqNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'setq'));
     for (const node of setqNodes) {
         if (!node.children)
             continue;

package/dist/checks/self-compare.js

@@ -12,7 +12,7 @@ function checkSelfCompare(content, file) {
 function checkSelfCompareAst(ast, file) {
     const issues = [];
     for (const fn of COMPARE_FUNCTIONS) {
-        const nodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, fn));
+        const nodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, fn));
         for (const node of nodes) {
             if (!node.children)
                 continue;

package/dist/checks/setq-multiple.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkSetqMultiple(content: string, file: string): Issue[];
+//# sourceMappingURL=setq-multiple.d.ts.map

package/dist/checks/setq-multiple.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkSetqMultiple = checkSetqMultiple;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkSetqMultiple(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        if (/\(setq\s+\S+\s+[^\s)]+\)\s*\(setq\b/.test(stripped)) {
+            issues.push({ file, line: i + 1, severity: 'warn', rule: 'setq_multiple', message: (0, locale_1.t)('setq_multiple') });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=setq-multiple.js.map

package/dist/checks/setq-single-arg.d.ts

@@ -0,0 +1,5 @@
+import { Issue } from '../types';
+import { AstNode } from '@atlisp/parser';
+export declare function checkSetqSingleArg(content: string, file: string): Issue[];
+export declare function checkSetqSingleArgAst(ast: AstNode, file: string): Issue[];
+//# sourceMappingURL=setq-single-arg.d.ts.map

package/dist/checks/setq-single-arg.js

@@ -0,0 +1,30 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkSetqSingleArg = checkSetqSingleArg;
+exports.checkSetqSingleArgAst = checkSetqSingleArgAst;
+const locale_1 = require("../locale");
+const parser_1 = require("@atlisp/parser");
+function checkSetqSingleArg(content, file) {
+    const ast = (0, parser_1.parseAst)(content);
+    return checkSetqSingleArgAst(ast, file);
+}
+function checkSetqSingleArgAst(ast, file) {
+    const issues = [];
+    const nodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'setq'));
+    for (const node of nodes) {
+        if (!node.children)
+            continue;
+        // (setq x) — 2 children: 'setq', x — missing value
+        if (node.children.length === 2) {
+            issues.push({
+                file,
+                line: node.pos.line,
+                severity: 'warn',
+                rule: 'setq_single_arg',
+                message: (0, locale_1.t)('setq_single_arg', node.children[1].name || ''),
+            });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=setq-single-arg.js.map

package/dist/checks/shadow-builtin.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkShadowBuiltin(content: string, file: string): Issue[];
+//# sourceMappingURL=shadow-builtin.d.ts.map

package/dist/checks/shadow-builtin.js

@@ -0,0 +1,77 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkShadowBuiltin = checkShadowBuiltin;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+const BUILTINS = new Set([
+    'car',
+    'cdr',
+    'cons',
+    'list',
+    'append',
+    'length',
+    'member',
+    'assoc',
+    'subst',
+    'apply',
+    'mapcar',
+    'foreach',
+    'while',
+    'repeat',
+    'if',
+    'cond',
+    'progn',
+    'setq',
+    'set',
+    'quote',
+    'function',
+    'lambda',
+    'defun',
+    'princ',
+    'print',
+    'prompt',
+    'getint',
+    'getreal',
+    'getstring',
+    'getpoint',
+    'getvar',
+    'setvar',
+    'command',
+    'vlax-',
+    'vla-',
+    'vl-',
+    'ssget',
+    'ssname',
+    'sslength',
+    'entget',
+    'entmod',
+    'entmake',
+    'entdel',
+    'entlast',
+    'entsel',
+    'tblobjname',
+    'tblsearch',
+    'tblnext',
+    'regapp',
+    'startapp',
+    'vl-registry-write',
+    'vl-registry-read',
+    'vl-registry-delete',
+    'vl-catch-all-apply',
+    'vl-catch-all-error-p',
+    'vl-load-com',
+    'vlax-get-or-create-object',
+]);
+function checkShadowBuiltin(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        const m = stripped.match(/\(defun\s+(\S+)\b/);
+        if (m && BUILTINS.has(m[1].toLowerCase())) {
+            issues.push({ file, line: i + 1, severity: 'warn', rule: 'shadow_builtin', message: (0, locale_1.t)('shadow_builtin', m[1]) });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=shadow-builtin.js.map

package/dist/checks/single-arg-and-or.js

@@ -11,7 +11,7 @@ function checkSingleArgAndOr(content, file) {
 function checkSingleArgAndOrAst(ast, file) {
     const issues = [];
     for (const form of ['and', 'or']) {
-        const nodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, form));
+        const nodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, form));
         for (const node of nodes) {
             if (!node.children)
                 continue;

package/dist/checks/strcat-usage.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkStrcatUsage(content: string, file: string): Issue[];
+//# sourceMappingURL=strcat-usage.d.ts.map

package/dist/checks/strcat-usage.js

@@ -0,0 +1,25 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkStrcatUsage = checkStrcatUsage;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkStrcatUsage(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLineRaw)(lines[i]);
+        // Check for (+ "str" ...) pattern
+        const m = stripped.match(/\(\+\s+"[^"]*"/);
+        if (m) {
+            issues.push({
+                file,
+                line: i + 1,
+                severity: 'warn',
+                rule: 'strcat_usage',
+                message: (0, locale_1.t)('strcat_usage'),
+            });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=strcat-usage.js.map

package/dist/checks/type-check.d.ts

@@ -0,0 +1,3 @@
+import { Issue } from '../types';
+export declare function checkTypeCheck(content: string, file: string): Issue[];
+//# sourceMappingURL=type-check.d.ts.map

package/dist/checks/type-check.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkTypeCheck = checkTypeCheck;
+const locale_1 = require("../locale");
+const utils_1 = require("../utils");
+function checkTypeCheck(content, file) {
+    const issues = [];
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const stripped = (0, utils_1.stripLine)(lines[i]);
+        const m = stripped.match(/\(setq\s+\S+\s+\(getvar\b/);
+        if (m) {
+            const varName = m[0].match(/\(setq\s+(\S+)/)?.[1] || '';
+            if (!varName)
+                continue;
+            const body = lines.slice(i, i + 5).join('\n');
+            const typeChk = '(type ' + varName;
+            const eqTypeChk = '(= (type ' + varName;
+            if (!body.includes(typeChk) && !body.includes(eqTypeChk)) {
+                issues.push({ file, line: i + 1, severity: 'warn', rule: 'type_check', message: (0, locale_1.t)('type_check', varName) });
+            }
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=type-check.js.map

package/dist/checks/unused-let.js

@@ -10,7 +10,7 @@ function checkUnusedLetBinding(content, file) {
 }
 function checkUnusedLetBindingAst(ast, file) {
     const issues = [];
-    const letNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'let'));
+    const letNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'let'));
     for (const node of letNodes) {
         if (!node.children || node.children.length < 2)
             continue;

package/dist/checks/unused-package-dep.js

@@ -41,7 +41,7 @@ function checkUnusedPackageDep(file) {
     const issues = [];
     const content = fs.readFileSync(file, 'utf-8');
     const ast = (0, parser_1.parseAst)(content);
-    const inPackageNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'in-package'));
+    const inPackageNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'in-package'));
     if (inPackageNodes.length === 0)
         return issues;
     const allPackages = new Set();
@@ -51,7 +51,7 @@ function checkUnusedPackageDep(file) {
         }
     }
     const usedSymbols = new Set();
-    const allLists = (0, parser_1.astFindAll)(ast, (n) => n.type === 'list');
+    const allLists = (0, parser_1.astFindAll)(ast, n => n.type === 'list');
     for (const node of allLists) {
         if (!node.children || node.children.length === 0)
             continue;
@@ -78,7 +78,7 @@ function checkUnusedPackageDep(file) {
     allPackages.delete(mainPackage);
     for (const pkg of allPackages) {
         if (!usedSymbols.has(pkg)) {
-            const node = inPackageNodes.find((n) => n.children && n.children.length >= 2 && (0, parser_1.astIsSymbol)(n.children[1]) && n.children[1].name === pkg);
+            const node = inPackageNodes.find(n => n.children && n.children.length >= 2 && (0, parser_1.astIsSymbol)(n.children[1]) && n.children[1].name === pkg);
             issues.push({
                 file,
                 line: node ? node.pos.line : 1,

package/dist/checks/variable-shadow.js

@@ -10,7 +10,7 @@ function checkVariableShadow(content, file) {
 }
 function checkVariableShadowAst(ast, file) {
     const issues = [];
-    const letNodes = (0, parser_1.astFindAll)(ast, (n) => (0, parser_1.astIsList)(n, 'let'));
+    const letNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'let'));
     for (const node of letNodes) {
         if (!node.children || node.children.length < 2)
             continue;

package/dist/checks/while-constant.d.ts

@@ -0,0 +1,5 @@
+import { Issue } from '../types';
+import { AstNode } from '@atlisp/parser';
+export declare function checkWhileConstant(content: string, file: string): Issue[];
+export declare function checkWhileConstantAst(ast: AstNode, file: string): Issue[];
+//# sourceMappingURL=while-constant.d.ts.map

package/dist/checks/while-constant.js

@@ -0,0 +1,40 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkWhileConstant = checkWhileConstant;
+exports.checkWhileConstantAst = checkWhileConstantAst;
+const locale_1 = require("../locale");
+const parser_1 = require("@atlisp/parser");
+function checkWhileConstant(content, file) {
+    const ast = (0, parser_1.parseAst)(content);
+    return checkWhileConstantAst(ast, file);
+}
+function checkWhileConstantAst(ast, file) {
+    const issues = [];
+    const whileNodes = (0, parser_1.astFindAll)(ast, n => (0, parser_1.astIsList)(n, 'while'));
+    for (const node of whileNodes) {
+        if (!node.children || node.children.length < 2)
+            continue;
+        const cond = node.children[1];
+        // Check for constant conditions: nil, T, 1, 0, etc.
+        if (cond.type === 'symbol' && (cond.name === 'nil' || cond.name === 'T')) {
+            issues.push({
+                file,
+                line: node.pos.line,
+                severity: 'warn',
+                rule: 'while_constant',
+                message: (0, locale_1.t)('while_constant', cond.name),
+            });
+        }
+        else if (cond.type === 'number') {
+            issues.push({
+                file,
+                line: node.pos.line,
+                severity: 'warn',
+                rule: 'while_constant',
+                message: (0, locale_1.t)('while_constant', String(cond.value)),
+            });
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=while-constant.js.map

package/dist/config.d.ts

@@ -1,5 +1,6 @@
 import { LintConfig } from './types';
 export declare function loadConfig(configPath?: string): LintConfig;
+export declare function getCheckSeverity(config: LintConfig, rule: string): string;
 export declare function findOverrides(filepath: string): Partial<LintConfig> | null;
 export declare function mergeOverrides(base: LintConfig, overrides: Partial<LintConfig>): LintConfig;
 //# sourceMappingURL=config.d.ts.map