@atlassian/webresource-webpack-plugin 4.10.2-64a2ef2

package/test/use-cases/asset-loading-via-js/asset-loading-via-js.test.js

@@ -0,0 +1,61 @@
+const assert = require('chai').assert;
+const parse = require('xml-parser');
+const webpack = require('webpack');
+const fs = require('fs');
+const path = require('path');
+
+const targetDir = path.join(__dirname, 'target');
+const webresourceOutput = path.join(targetDir, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml');
+
+describe('asset-loading-via-js', function() {
+    const config = require('./webpack.config.js');
+
+    let stats;
+    let assets;
+    let resources;
+
+    beforeEach(done => {
+        webpack(config, (err, st) => {
+            stats = st;
+
+            const xmlFile = fs.readFileSync(webresourceOutput, 'utf-8');
+            const results = parse(xmlFile);
+            assets = results.root.children.find(n => n.attributes.key.startsWith('assets'));
+            resources = assets.children.filter(n => n.name === 'resource');
+            done();
+        });
+    });
+
+    it('should create an "asset"-webresource containing the asset', () => {
+        assert.ok(assets);
+        assert.equal(stats.hasErrors(), false);
+        assert.equal(stats.hasWarnings(), false);
+        assert.equal(resources[0].attributes.type, 'download');
+        assert.equal(path.extname(resources[0].attributes.name), '.png');
+    });
+
+    it('should add all assets to the "asset"-webresource', () => {
+        assert.ok(assets);
+        assert.equal(stats.hasErrors(), false);
+        assert.equal(stats.hasWarnings(), false);
+        assert.equal(resources.length, 2);
+        assert.equal(resources[0].attributes.type, 'download');
+        assert.equal(path.extname(resources[0].attributes.name), '.png');
+        assert.equal(resources[1].attributes.type, 'download');
+        assert.equal(path.extname(resources[1].attributes.name), '.svg');
+    });
+
+    it('should overwrite webpack output path to point to a wrm-resource', () => {
+        // setup
+        const bundleFile = fs.readFileSync(path.join(targetDir, 'app.js'), 'utf-8');
+        const publicPathLines = bundleFile.match(/__webpack_require__\.p\s*?=.+?;/g);
+        const injectedLine = publicPathLines.find(line => line.includes('download'));
+
+        assert.isNotEmpty(
+            injectedLine,
+            'an override to the public path helper that uses a WRM-friendly URL should be injected, but was not'
+        );
+        assert.startsWith(injectedLine, '__webpack_require__.p = AJS.contextPath()');
+        assert.endsWith(injectedLine, `/download/resources/com.atlassian.plugin.test:${assets.attributes.key}/";`);
+    });
+});

package/test/use-cases/asset-loading-via-js/src/app.js

@@ -0,0 +1,8 @@
+import ice from './ice.png';
+import rect from './rect.svg';
+
+const image = new Image();
+image.src = ice;
+
+const image2 = new Image();
+image2.src = rect;

package/test/use-cases/asset-loading-via-js/src/rect.svg

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg width="48px" height="64px" viewBox="0 0 48 64" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <rect width="48" height="64" style="fill:rgb(0,0,255)" />
+</svg>

package/test/use-cases/asset-loading-via-js/webpack.config.js

@@ -0,0 +1,31 @@
+const path = require('path');
+const WrmPlugin = require('../../../src/WrmPlugin');
+const FRONTEND_SRC_DIR = path.join(__dirname, 'src');
+const OUTPUT_DIR = path.join(__dirname, 'target');
+
+module.exports = {
+    mode: 'development',
+    entry: {
+        app: path.join(FRONTEND_SRC_DIR, 'app.js'),
+    },
+    devtool: false,
+    module: {
+        rules: [
+            {
+                test: /\.(png|svg)$/,
+                loader: 'file-loader',
+            },
+        ],
+    },
+    plugins: [
+        new WrmPlugin({
+            pluginKey: 'com.atlassian.plugin.test',
+            xmlDescriptors: path.join(OUTPUT_DIR, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml'),
+            verbose: false,
+        }),
+    ],
+    output: {
+        filename: '[name].js',
+        path: OUTPUT_DIR,
+    },
+};

package/test/use-cases/associations-complex/associations-complex.test.js

@@ -0,0 +1,82 @@
+const fs = require('fs');
+const path = require('path');
+const webpack = require('webpack');
+const expect = require('chai').expect;
+
+const config = require('./webpack.config');
+
+const targetDir = path.join(__dirname, 'target/classes');
+const webresourceOutput = path.join(targetDir, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml');
+
+describe('associations-complex', () => {
+    before(done => {
+        webpack(config, (err, stats) => {
+            if (err) {
+                throw err;
+            }
+
+            if (stats.hasErrors() || stats.hasWarnings()) {
+                throw Error('Webpack build failed.');
+            }
+
+            done();
+        });
+    });
+
+    it('compiles an xml file', () => {
+        expect(fs.existsSync(webresourceOutput)).to.be.equal(true);
+    });
+
+    it('output includes compiled and copied files', () => {
+        const files = fs.readdirSync(targetDir);
+        const jsFiles = files.filter(file => path.extname(file) === '.js');
+
+        expect(jsFiles).to.deep.equal([
+            'copied-file-should-be-ignored.js',
+            'qunit-require-shim-DEV_PSEUDO_HASH.js',
+            'simple-entry-2.js',
+            'simple-entry.js',
+            'simple-entry~simple-entry-2.js',
+        ]);
+    });
+
+    describe('association file', () => {
+        let associationJsonContent;
+
+        before(() => {
+            const jsonPath = path.join(
+                targetDir,
+                'META-INF/fe-manifest-associations/com.atlassian.plugin.test-webpack.intermediary.json'
+            );
+
+            const isJsonExisting = fs.existsSync(jsonPath);
+            if (!isJsonExisting) {
+                throw new Error('Association JSON was not created.');
+            }
+
+            associationJsonContent = JSON.parse(fs.readFileSync(jsonPath, 'utf-8'));
+        });
+
+        it('association file structure is correct', () => {
+            expect(associationJsonContent).to.have.property('packageName');
+            expect(typeof associationJsonContent.packageName).to.equal('string');
+            expect(associationJsonContent).to.have.property('outputDirectoryFiles');
+            expect(associationJsonContent.outputDirectoryFiles).to.be.an('array');
+        });
+
+        it('association package name is inferred from build context', () => {
+            expect(associationJsonContent.packageName).to.equal(
+                '@atlassian/webpack-webresource-plugin.tests.associations-complex'
+            );
+        });
+
+        it('association file includes relatives paths for files compiled through entries (exclusively) plus qunit-require-shim', () => {
+            expect(associationJsonContent.outputDirectoryFiles).to.deep.equal([
+                'simple-entry~simple-entry-2.js',
+                'simple-entry.js',
+                'simple-entry-2.js',
+                'qunit-require-shim-DEV_PSEUDO_HASH.js',
+            ]);
+        });
+    });
+});

package/test/use-cases/associations-complex/package-lock.json

@@ -0,0 +1,73 @@
+{
+  "name": "@atlassian/webpack-webresource-plugin.tests.associations-complex",
+  "version": "0.0.1",
+  "lockfileVersion": 3,
+  "requires": true,
+  "packages": {
+    "": {
+      "name": "@atlassian/webpack-webresource-plugin.tests.associations-complex",
+      "version": "0.0.1",
+      "dependencies": {
+        "atlassian-webresource-webpack-plugin": "file:../../.."
+      },
+      "engines": {
+        "node": ">=12",
+        "npm": ">=6.9"
+      }
+    },
+    "../../..": {
+      "version": "4.9.0",
+      "license": "Apache-2.0",
+      "dependencies": {
+        "glob": "^7.1.2",
+        "lodash": "^4.17.15",
+        "mkdirp": "^0.5.1",
+        "pretty-data": "^0.40.0",
+        "tapable": "^1.1.0",
+        "url-join": "^4.0.0",
+        "uuid": "^3.3.2",
+        "webpack-merge": "^4.2.2",
+        "webpack-sources": "^1.1.0"
+      },
+      "devDependencies": {
+        "babel-eslint": "^10.0.1",
+        "chai": "^4.2.0",
+        "chai-string": "^1.5.0",
+        "chai-uuid": "^1.0.6",
+        "css-loader": "^1.0.1",
+        "eslint": "^5.9.0",
+        "eslint-config-prettier": "^3.3.0",
+        "eslint-plugin-babel": "^5.2.1",
+        "eslint-plugin-filenames": "^1.3.2",
+        "eslint-plugin-jasmine": "^2.10.1",
+        "eslint-plugin-mocha": "^5.2.0",
+        "eslint-plugin-node": "^8.0.0",
+        "eslint-plugin-prettier": "^3.0.0",
+        "extract-text-webpack-plugin": "4.0.0-beta.0",
+        "file-loader": "^2.0.0",
+        "jquery": "^3.4.1",
+        "mini-css-extract-plugin": "^0.4.4",
+        "mocha": "^5.2.0",
+        "mocha-junit-reporter": "^1.18.0",
+        "prettier": "^1.15.2",
+        "prettier-eslint": "^8.8.2",
+        "style-loader": "^0.23.1",
+        "underscore": "^1.9.1",
+        "webpack": "^4.41.3",
+        "webpack-cli": "^3.1.2",
+        "xml-parser": "^1.2.1"
+      },
+      "engines": {
+        "node": ">=8.12.0",
+        "npm": ">=6.9.0"
+      },
+      "peerDependencies": {
+        "webpack": "^4"
+      }
+    },
+    "node_modules/atlassian-webresource-webpack-plugin": {
+      "resolved": "../../..",
+      "link": true
+    }
+  }
+}

package/test/use-cases/associations-complex/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@atlassian/webpack-webresource-plugin.tests.associations-complex",
+  "version": "0.0.1",
+  "private": true,
+  "engines": {
+    "node": ">=12",
+    "npm": ">=6.9"
+  }
+}

package/test/use-cases/associations-complex/src/entry.js

@@ -0,0 +1,5 @@
+import { logChunk } from './to-be-chunked';
+
+define('module/a', [], function() {
+    logChunk();
+});

package/test/use-cases/associations-complex/src/entry2.js

@@ -0,0 +1,5 @@
+import { logChunk } from './to-be-chunked';
+
+define('module/a', [], function() {
+    logChunk();
+});

package/test/use-cases/associations-complex/src/qunit.tests.js

@@ -0,0 +1,2 @@
+// This file tests a use case where a project has qunit test files and WWRP
+// injects the qunit-require-shim file into the output.

package/test/use-cases/associations-complex/src/to-be-chunked.js

@@ -0,0 +1 @@
+export const logChunk = () => console.log('this file will be chunked.');

package/test/use-cases/associations-complex/webpack.config.js

@@ -0,0 +1,48 @@
+const WrmPlugin = require('../../../src/WrmPlugin');
+const path = require('path');
+const fs = require('fs');
+
+const FRONTEND_SRC_DIR = path.resolve(__dirname, 'src');
+const OUTPUT_DIR = path.resolve(__dirname, 'target/classes');
+
+const DIRECT_COPY_FILE = 'copied-file-should-be-ignored.js';
+
+module.exports = {
+    mode: 'development',
+    context: FRONTEND_SRC_DIR,
+    entry: {
+        'simple-entry': path.join(FRONTEND_SRC_DIR, 'entry.js'),
+        'simple-entry-2': path.join(FRONTEND_SRC_DIR, 'entry2.js'),
+    },
+    optimization: {
+        splitChunks: {
+            chunks: 'all',
+            minSize: 0,
+        },
+    },
+    plugins: [
+        new WrmPlugin({
+            pluginKey: 'com.atlassian.plugin.test',
+            contextMap: { 'simple-entry': [''] },
+            addEntrypointNameAsContext: true,
+            xmlDescriptors: path.join(OUTPUT_DIR, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml'),
+            verbose: false,
+            __testGlobs__: ['./**/*.tests.js'],
+        }),
+        {
+            apply: compiler => {
+                compiler.plugin('emit', (compilation, callback) => {
+                    const sourceFile = path.join(compiler.context, DIRECT_COPY_FILE);
+                    const destinationFile = path.join(compiler.outputPath, DIRECT_COPY_FILE);
+                    fs.mkdirSync(path.dirname(destinationFile), { recursive: true });
+                    fs.copyFileSync(sourceFile, destinationFile);
+                    callback();
+                });
+            },
+        },
+    ],
+    output: {
+        filename: '[name].js',
+        path: path.resolve(OUTPUT_DIR),
+    },
+};

package/test/use-cases/associations-simple/associations-simple.test.js

@@ -0,0 +1,65 @@
+const fs = require('fs');
+const path = require('path');
+const webpack = require('webpack');
+const expect = require('chai').expect;
+
+const config = require('./webpack.config');
+
+const targetDir = path.join(__dirname, 'target/classes');
+const webresourceOutput = path.join(targetDir, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml');
+
+describe('simple case with association', () => {
+    before(done => {
+        webpack(config, (err, stats) => {
+            if (err) {
+                throw err;
+            }
+
+            if (stats.hasErrors() || stats.hasWarnings()) {
+                throw Error('Webpack build failed.');
+            }
+
+            done();
+        });
+    });
+
+    it('compiles an xml file', () => {
+        expect(fs.existsSync(webresourceOutput)).to.be.equal(true);
+    });
+
+    describe('association file', () => {
+        let associationJsonContent;
+
+        before(() => {
+            const jsonPath = path.join(
+                targetDir,
+                'META-INF/fe-manifest-associations/com.atlassian.plugin.test-webpack.intermediary.json'
+            );
+
+            const isJsonExisting = fs.existsSync(jsonPath);
+            if (!isJsonExisting) {
+                throw new Error('Association JSON was not created.');
+            }
+
+            associationJsonContent = JSON.parse(fs.readFileSync(jsonPath, 'utf-8'));
+        });
+
+        it('association file structure is correct', () => {
+            expect(associationJsonContent).to.have.property('packageName');
+            expect(typeof associationJsonContent.packageName).to.equal('string');
+            expect(associationJsonContent).to.have.property('outputDirectoryFiles');
+            expect(associationJsonContent.outputDirectoryFiles).to.be.an('array');
+        });
+
+        it('association package name is taken from config', () => {
+            expect(associationJsonContent.packageName).to.equal(
+                '@atlassian/webpack-webresource-plugin.tests.associations-simple'
+            );
+        });
+
+        it('association file includes relatives paths for files compiled through entries (exclusively)', () => {
+            expect(associationJsonContent.outputDirectoryFiles).to.include('simple-entry.js');
+            expect(associationJsonContent.outputDirectoryFiles.length).to.equal(1);
+        });
+    });
+});

package/test/use-cases/associations-simple/package-lock.json

@@ -0,0 +1,69 @@
+{
+  "name": "@atlassian/webpack-webresource-plugin.tests.associations-simple",
+  "version": "0.0.1",
+  "lockfileVersion": 3,
+  "requires": true,
+  "packages": {
+    "": {
+      "name": "@atlassian/webpack-webresource-plugin.tests.associations-simple",
+      "version": "0.0.1",
+      "dependencies": {
+        "atlassian-webresource-webpack-plugin": "file:../../.."
+      }
+    },
+    "../../..": {
+      "version": "4.9.0",
+      "license": "Apache-2.0",
+      "dependencies": {
+        "glob": "^7.1.2",
+        "lodash": "^4.17.15",
+        "mkdirp": "^0.5.1",
+        "pretty-data": "^0.40.0",
+        "tapable": "^1.1.0",
+        "url-join": "^4.0.0",
+        "uuid": "^3.3.2",
+        "webpack-merge": "^4.2.2",
+        "webpack-sources": "^1.1.0"
+      },
+      "devDependencies": {
+        "babel-eslint": "^10.0.1",
+        "chai": "^4.2.0",
+        "chai-string": "^1.5.0",
+        "chai-uuid": "^1.0.6",
+        "css-loader": "^1.0.1",
+        "eslint": "^5.9.0",
+        "eslint-config-prettier": "^3.3.0",
+        "eslint-plugin-babel": "^5.2.1",
+        "eslint-plugin-filenames": "^1.3.2",
+        "eslint-plugin-jasmine": "^2.10.1",
+        "eslint-plugin-mocha": "^5.2.0",
+        "eslint-plugin-node": "^8.0.0",
+        "eslint-plugin-prettier": "^3.0.0",
+        "extract-text-webpack-plugin": "4.0.0-beta.0",
+        "file-loader": "^2.0.0",
+        "jquery": "^3.4.1",
+        "mini-css-extract-plugin": "^0.4.4",
+        "mocha": "^5.2.0",
+        "mocha-junit-reporter": "^1.18.0",
+        "prettier": "^1.15.2",
+        "prettier-eslint": "^8.8.2",
+        "style-loader": "^0.23.1",
+        "underscore": "^1.9.1",
+        "webpack": "^4.41.3",
+        "webpack-cli": "^3.1.2",
+        "xml-parser": "^1.2.1"
+      },
+      "engines": {
+        "node": ">=8.12.0",
+        "npm": ">=6.9.0"
+      },
+      "peerDependencies": {
+        "webpack": "^4"
+      }
+    },
+    "node_modules/atlassian-webresource-webpack-plugin": {
+      "resolved": "../../..",
+      "link": true
+    }
+  }
+}

package/test/use-cases/associations-simple/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "@atlassian/webpack-webresource-plugin.tests.associations-simple",
+  "version": "0.0.1",
+  "private": true
+}

package/test/use-cases/associations-simple/src/simple.js

@@ -0,0 +1,3 @@
+define('module/a', [], function() {
+    console.log('it really is simple.');
+});

package/test/use-cases/associations-simple/webpack.config.js

@@ -0,0 +1,27 @@
+const WrmPlugin = require('../../../src/WrmPlugin');
+const path = require('path');
+
+const FRONTEND_SRC_DIR = path.resolve(__dirname, 'src');
+const OUTPUT_DIR = path.resolve(__dirname, 'target/classes');
+
+module.exports = {
+    mode: 'development',
+    context: FRONTEND_SRC_DIR,
+    entry: {
+        'simple-entry': path.join(FRONTEND_SRC_DIR, 'simple.js'),
+    },
+    plugins: [
+        new WrmPlugin({
+            pluginKey: 'com.atlassian.plugin.test',
+            packageName: '@atlassian/webpack-webresource-plugin.tests.associations-simple',
+            contextMap: { 'simple-entry': [''] },
+            addEntrypointNameAsContext: true,
+            xmlDescriptors: path.join(OUTPUT_DIR, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml'),
+            verbose: false,
+        }),
+    ],
+    output: {
+        filename: '[name].js',
+        path: path.resolve(OUTPUT_DIR),
+    },
+};

package/test/use-cases/async-chunks/async-chunks.test.js

@@ -0,0 +1,113 @@
+const assert = require('chai').assert;
+const parse = require('xml-parser');
+const webpack = require('webpack');
+const fs = require('fs');
+const path = require('path');
+
+const targetDir = path.join(__dirname, 'target');
+const webresourceOutput = path.join(targetDir, 'META-INF', 'plugin-descriptor', 'wr-webpack-bundles.xml');
+
+describe('async-chunks', function() {
+    const config = require('./webpack.config.js');
+
+    let stats;
+    let runtime;
+    let app;
+    let asyncChunk1;
+    let asyncChunk2;
+
+    function getDependencies(node) {
+        return node.children.filter(n => n.name === 'dependency');
+    }
+
+    function getContent(nodes) {
+        return nodes.map(n => n.content);
+    }
+
+    beforeEach(done => {
+        webpack(config, (err, st) => {
+            stats = st;
+
+            const xmlFile = fs.readFileSync(webresourceOutput, 'utf-8');
+            const results = parse(xmlFile);
+            runtime = results.root.children.find(n => n.attributes.key.startsWith('entry'));
+            app = results.root.children.find(n => n.attributes.key === 'split_app');
+            asyncChunk1 = results.root.children.find(n => n.attributes.key === '0');
+            asyncChunk2 = results.root.children.find(n => n.attributes.key === '1');
+            done();
+        });
+    });
+
+    it('should create a webresource for each async chunk', () => {
+        assert.ok(app, 'entry does not exist');
+        assert.ok(asyncChunk1, 'asyncChunk1 does not exist');
+        assert.ok(asyncChunk2, 'asyncChunk2 does not exist');
+        assert.equal(stats.hasErrors(), false, 'should not have errors');
+        assert.equal(stats.hasWarnings(), false, 'should not have warnings');
+    });
+
+    it('should inject a WRM pre-condition checker into the webpack runtime', () => {
+        // setup
+        const bundleFile = fs.readFileSync(path.join(targetDir, 'runtime~app.js'), 'utf-8');
+        const expectedRuntimeAdjustment = `
+/******/ 		var promises = [];
+/******/
+/******/ 		if(installedChunks[chunkId] === 0) { // 0 means "already installed".
+/******/ 		    return Promise.resolve();
+/******/ 		}
+/******/
+/******/ 		if (installedChunks[chunkId]) {
+/******/ 		    return installedChunks[chunkId][2];
+/******/ 		}
+/******/
+/******/ 		promises.push(
+/******/ 		    new Promise(function(resolve, reject) {
+/******/ 		        installedChunks[chunkId] = [resolve, reject];
+/******/ 		    }),
+/******/ 		    new Promise(function(resolve, reject) {
+/******/ 		        WRM.require('wrc!com.atlassian.plugin.test:' + chunkId).then(resolve, reject);
+/******/ 		    })
+/******/ 		);
+/******/ 		return installedChunks[chunkId][2] = Promise.all(promises);`;
+
+        assert.include(bundleFile, expectedRuntimeAdjustment);
+    });
+
+    describe('web-resource dependencies', () => {
+        let entryDeps;
+        let appDeps;
+        let async1Deps;
+        let async2Deps;
+
+        beforeEach(() => {
+            entryDeps = getContent(getDependencies(runtime));
+            appDeps = getContent(getDependencies(app));
+            async1Deps = getContent(getDependencies(asyncChunk1));
+            async2Deps = getContent(getDependencies(asyncChunk2));
+        });
+
+        it('adds required WRM dependency only to the web-resource with the webpack runtime', () => {
+            const WRM_KEY = 'com.atlassian.plugins.atlassian-plugins-webresource-rest:web-resource-manager';
+            assert.equal(entryDeps.includes(WRM_KEY), true);
+            assert.notEqual(appDeps.includes(WRM_KEY), true);
+            assert.notEqual(async1Deps.includes(WRM_KEY), true);
+            assert.notEqual(async2Deps.includes(WRM_KEY), true);
+        });
+
+        it('adds shared provided dependencies only to the app', () => {
+            const UNDERSCORE_KEY = 'com.atlassian.plugin.jslibs:underscore-1.4.4';
+            assert.notEqual(entryDeps.includes(UNDERSCORE_KEY), true);
+            assert.equal(appDeps.includes(UNDERSCORE_KEY), true);
+            assert.notEqual(async1Deps.includes(UNDERSCORE_KEY), true);
+            assert.notEqual(async2Deps.includes(UNDERSCORE_KEY), true);
+        });
+
+        it('adds async-chunk-only deps only to the async-chunk-webresource', () => {
+            const JQUERY_KEY = 'jira.webresources:jquery';
+            assert.notEqual(entryDeps.includes(JQUERY_KEY), true);
+            assert.notEqual(appDeps.includes(JQUERY_KEY), true);
+            assert.equal(async1Deps.includes(JQUERY_KEY), true);
+            assert.notEqual(async2Deps.includes(JQUERY_KEY), true);
+        });
+    });
+});

package/test/use-cases/async-chunks/src/app.js

@@ -0,0 +1,9 @@
+import _ from 'underscore';
+
+import('./async-bar').then(x => {
+    console.log(x);
+});
+
+import('./async-foo').then(x => {
+    console.log(x);
+});

package/test/use-cases/async-chunks/src/async-bar.js

@@ -0,0 +1,4 @@
+import $ from 'jquery';
+import _ from 'underscore';
+
+export default 'bar';

package/test/use-cases/async-chunks/src/async-foo.js

@@ -0,0 +1,2 @@
+export default 'foo';
+import _ from 'underscore';