@atlassian/aui 9.2.1 → 9.2.5

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@atlassian/aui",
     "description": "Atlassian User Interface library",
-    "version": "9.2.1",
+    "version": "9.2.5",
     "author": "Atlassian Pty Ltd.",
     "homepage": "https://aui.atlassian.com",
     "license": "Apache-2.0",
@@ -38,11 +38,11 @@
         "backbone": "1.4.0",
         "css.escape": "1.5.0",
         "fancy-file-input": "2.0.4",
-        "jquery-ui": "1.12.1",
+        "jquery-ui": "1.13.0",
         "skatejs": "0.13.17",
         "skatejs-template-html": "0.0.0",
         "trim-extra-html-whitespace": "1.3.0",
-        "underscore": "1.10.2"
+        "underscore": "1.13.1"
     },
     "devDependencies": {
         "@atlassian/adg-server-iconfont": "3.1.0",

package/src/js/aui/date-picker.js

@@ -337,6 +337,11 @@ const initPolyfill = function (datePicker) {
     // shows that changing the `type` of input does not erase its value.
     // see https://codepen.io/chrisdarroch/pen/YzwgjyJ
     $field.prop('type', 'text');
+    // Set default value on initialization to handle all date formats.
+    // It is possible, because of changing type to text on the line above.
+    $field.val($field.attr('value'));
+    // Trigger change to update calendar popup value.
+    $field.trigger('propertychange');
 
     // demonstrate the polyfill is initialised
     $field.attr('data-aui-dp-uuid', datePickerUUID);

package/src/js/aui/i18n.js

@@ -1,5 +1,5 @@
 import format from './format';
-import globalize from './internal/globalize';
+import { putOnI18nIfAbsent } from './internal/globalize';
 import keys from './internal/i18n/aui';
 
 /**
@@ -7,7 +7,7 @@ import keys from './internal/i18n/aui';
  * the key is returned - this could occur in plugin mode if the I18n transform is not performed;
  * or in flatpack mode if the i18n JS file is not loaded.
  */
-export var I18n = {
+const I18n = {
     keys: keys,
     getText: function (key, ...params) {
         if (Object.prototype.hasOwnProperty.call(this.keys, key)) {
@@ -18,10 +18,19 @@ export var I18n = {
     }
 };
 
+export {
+    I18n,
+    format
+}
+
 /**
  * Deprecated - do not use AJS.I18n.getText from global scope within AUI code. Use import { I18n } from '../i18n'
  * Also keep in mind that WRM is looking for patterns like "I18n.getText" so do not create
  * aliases for I18n or export it from here using 'default'. Webpack transforms it then to
  * 'd.default.getText' and it won't match.
  **/
-globalize('I18n', I18n);
+// eslint-disable-next-line guard-for-in
+for (const property in I18n) {
+    // AUI-5431 Add to global namespace, but do not override what is set by the WRM
+    putOnI18nIfAbsent(property, I18n[property]);
+}

package/src/js/aui/inline-dialog.js

@@ -6,7 +6,7 @@ import globalize from './internal/globalize';
 import keyCode from './key-code';
 import cssEscape from 'css.escape';
 
-/* eslint quotmark:off, eqeqeq:off, strict:off, complexity:off */
+/* eslint quotes:off, eqeqeq:off, strict:off, complexity:off */
 
 /**
  * Creates a new inline dialog.

package/src/js/aui/internal/globalize.js

@@ -1,9 +1,39 @@
 const NAMESPACE = 'AJS';
+const I18N_OBJECT_NAME = 'I18n';
 
-export default function globalize (name, value) {
+function initNamespace() {
     if (typeof window[NAMESPACE] !== 'object') {
         window[NAMESPACE] = {};
     }
+}
+
+/**
+ * Makes given value available globally under window[name] attribute.
+ * Keep in mind that this is needed for p2-plugin where chunks of AUI
+ * can be loaded separately.
+ *
+ * In order for global namespace to work in `aui.prototyping.js` and
+ * `aui.prototyping.nodeps.js` the proper exports need to be added to:
+ * `packages/core/entry/aui.batch.prototyping.js`
+ *
+ * @param {string} name Name of the attribute
+ * @param {any} value Value to expose globally
+ * @returns exposed value
+ */
+export default function globalize (name, value) {
+    initNamespace();
 
     return window[NAMESPACE][name] = value;
 }
+
+export function putOnI18nIfAbsent (name, value) {
+    initNamespace();
+
+    if (typeof window[NAMESPACE][I18N_OBJECT_NAME] !== 'object') {
+        window[NAMESPACE][I18N_OBJECT_NAME] = {};
+    }
+
+    if (typeof window[NAMESPACE][I18N_OBJECT_NAME][name] === 'undefined') {
+        window[NAMESPACE][I18N_OBJECT_NAME][name] = value;
+    }
+}

package/src/js/aui/tabs.js

@@ -214,7 +214,7 @@ function calculateResponsiveTabs(tabsContainer, index) {
         }
 
         if (!$tabsContainer.hasClass('aui-tabs-disabled')) {
-            $dropdown.on('click', 'a', handleTabClick);
+            $dropdown.on('click.aui-tabs', 'a', handleTabClick);
         }
 
         /* Workaround for bug in Edge where the dom is just not being re-rendered properly
@@ -371,7 +371,7 @@ function getResponsiveTabs () {
 function initWindow () {
     const handler = debounce(responsiveResizeHandler, 200);
     handler(getResponsiveTabs());
-    $(window).on('resize', () => handler(getResponsiveTabs()));
+    $(window).on('resize.aui-tabs', () => handler(getResponsiveTabs()));
 }
 
 function initTab (tab) {
@@ -392,7 +392,7 @@ function initTab (tab) {
         });
 
         // Set up click event for tabs
-        $tabMenu.on('click', 'a', handleTabClick);
+        $tabMenu.on('click.aui-tabs', 'a', handleTabClick);
         $tab.data('aui-tab-events-bound', true);
 
         initPanes(tab);

package/src/js-vendor/jquery/plugins/jquery.form.js

@@ -136,6 +136,9 @@ $.fn.ajaxSubmit = function(options) {
 		var oldSuccess = options.success || function(){};
 		callbacks.push(function(data) {
 			var fn = options.replaceTarget ? 'replaceWith' : 'html';
+			// Validate `data` through `HTML encoding` when passed `data` is passed
+			// to `html()`, as suggested in https://github.com/jquery-form/form/issues/464
+			fn == 'html' ? data = $.parseHTML($("<div>").text(data).html()) : '';
 			$(options.target)[fn](data).each(oldSuccess, arguments);
 		});
 	}
@@ -428,7 +431,10 @@ $.fn.ajaxSubmit = function(options) {
 			return (doc && doc.documentElement && doc.documentElement.nodeName != 'parsererror') ? doc : null;
 		};
 		var parseJSON = $.parseJSON || function(s) {
-			return window['eval']('(' + s + ')');
+			// Arise an error resolvable including jquery instead of
+            // making a new function using unsanitized inputs
+            window.console.error('jquery.parseJSON is undefined');
+			return null;
 		};
 
 		var httpData = function( xhr, type, s ) { // mostly lifted from jq1.4.4

package/src/less/aui-select2.less

@@ -234,14 +234,16 @@
 .aui-select2-container.select2-container .select2-choice:after {
     #aui.icon-pseudoelement();
     content: @aui-glyph-chevron-down;
-    left: 100%; /* "left" + "margin-left" required because of webkit not working properly with "right" */
     height: 0;
     margin-left: -18px;
     margin-top: -2px;
     opacity: 1;
     position: absolute;
-    top: 7px;
+    top: calc(50% - 10px);
     width: 0;
+    font-size: 16px;
+    line-height: 24px;
+    right: 22px;
 }
 
 /* Set the default text color to inherit.
@@ -272,9 +274,12 @@
 .aui-select2-container.select2-container-multi .select2-choices {
     #aui-forms.aui-select2-input-field-style(normal);
     #aui.icon(@aui-glyph-chevron-down, {
-        font-size: inherit;
+        font-size: 16.5px;
         left: inherit;
-        right: 0;
+        color: var(--aui-button-default-text-color);
+        right: 3px;
+        top: 50%;
+        line-height: 16px;
     });
 
     min-height: 0;

package/src/less/forms-current.less

@@ -243,13 +243,14 @@ form.aui:not(.aui-legacy-forms) {
     }
 
     // both are @ak-color-N600
-    @chevron-dark:   url('data:image/svg+xml,%3Csvg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath fill="%23A5ADBA" d="m6.744 8.744a1.053 1.053 0 0 0 0 1.49l4.547 4.557a1 1 0 0 0 1.416 0l4.55-4.558a1.051 1.051 0 1 0-1.488-1.488l-3.77 3.776-3.768-3.776a1.051 1.051 0 0 0-1.487 0z"/%3E%3C/svg%3E%0A');
-    @chevron-light:  url('data:image/svg+xml,%3Csvg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath fill="%23344563" d="m6.744 8.744a1.053 1.053 0 0 0 0 1.49l4.547 4.557a1 1 0 0 0 1.416 0l4.55-4.558a1.051 1.051 0 1 0-1.488-1.488l-3.77 3.776-3.768-3.776a1.051 1.051 0 0 0-1.487 0z"/%3E%3C/svg%3E%0A');
+    @chevron-dark:   url('data:image/svg+xml,%3Csvg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath fill="%23A5ADBA" d="M8.292 10.293a1.009 1.009 0 000 1.419l2.939 2.965c.218.215.5.322.779.322s.556-.107.769-.322l2.93-2.955a1.01 1.01 0 000-1.419.987.987 0 00-1.406 0l-2.298 2.317-2.307-2.327a.99.99 0 00-1.406 0z"/%3E%3C/svg%3E%0A');
+    @chevron-light:  url('data:image/svg+xml,%3Csvg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath fill="%23344563" d="M8.292 10.293a1.009 1.009 0 000 1.419l2.939 2.965c.218.215.5.322.779.322s.556-.107.769-.322l2.93-2.955a1.01 1.01 0 000-1.419.987.987 0 00-1.406 0l-2.298 2.317-2.307-2.327a.99.99 0 00-1.406 0z"/%3E%3C/svg%3E%0A');
 
     select[disabled]:not([size]),
     .select:not([size]) {
         background-repeat: no-repeat;
-        background-position: 100% 50%;
+        background-position: calc(100% + 1.5px) 50%;
+        background-size: 25px;
     }
 
     select.select[disabled]:not([size]) {
@@ -259,7 +260,7 @@ form.aui:not(.aui-legacy-forms) {
     }
 
     select.select:not([size]) {
-        padding-right: 22px;
+        padding-right: 20px;
         background-image: @chevron-light;
     }
 

package/src/less/imports/mixins/dropdown2-trigger-chevron-icon.less

@@ -2,7 +2,7 @@
 
 #aui {
     .aui-dropdown2-trigger-chevron-icon(@glyphsize: @aui-icon-size-small; @canvassize: @aui-icon-size-small-canvas) {
-        @canvas-padding: ((@canvassize - @glyphsize) / 2);
+
         #aui.icon-pseudoelement(@aui-icon-font-family);
         content: @aui-glyph-chevron-down;
         font-size: @glyphsize;
@@ -10,7 +10,7 @@
         line-height: 1;
         margin-top: -(@glyphsize / 2);
         position: absolute;
-        right: @canvas-padding;
+        right: 3.5px;
         top: 50%;
         text-indent: 0; // Reset indentation set by split button
         width: @glyphsize;

package/src/less/single-select.less

@@ -136,8 +136,6 @@ aui-select {
 
         &:not([aria-busy])::before {
             #aui.aui-dropdown2-trigger-chevron-icon();
-
-            right: ((@select-trigger-width - @aui-icon-size-small - (@aui-button-border-width *2)) / 2);
         }
     }
 }