@atlaspack/transformer-html 2.14.5-canary.145 → 2.14.5-canary.147

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaspack/transformer-html
 
+## 2.15.0
+
+### Minor Changes
+
+- [#731](https://github.com/atlassian-labs/atlaspack/pull/731) [`23d561e`](https://github.com/atlassian-labs/atlaspack/commit/23d561e51e68b0c38fd1ff4e4fb173e5e7b01cf2) Thanks [@marcins](https://github.com/marcins)! - Implement "inline isolated" scripts
+
+### Patch Changes
+
+- Updated dependencies [[`23d561e`](https://github.com/atlassian-labs/atlaspack/commit/23d561e51e68b0c38fd1ff4e4fb173e5e7b01cf2)]:
+  - @atlaspack/feature-flags@2.21.0
+  - @atlaspack/rust@3.5.0
+  - @atlaspack/plugin@2.14.23
+
 ## 2.14.22
 
 ### Patch Changes

package/lib/inline.js

@@ -18,6 +18,13 @@ function _posthtml() {
   };
   return data;
 }
+function _featureFlags() {
+  const data = require("@atlaspack/feature-flags");
+  _featureFlags = function () {
+    return data;
+  };
+  return data;
+}
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 // @ts-expect-error TS2724
 
@@ -113,6 +120,11 @@ function extractInlineAssets(asset, ast) {
         if ((_node$attrs = node.attrs) !== null && _node$attrs !== void 0 && _node$attrs.type && node.tag === 'style') {
           delete node.attrs.type;
         }
+        let bundleBehavior = 'inline';
+        if ((0, _featureFlags().getFeatureFlag)('inlineIsolatedScripts') && typeof node.attrs['data-atlaspack-isolated'] !== 'undefined') {
+          bundleBehavior = 'inlineIsolated';
+          delete node.attrs['data-atlaspack-isolated'];
+        }
 
         // insert parcelId to allow us to retrieve node during packaging
         node.attrs['data-parcel-key'] = parcelKey;
@@ -126,7 +138,7 @@ function extractInlineAssets(asset, ast) {
           type,
           content: value,
           uniqueKey: parcelKey,
-          bundleBehavior: 'inline',
+          bundleBehavior,
           // @ts-expect-error TS2322
           env,
           meta: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/transformer-html",
-  "version": "2.14.5-canary.145+231e0acb3",
+  "version": "2.14.5-canary.147+6a4a9e878",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -20,9 +20,10 @@
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/diagnostic": "2.14.1-canary.213+231e0acb3",
-    "@atlaspack/plugin": "2.14.5-canary.145+231e0acb3",
-    "@atlaspack/rust": "3.2.1-canary.145+231e0acb3",
+    "@atlaspack/diagnostic": "2.14.1-canary.215+6a4a9e878",
+    "@atlaspack/feature-flags": "2.14.1-canary.215+6a4a9e878",
+    "@atlaspack/plugin": "2.14.5-canary.147+6a4a9e878",
+    "@atlaspack/rust": "3.2.1-canary.147+6a4a9e878",
     "nullthrows": "^1.1.1",
     "posthtml": "^0.16.5",
     "posthtml-parser": "^0.10.1",
@@ -31,8 +32,8 @@
     "srcset": "4"
   },
   "devDependencies": {
-    "@atlaspack/core": "2.16.2-canary.145+231e0acb3"
+    "@atlaspack/core": "2.16.2-canary.147+6a4a9e878"
   },
   "type": "commonjs",
-  "gitHead": "231e0acb3008231b09b224868f415771d087c23c"
+  "gitHead": "6a4a9e878585987cdb3488f9655b645fc86935a5"
 }

package/src/inline.ts

@@ -1,9 +1,15 @@
-import type {AST, MutableAsset, TransformerResult} from '@atlaspack/types';
+import type {
+  AST,
+  BundleBehavior,
+  MutableAsset,
+  TransformerResult,
+} from '@atlaspack/types';
 import {hashString} from '@atlaspack/rust';
 // @ts-expect-error TS2724
 import type {PostHTMLNode} from 'posthtml';
 
 import PostHTML from 'posthtml';
+import {getFeatureFlag} from '@atlaspack/feature-flags';
 
 const SCRIPT_TYPES = {
   'application/javascript': 'js',
@@ -120,6 +126,15 @@ export default function extractInlineAssets(
           delete node.attrs.type;
         }
 
+        let bundleBehavior: BundleBehavior = 'inline';
+        if (
+          getFeatureFlag('inlineIsolatedScripts') &&
+          typeof node.attrs['data-atlaspack-isolated'] !== 'undefined'
+        ) {
+          bundleBehavior = 'inlineIsolated';
+          delete node.attrs['data-atlaspack-isolated'];
+        }
+
         // insert parcelId to allow us to retrieve node during packaging
         node.attrs['data-parcel-key'] = parcelKey;
         asset.setAST(ast); // mark dirty
@@ -133,7 +148,7 @@ export default function extractInlineAssets(
           type,
           content: value,
           uniqueKey: parcelKey,
-          bundleBehavior: 'inline',
+          bundleBehavior,
           // @ts-expect-error TS2322
           env,
           meta: {

package/test/HTMLTransformer.test.ts

@@ -351,4 +351,25 @@ describe('HTMLTransformer', () => {
       },
     ]);
   });
+
+  it('transforms simple inline script with data-atlaspack-isolated', async () => {
+    const code = `
+<html>
+  <body>
+    <script data-atlaspack-isolated>console.log('blah'); require('path');</script>
+  </body>
+</html>
+    `;
+    const {transformResult, inputAsset} = await runTestTransform(code);
+    assert(transformResult.includes(inputAsset));
+    const assets = normalizeAssets(transformResult);
+    assert.deepEqual(assets[1], {
+      type: 'js',
+      content: "console.log('blah'); require('path');",
+      uniqueKey: 'a8a37984d2e520b9',
+      bundleBehavior: 'inlineIsolated',
+      env: null,
+      meta: null,
+    });
+  });
 });