@atlaspack/runtime-js 2.12.1-canary.3589 → 2.12.1-canary.3592

package/lib/JSRuntime.js

@@ -404,7 +404,16 @@ function getLoaderRuntime({
     } else if (to.type === 'js' && to.env.outputFormat === 'commonjs') {
       return `Promise.resolve(__parcel__require__("./" + ${relativePathExpr}))`;
     }
-    let absoluteUrlExpr = shouldUseRuntimeManifest(bundle, options) ? `require('./helpers/bundle-manifest').resolve(${JSON.stringify(to.publicId)})` : getAbsoluteUrlExpr(relativePathExpr, bundle, to, shardingConfig);
+    let absoluteUrlExpr;
+    if (shouldUseRuntimeManifest(bundle, options)) {
+      let publicId = JSON.stringify(to.publicId);
+      absoluteUrlExpr = `require('./helpers/bundle-manifest').resolve(${publicId})`;
+      if (shardingConfig) {
+        absoluteUrlExpr = `require('@atlaspack/domain-sharding').shardUrl(${absoluteUrlExpr}, ${shardingConfig.maxShards})`;
+      }
+    } else {
+      absoluteUrlExpr = getAbsoluteUrlExpr(relativePathExpr, bundle, to, shardingConfig);
+    }
     let code = `require(${JSON.stringify(loader)})(${absoluteUrlExpr})`;
 
     // In development, clear the require cache when an error occurs so the
@@ -546,6 +555,9 @@ function getURLRuntime(dependency, from, to, options, shardingConfig) {
     } else {
       code += `let bundleURL = require('./helpers/bundle-url');\n`;
       code += `let url = bundleURL.getBundleURL('${from.publicId}') + ${relativePathExpr};`;
+      if (shardingConfig) {
+        code += `url = require('@atlaspack/domain-sharding').shardUrl(url, ${shardingConfig.maxShards});`;
+      }
       code += `module.exports = workerURL(url, bundleURL.getOrigin(url), ${String(from.env.outputFormat === 'esmodule')});`;
     }
   } else {
@@ -602,10 +614,11 @@ function getAbsoluteUrlExpr(relativePathExpr, fromBundle, toBundle, shardingConf
     // This will be compiled to new URL(url, import.meta.url) or new URL(url, 'file:' + __filename).
     return `new __parcel__URL__(${relativePathExpr}).toString()`;
   }
-  if (shardingConfig) {
-    return `require('./helpers/bundle-url-shards').getShardedBundleURL('${toBundle.name}', ${shardingConfig.maxShards}) + ${relativePathExpr}`;
+  const regularBundleUrl = `require('./helpers/bundle-url').getBundleURL('${fromBundle.publicId}') + ${relativePathExpr}`;
+  if (!shardingConfig) {
+    return regularBundleUrl;
   }
-  return `require('./helpers/bundle-url').getBundleURL('${fromBundle.publicId}') + ${relativePathExpr}`;
+  return `require('@atlaspack/domain-sharding').shardUrl(${regularBundleUrl}, ${shardingConfig.maxShards})`;
 }
 function shouldUseRuntimeManifest(bundle, options) {
   let env = bundle.env;

package/lib/helpers/bundle-url.js

@@ -1,8 +1,6 @@
 "use strict";
 
-var _require = require('./bundle-url-common'),
-  getBaseURL = _require.getBaseURL,
-  stackTraceUrlRegexp = _require.stackTraceUrlRegexp;
+var stackTraceUrlRegexp = /(https?|file|ftp|(chrome|moz|safari-web)-extension):\/\/[^)\n]+/g;
 var bundleURL = {};
 
 /**
@@ -10,19 +8,30 @@ var bundleURL = {};
  * If the URL is not cached, it computes and stores it in the cache.
  *
  * @param {string} id - The identifier for the bundle.
+ * @param {Error?} inputError - An error object to extract the stack trace from
+ * (for testing purposes).
  * @returns {string} The URL of the bundle, without file name.
  */
-function getBundleURLCached(id) {
+function getBundleURLCached(id, inputError) {
   var value = bundleURL[id];
   if (!value) {
-    value = getBundleURL();
+    value = getBundleURL(inputError);
     bundleURL[id] = value;
   }
   return value;
 }
-function getBundleURL() {
+
+/** Get the URL without the filename (last / segment)
+ *
+ * @param {string} url
+ * @returns {string} The URL with the file name removed
+ */
+function getBaseURL(url) {
+  return url.slice(0, url.lastIndexOf('/')) + '/';
+}
+function getBundleURL(inputError) {
   try {
-    throw new Error();
+    throw inputError !== null && inputError !== void 0 ? inputError : new Error();
   } catch (err) {
     var matches = ('' + err.stack).match(stackTraceUrlRegexp);
     if (matches) {
@@ -41,5 +50,8 @@ function getBundleURL() {
 function getOrigin(url) {
   return new URL(url).origin;
 }
+
+// TODO: convert this file to ESM once HMR issues are resolved
 exports.getOrigin = getOrigin;
-exports.getBundleURL = getBundleURLCached;
+exports.getBundleURL = getBundleURLCached;
+exports.getBaseURL = getBaseURL;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/runtime-js",
-  "version": "2.12.1-canary.3589+5a0e0f961",
+  "version": "2.12.1-canary.3592+27d350650",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -12,15 +12,16 @@
   "main": "lib/JSRuntime.js",
   "source": "src/JSRuntime.js",
   "engines": {
-    "atlaspack": "2.12.1-canary.3589+5a0e0f961",
+    "atlaspack": "2.12.1-canary.3592+27d350650",
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/diagnostic": "2.12.1-canary.3589+5a0e0f961",
-    "@atlaspack/feature-flags": "2.12.1-canary.3589+5a0e0f961",
-    "@atlaspack/plugin": "2.12.1-canary.3589+5a0e0f961",
-    "@atlaspack/utils": "2.12.1-canary.3589+5a0e0f961",
+    "@atlaspack/diagnostic": "2.12.1-canary.3592+27d350650",
+    "@atlaspack/domain-sharding": "2.12.1-canary.3592+27d350650",
+    "@atlaspack/feature-flags": "2.12.1-canary.3592+27d350650",
+    "@atlaspack/plugin": "2.12.1-canary.3592+27d350650",
+    "@atlaspack/utils": "2.12.1-canary.3592+27d350650",
     "nullthrows": "^1.1.1"
   },
-  "gitHead": "5a0e0f961eb5d872120244c63288752bac7a04a5"
+  "gitHead": "27d35065043dfc8669fe2618748cb3c6300c760a"
 }

package/src/JSRuntime.js

@@ -485,11 +485,23 @@ function getLoaderRuntime({
       return `Promise.resolve(__parcel__require__("./" + ${relativePathExpr}))`;
     }
 
-    let absoluteUrlExpr = shouldUseRuntimeManifest(bundle, options)
-      ? `require('./helpers/bundle-manifest').resolve(${JSON.stringify(
-          to.publicId,
-        )})`
-      : getAbsoluteUrlExpr(relativePathExpr, bundle, to, shardingConfig);
+    let absoluteUrlExpr;
+    if (shouldUseRuntimeManifest(bundle, options)) {
+      let publicId = JSON.stringify(to.publicId);
+      absoluteUrlExpr = `require('./helpers/bundle-manifest').resolve(${publicId})`;
+
+      if (shardingConfig) {
+        absoluteUrlExpr = `require('@atlaspack/domain-sharding').shardUrl(${absoluteUrlExpr}, ${shardingConfig.maxShards})`;
+      }
+    } else {
+      absoluteUrlExpr = getAbsoluteUrlExpr(
+        relativePathExpr,
+        bundle,
+        to,
+        shardingConfig,
+      );
+    }
+
     let code = `require(${JSON.stringify(loader)})(${absoluteUrlExpr})`;
 
     // In development, clear the require cache when an error occurs so the
@@ -732,6 +744,9 @@ function getURLRuntime(
     } else {
       code += `let bundleURL = require('./helpers/bundle-url');\n`;
       code += `let url = bundleURL.getBundleURL('${from.publicId}') + ${relativePathExpr};`;
+      if (shardingConfig) {
+        code += `url = require('@atlaspack/domain-sharding').shardUrl(url, ${shardingConfig.maxShards});`;
+      }
       code += `module.exports = workerURL(url, bundleURL.getOrigin(url), ${String(
         from.env.outputFormat === 'esmodule',
       )});`;
@@ -827,11 +842,13 @@ function getAbsoluteUrlExpr(
     return `new __parcel__URL__(${relativePathExpr}).toString()`;
   }
 
-  if (shardingConfig) {
-    return `require('./helpers/bundle-url-shards').getShardedBundleURL('${toBundle.name}', ${shardingConfig.maxShards}) + ${relativePathExpr}`;
+  const regularBundleUrl = `require('./helpers/bundle-url').getBundleURL('${fromBundle.publicId}') + ${relativePathExpr}`;
+
+  if (!shardingConfig) {
+    return regularBundleUrl;
   }
 
-  return `require('./helpers/bundle-url').getBundleURL('${fromBundle.publicId}') + ${relativePathExpr}`;
+  return `require('@atlaspack/domain-sharding').shardUrl(${regularBundleUrl}, ${shardingConfig.maxShards})`;
 }
 
 function shouldUseRuntimeManifest(

package/src/helpers/bundle-url.js

@@ -1,4 +1,5 @@
-const {getBaseURL, stackTraceUrlRegexp} = require('./bundle-url-common');
+const stackTraceUrlRegexp =
+  /(https?|file|ftp|(chrome|moz|safari-web)-extension):\/\/[^)\n]+/g;
 
 const bundleURL = {};
 
@@ -7,22 +8,33 @@ const bundleURL = {};
  * If the URL is not cached, it computes and stores it in the cache.
  *
  * @param {string} id - The identifier for the bundle.
+ * @param {Error?} inputError - An error object to extract the stack trace from
+ * (for testing purposes).
  * @returns {string} The URL of the bundle, without file name.
  */
-function getBundleURLCached(id) {
+function getBundleURLCached(id, inputError) {
   let value = bundleURL[id];
 
   if (!value) {
-    value = getBundleURL();
+    value = getBundleURL(inputError);
     bundleURL[id] = value;
   }
 
   return value;
 }
 
-function getBundleURL() {
+/** Get the URL without the filename (last / segment)
+ *
+ * @param {string} url
+ * @returns {string} The URL with the file name removed
+ */
+function getBaseURL(url) {
+  return url.slice(0, url.lastIndexOf('/')) + '/';
+}
+
+function getBundleURL(inputError) {
   try {
-    throw new Error();
+    throw inputError ?? new Error();
   } catch (err) {
     var matches = ('' + err.stack).match(stackTraceUrlRegexp);
     if (matches) {
@@ -43,5 +55,7 @@ function getOrigin(url) {
   return new URL(url).origin;
 }
 
+// TODO: convert this file to ESM once HMR issues are resolved
 exports.getOrigin = getOrigin;
 exports.getBundleURL = getBundleURLCached;
+exports.getBaseURL = getBaseURL;

package/test/bundle-url.test.js

@@ -0,0 +1,62 @@
+// @flow
+import assert from 'assert';
+
+import {getBaseURL, getBundleURL} from '../src/helpers/bundle-url';
+
+const createErrorStack = (url) => {
+  // This error stack is copied from a local dev, with a bunch
+  // of lines trimmed off the end so it's not unnecessarily long
+  return `
+Error
+    at Object.getBundleURL (http://localhost:8081/main-bundle.1a2fa8b7.js:15688:29)
+    at Object.getBundleURLCached (http://localhost:8081/main-bundle.1a2fa8b7.js:15688:29)
+    at a7u9v.6d3ceb6ac67fea50 (${url}:361466:46)
+    at newRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:71:24)
+    at localRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:84:35)
+    at 7H8wc.react-intl-next (http://localhost:8081/main-bundle.1a2fa8b7.js:279746:28)
+    at newRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:71:24)
+    at localRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:84:35)
+    at 1nL5S../manifest (http://localhost:8081/main-bundle.1a2fa8b7.js:279714:17)
+    at newRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:71:24)
+    at localRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:84:35)
+`.trim();
+};
+
+describe('getBaseUrl', () => {
+  it('should return the URL with the filename removed', () => {
+    const testUrl =
+      'https://bundle-shard-3.assets.example.com/assets/testBundle.123abc.js';
+
+    assert.equal(
+      getBaseURL(testUrl),
+      'https://bundle-shard-3.assets.example.com/assets/',
+    );
+  });
+
+  it('should handle domains with no .', () => {
+    const testUrl = 'http://localhost/assets/testBundle.123abc.js';
+
+    assert.equal(getBaseURL(testUrl), 'http://localhost/assets/');
+  });
+
+  it('should handle domains with ports', () => {
+    const testUrl = 'http://localhost:8081/assets/testBundle.123abc.js';
+
+    assert.equal(getBaseURL(testUrl), 'http://localhost:8081/assets/');
+  });
+});
+
+describe('getBundleURL', () => {
+  it('should return the URL of the bundle without the file name', () => {
+    const testUrl =
+      'https://bundle-domain.assets.example.com/assets/testBundle.123abc.js';
+
+    const errorStack = createErrorStack(testUrl);
+    const error = new Error();
+    error.stack = errorStack;
+
+    const result = getBundleURL('test-asset', error);
+
+    assert.equal(result, 'https://bundle-domain.assets.example.com/assets/');
+  });
+});

package/lib/helpers/bundle-url-common.js

@@ -1,13 +0,0 @@
-"use strict";
-
-/** Get the URL without the filename (last / segment)
- *
- * @param {string} url
- * @returns {string} The URL with the file name removed
- */
-function getBaseURL(url) {
-  return url.slice(0, url.lastIndexOf('/')) + '/';
-}
-var stackTraceUrlRegexp = /(https?|file|ftp|(chrome|moz|safari-web)-extension):\/\/[^)\n]+/g;
-exports.getBaseURL = getBaseURL;
-exports.stackTraceUrlRegexp = stackTraceUrlRegexp;

package/lib/helpers/bundle-url-shards.js

@@ -1,86 +0,0 @@
-"use strict";
-
-var _require = require('./bundle-url-common'),
-  getBaseURL = _require.getBaseURL,
-  stackTraceUrlRegexp = _require.stackTraceUrlRegexp;
-var bundleURL = {};
-
-/**
- * Retrieves the sharded bundle URL based on the bundle name and the maximum number of shards.
- *
- * @param {string} bundleName - The file name of the requested bundle.
- * @param {number} maxShards - The maximum number of domain shards available.
- * @param {Error} inputError - An error object to extract the stack trace from
- * (for testing purposes).
- * @returns {string} The URL of the sharded bundle, without file name.
- */
-function getShardedBundleURL(bundleName, maxShards, inputError) {
-  var value = bundleURL[bundleName];
-  if (value) {
-    return value;
-  }
-  try {
-    throw inputError !== null && inputError !== void 0 ? inputError : new Error();
-  } catch (err) {
-    var matches = ('' + err.stack).match(stackTraceUrlRegexp);
-    if (!matches) {
-      return '/';
-    }
-
-    // The first stack frame will be this function.
-    // Use the 2nd one, which will be a runtime in the original bundle.
-    var stackUrl = matches[1];
-    var baseUrl = getBaseURL(stackUrl);
-
-    // Global variable is set by SSR servers when HTTP1.1 traffic is detected
-    if (!globalThis.__ATLASPACK_ENABLE_DOMAIN_SHARDS) {
-      bundleURL[bundleName] = baseUrl;
-      return baseUrl;
-    }
-    var shardNumber = getDomainShardIndex(bundleName, maxShards);
-    var url = new URL(baseUrl);
-    var shardedDomain = getShardedDomain(url.hostname, shardNumber);
-    url.hostname = shardedDomain;
-    value = url.toString();
-    bundleURL[bundleName] = value;
-    return value;
-  }
-}
-function getDomainShardIndex(str, maxShards) {
-  var shard = str.split('').reduce(function (a, b) {
-    var n = (a << maxShards) - a + b.charCodeAt(0);
-
-    // The value returned by << is 64 bit, the & operator coerces to 32,
-    // prevents overflow as we iterate.
-    return n & n;
-  }, 0);
-  shard = shard % maxShards;
-
-  // Make number positive
-  if (shard < 0) {
-    shard += maxShards;
-  }
-  return shard;
-}
-function getShardedDomain(domain, shard) {
-  var i = domain.indexOf('.');
-
-  // Domains like localhost have no . separators
-  if (i === -1) {
-    return "".concat(removeTrailingShard(domain), "-").concat(shard);
-  }
-
-  // If this domain already has a shard number in it, strip it out before adding
-  // the new one
-  var firstSubdomain = removeTrailingShard(domain.slice(0, i));
-  return "".concat(firstSubdomain, "-").concat(shard).concat(domain.slice(i));
-}
-var trailingShardRegex = /-\d+$/;
-function removeTrailingShard(subdomain) {
-  if (!trailingShardRegex.test(subdomain)) {
-    return subdomain;
-  }
-  var shardIdx = subdomain.lastIndexOf('-');
-  return subdomain.slice(0, shardIdx);
-}
-exports.getShardedBundleURL = getShardedBundleURL;

package/src/helpers/bundle-url-common.js

@@ -1,14 +0,0 @@
-/** Get the URL without the filename (last / segment)
- *
- * @param {string} url
- * @returns {string} The URL with the file name removed
- */
-function getBaseURL(url) {
-  return url.slice(0, url.lastIndexOf('/')) + '/';
-}
-
-const stackTraceUrlRegexp =
-  /(https?|file|ftp|(chrome|moz|safari-web)-extension):\/\/[^)\n]+/g;
-
-exports.getBaseURL = getBaseURL;
-exports.stackTraceUrlRegexp = stackTraceUrlRegexp;

package/src/helpers/bundle-url-shards.js

@@ -1,99 +0,0 @@
-const {getBaseURL, stackTraceUrlRegexp} = require('./bundle-url-common');
-
-const bundleURL = {};
-
-/**
- * Retrieves the sharded bundle URL based on the bundle name and the maximum number of shards.
- *
- * @param {string} bundleName - The file name of the requested bundle.
- * @param {number} maxShards - The maximum number of domain shards available.
- * @param {Error} inputError - An error object to extract the stack trace from
- * (for testing purposes).
- * @returns {string} The URL of the sharded bundle, without file name.
- */
-function getShardedBundleURL(bundleName, maxShards, inputError) {
-  let value = bundleURL[bundleName];
-
-  if (value) {
-    return value;
-  }
-
-  try {
-    throw inputError ?? new Error();
-  } catch (err) {
-    var matches = ('' + err.stack).match(stackTraceUrlRegexp);
-
-    if (!matches) {
-      return '/';
-    }
-
-    // The first stack frame will be this function.
-    // Use the 2nd one, which will be a runtime in the original bundle.
-    const stackUrl = matches[1];
-    const baseUrl = getBaseURL(stackUrl);
-
-    // Global variable is set by SSR servers when HTTP1.1 traffic is detected
-    if (!globalThis.__ATLASPACK_ENABLE_DOMAIN_SHARDS) {
-      bundleURL[bundleName] = baseUrl;
-      return baseUrl;
-    }
-
-    const shardNumber = getDomainShardIndex(bundleName, maxShards);
-    const url = new URL(baseUrl);
-
-    const shardedDomain = getShardedDomain(url.hostname, shardNumber);
-    url.hostname = shardedDomain;
-
-    value = url.toString();
-
-    bundleURL[bundleName] = value;
-    return value;
-  }
-}
-
-function getDomainShardIndex(str, maxShards) {
-  let shard = str.split('').reduce((a, b) => {
-    const n = (a << maxShards) - a + b.charCodeAt(0);
-
-    // The value returned by << is 64 bit, the & operator coerces to 32,
-    // prevents overflow as we iterate.
-    return n & n;
-  }, 0);
-
-  shard = shard % maxShards;
-
-  // Make number positive
-  if (shard < 0) {
-    shard += maxShards;
-  }
-
-  return shard;
-}
-
-function getShardedDomain(domain, shard) {
-  let i = domain.indexOf('.');
-
-  // Domains like localhost have no . separators
-  if (i === -1) {
-    return `${removeTrailingShard(domain)}-${shard}`;
-  }
-
-  // If this domain already has a shard number in it, strip it out before adding
-  // the new one
-  const firstSubdomain = removeTrailingShard(domain.slice(0, i));
-
-  return `${firstSubdomain}-${shard}${domain.slice(i)}`;
-}
-
-const trailingShardRegex = /-\d+$/;
-
-function removeTrailingShard(subdomain) {
-  if (!trailingShardRegex.test(subdomain)) {
-    return subdomain;
-  }
-
-  const shardIdx = subdomain.lastIndexOf('-');
-  return subdomain.slice(0, shardIdx);
-}
-
-exports.getShardedBundleURL = getShardedBundleURL;

package/test/bundle-url-common.test.js

@@ -1,29 +0,0 @@
-// @flow
-import assert from 'assert';
-
-// $FlowFixMe importing TypeScript
-import {getBaseURL} from '../src/helpers/bundle-url-common';
-
-describe('getBaseUrl', () => {
-  it('should return the URL with the filename removed', () => {
-    const testUrl =
-      'https://bundle-shard-3.assets.example.com/assets/testBundle.123abc.js';
-
-    assert.equal(
-      getBaseURL(testUrl),
-      'https://bundle-shard-3.assets.example.com/assets/',
-    );
-  });
-
-  it('should handle domains with no .', () => {
-    const testUrl = 'http://localhost/assets/testBundle.123abc.js';
-
-    assert.equal(getBaseURL(testUrl), 'http://localhost/assets/');
-  });
-
-  it('should handle domains with ports', () => {
-    const testUrl = 'http://localhost:8081/assets/testBundle.123abc.js';
-
-    assert.equal(getBaseURL(testUrl), 'http://localhost:8081/assets/');
-  });
-});

package/test/bundle-url-shards.test.js

@@ -1,132 +0,0 @@
-// @flow
-import assert from 'assert';
-
-import {fsFixture, overlayFS, bundle} from '@atlaspack/test-utils';
-
-// $FlowFixMe importing TypeScript
-import {getShardedBundleURL} from '../src/helpers/bundle-url-shards';
-
-const createErrorStack = (url) => {
-  // This error stack is copied from a local dev, with a bunch
-  // of lines trimmed off the end so it's not unnecessarily long
-  return `
-Error
-    at Object.getShardedBundleURL (http://localhost:8081/main-bundle.1a2fa8b7.js:15688:29)
-    at a7u9v.6d3ceb6ac67fea50 (${url}.1a2fa8b7.js:361466:46)
-    at newRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:71:24)
-    at localRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:84:35)
-    at 7H8wc.react-intl-next (http://localhost:8081/main-bundle.1a2fa8b7.js:279746:28)
-    at newRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:71:24)
-    at localRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:84:35)
-    at 1nL5S../manifest (http://localhost:8081/main-bundle.1a2fa8b7.js:279714:17)
-    at newRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:71:24)
-    at localRequire (http://localhost:8081/main-bundle.1a2fa8b7.js:84:35)
-`.trim();
-};
-
-describe('bundle-url-shards helper', () => {
-  describe('getShardedBundleURL', () => {
-    beforeEach(() => {
-      // $FlowFixMe
-      delete globalThis.__ATLASPACK_ENABLE_DOMAIN_SHARDS;
-    });
-
-    it('should shard a URL if the global variable is set', () => {
-      const testBundle = 'test-bundle.123abc.js';
-
-      // $FlowFixMe
-      globalThis.__ATLASPACK_ENABLE_DOMAIN_SHARDS = true;
-
-      const err = new Error();
-      err.stack = createErrorStack(
-        'https://bundle-shard.assets.example.com/assets/ParentBundle.cba321.js',
-      );
-
-      const result = getShardedBundleURL(testBundle, 5, err);
-
-      assert.equal(result, 'https://bundle-shard-0.assets.example.com/assets/');
-    });
-
-    it('should re-shard a domain that has already been sharded', () => {
-      const testBundle = 'TestBundle.1a2b3c.js';
-
-      // $FlowFixMe
-      globalThis.__ATLASPACK_ENABLE_DOMAIN_SHARDS = true;
-
-      const err = new Error();
-      err.stack = createErrorStack(
-        'https://bundle-shard-1.assets.example.com/assets/ParentBundle.cba321.js',
-      );
-
-      const result = getShardedBundleURL(testBundle, 5, err);
-
-      assert.equal(result, 'https://bundle-shard-4.assets.example.com/assets/');
-    });
-
-    it('should not add a shard if the cookie is not present', () => {
-      const testBundle = 'UnshardedBundle.9z8x7y.js';
-
-      const err = new Error();
-      err.stack = createErrorStack(
-        'https://bundle-unsharded.assets.example.com/assets/ParentBundle.cba321.js',
-      );
-
-      const result = getShardedBundleURL(testBundle, 5, err);
-
-      assert.equal(
-        result,
-        'https://bundle-unsharded.assets.example.com/assets/',
-      );
-    });
-  });
-
-  describe('compiled into JS Runtime', () => {
-    it('should insert all arguments into compiled output', async () => {
-      const maxShards = 8;
-      await fsFixture(overlayFS)`
-        package.json:
-          {
-            "name": "bundle-sharding-test",
-            "@atlaspack/runtime-js": {
-              "domainSharding": {
-                "maxShards": ${maxShards}
-              }
-            }
-          }
-
-        src/index.js:
-          async function fn() {
-            const a = await import('./a.js');
-            const b = await import('./b.js');
-            console.log('a', a, b);
-          }
-          fn();
-
-        src/a.js:
-          export const a = async () => {
-            const b = await import('./b');
-            return b + 'A';
-          }
-        src/b.js:
-          export const b = 'B';
-
-        yarn.lock:
-      `;
-
-      const bundleGraph = await bundle('src/index.js', {inputFS: overlayFS});
-
-      const mainBundle = bundleGraph
-        .getBundles()
-        .find((b) => b.name === 'index.js');
-      if (!mainBundle) return assert(mainBundle);
-
-      const code = await overlayFS.readFile(mainBundle.filePath, 'utf-8');
-      assert.ok(
-        code.includes(
-          `require("e3ed71d88565db").getShardedBundleURL('b.8575baaf.js', ${maxShards}) + "b.8575baaf.js"`,
-        ),
-        'Expected generated code for getShardedBundleURL was not found',
-      );
-    });
-  });
-});